August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: ice1712: add const to snd_ak4xxx_private structures
by Bhumika Goyal 06 Aug '17

06 Aug '17

Declare snd_ak4xxx_private structures as const as they are only passed to the function snd_ice1712_akm4xxx_init. This argument is of type const, so make the structures const. Done using Coccinelle: @match disable optional_qualifier@ identifier s; position p; @@ static struct snd_ak4xxx_private s@p={...}; @good1@ identifier match.s; position p; @@ snd_ice1712_akm4xxx_init(...,&s@p,...) @bad@ identifier match.s; position p!={match.p,good1.p}; @@ s@p @depends on !bad disable optional_qualifier@ identifier match.s; @@ static +const struct snd_ak4xxx_private s={...}; Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/pci/ice1712/delta.c | 12 ++++++------ sound/pci/ice1712/ews.c | 6 +++--- sound/pci/ice1712/hoontech.c | 2 +- sound/pci/ice1712/phase.c | 2 +- sound/pci/ice1712/revo.c | 10 +++++----- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/sound/pci/ice1712/delta.c b/sound/pci/ice1712/delta.c index da5f37b..4e470f0 100644 --- a/sound/pci/ice1712/delta.c +++ b/sound/pci/ice1712/delta.c @@ -454,7 +454,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_audiophile_priv = { +static const struct snd_ak4xxx_private akm_audiophile_priv = { .caddr = 2, .cif = 0, .data_mask = ICE1712_DELTA_AP_DOUT, @@ -475,7 +475,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_delta410_priv = { +static const struct snd_ak4xxx_private akm_delta410_priv = { .caddr = 0, .cif = 0, .data_mask = ICE1712_DELTA_AP_DOUT, @@ -497,7 +497,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_delta1010lt_priv = { +static const struct snd_ak4xxx_private akm_delta1010lt_priv = { .caddr = 2, .cif = 0, /* the default level of the CIF pin from AK4524 */ .data_mask = ICE1712_DELTA_1010LT_DOUT, @@ -519,7 +519,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_delta66e_priv = { +static const struct snd_ak4xxx_private akm_delta66e_priv = { .caddr = 2, .cif = 0, /* the default level of the CIF pin from AK4524 */ .data_mask = ICE1712_DELTA_66E_DOUT, @@ -542,7 +542,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_delta44_priv = { +static const struct snd_ak4xxx_private akm_delta44_priv = { .caddr = 2, .cif = 0, /* the default level of the CIF pin from AK4524 */ .data_mask = ICE1712_DELTA_CODEC_SERIAL_DATA, @@ -564,7 +564,7 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco } }; -static struct snd_ak4xxx_private akm_vx442_priv = { +static const struct snd_ak4xxx_private akm_vx442_priv = { .caddr = 2, .cif = 0, .data_mask = ICE1712_VX442_DOUT, diff --git a/sound/pci/ice1712/ews.c b/sound/pci/ice1712/ews.c index ec07136..5bc14e8 100644 --- a/sound/pci/ice1712/ews.c +++ b/sound/pci/ice1712/ews.c @@ -354,7 +354,7 @@ static void ews88_setup_spdif(struct snd_ice1712 *ice, int rate) } }; -static struct snd_ak4xxx_private akm_ews88mt_priv = { +static const struct snd_ak4xxx_private akm_ews88mt_priv = { .caddr = 2, .cif = 1, /* CIF high */ .data_mask = ICE1712_EWS88_SERIAL_DATA, @@ -375,7 +375,7 @@ static void ews88_setup_spdif(struct snd_ice1712 *ice, int rate) } }; -static struct snd_ak4xxx_private akm_ewx2496_priv = { +static const struct snd_ak4xxx_private akm_ewx2496_priv = { .caddr = 2, .cif = 1, /* CIF high */ .data_mask = ICE1712_EWS88_SERIAL_DATA, @@ -396,7 +396,7 @@ static void ews88_setup_spdif(struct snd_ice1712 *ice, int rate) } }; -static struct snd_ak4xxx_private akm_6fire_priv = { +static const struct snd_ak4xxx_private akm_6fire_priv = { .caddr = 2, .cif = 1, /* CIF high */ .data_mask = ICE1712_6FIRE_SERIAL_DATA, diff --git a/sound/pci/ice1712/hoontech.c b/sound/pci/ice1712/hoontech.c index a40001c..de2fcc9 100644 --- a/sound/pci/ice1712/hoontech.c +++ b/sound/pci/ice1712/hoontech.c @@ -278,7 +278,7 @@ static int snd_ice1712_value_init(struct snd_ice1712 *ice) } }; - static struct snd_ak4xxx_private akm_stdsp24_mv_priv = { + static const struct snd_ak4xxx_private akm_stdsp24_mv_priv = { .caddr = 2, .cif = 1, /* CIF high */ .data_mask = ICE1712_STDSP24_SERIAL_DATA, diff --git a/sound/pci/ice1712/phase.c b/sound/pci/ice1712/phase.c index e9ca89c..4f85482 100644 --- a/sound/pci/ice1712/phase.c +++ b/sound/pci/ice1712/phase.c @@ -108,7 +108,7 @@ struct phase28_spec { .num_adcs = 2, }; -static struct snd_ak4xxx_private akm_phase22_priv = { +static const struct snd_ak4xxx_private akm_phase22_priv = { .caddr = 2, .cif = 1, .data_mask = 1 << 4, diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c index 1d81ae6..5cc4213 100644 --- a/sound/pci/ice1712/revo.c +++ b/sound/pci/ice1712/revo.c @@ -244,7 +244,7 @@ static int revo51_i2c_init(struct snd_ice1712 *ice, .dac_info = revo71_front, }; -static struct snd_ak4xxx_private akm_revo_front_priv = { +static const struct snd_ak4xxx_private akm_revo_front_priv = { .caddr = 1, .cif = 0, .data_mask = VT1724_REVO_CDOUT, @@ -266,7 +266,7 @@ static int revo51_i2c_init(struct snd_ice1712 *ice, .dac_info = revo71_surround, }; -static struct snd_ak4xxx_private akm_revo_surround_priv = { +static const struct snd_ak4xxx_private akm_revo_surround_priv = { .caddr = 3, .cif = 0, .data_mask = VT1724_REVO_CDOUT, @@ -287,7 +287,7 @@ static int revo51_i2c_init(struct snd_ice1712 *ice, .dac_info = revo51_dac, }; -static struct snd_ak4xxx_private akm_revo51_priv = { +static const struct snd_ak4xxx_private akm_revo51_priv = { .caddr = 2, .cif = 0, .data_mask = VT1724_REVO_CDOUT, @@ -305,7 +305,7 @@ static int revo51_i2c_init(struct snd_ice1712 *ice, .adc_info = revo51_adc, }; -static struct snd_ak4xxx_private akm_revo51_adc_priv = { +static const struct snd_ak4xxx_private akm_revo51_adc_priv = { .caddr = 2, .cif = 0, .data_mask = VT1724_REVO_CDOUT, @@ -355,7 +355,7 @@ static void ap192_set_rate_val(struct snd_akm4xxx *ak, unsigned int rate) .dac_info = ap192_dac, }; -static struct snd_ak4xxx_private akm_ap192_priv = { +static const struct snd_ak4xxx_private akm_ap192_priv = { .caddr = 2, .cif = 0, .data_mask = VT1724_REVO_CDOUT, -- 1.9.1

2 1

[alsa-devel] [PATCH v06 31/36] uapi linux/patchkey.h: change #error to #warning if file included directly
by Mikko Rapeli 06 Aug '17

06 Aug '17

Would be nice to be able to compile all userspace header files also alone. Signed-off-by: Mikko Rapeli <mikko.rapeli(a)iki.fi> Cc: alsa-devel(a)alsa-project.org Cc: Andrew Veliath <andrewtv(a)usa.net> Cc: Riccardo Facchetti <fizban(a)tin.it> --- include/uapi/linux/patchkey.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/patchkey.h b/include/uapi/linux/patchkey.h index 1bda0e56bc5e..cee195d6d826 100644 --- a/include/uapi/linux/patchkey.h +++ b/include/uapi/linux/patchkey.h @@ -11,7 +11,7 @@ */ #ifndef _LINUX_PATCHKEY_H_INDIRECT -#error "patchkey.h included directly" +#warning "patchkey.h included directly" #endif #ifndef _UAPI_LINUX_PATCHKEY_H -- 2.13.3

1 0

[alsa-devel] ASUS G752VS: Linux audio/sound problems
by Aljoša 06 Aug '17

06 Aug '17

ASUS G752VS laptop - latest 310 BIOS; OS: Ubuntu 17.04 - fully updated, kernel 4.10.0-30. This Asus laptop has two stereo speakers behind the display on the rear side of the notebook, and a separate subwoofer that sits on the underside. I'm reporting here the following Linux audio/sound issues: 1) Microphone jack doesn't work (it works ok in Windows 10). 2) Headphone jack doesn't work (it works ok in Windows 10). It works somehow when the hdajackretask headphones trick is applied (override pin 0x16 to headpohne). 3) If within sound settings the "Analog Stereo Output" mode is selected, the subwoofer doesn't work and its volume control is grayed out (disabled). If within sound settings the "Analog Surround 4.0 Output" mode is selected, fade control works even if laptop doesn't have both front and rear speakers, and the subwoofer works ok but its volume control is grayed out (disabled). Test laptop sound (2 speakers + subwoofer) without hdajackretask headphones trick (override pin 0x16 to headpohne) applied: Front left and front right both works ok. Rear left and rear right both works ok and sound is coming from the subwoofer both when rear left and rear right test button is clicked. Test laptop sound (2 speakers + subwoofer) with hdajackretask headphones trick (override pin 0x16 to headpohne) applied: Front left and front right both doesn't work. Rear left and rear right both works ok and sound is coming from the subwoofer both when rear left and rear right test button is clicked. 4) Not sure if this is somehow related to audio/sound problems, but the fact is that the right side of the laptop (area around audio jacks) is pretty hot compared to the left side which is completely cold (in Windoes 10 the area around audio jacks is completely cold). Please find attached the 'alsa-info.sh output' and two related images. Best regards, Aljosa.

1 0

[alsa-devel] [PATCH 0/5] ALSA: control: fix issue of concurrent access for TLV operations
by Takashi Sakamoto 05 Aug '17

05 Aug '17

Hi, In a design of ALSA control core, each set of elements have data of Type-Length-Value shape. This is called as TLV data. In ALSA control interface, applications can three types of requests to elements about TLV data; read, write and command. In current implementation of ALSA control core, these three requests are handled with read lock of a counting semaphore. However, this has an issue of concurrent access because in theory write/command requests have sub-effects to change state of the set of elements in a point of TLV data. Read requests and write/command requests are handled exclusively as well as each write/command requests. This patchset is for this purpose. Additionally, this applies code refactoring to TLV ioctl handler and TLV handler for user-defined element set so that they get better shape for readers. Takashi Sakamoto (5): ALSA: control: queue events within locking of controls_rwsem for TLV operation ALSA: control: use counting semaphore as write lock for TLV write/command operations ALSA: control: obsolete user_ctl_lock ALSA: control: code refactoring TLV ioctl handler ALSA: control: code refactoring for TLV request handler to user element set include/sound/core.h | 2 - sound/core/control.c | 252 +++++++++++++++++++++++++++++++-------------------- sound/core/init.c | 1 - 3 files changed, 155 insertions(+), 100 deletions(-) -- 2.11.0

2 7

[alsa-devel] [PATCH] ASoC: Intel: constify pci_device_id.
by Arvind Yadav 04 Aug '17

04 Aug '17

pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- sound/soc/intel/atom/sst/sst_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c index 3a0b3bf..6906ee6 100644 --- a/sound/soc/intel/atom/sst/sst_pci.c +++ b/sound/soc/intel/atom/sst/sst_pci.c @@ -181,7 +181,7 @@ static void intel_sst_remove(struct pci_dev *pci) } /* PCI Routines */ -static struct pci_device_id intel_sst_ids[] = { +static const struct pci_device_id intel_sst_ids[] = { { PCI_VDEVICE(INTEL, SST_MRFLD_PCI_ID), 0}, { 0, } }; -- 2.7.4

2 1

[alsa-devel] [PATCH RESEND v3 0/3] Add support for es8323 and hdmi audio to the firefly-rk3288
by Romain Perier 04 Aug '17

04 Aug '17

This set of patches enables support for the es8323 codecs on the firefly-rk3288. It adds the required DT definitions to link rockchip-i2s to the es8388 analog output. As the support for HDMI audio is also built-in in the corresponding ASoC machine driver, HDMI audio output is also enabled. Changes in v3: - Synced DT with the one of the Rock2, the properties have been lexically re-ordered in the right order, I have splitted the headphone pinctrl in two: phone_ctl and hp_det Changes in v2: - Adapted DT for the firefly-rk3288 to the ASoC machine driver rk3288-hdmi-analog - Added patch 02/03 to this series - Re-wrote this cover letter Romain Perier (3): SoC: es8328-i2c: Add compatible for ES8323 arm: dts: rockchip: Don't set otp-gpio pinctrl by default in rk3288.dtsi arm: dts: Add support for ES8323 to the Firefly-RK3288 Documentation/devicetree/bindings/sound/es8328.txt | 5 ++- arch/arm/boot/dts/rk3288-evb.dtsi | 4 +++ arch/arm/boot/dts/rk3288-firefly.dtsi | 38 ++++++++++++++++++++++ arch/arm/boot/dts/rk3288-veyron.dtsi | 4 +++ arch/arm/boot/dts/rk3288.dtsi | 4 --- sound/soc/codecs/es8328-i2c.c | 2 ++ 6 files changed, 52 insertions(+), 5 deletions(-) -- 2.11.0

2 13

[alsa-devel] Problem with DoP mode in Chord 2qute USB audio
by Pavel Hofman 03 Aug '17

03 Aug '17

Hello, I am working with owner of Chord 2qute on the following problem (FYI long discussion at http://www.diyaudio.com/forums/pc-based/310578-chord-2qute-dop-challenge.ht…): Regular 176.4/24 PCM plays OK, however 176.4/24 DoP produces random 1-2 sec sound interruptions every several tens of seconds. Tested players - squeezelite, MPD. The soundcard has its own power supply. I googled out several reports of simlar problem with this soundcard, mostly on linux (did not see any problem report for OSX). alsainfo: http://www.fyn13.dk/diy/alsa_output_chord_2qute_4.4.0-62.txt lsusb -v : http://www.fyn13.dk/diy/chord_lsusb.txt hw_params and stream0 files are identical for both 176.4/24 PCM and DoP: /proc/asound/card1/pcm0p/sub0/hw_params: access: RW_INTERLEAVED format: S32_LE subformat: STD channels: 2 rate: 176400 (176400/1) period_size: 1764 buffer_size: 7056 /proc/asound/card1/stream0: Chord Electronics Ltd 2Qute at usb-0000:00:14.0-2, high speed : USB Audio Playback: Status: Running Interface = 2 Altset = 1 Packet Size = 224 Momentary freq = 176402 Hz (0x16.0ce0) Feedback Format = 16.16 Interface 2 Altset 1 Format: S32_LE Channels: 2 Endpoint: 5 OUT (ASYNC) Rates: 32000, 44100, 48000, 88200, 96000, 176400, 192000, 352800, 384000 Data packet interval: 125 us We checked for XRUNs, none were produced during the interruption in DoP playback. Powerful 4-core CPU Intel Pentium 4405U @ 2.10GHz, idle > 99% of time in DoP playback. However, the IRQs rate of the onboard XHCI controller is 8k/s for both PCM and DoP playback which corresponds to 1 IRQ every 125us frame. The rate drops to almost zero when playback is stopped in the player - clearly it is related to the soundcard. Could this perhaps be a sign of the problem? Please is there a way to lower the rate, like the old removed param nrpacks of the usb-audio driver? I suspect a buggy XMOS firmware. I very much appreciate any suggestion or help, either with fixing in software, or further diagnostics to support potential claim to the manufacturer. Thank you very much. With regards, Pavel.

2 2

[alsa-devel] [PATCH 0/3] ASoC: Intel: kbl: Add Multi-endpoint Playback & Echo Ref support
by Naveen M 03 Aug '17

03 Aug '17

1. Add new FE capabilities to support: a. Parallel playback on 2 ports simultaneously Define new frontends to enable additional playback port. This will be used when platform needs to support multi-playback on different ports. Ex: Headset and Speaker simultaneously b. Echo reference capture capability Certain platforms need reference stream of playback to supplement User-space post-processing algorithms. This pin enables platform driver to provide such a FE. 2. Add DAI links for parallel playback and echo ref 3. Add map for new DAIs for parallel playback and echo ref Naveen M (3): ASoC: Intel: kbl: Add new FEs for Multi-Playback & Echo-Reference ASoC: Intel: kbl: Add DAI links for Multi-Playback & Echo-reference ASoC: Intel: kbl: Add map for new DAIs for Multi-Playback & Echo Ref sound/soc/intel/boards/kbl_rt5663_max98927.c | 30 +++++++++++++++++++--- .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 30 +++++++++++++++++++--- sound/soc/intel/skylake/skl-pcm.c | 26 +++++++++++++++++++ 3 files changed, 80 insertions(+), 6 deletions(-) -- 1.9.1

3 7

[alsa-devel] [PATCH 0/9] Add Cannonlake Audio DSP support
by Guneshwor Singh 03 Aug '17

03 Aug '17

Cannonlake (CNL) audio is similar to Broxton with a substantial difference in ipc registers. This series enables CNL support by adding required dsp library functions and ipc register programming. CNL has 4 dsp cores, additional core support is also added here. To accommodate the above changes in the current code, existing helper functions, common functions that are reusable and dsp ops are modified. Dharageswari R (1): ASoC: Intel: Skylake: Add num of cores in dsp ops Guneshwor Singh (7): ASoC: Intel: Skylake: Use num_core to allocate instead of macro ASoC: Intel: cnl: Add cnl dsp functions and registers ASoC: Intel: Skylake: Move platform specific init to platform dsp_init() ASoC: Intel: cnl: Unstatify common ipc functions ASoC: Intel: cnl: Add sst library functions for cnl platform ASoC: Intel: cnl: add dsp ops for cannonlake ASoC: Intel: cnl: add pci id for cnl Pardha Saradhi K (1): ASoC: Intel: Skylake: Add dsp cores management sound/soc/intel/skylake/Makefile | 5 +- sound/soc/intel/skylake/bxt-sst.c | 5 +- sound/soc/intel/skylake/cnl-sst-dsp.c | 274 ++++++++++++++++++ sound/soc/intel/skylake/cnl-sst-dsp.h | 112 ++++++++ sound/soc/intel/skylake/cnl-sst.c | 495 ++++++++++++++++++++++++++++++++ sound/soc/intel/skylake/skl-messages.c | 31 ++ sound/soc/intel/skylake/skl-sst-dsp.c | 2 +- sound/soc/intel/skylake/skl-sst-ipc.c | 6 +- sound/soc/intel/skylake/skl-sst-ipc.h | 12 +- sound/soc/intel/skylake/skl-sst-utils.c | 6 +- sound/soc/intel/skylake/skl-sst.c | 6 +- sound/soc/intel/skylake/skl-topology.c | 26 +- sound/soc/intel/skylake/skl.c | 11 + sound/soc/intel/skylake/skl.h | 1 + 14 files changed, 970 insertions(+), 22 deletions(-) create mode 100644 sound/soc/intel/skylake/cnl-sst-dsp.c create mode 100644 sound/soc/intel/skylake/cnl-sst-dsp.h create mode 100644 sound/soc/intel/skylake/cnl-sst.c -- 2.13.0

3 19

[alsa-devel] [PATCH] ASoC: Intel: Skylake: Use correct nuvoton codec ID
by Naveen M 03 Aug '17

03 Aug '17

Correcting the nau88l25 codec ID to match secondary codec and load the machine driver. Signed-off-by: Naveen M <naveen.m(a)intel.com> Signed-off-by: Harsha Priya <harshapriya.n(a)intel.com> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 334917e..608c147 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -879,12 +879,12 @@ static void skl_remove(struct pci_dev *pci) static struct sst_codecs skl_codecs = { .num_codecs = 1, - .codecs = {"NAU88L25"} + .codecs = {"10508825"} }; static struct sst_codecs kbl_codecs = { .num_codecs = 1, - .codecs = {"NAU88L25"} + .codecs = {"10508825"} }; static struct sst_codecs bxt_codecs = { -- 1.9.1

3 2