July 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/2] ASoC: Intel: Skylake: explicitly add the headers sst-dsp.h
by Guneshwor Singh 03 Jul '17

03 Jul '17

From: Vinod Koul <vinod.koul(a)intel.com> Commit bdd0384a5ada ("ASoC: Intel: Skylake: Add support to read firmware registers") introduced firmware register read so added sst-dsp-priv.h but missed adding sst-dsp.h as that leads to below compiler warning: In file included from sound/soc/intel/skylake/skl-debug.c:23:0: >> sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: 'struct sst_pdata' declared inside parameter list [enabled by default] int (*init)(struct sst_dsp *sst, struct sst_pdata *pdata); ^ >> sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] So add the missing header. Fixes: bdd0384a5ada ("ASoC: Intel: Skylake: Add support to read firmware registers") Reported-by: kbuild test robot <fengguang.wu(a)intel.com> Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> Signed-off-by: Guneshwor Singh <guneshwor.o.singh(a)intel.com> --- sound/soc/intel/skylake/skl-debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl-debug.c b/sound/soc/intel/skylake/skl-debug.c index 75497b1fda45..34d06abbf796 100644 --- a/sound/soc/intel/skylake/skl-debug.c +++ b/sound/soc/intel/skylake/skl-debug.c @@ -20,6 +20,7 @@ #include "skl-sst-ipc.h" #include "skl-tplg-interface.h" #include "skl-topology.h" +#include "../common/sst-dsp.h" #include "../common/sst-dsp-priv.h" #define MOD_BUF PAGE_SIZE -- 2.13.0

2 3

Re: [alsa-devel] ioctl(fd, SNDRV_CTL_IOCTL_ELEM_REPLACE, ... not working from userspace ?
by Clemens Ladisch 03 Jul '17

03 Jul '17

Fulup Ar Foll wrote: > Looking at this code I do not understand why the replace iotcl is refused. if (!(kctl->vd[0].access & SNDRV_CTL_ELEM_ACCESS_USER)) { ret = -EINVAL; Kernel drivers do not expect that their own controls change. Regards, Clemens

1 0

[alsa-devel] [PATCH 0/6] add support for Sama5d2 audio PLL and enable ClassD
by Quentin Schulz 03 Jul '17

03 Jul '17

This patch series adds support for the audio PLL and enables ClassD that can be found in ATMEL Sama5d2 SoCs. There are two audio PLLs (PMC and PAD) that shares the same parent (FRAC). FRAC can output between 620 and 700MHz and only multiply the rate of its parent. The two audio PLLs then divide the FRAC rate to best match the asked rate. I basically took an old patch series posted by Nicolas on December, 6th 2016[1][2][3] and the comments Boris did on the first version[4] Nicolas sent on July, 15th 2015. I also fixed the function used to compute the divisors, removed useless spinlocks and added a range to the audio frac PLL to stay within vendor's supported range. Clocks that are children of gclk (generated-clk) are now able to propagate rate to the audio PLL clocks when needed. However, since there is no rate locking, we enforce that classd_gclk be the only child of audio_pll_pmc so we avoid multiple children modifiying parent's rate, and classd driver modifying parent's rate which would impact the rate of each of parent's children. Thanks, Quentin [1] https://patchwork.kernel.org/patch/9462351/ [2] https://patchwork.kernel.org/patch/9462347/ [3] https://patchwork.kernel.org/patch/9462349/ [4] https://www.spinics.net/lists/arm-kernel/msg436120.html Cyrille Pitchen (2): ARM: dts: at91: sama5d2: add classd nodes ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Nicolas Ferre (1): clk: at91: add audio pll clock driver Quentin Schulz (3): clk: at91: clk-generated: remove useless divisor loop clk: at91: clk-generated: create function to find best_diff clk: at91: clk-generated: make gclk determine audio_pll rate .../devicetree/bindings/clock/at91-clock.txt | 10 + arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ++ arch/arm/boot/dts/sama5d2.dtsi | 39 +++- arch/arm/mach-at91/Kconfig | 4 + drivers/clk/at91/Makefile | 2 + drivers/clk/at91/clk-audio-pll-pad.c | 204 ++++++++++++++++++ drivers/clk/at91/clk-audio-pll-pmc.c | 175 +++++++++++++++ drivers/clk/at91/clk-audio-pll.c | 237 +++++++++++++++++++++ drivers/clk/at91/clk-generated.c | 79 +++++-- include/linux/clk/at91_pmc.h | 25 +++ sound/soc/atmel/atmel-classd.c | 20 +- 11 files changed, 772 insertions(+), 39 deletions(-) create mode 100644 drivers/clk/at91/clk-audio-pll-pad.c create mode 100644 drivers/clk/at91/clk-audio-pll-pmc.c create mode 100644 drivers/clk/at91/clk-audio-pll.c -- 2.11.0

4 13

[alsa-devel] Issue on Linux 4.12-rc7 on iMX6 based board
by gianluca 03 Jul '17

03 Jul '17

Hello list, I have some issue using the sgtl5000 on two custom boards based with iMX6. One board has iMX6DL and the other has iMX6QP. The issue is I have a (dramatically high) strange value on mixer settings (looks like a int32 limit or similar) This is the output of amixer: > # amixer > Simple mixer control 'Headphone',0 > Capabilities: pvolume pswitch pswitch-joined > Playback channels: Front Left - Front Right > Limits: Playback 0 - 127 > Mono: > Front Left: Playback 0 [2147483647%] [-51.50dB] [on] > Front Right: Playback 0 [2147483647%] [-51.50dB] [on] > Simple mixer control 'Headphone Mux',0 > Capabilities: enum > Items: 'DAC' 'LINE_IN' > Item0: 'DAC' > Simple mixer control 'Headphone Playback ZC',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [on] > Simple mixer control 'PCM',0 > Capabilities: pvolume > Playback channels: Front Left - Front Right > Limits: Playback 0 - 192 > Mono: > Front Left: Playback 1 [2147483647%] > Front Right: Playback 0 [2147483647%] > Simple mixer control 'Lineout',0 > Capabilities: pvolume pswitch pswitch-joined > Playback channels: Front Left - Front Right > Limits: Playback 0 - 31 > Mono: > Front Left: Playback 18 [2147483647%] [-6.50dB] [on] > Front Right: Playback 18 [2147483647%] [-6.50dB] [on] > Simple mixer control 'Mic',0 > Capabilities: volume volume-joined > Playback channels: Mono > Capture channels: Mono > Limits: 0 - 3 > Mono: 0 [2147483647%] [0.00dB] > Simple mixer control 'Capture',0 > Capabilities: cvolume > Capture channels: Front Left - Front Right > Limits: Capture 0 - 15 > Front Left: Capture 0 [2147483647%] > Front Right: Capture 0 [2147483647%] > Simple mixer control 'Capture Attenuate Switch (-6dB)',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [off] > Simple mixer control 'Capture Mux',0 > Capabilities: enum > Items: 'MIC_IN' 'LINE_IN' > Item0: 'MIC_IN' > Simple mixer control 'Capture ZC',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [on] > In attachment there is a screenshot of alsamixer All audio stuff are not hear at all.... :-( After the output of the sgtl5000 I have a audio-booster and it is set at the maximum level. I have another board based on the iMX28, SGTL5000 and the same audio booster and everything is working good. So I can suppose something related the initialization of the codec. Any help? Best Regards, Gianluca Renzi -- Eurek s.r.l. | Electronic Engineering | http://www.eurek.it via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120 p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212

2 11

[alsa-devel] [PATCH] aplay: Fix header for raw format
by Ion-Horia Petrisor 03 Jul '17

03 Jul '17

Raw format has no header, so use 0 when calling playback_go. Signed-off-by: Ion-Horia Petrisor <ion-horia.petrisor(a)nxp.com> --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index 00af662..fe274ed 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -2831,7 +2831,7 @@ static void playback(char *name) /* should be raw data */ init_raw_data(); pbrec_count = calc_count(); - playback_go(fd, dta, pbrec_count, FORMAT_RAW, name); + playback_go(fd, 0, pbrec_count, FORMAT_RAW, name); } __end: if (fd != 0) -- 2.7.4

3 6

[alsa-devel] [PATCH] ALSA: hda/realtek - Remove GPIO_MASK
by Kai-Heng Feng 03 Jul '17

03 Jul '17

GPIO_MASK was introduced in commit "df694daa3c01 [ALSA] hda-codec - Add the support of ALC262,ALC883,ALC885,ALC861" but it's not being used. So we can simply remove it. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c79491a1cd47..425a4abd8ad0 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -41,9 +41,6 @@ /* keep halting ALC5505 DSP, for power saving */ #define HALT_REALTEK_ALC5505 -/* for GPIO Poll */ -#define GPIO_MASK 0x03 - /* extra amp-initialization sequence types */ enum { ALC_INIT_NONE, -- 2.13.2

2 1

[alsa-devel] I sent hardware informations with the script about a MEDION laptop with Intel devices
by fulgor fulgor 03 Jul '17

03 Jul '17

Is there any news about a module for this laptop ? fulgor

2 1

[alsa-devel] [PATCH] ALSA: hda/realtek - Fix typo
by Shih-Yuan Lee (FourDollars) 03 Jul '17

03 Jul '17

The PIN number for Dell headset mode of ALC3271 is wrong. Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c39bc49..d0cf1f3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6553,7 +6553,7 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0299, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x12, 0xb7a60130}, - {0x13, 0xb8a60140}, + {0x13, 0xb8a61140}, {0x17, 0x90170110}), {} }; -- 2.7.4

2 1

[alsa-devel] [v2 0/4] Add debugfs support for skylake driver
by Guneshwor Singh 03 Jul '17

03 Jul '17

This series introduces debugfs support for skylake driver. It helps in debugging by providing module configurations which is loaded from topology. It also allows to read the firmware registers which are a part of SRAM memory area accessible by host CPU through a memory window. Guneshwor Singh (1): ASoC: Intel: common: Add sram address to sst_addr structure Sodhi, VunnyX (1): ASoC: Intel: Skylake: Add support to read firmware registers Vinod Koul (2): ASoC: Intel: Skylake: Add debugfs support ASoC: Intel: Skylake: Debugfs facility to dump module config Changes in v2: - Re-ordered patch and squashed platform changes Guneshwor Singh (1): ASoC: Intel: common: Add sram address to sst_addr structure Sodhi, VunnyX (1): ASoC: Intel: Skylake: Add support to read firmware registers Vinod Koul (2): ASoC: Intel: Skylake: Add debugfs support ASoC: Intel: Skylake: Debugfs facility to dump module config sound/soc/intel/common/sst-dsp-priv.h | 4 + sound/soc/intel/skylake/Makefile | 4 + sound/soc/intel/skylake/bxt-sst.c | 4 + sound/soc/intel/skylake/skl-debug.c | 269 +++++++++++++++++++++++++++++++++ sound/soc/intel/skylake/skl-sst.c | 5 + sound/soc/intel/skylake/skl-topology.c | 3 + sound/soc/intel/skylake/skl.c | 5 + sound/soc/intel/skylake/skl.h | 26 ++++ 8 files changed, 320 insertions(+) create mode 100644 sound/soc/intel/skylake/skl-debug.c -- 2.13.0

5 11

[alsa-devel] [asoc:topic/intel 37/40] sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data (fwd)
by Julia Lawall 03 Jul '17

03 Jul '17

This doesn't show enough of the context to see the allocation, but please check. thanks, julia ---------- Forwarded message ---------- Date: Sat, 1 Jul 2017 02:40:21 +0800 From: kbuild test robot <fengguang.wu(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: [asoc:topic/intel 37/40] sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: bdd0384a5ada8bb5745e5f29c10a5ba88827efad commit: 5cdf6c09ca9de3f037ba2d770206f3374459602d [37/40] ASoC: Intel: Skylake: Add debugfs support :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago >> sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git git remote update asoc git checkout 5cdf6c09ca9de3f037ba2d770206f3374459602d vim +53 sound/soc/intel/skylake/skl-debug.c 5cdf6c09 Vinod Koul 2017-06-30 37 skl->platform->component.debugfs_root); 5cdf6c09 Vinod Koul 2017-06-30 38 if (IS_ERR(d->fs) || !d->fs) { 5cdf6c09 Vinod Koul 2017-06-30 39 dev_err(&skl->pci->dev, "debugfs root creation failed\n"); 5cdf6c09 Vinod Koul 2017-06-30 40 return NULL; 5cdf6c09 Vinod Koul 2017-06-30 41 } 5cdf6c09 Vinod Koul 2017-06-30 42 5cdf6c09 Vinod Koul 2017-06-30 43 d->skl = skl; 5cdf6c09 Vinod Koul 2017-06-30 44 d->dev = &skl->pci->dev; 5cdf6c09 Vinod Koul 2017-06-30 45 5cdf6c09 Vinod Koul 2017-06-30 46 return d; 5cdf6c09 Vinod Koul 2017-06-30 47 } 5cdf6c09 Vinod Koul 2017-06-30 48 5cdf6c09 Vinod Koul 2017-06-30 49 void skl_debugfs_exit(struct skl_debug *d) 5cdf6c09 Vinod Koul 2017-06-30 50 { 5cdf6c09 Vinod Koul 2017-06-30 51 debugfs_remove_recursive(d->fs); 5cdf6c09 Vinod Koul 2017-06-30 52 5cdf6c09 Vinod Koul 2017-06-30 @53 kfree(d); 5cdf6c09 Vinod Koul 2017-06-30 54 5cdf6c09 Vinod Koul 2017-06-30 55 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1