June 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: kirkwood-i2s: fix error return code in kirkwood_i2s_dev_probe()
by Gustavo A. R. Silva 07 Jul '17

07 Jul '17

platform_get_irq() returns an error code, but the kirkwood-i2s driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- sound/soc/kirkwood/kirkwood-i2s.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 3a36d60..3b09f71 100644 --- a/sound/soc/kirkwood/kirkwood-i2s.c +++ b/sound/soc/kirkwood/kirkwood-i2s.c @@ -550,9 +550,9 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev) return PTR_ERR(priv->io); priv->irq = platform_get_irq(pdev, 0); - if (priv->irq <= 0) { - dev_err(&pdev->dev, "platform_get_irq failed\n"); - return -ENXIO; + if (priv->irq < 0) { + dev_err(&pdev->dev, "platform_get_irq failed: %d\n", priv->irq); + return priv->irq; } if (np) { -- 2.5.0

2 1

[alsa-devel] [PATCH] ASoC: twl6040: fix error return code in twl6040_probe()
by Gustavo A. R. Silva 07 Jul '17

07 Jul '17

platform_get_irq() returns an error code, but the twl6040 driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- sound/soc/codecs/twl6040.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c index 2b6ad09..96cf94a 100644 --- a/sound/soc/codecs/twl6040.c +++ b/sound/soc/codecs/twl6040.c @@ -1123,8 +1123,8 @@ static int twl6040_probe(struct snd_soc_codec *codec) priv->plug_irq = platform_get_irq(pdev, 0); if (priv->plug_irq < 0) { - dev_err(codec->dev, "invalid irq\n"); - return -EINVAL; + dev_err(codec->dev, "invalid irq: %d\n", priv->plug_irq); + return priv->plug_irq; } INIT_DELAYED_WORK(&priv->hs_jack.work, twl6040_accessory_work); -- 2.5.0

2 1

[alsa-devel] [PATCH] ASoC: imx-ssi: add check on platform_get_irq return value
by Gustavo A. R. Silva 07 Jul '17

07 Jul '17

Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value. Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- sound/soc/fsl/imx-ssi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c index b95132e..0679061 100644 --- a/sound/soc/fsl/imx-ssi.c +++ b/sound/soc/fsl/imx-ssi.c @@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev) } ssi->irq = platform_get_irq(pdev, 0); + if (ssi->irq < 0) { + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq); + return ssi->irq; + } ssi->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(ssi->clk)) { -- 2.5.0

3 2

[alsa-devel] [PATCH 0/3] mfd: move include files out of include/linux/i2c
by Wolfram Sang 06 Jul '17

06 Jul '17

It doesn't make sense to use include/linux/i2c for client drivers which may in fact rather be hwmon or input or whatever devices. As a result, I want to deprecate include/linux/i2c for good. This series moves the include files to a better location, for the mfd subsystem to include/linux/mfd. Because of twl.h, this touches quite some subsystems, but I still think it is worth it. I prefer the series to go upstream via the subsystem tree; if you prefer that I take it via I2C, just let me know. No runtime testing because of no HW, but buildbot is happy with this series at least. A branch can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data Thanks and kind regards, Wolfram Wolfram Sang (3): mfd: dm355evm_msp: move header file out of I2C realm mfd: tps65010: move header file out of I2C realm mfd: twl: move header file out of I2C realm arch/arm/mach-omap1/board-h2-mmc.c | 2 +- arch/arm/mach-omap1/board-h2.c | 2 +- arch/arm/mach-omap1/board-h3-mmc.c | 2 +- arch/arm/mach-omap1/board-h3.c | 2 +- arch/arm/mach-omap1/board-osk.c | 2 +- arch/arm/mach-omap2/common.h | 2 +- arch/arm/mach-omap2/omap_twl.c | 2 +- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 2 +- arch/arm/mach-s3c24xx/mach-osiris.c | 2 +- drivers/gpio/gpio-twl4030.c | 2 +- drivers/iio/adc/twl4030-madc.c | 2 +- drivers/iio/adc/twl6030-gpadc.c | 2 +- drivers/input/keyboard/twl4030_keypad.c | 2 +- drivers/input/misc/dm355evm_keys.c | 2 +- drivers/input/misc/twl4030-pwrbutton.c | 2 +- drivers/input/misc/twl4030-vibra.c | 2 +- drivers/mfd/dm355evm_msp.c | 2 +- drivers/mfd/tps65010.c | 2 +- drivers/mfd/twl-core.c | 6 +++--- drivers/mfd/twl4030-audio.c | 2 +- drivers/mfd/twl4030-irq.c | 2 +- drivers/mfd/twl4030-power.c | 2 +- drivers/mfd/twl6030-irq.c | 2 +- drivers/phy/phy-twl4030-usb.c | 2 +- drivers/power/supply/twl4030_charger.c | 2 +- drivers/pwm/pwm-twl-led.c | 2 +- drivers/pwm/pwm-twl.c | 2 +- drivers/regulator/twl-regulator.c | 2 +- drivers/regulator/twl6030-regulator.c | 2 +- drivers/rtc/rtc-dm355evm.c | 2 +- drivers/rtc/rtc-twl.c | 2 +- drivers/usb/host/ohci-omap.c | 2 +- drivers/usb/phy/phy-isp1301-omap.c | 2 +- drivers/usb/phy/phy-twl6030-usb.c | 2 +- drivers/video/backlight/pandora_bl.c | 2 +- drivers/video/fbdev/omap/lcd_h3.c | 2 +- drivers/watchdog/twl4030_wdt.c | 2 +- include/linux/{i2c => mfd}/dm355evm_msp.h | 0 include/linux/{i2c => mfd}/tps65010.h | 2 +- include/linux/{i2c => mfd}/twl.h | 0 sound/soc/codecs/twl4030.c | 2 +- 41 files changed, 41 insertions(+), 41 deletions(-) rename include/linux/{i2c => mfd}/dm355evm_msp.h (100%) rename include/linux/{i2c => mfd}/tps65010.h (99%) rename include/linux/{i2c => mfd}/twl.h (100%) -- 2.11.0

11 15

[alsa-devel] [PATCH 0/6] add support for Sama5d2 audio PLL and enable ClassD
by Quentin Schulz 03 Jul '17

03 Jul '17

This patch series adds support for the audio PLL and enables ClassD that can be found in ATMEL Sama5d2 SoCs. There are two audio PLLs (PMC and PAD) that shares the same parent (FRAC). FRAC can output between 620 and 700MHz and only multiply the rate of its parent. The two audio PLLs then divide the FRAC rate to best match the asked rate. I basically took an old patch series posted by Nicolas on December, 6th 2016[1][2][3] and the comments Boris did on the first version[4] Nicolas sent on July, 15th 2015. I also fixed the function used to compute the divisors, removed useless spinlocks and added a range to the audio frac PLL to stay within vendor's supported range. Clocks that are children of gclk (generated-clk) are now able to propagate rate to the audio PLL clocks when needed. However, since there is no rate locking, we enforce that classd_gclk be the only child of audio_pll_pmc so we avoid multiple children modifiying parent's rate, and classd driver modifying parent's rate which would impact the rate of each of parent's children. Thanks, Quentin [1] https://patchwork.kernel.org/patch/9462351/ [2] https://patchwork.kernel.org/patch/9462347/ [3] https://patchwork.kernel.org/patch/9462349/ [4] https://www.spinics.net/lists/arm-kernel/msg436120.html Cyrille Pitchen (2): ARM: dts: at91: sama5d2: add classd nodes ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Nicolas Ferre (1): clk: at91: add audio pll clock driver Quentin Schulz (3): clk: at91: clk-generated: remove useless divisor loop clk: at91: clk-generated: create function to find best_diff clk: at91: clk-generated: make gclk determine audio_pll rate .../devicetree/bindings/clock/at91-clock.txt | 10 + arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ++ arch/arm/boot/dts/sama5d2.dtsi | 39 +++- arch/arm/mach-at91/Kconfig | 4 + drivers/clk/at91/Makefile | 2 + drivers/clk/at91/clk-audio-pll-pad.c | 204 ++++++++++++++++++ drivers/clk/at91/clk-audio-pll-pmc.c | 175 +++++++++++++++ drivers/clk/at91/clk-audio-pll.c | 237 +++++++++++++++++++++ drivers/clk/at91/clk-generated.c | 79 +++++-- include/linux/clk/at91_pmc.h | 25 +++ sound/soc/atmel/atmel-classd.c | 20 +- 11 files changed, 772 insertions(+), 39 deletions(-) create mode 100644 drivers/clk/at91/clk-audio-pll-pad.c create mode 100644 drivers/clk/at91/clk-audio-pll-pmc.c create mode 100644 drivers/clk/at91/clk-audio-pll.c -- 2.11.0

4 13

[alsa-devel] Issue on Linux 4.12-rc7 on iMX6 based board
by gianluca 03 Jul '17

03 Jul '17

Hello list, I have some issue using the sgtl5000 on two custom boards based with iMX6. One board has iMX6DL and the other has iMX6QP. The issue is I have a (dramatically high) strange value on mixer settings (looks like a int32 limit or similar) This is the output of amixer: > # amixer > Simple mixer control 'Headphone',0 > Capabilities: pvolume pswitch pswitch-joined > Playback channels: Front Left - Front Right > Limits: Playback 0 - 127 > Mono: > Front Left: Playback 0 [2147483647%] [-51.50dB] [on] > Front Right: Playback 0 [2147483647%] [-51.50dB] [on] > Simple mixer control 'Headphone Mux',0 > Capabilities: enum > Items: 'DAC' 'LINE_IN' > Item0: 'DAC' > Simple mixer control 'Headphone Playback ZC',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [on] > Simple mixer control 'PCM',0 > Capabilities: pvolume > Playback channels: Front Left - Front Right > Limits: Playback 0 - 192 > Mono: > Front Left: Playback 1 [2147483647%] > Front Right: Playback 0 [2147483647%] > Simple mixer control 'Lineout',0 > Capabilities: pvolume pswitch pswitch-joined > Playback channels: Front Left - Front Right > Limits: Playback 0 - 31 > Mono: > Front Left: Playback 18 [2147483647%] [-6.50dB] [on] > Front Right: Playback 18 [2147483647%] [-6.50dB] [on] > Simple mixer control 'Mic',0 > Capabilities: volume volume-joined > Playback channels: Mono > Capture channels: Mono > Limits: 0 - 3 > Mono: 0 [2147483647%] [0.00dB] > Simple mixer control 'Capture',0 > Capabilities: cvolume > Capture channels: Front Left - Front Right > Limits: Capture 0 - 15 > Front Left: Capture 0 [2147483647%] > Front Right: Capture 0 [2147483647%] > Simple mixer control 'Capture Attenuate Switch (-6dB)',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [off] > Simple mixer control 'Capture Mux',0 > Capabilities: enum > Items: 'MIC_IN' 'LINE_IN' > Item0: 'MIC_IN' > Simple mixer control 'Capture ZC',0 > Capabilities: pswitch pswitch-joined > Playback channels: Mono > Mono: Playback [on] > In attachment there is a screenshot of alsamixer All audio stuff are not hear at all.... :-( After the output of the sgtl5000 I have a audio-booster and it is set at the maximum level. I have another board based on the iMX28, SGTL5000 and the same audio booster and everything is working good. So I can suppose something related the initialization of the codec. Any help? Best Regards, Gianluca Renzi -- Eurek s.r.l. | Electronic Engineering | http://www.eurek.it via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120 p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212

2 11

[alsa-devel] [PATCH] aplay: Fix header for raw format
by Ion-Horia Petrisor 03 Jul '17

03 Jul '17

Raw format has no header, so use 0 when calling playback_go. Signed-off-by: Ion-Horia Petrisor <ion-horia.petrisor(a)nxp.com> --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index 00af662..fe274ed 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -2831,7 +2831,7 @@ static void playback(char *name) /* should be raw data */ init_raw_data(); pbrec_count = calc_count(); - playback_go(fd, dta, pbrec_count, FORMAT_RAW, name); + playback_go(fd, 0, pbrec_count, FORMAT_RAW, name); } __end: if (fd != 0) -- 2.7.4

3 6

[alsa-devel] [v2 0/4] Add debugfs support for skylake driver
by Guneshwor Singh 03 Jul '17

03 Jul '17

This series introduces debugfs support for skylake driver. It helps in debugging by providing module configurations which is loaded from topology. It also allows to read the firmware registers which are a part of SRAM memory area accessible by host CPU through a memory window. Guneshwor Singh (1): ASoC: Intel: common: Add sram address to sst_addr structure Sodhi, VunnyX (1): ASoC: Intel: Skylake: Add support to read firmware registers Vinod Koul (2): ASoC: Intel: Skylake: Add debugfs support ASoC: Intel: Skylake: Debugfs facility to dump module config Changes in v2: - Re-ordered patch and squashed platform changes Guneshwor Singh (1): ASoC: Intel: common: Add sram address to sst_addr structure Sodhi, VunnyX (1): ASoC: Intel: Skylake: Add support to read firmware registers Vinod Koul (2): ASoC: Intel: Skylake: Add debugfs support ASoC: Intel: Skylake: Debugfs facility to dump module config sound/soc/intel/common/sst-dsp-priv.h | 4 + sound/soc/intel/skylake/Makefile | 4 + sound/soc/intel/skylake/bxt-sst.c | 4 + sound/soc/intel/skylake/skl-debug.c | 269 +++++++++++++++++++++++++++++++++ sound/soc/intel/skylake/skl-sst.c | 5 + sound/soc/intel/skylake/skl-topology.c | 3 + sound/soc/intel/skylake/skl.c | 5 + sound/soc/intel/skylake/skl.h | 26 ++++ 8 files changed, 320 insertions(+) create mode 100644 sound/soc/intel/skylake/skl-debug.c -- 2.13.0

5 11

[alsa-devel] [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
by Gustavo A. R. Silva 01 Jul '17

01 Jul '17

platform_get_irq() returns an error code, but the ac97c driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- sound/atmel/ac97c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index 65e6948..9d2c9d9 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_dbg(&pdev->dev, "could not get irq\n"); - return -ENXIO; + dev_dbg(&pdev->dev, "could not get irq: %d\n", irq); + return irq; } pclk = clk_get(&pdev->dev, "ac97_clk"); -- 2.5.0

2 1

[alsa-devel] [PATCH] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()
by Gustavo A. R. Silva 30 Jun '17

30 Jun '17

platform_get_irq() returns an error code, but the sata_rcar driver ignores it and always returns -ENODEV. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva(a)embeddedor.com> --- sound/x86/intel_hdmi_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c index c19efc9..a095150 100644 --- a/sound/x86/intel_hdmi_audio.c +++ b/sound/x86/intel_hdmi_audio.c @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) /* get resources */ irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "Could not get irq resource\n"); - return -ENODEV; + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq); + return irq; } res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.5.0

2 7