December 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [RFC v4 0/3] Enable HDA Codec support on Intel Platforms (Series1)
by Rakesh Ughreja 02 Jan '18

02 Jan '18

Enhanced HD Audio capabilities introduced in HD Audio controllers are added in backward compatible way i.e. it does not change the behavior of the controller with respect to HDA Bus and HDA devices. Since there is no change in the hardware with respect to the HDA bus and HDA device it is more appropriate to represent the same in software as well. In order to align software representation with hardware it makes more sense to have common data structures across device, bus and driver for both enhanced HDA controllers and legacy HDA controllers. This patch series removes the hdac_ext_device structure, hdac_ext_bus and hdac_ext_driver data structures so that legacy and enhanced HDaudio capabilities can be handled in a backwards-compatible way without separate definitions. Once this clean-up is complete, additional patches will allow for HDaudio codec support in an ASoC framework without the need to develop new codec drivers, thereby enabling the use of the Intel DSP on more platforms (currently limited to hdmi). Changes in v4: - No changes in this series except rebase as there were no comments. Changes in v3: - No changes in this series except rebase as there were no comments. Changes in v2: - First three patches from v1 are merged so not included in this series. - No changes in this series except rebase as there were no comments. Rakesh Ughreja (3): ALSA: hdac: Remove usage of struct hdac_ext_device and use hdac_device instead ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus instead ALSA: hdac: Remove usage of struct hdac_ext_driver, use hdac_driver instead include/sound/hdaudio.h | 21 ++ include/sound/hdaudio_ext.h | 119 +++------- sound/hda/ext/hdac_ext_bus.c | 76 +++--- sound/hda/ext/hdac_ext_controller.c | 55 +++-- sound/hda/ext/hdac_ext_stream.c | 104 ++++----- sound/soc/codecs/hdac_hdmi.c | 415 ++++++++++++++++----------------- sound/soc/intel/skylake/skl-messages.c | 50 ++-- sound/soc/intel/skylake/skl-nhlt.c | 8 +- sound/soc/intel/skylake/skl-pcm.c | 112 +++++---- sound/soc/intel/skylake/skl-topology.c | 18 +- sound/soc/intel/skylake/skl-topology.h | 6 +- sound/soc/intel/skylake/skl.c | 176 +++++++------- sound/soc/intel/skylake/skl.h | 7 +- 13 files changed, 521 insertions(+), 646 deletions(-) -- 2.7.4

3 5

[alsa-devel] [PATCH] slimbus: qcom: fix incompatible pointer warning
by srinivas.kandagatla＠linaro.org 31 Dec '17

31 Dec '17

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> One of the pointer passed to dmam_alloc_coherent seems to be phys_addr_t * instead of dma_addr_t *. This address will be used by dma apis, so change this to proper type. Reported-by: kbuild test robot <fengguang.wu(a)intel.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- drivers/slimbus/qcom-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 35ad70dbfe3a..f51de1277912 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -93,7 +93,7 @@ struct slim_ctrl_buf { void *base; - phys_addr_t phy; + dma_addr_t phy; spinlock_t lock; int head; int tail; -- 2.15.0

2 1

[alsa-devel] [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support
by Chen.Liu 29 Dec '17

29 Dec '17

From: "Chen.Liu" <chen.liu.opensource(a)gmail.com> Issue: MCLK=24MHZ,SYSCLOCK=12.288MHZ. When the 'wm8960_set_pll' function is called,the driver will prompted "WM8960 PLL: unsupported N = 4" error message. However,the value of PLLN should be 8 based on the table45( PLL Frequency Examples) of the wm8960 chip manuanl. Reason: The intergrated PLL can be used to generate SYSCLK for the wm8960. The pll_factors function in the wm8960.c file is mainly responsible for setting the divider factor of the PLL divider with reference to MCLK clock frequency to obtain the required SYSCLK clock frequency. The configure diagram for this function can be seen below. MCLK-->[f/2]-->[R=f2/f1]-->[f/4]-->[f/N](1)-->SYSCLOCK The configuration of the PLL divider in above diagram is applicable to MCLK clock frequency is less than or equal to 14.4MHZ. examples: (1)MCLK=12MHz, required clock = 12.288MHz. R should be chosen to ensure 5 < PLLN < 13. There is a fixed divide by 4 in the PLL and a selectable divide by N after the PLL which should be set to divide by 1 to meet this requirement. Enabling the divide by 1 sets the required f2 = 4 x 1 x 12.288MHz = 49.152MHz. R = 49.152 / (12 / 2) = 8.192 PLLN = int R = 8 (2)MCLK=24MHz, required clock = 12.288MHz. Enabling the divide by 1 sets the required f2 = 4 x 1 x 12.288MHZ = 49.152MHZ. R = 49.152 / (24 / 2) = 4.096 PLLN = int R = 4 And if the [f/N] reg is set to 2,then the required f2 = 4x2x12.288MHZ = 98.304MHZ. R = 98.304 / (24 / 2) = 8.192 PLLN = int R = 8 Because the [f/N] reg is fixed divide by 1,that's why driver prompted error message. Solution: The purpose of this patch is when the conditions(5 < PLLN < 13) is false, set the register[f/N] to be 2, and the recalculate the divide factor of the PLL divider. MCLK-->[f/2]-->[R=f2/f1]-->[f/4]-->[f/N](2)-->SYSCLOCK Signed-off-by: Chen.Liu <chen.liu.opensource(a)gmail.com> --- Changes in v2: - The calculation of the Ndiv is encapsulated in a loop. - Use 'unsupported' instead of 'unsupport'. --- sound/soc/codecs/wm8960.c | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 997c446..83dd746 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -1036,28 +1036,38 @@ static bool is_pll_freq_available(unsigned int source, unsigned int target) * to allow rounding later */ #define FIXED_PLL_SIZE ((1 << 24) * 10) -static int pll_factors(unsigned int source, unsigned int target, +static int pll_factors(struct snd_soc_codec *codec, + unsigned int source, unsigned int target, struct _pll_div *pll_div) { unsigned long long Kpart; unsigned int K, Ndiv, Nmod; + int unsupported = 0; pr_debug("WM8960 PLL: setting %dHz->%dHz\n", source, target); /* Scale up target to PLL operating frequency */ target *= 4; - Ndiv = target / source; - if (Ndiv < 6) { - source >>= 1; - pll_div->pre_div = 1; + while (1) { Ndiv = target / source; - } else - pll_div->pre_div = 0; + if (Ndiv < 6) { + source >>= 1; + pll_div->pre_div = 1; + Ndiv = target / source; + } else + pll_div->pre_div = 0; + + if ((Ndiv < 6) || (Ndiv > 12)) { + if (unsupported == 1) { + pr_err("WM8960 PLL: Unsupported N=%d\n", Ndiv); + return -EINVAL; + } + } else + break; - if ((Ndiv < 6) || (Ndiv > 12)) { - pr_err("WM8960 PLL: Unsupported N=%d\n", Ndiv); - return -EINVAL; + target *= 2; + unsupported += 1; } pll_div->n = Ndiv; @@ -1077,6 +1087,10 @@ static int pll_factors(unsigned int source, unsigned int target, pll_div->k = K; + if (unsupported) + snd_soc_update_bits(codec, WM8960_CLOCK1, 0x6, + WM8960_SYSCLK_DIV_2); + pr_debug("WM8960 PLL: N=%x K=%x pre_div=%d\n", pll_div->n, pll_div->k, pll_div->pre_div); @@ -1091,7 +1105,7 @@ static int wm8960_set_pll(struct snd_soc_codec *codec, int ret; if (freq_in && freq_out) { - ret = pll_factors(freq_in, freq_out, &pll_div); + ret = pll_factors(codec, freq_in, freq_out, &pll_div); if (ret != 0) return ret; } -- 1.8.3.1

4 13

[alsa-devel] KASAN tool mem leak issue
by b_lkasam＠codeaurora.org 29 Dec '17

29 Dec '17

hi ALSA team, Recently when running KASAN on our devices, we found below KASAN failure wrt uninitialized mem access(or null-ptr deref) in file sound/core/timer.c. And our codebase already have this fix https://www.spinics.net/lists/alsa-devel/msg63410.html Seems issue is still present, please help check and comment. Let me know if you need any other inputs. Observed Result:- ================================================================== sde_rotator ae00000.qcom,mdss_rotator: <SDEROT_WARN> invalid ioctl type c040563d sde_rotator ae00000.qcom,mdss_rotator: <SDEROT_WARN> invalid ioctl type 4c81 BUG: KASAN: null-ptr-deref in copy_to_user arch/arm64/include/asm/uaccess.h:398 [inline] BUG: KASAN: null-ptr-deref in snd_timer_user_read+0x33c/0x458 sound/core/timer.c:2010 Read of size 32 at addr (null) by task syz-executor/2171 sde_rotator ae00000.qcom,mdss_rotator: <SDEROT_WARN> invalid output format 0x00000000 7x2305 CPU: 6 PID: 2171 Comm: syz-executor Tainted: G B W O 4.9.65+ #1 Hardware name: Qualcomm Technologies, Inc. SDM670 PM660 + PM660L MTP (DT) Call trace: [<ffffff9ed988d390>] dump_backtrace+0x0/0x428 arch/arm64/kernel/traps.c:76 [<ffffff9ed988d7e0>] show_stack+0x28/0x38 arch/arm64/kernel/traps.c:226 [<ffffff9ed9e2d9b8>] __dump_stack lib/dump_stack.c:15 [inline] [<ffffff9ed9e2d9b8>] dump_stack+0xd4/0x124 lib/dump_stack.c:51 [<ffffff9ed9b1d77c>] kasan_report_error mm/kasan/report.c:345 [inline] [<ffffff9ed9b1d77c>] kasan_report.part.2+0xdc/0x2f0 mm/kasan/report.c:371 [<ffffff9ed9b1df44>] kasan_report+0x5c/0x70 mm/kasan/report.c:372 [<ffffff9ed9b1c434>] check_memory_region_inline mm/kasan/kasan.c:301 [inline] [<ffffff9ed9b1c434>] check_memory_region+0x12c/0x1c0 mm/kasan/kasan.c:315 [<ffffff9ed9b1c4e0>] kasan_check_read+0x18/0x20 mm/kasan/kasan.c:320 [<ffffff9edad44144>] copy_to_user arch/arm64/include/asm/uaccess.h:398 [inline] [<ffffff9edad44144>] snd_timer_user_read+0x33c/0x458 sound/core/timer.c:2010 [<ffffff9ed9b425e0>] __vfs_read+0xe0/0x2a0 fs/read_write.c:452 [<ffffff9ed9b43e68>] vfs_read+0xb8/0x1c0 fs/read_write.c:475 [<ffffff9ed9b461d4>] SYSC_read fs/read_write.c:591 [inline] [<ffffff9ed9b461d4>] SyS_read+0xcc/0x170 fs/read_write.c:584 [<ffffff9ed9883f70>] el0_svc_naked+0x24/0x28 ================================================================== Thank You, Laxminath Kasam

2 1

[alsa-devel] [PATCH 1/4] ASoC: mediatek: fix error handling in mt2701_afe_pcm_dev_probe()
by Ryder Lee 28 Dec '17

28 Dec '17

Fix unbalanced error handling path which will get incorrect counts if probe failed. The .remove() should be adjusted accordingly. Signed-off-by: Ryder Lee <ryder.lee(a)mediatek.com> --- sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c index 8fda182..b3f6f73 100644 --- a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +++ b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c @@ -1591,8 +1591,12 @@ static int mt2701_afe_pcm_dev_probe(struct platform_device *pdev) platform_set_drvdata(pdev, afe); pm_runtime_enable(&pdev->dev); - if (!pm_runtime_enabled(&pdev->dev)) - goto err_pm_disable; + if (!pm_runtime_enabled(&pdev->dev)) { + ret = mt2701_afe_runtime_resume(&pdev->dev); + if (ret) + goto err_pm_disable; + } + pm_runtime_get_sync(&pdev->dev); ret = snd_soc_register_platform(&pdev->dev, &mtk_afe_pcm_platform); @@ -1610,16 +1614,12 @@ static int mt2701_afe_pcm_dev_probe(struct platform_device *pdev) goto err_dai_component; } - mt2701_afe_runtime_resume(&pdev->dev); - return 0; err_dai_component: - snd_soc_unregister_component(&pdev->dev); - -err_platform: snd_soc_unregister_platform(&pdev->dev); - +err_platform: + pm_runtime_put_sync(&pdev->dev); err_pm_disable: pm_runtime_disable(&pdev->dev); @@ -1628,17 +1628,14 @@ static int mt2701_afe_pcm_dev_probe(struct platform_device *pdev) static int mt2701_afe_pcm_dev_remove(struct platform_device *pdev) { - struct mtk_base_afe *afe = platform_get_drvdata(pdev); - + pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) mt2701_afe_runtime_suspend(&pdev->dev); - pm_runtime_put_sync(&pdev->dev); snd_soc_unregister_component(&pdev->dev); snd_soc_unregister_platform(&pdev->dev); - /* disable afe clock */ - mt2701_afe_disable_clock(afe); + return 0; } -- 1.9.1

1 4

[alsa-devel] Sound to HDMI device delayed
by Freek de Kruijf 28 Dec '17

28 Dec '17

I have the following sound devices: hwinfo --sound Absolute path to 'hwinfo' is '/usr/sbin/hwinfo', so running it may require superuser privileges (eg. root). freek@eiktum:~> /usr/sbin/hwinfo --sound 16: PCI 14.2: 0403 Audio device [Created at pci.378] Unique ID: 5Dex.BDUuYMOWyw7 SysFS ID: /devices/pci0000:00/0000:00:14.2 SysFS BusID: 0000:00:14.2 Hardware Class: sound Model: "ATI SBx00 Azalia (Intel HDA)" Vendor: pci 0x1002 "ATI Technologies Inc" Device: pci 0x4383 "SBx00 Azalia (Intel HDA)" SubVendor: pci 0x1002 "ATI Technologies Inc" SubDevice: pci 0x4383 Revision: 0x40 Memory Range: 0xfe6f8000-0xfe6fbfff (rw,non-prefetchable) IRQ: 10 (no events) Module Alias: "pci:v00001002d00004383sv00001002sd00004383bc04sc03i00" Driver Info #0: Driver Status: snd_hda_intel is active Driver Activation Cmd: "modprobe snd_hda_intel" Config Status: cfg=yes, avail=yes, need=no, active=unknown 26: PCI 500.1: 0403 Audio device [Created at pci.378] Unique ID: 5yAR.dhjYDcGDBr3 Parent ID: _Znp.ZJmKoWxd6BF SysFS ID: /devices/pci0000:00/0000:00:02.0/0000:05:00.1 SysFS BusID: 0000:05:00.1 Hardware Class: sound Model: "ATI RV770 HDMI Audio [Radeon HD 4850/4870]" Vendor: pci 0x1002 "ATI Technologies Inc" Device: pci 0xaa30 "RV770 HDMI Audio [Radeon HD 4850/4870]" SubVendor: pci 0x1787 "Hightech Information System Ltd." SubDevice: pci 0xaa30 Driver: "snd_hda_intel" Driver Modules: "snd_hda_intel" Memory Range: 0xfe9ec000-0xfe9effff (rw,non-prefetchable) IRQ: 36 (1104 events) Module Alias: "pci:v00001002d0000AA30sv00001787sd0000AA30bc04sc03i00" Driver Info #0: Driver Status: snd_hda_intel is active Driver Activation Cmd: "modprobe snd_hda_intel" Config Status: cfg=yes, avail=yes, need=no, active=unknown Attached to: #18 (PCI bridge) I have my monitor connected via HDMI and that monitor has speakers. The monitor is: hwinfo --monitor 29: None 00.0: 10002 LCD Monitor [Created at monitor.125] Unique ID: rdCR.ukgc1_4VzS0 Parent ID: Ddhb.zvQlrOmSRQ8 Hardware Class: monitor Model: "R231" Vendor: ACR Device: eisa 0x0504 "R231" Serial ID: "T6GEE0012400" Resolution: 720x400@70Hz Resolution: 640x480@60Hz Resolution: 640x480@67Hz Resolution: 800x600@56Hz Resolution: 800x600@60Hz Resolution: 1024x768@60Hz Resolution: 1024x768@70Hz Resolution: 1152x864@75Hz Resolution: 1280x1024@60Hz Resolution: 1280x720@60Hz Resolution: 1920x1080@60Hz Size: 509x286 mm Year of Manufacture: 2016 Week of Manufacture: 4 Detailed Timings #0: Resolution: 1920x1080 Horizontal: 1920 2008 2052 2200 (+88 +132 +280) +hsync Vertical: 1080 1084 1089 1125 (+4 +9 +45) +vsync Frequencies: 148.50 MHz, 67.50 kHz, 60.00 Hz Driver Info #0: Max. Resolution: 1920x1080 Vert. Sync Range: 56-75 Hz Hor. Sync Range: 31-75 kHz Bandwidth: 148 MHz Config Status: cfg=no, avail=yes, need=no, active=unknown Attached to: #8 (VGA compatible controller) The sound is working OK, however the problem is that the sound is delayed by about one second compared to the picture on the screen. Most visible/hearable by using Musescore, where a music note is highlighted when it is played. Using VGA and the other sound card there is no delay. output of alsa-info.sh is attached. -- fr.gr. member openSUSE Freek de Kruijf

1 0

[alsa-devel] pulseaudio crash when unplugging hdmi while playing audio over hdmi on Cherry Trail devices
by Hans de Goede 28 Dec '17

28 Dec '17

Hi All, First of all good news, with kernel 4.15-rc2 and alsa-lib 1.1.5 audio over hdmi works on Cherry Trail devices after selecting the right output profile. But when unplugging the hdmi cable pa dies. Running pa under gdb says it gets killed with SIGKILL, so I think this is another realtime issue where it gets killed by the kernel for exceeding its CPU budget. I've a log file of a run which ends with SIGKILL here: https://fedorapeople.org/~jwrdegoede/pulseaudio-cht-hdmi.log What stands out is a whole lot of errors / underruns after: D: [pulseaudio] module-alsa-card.c: Jack 'HDMI/DP,pcm=1 Jack' is now unplugged D: [pulseaudio] device-port.c: Setting port hdmi-output-1 to status no So it seems that the problem is that pa still tries to use the device after the unplug, even though it sees the unplug before getting any errors. Regards, Hans

2 2

[alsa-devel] ALSA: Soc_compress open file node allows more than once
by b_lkasam＠codeaurora.org 28 Dec '17

28 Dec '17

Hi ALSA team, This is regarding compress offload framework file operations wrt open system call. For open call to this driver currently allows for same node more than once. This may result in memleak issues or data corruption if same node in use by multiple instances. can we have restriction to avoid open of same node using some refcount? we can either have refcount under compr->private_data and cross check in below function before proceeding. static int snd_compr_open(struct inode *inode, struct file *f) Please suggest accordingly. Thanks Laxminath Kasam, Qualcomm.

3 3

[alsa-devel] [PATCH] ASoC: rt5514-spi: Check the validity of drvdata pointer on resume
by Marc Zyngier 27 Dec '17

27 Dec '17

The rt5514-spi driver seem to assume the validity of the drvdata pointer on resume, which it may not be populated, leading to a not-so-nice crash. This stems from the fact that rt5514_spi_pcm_probe() is never called on my system (a kevin Chromebook). No idea why, but if it can happen, it is worth fixing. Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule data copy in resume function") Signed-off-by: Marc Zyngier <marc.zyngier(a)arm.com> --- sound/soc/codecs/rt5514-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 2df91db765ac..9255afcf2c3a 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -482,7 +482,7 @@ static int __maybe_unused rt5514_resume(struct device *dev) if (device_may_wakeup(dev)) disable_irq_wake(irq); - if (rt5514_dsp->substream) { + if (rt5514_dsp && rt5514_dsp->substream) { rt5514_spi_burst_read(RT5514_IRQ_CTRL, (u8 *)&buf, sizeof(buf)); if (buf[0] & RT5514_IRQ_STATUS_BIT) rt5514_schedule_copy(rt5514_dsp); -- 2.14.2

1 0

[alsa-devel] [PATCH 0/3] ASoC: remove symmetric_xxx from snd_soc_dai
by Kuninori Morimoto 27 Dec '17

27 Dec '17

Hi Mark These are not important, but cleanup. Current snd_soc_dai has symmetric_xxx, but these are moved to snd_soc_dai_driver now. wm2200 is the only user now. Kuninori Morimoto (3): ASoC: wm2200: use snd_soc_codec_get_drvdata() ASoC: wm2200: don't use snd_soc_dai::symmetric_rates ASoC: soc-dai.h: remove symmetric_xxx from snd_soc_dai include/sound/soc-dai.h | 3 --- sound/soc/codecs/wm2200.c | 9 ++++++--- 2 files changed, 6 insertions(+), 6 deletions(-) -- 1.9.1

2 6