October 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc236
by Hui Wang 24 Oct '17

24 Oct '17

We have several Dell laptops which use the codec alc236, the headset mic can't work on these machines. Following the commit 736f20a70, we add the pin cfg table to make the headset mic work. Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 701eb7d..02c79d6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6429,6 +6429,14 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { ALC225_STANDARD_PINS, {0x12, 0xb7a60130}, {0x1b, 0x90170110}), + SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0x90a60140}, + {0x14, 0x90170110}, + {0x21, 0x02211020}), + SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0x90a60140}, + {0x14, 0x90170150}, + {0x21, 0x02211020}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, {0x14, 0x90170110}, {0x21, 0x02211020}), -- 2.7.4

2 1

[alsa-devel] [PATCH v2 34/37] ALSA/dummy: Replace tasklet with softirq hrtimer
by Anna-Maria Gleixner 24 Oct '17

24 Oct '17

From: Thomas Gleixner <tglx(a)linutronix.de> The tasklet is used to defer the execution of snd_pcm_period_elapsed() to the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer callback in softirq context as well which renders the tasklet useless. [o-takashi: avoid stall due to a call of hrtimer_cancel() on a callback of hrtimer] Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Signed-off-by: Anna-Maria Gleixner <anna-maria(a)linutronix.de> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Cc: alsa-devel(a)alsa-project.org Link: http://lkml.kernel.org/r/20170905161820.jtysvxtfleunbbmf@breakpoint.cc --- On 2017-09-06 01:05:43 [+0900], Takashi Sakamoto wrote: > As Iwai-san mentioned, in this function, .trigger can be called in two > cases; XRUN occurs and draining is done. Thus, let you change the comment as > 'In cases of XRUN and draining, this calls .trigger to stop PCM substream.'. > I'm sorry to trouble you. > > snd_pcm_period_elapsed() > ->snd_pcm_update_hw_ptr0() > ->snd_pcm_update_state() > ->snd_pcm_drain_done() > ... > ->.trigger(TRIGGER_STOP) > ->xrun() > ->snd_pcm_stop() > ... > ->.trigger(TRIGGER_STOP) > I think you asked me just to update the comment. Did I do it right? v2...v3: updated the comment as per Takashi Sakamoto's suggestion. v1...v2: merged Takashi Sakamoto fixup of the original patch into v2. sound/drivers/dummy.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -376,17 +376,9 @@ struct dummy_hrtimer_pcm { ktime_t period_time; atomic_t running; struct hrtimer timer; - struct tasklet_struct tasklet; struct snd_pcm_substream *substream; }; -static void dummy_hrtimer_pcm_elapsed(unsigned long priv) -{ - struct dummy_hrtimer_pcm *dpcm = (struct dummy_hrtimer_pcm *)priv; - if (atomic_read(&dpcm->running)) - snd_pcm_period_elapsed(dpcm->substream); -} - static enum hrtimer_restart dummy_hrtimer_callback(struct hrtimer *timer) { struct dummy_hrtimer_pcm *dpcm; @@ -394,7 +386,14 @@ static enum hrtimer_restart dummy_hrtime dpcm = container_of(timer, struct dummy_hrtimer_pcm, timer); if (!atomic_read(&dpcm->running)) return HRTIMER_NORESTART; - tasklet_schedule(&dpcm->tasklet); + /* + * In cases of XRUN and draining, this calls .trigger to stop PCM + * substream. + */ + snd_pcm_period_elapsed(dpcm->substream); + if (!atomic_read(&dpcm->running)) + return HRTIMER_NORESTART; + hrtimer_forward_now(timer, dpcm->period_time); return HRTIMER_RESTART; } @@ -404,7 +403,7 @@ static int dummy_hrtimer_start(struct sn struct dummy_hrtimer_pcm *dpcm = substream->runtime->private_data; dpcm->base_time = hrtimer_cb_get_time(&dpcm->timer); - hrtimer_start(&dpcm->timer, dpcm->period_time, HRTIMER_MODE_REL); + hrtimer_start(&dpcm->timer, dpcm->period_time, HRTIMER_MODE_REL_SOFT); atomic_set(&dpcm->running, 1); return 0; } @@ -414,14 +413,14 @@ static int dummy_hrtimer_stop(struct snd struct dummy_hrtimer_pcm *dpcm = substream->runtime->private_data; atomic_set(&dpcm->running, 0); - hrtimer_cancel(&dpcm->timer); + if (!hrtimer_callback_running(&dpcm->timer)) + hrtimer_cancel(&dpcm->timer); return 0; } static inline void dummy_hrtimer_sync(struct dummy_hrtimer_pcm *dpcm) { hrtimer_cancel(&dpcm->timer); - tasklet_kill(&dpcm->tasklet); } static snd_pcm_uframes_t @@ -466,12 +465,10 @@ static int dummy_hrtimer_create(struct s if (!dpcm) return -ENOMEM; substream->runtime->private_data = dpcm; - hrtimer_init(&dpcm->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); + hrtimer_init(&dpcm->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT); dpcm->timer.function = dummy_hrtimer_callback; dpcm->substream = substream; atomic_set(&dpcm->running, 0); - tasklet_init(&dpcm->tasklet, dummy_hrtimer_pcm_elapsed, - (unsigned long)dpcm); return 0; }

2 1

[alsa-devel] [PATCH v3] ALSA: hda: Abort capability probe on invalid capability
by Rakesh Ughreja 24 Oct '17

24 Oct '17

On reading wrong capability pointer values driver may crash, so whenever driver discovers unknown HDA capability, log it as error and stop traversing the link list further. Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja(a)intel.com> --- sound/hda/hdac_controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 978dc18..8f7d0d9 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus) break; default: - dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap); + dev_err(bus->dev, "Unknown capability %d\n", cur_cap); + cur_cap = 0; break; } -- 2.7.4

3 2

[alsa-devel] how to dynamic link one cpu dai to codec dai?
by Gou, Kylin 24 Oct '17

24 Oct '17

Hi Sir, I registered 2 codec dai and 1 cpu dai . However , I want to link cpu dai to different codec dai , can we dynamic link cpu dai to each codec dai? I didn't find any document for it. Thanks, Kylin ******************************* IMPORTANT MESSAGE ****************************** This transmission may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. ********************************************************************************

1 0

[alsa-devel] Prague Audio miniconference - topics for discussion?
by Mark Brown 23 Oct '17

23 Oct '17

As previously announced[1] by Takashi our annual Linux audio miniconference will be held this year at the SuSE offices in Prague on 27th October (the week of ELC-E). Thanks again to SuSe for sponsoring this. As with previous years let's pull together an agenda through a mailing list discussion - if people could reply to this mail with any topics they'd like to discuss we can take it from there. Of course if we can sort things out more quickly via the mailing list that's even better! I'll start things off by mentining the TLV issues that Sakamoto-san was raising - do we have any better ideas to handle larger binary controls than what's currently being done? [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124623.html

6 6

[alsa-devel] [PATCH] ASoC: Intel: Add depends on X86
by Vinod Koul 23 Oct '17

23 Oct '17

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Make all Intel audio drivers dependent on X86 to avoid compilation errors for s390 and xtensa architectures. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reported-by: kbuild test robot <fengguang.wu(a)intel.com> Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> --- sound/soc/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 1dcc9e456610..a59dda39007e 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -31,6 +31,7 @@ config SND_SOC_ACPI_INTEL_MATCH config SND_SOC_INTEL_SST_TOPLEVEL tristate "Intel ASoC SST drivers" + depends on X86 select SND_SOC_INTEL_MACH select SND_SOC_INTEL_COMMON -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget
by Carlo Caione 23 Oct '17

23 Oct '17

From: Carlo Caione <carlo(a)endlessm.com> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. Signed-off-by: Carlo Caione <carlo(a)endlessm.com> --- sound/soc/codecs/rt5651.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index da60b28ba3df..28f7210cec91 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -883,8 +883,8 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { /* micbias */ SND_SOC_DAPM_SUPPLY("LDO", RT5651_PWR_ANLG1, RT5651_PWR_LDO_BIT, 0, NULL, 0), - SND_SOC_DAPM_MICBIAS("micbias1", RT5651_PWR_ANLG2, - RT5651_PWR_MB1_BIT, 0), + SND_SOC_DAPM_SUPPLY("micbias1", RT5651_PWR_ANLG2, + RT5651_PWR_MB1_BIT, 0, NULL, 0), /* Input Lines */ SND_SOC_DAPM_INPUT("MIC1"), SND_SOC_DAPM_INPUT("MIC2"), -- 2.14.2

3 3

[alsa-devel] [asoc:topic/intel 38/38] sound/soc/intel/common/sst-firmware.c:1278:20: error: expected declaration specifiers or '...' before string constant
by kbuild test robot 23 Oct '17

23 Oct '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: f6a118a800e35af2c63f90cbcc23093f4b53b3a2 commit: f6a118a800e35af2c63f90cbcc23093f4b53b3a2 [38/38] ASoC: Intel: clarify Kconfig dependencies config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout f6a118a800e35af2c63f90cbcc23093f4b53b3a2 # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): >> sound/soc/intel/common/sst-firmware.c:1278:20: error: expected declaration specifiers or '...' before string constant MODULE_DESCRIPTION("Intel SST Firmware Loader"); ^ sound/soc/intel/common/sst-firmware.c:1279:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^ -- sound/soc/intel/haswell/sst-haswell-pcm.c: In function 'create_adsp_page_table': >> sound/soc/intel/haswell/sst-haswell-pcm.c:446:2: error: implicit declaration of function 'snd_sgbuf_aligned_pages' [-Werror=implicit-function-declaration] pages = snd_sgbuf_aligned_pages(size); ^ cc1: some warnings being treated as errors vim +1278 sound/soc/intel/common/sst-firmware.c a395bdd6 Takashi Iwai 2016-07-11 1277 a395bdd6 Takashi Iwai 2016-07-11 @1278 MODULE_DESCRIPTION("Intel SST Firmware Loader"); :::::: The code at line 1278 was first introduced by commit :::::: a395bdd6b24b692adbce0df6510ec9f2af57573e ASoC: intel: Fix sst-dsp dependency on dw stuff :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

4 5

[alsa-devel] HDMI LPE audio on Intel Compute Stick 2nd Gen (CHT)
by Ian W MORRISON 22 Oct '17

22 Oct '17

Hi Pierre, I've just noticed that non of the kernels from v4.13 and up run on my Intel Compute Stick (2nd gen Cherry Trail STK1AW32SC) unit and have HDMI LPE audio working. Before I spend anytime looking into this can you confirm if you have the same issue as I just want to rule out a hardware malfunction with my unit first? Thanks, Ian

3 7

[alsa-devel] [asoc:topic/intel 38/38] sound/soc//intel/skylake/skl-sst-cldma.c:92:22: error: implicit declaration of function 'virt_to_phys'
by kbuild test robot 21 Oct '17

21 Oct '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: f6a118a800e35af2c63f90cbcc23093f4b53b3a2 commit: f6a118a800e35af2c63f90cbcc23093f4b53b3a2 [38/38] ASoC: Intel: clarify Kconfig dependencies config: s390-allyesconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout f6a118a800e35af2c63f90cbcc23093f4b53b3a2 # save the attached .config to linux build tree make.cross ARCH=s390 All errors (new ones prefixed by >>): sound/soc//intel/skylake/skl-sst-cldma.c: In function 'skl_cldma_setup_bdle': >> sound/soc//intel/skylake/skl-sst-cldma.c:92:22: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration] phys_addr_t addr = virt_to_phys(dmab_data->area + ^~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/virt_to_phys +92 sound/soc//intel/skylake/skl-sst-cldma.c a4386450b Jeeja KP 2015-12-18 82 914426c86 Vinod Koul 2015-07-10 83 /* Code loader helper APIs */ 914426c86 Vinod Koul 2015-07-10 84 static void skl_cldma_setup_bdle(struct sst_dsp *ctx, 914426c86 Vinod Koul 2015-07-10 85 struct snd_dma_buffer *dmab_data, 914426c86 Vinod Koul 2015-07-10 86 u32 **bdlp, int size, int with_ioc) 914426c86 Vinod Koul 2015-07-10 87 { 914426c86 Vinod Koul 2015-07-10 88 u32 *bdl = *bdlp; 914426c86 Vinod Koul 2015-07-10 89 914426c86 Vinod Koul 2015-07-10 90 ctx->cl_dev.frags = 0; 914426c86 Vinod Koul 2015-07-10 91 while (size > 0) { 914426c86 Vinod Koul 2015-07-10 @92 phys_addr_t addr = virt_to_phys(dmab_data->area + 914426c86 Vinod Koul 2015-07-10 93 (ctx->cl_dev.frags * ctx->cl_dev.bufsize)); 914426c86 Vinod Koul 2015-07-10 94 914426c86 Vinod Koul 2015-07-10 95 bdl[0] = cpu_to_le32(lower_32_bits(addr)); 914426c86 Vinod Koul 2015-07-10 96 bdl[1] = cpu_to_le32(upper_32_bits(addr)); 914426c86 Vinod Koul 2015-07-10 97 914426c86 Vinod Koul 2015-07-10 98 bdl[2] = cpu_to_le32(ctx->cl_dev.bufsize); 914426c86 Vinod Koul 2015-07-10 99 914426c86 Vinod Koul 2015-07-10 100 size -= ctx->cl_dev.bufsize; 914426c86 Vinod Koul 2015-07-10 101 bdl[3] = (size || !with_ioc) ? 0 : cpu_to_le32(0x01); 914426c86 Vinod Koul 2015-07-10 102 914426c86 Vinod Koul 2015-07-10 103 bdl += 4; 914426c86 Vinod Koul 2015-07-10 104 ctx->cl_dev.frags++; 914426c86 Vinod Koul 2015-07-10 105 } 914426c86 Vinod Koul 2015-07-10 106 } 914426c86 Vinod Koul 2015-07-10 107 :::::: The code at line 92 was first introduced by commit :::::: 914426c8657c1e934b015ffa32e7bfd0cb34f47f ASoC: Intel: Skylake: add code loader DMA operations :::::: TO: Vinod Koul <vinod.koul(a)intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0