October 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/6] ASoC: Intel: Skylake: Add a clk driver to enable ssp clks early
by Subhransu S. Prusty 24 Oct '17

24 Oct '17

For certain platforms we require to start the clocks (mclk/sclk/fs) before the stream start. Example: for few systems, codec needs the mclk/sclk/fs to be enabled early for a successful clock synchronization and for some others, clock need to be enabled at boot and should be ON always. By sending set_dma_control IPC (with the i2s blobs queried from NHLT), these clocks can be enabled early after the firmware is downloaded. With this series, a virtual clock driver is created which provides interface to send the required IPCs from machine driver to enable the clocks. NHLT is parsed during probe and the clock information is populated. The pointer to blob is cached and sent along with the set_dma_control IPC structure during the clk prepare/unprepare callback. Clocks are created for a ssp if the nhlt table has endpoint configuration for that particular ssp. Skylake driver creates a platform driver with the clock information and register the clk ops callback. kabylake machine driver uses the clock interface to enable the clocks early as it is required by the rt5663 driver for clock synchronization. set_dma_control API can be used with different payload configuration. Modify the arguments to take configurable parameters. Harsha Priya (1): ASoC: Intel: kbl: Enable mclk and ssp sclk early Jaikrishna Nemallapudi (5): ASoC: Intel: Skylake: Modify skl_dsp_set_dma_control API arguments ASoC: Intel: Skylake: Parse nhlt to populate clock information ASoC: Intel: Skylake: Prepare DMA control IPC to enable/disable clock ASoC: Intel: Skylake: Register clock device and ops ASoC: Intel: Skylake: Add ssp clock driver sound/soc/intel/Kconfig | 8 + sound/soc/intel/boards/kbl_rt5663_max98927.c | 94 ++++++++- sound/soc/intel/skylake/Makefile | 5 + sound/soc/intel/skylake/skl-i2s.h | 56 ++++++ sound/soc/intel/skylake/skl-messages.c | 109 +++++++++- sound/soc/intel/skylake/skl-nhlt.c | 148 ++++++++++++++ sound/soc/intel/skylake/skl-ssp-clk.c | 287 +++++++++++++++++++++++++++ sound/soc/intel/skylake/skl-ssp-clk.h | 124 ++++++++++++ sound/soc/intel/skylake/skl-topology.h | 4 +- sound/soc/intel/skylake/skl.c | 235 ++++++++++++++++++++++ sound/soc/intel/skylake/skl.h | 12 ++ 11 files changed, 1070 insertions(+), 12 deletions(-) create mode 100644 sound/soc/intel/skylake/skl-i2s.h create mode 100644 sound/soc/intel/skylake/skl-ssp-clk.c create mode 100644 sound/soc/intel/skylake/skl-ssp-clk.h -- 1.9.1

5 17

[alsa-devel] ASoC: writing basic custom codecs?
by Albin Stigö 24 Oct '17

24 Oct '17

Hello, I have implemented a custom i2s codec on an FPGA. Because of how the FPGA is clocked I'm getting samples at 39ksps, which to my surprise worked great after some simple kernel patching (the codec is bit & frame master). For experimentation I used the snd-soc-dummy coded defined in soc-utils.c. Now I'm trying to write a very simple codec to "lock" the rate to 39000: https://github.com/ast/vfzfpga-codec The driver loads just fine but I just get "not registered" when I try to use the codec. I feel I'm missing something very obvious here. I've been through the documentation and tried to read the sources but I'm a bit stuck.. What am I missing? --Albin

1 0

[alsa-devel] Prague Audio miniconference - draft schedule
by Mark Brown 24 Oct '17

24 Oct '17

As previously announced[1] by Takashi our annual Linux audio miniconference will be held this year at the SuSE offices in Prague on Friday 27th October (the week of ELC-E). Thanks again to SuSE for sponsoring this. Following the earlier discussion I've pulled together a list of topics. I've put people's names against everything, mostly the people who suggested things but sometimes also other people who should probably be involved. I'm proposing that we work through things in roughly this order. Does this make sense to people? Any other topics? Summary - API status summary (tiwai) - Userspace release schedule - Docs - Dropping old drivers - Treble overview (Eric) - aplay rewrite (Sakamoto-san) ABI issues - USB PCM handling (tiwai) - mmap no IRQ (Eric) - TLV API issues (Sakamoto-san) - Obsolete dimen from struct snd_ctl_elem_info (Sakamoto-san) - Y2038 (tiwai) Future stuff/internals - Clock handling (Peter) - CCF, multi-clock selection - Digital domains (Charles/Lars/Morimoto-san) - Large regmaps (Charles) [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124623.html

3 6

[alsa-devel] [PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc236
by Hui Wang 24 Oct '17

24 Oct '17

We have several Dell laptops which use the codec alc236, the headset mic can't work on these machines. Following the commit 736f20a70, we add the pin cfg table to make the headset mic work. Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 701eb7d..02c79d6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6429,6 +6429,14 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { ALC225_STANDARD_PINS, {0x12, 0xb7a60130}, {0x1b, 0x90170110}), + SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0x90a60140}, + {0x14, 0x90170110}, + {0x21, 0x02211020}), + SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0x90a60140}, + {0x14, 0x90170150}, + {0x21, 0x02211020}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, {0x14, 0x90170110}, {0x21, 0x02211020}), -- 2.7.4

2 1

[alsa-devel] [PATCH v2 34/37] ALSA/dummy: Replace tasklet with softirq hrtimer
by Anna-Maria Gleixner 24 Oct '17

24 Oct '17

From: Thomas Gleixner <tglx(a)linutronix.de> The tasklet is used to defer the execution of snd_pcm_period_elapsed() to the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer callback in softirq context as well which renders the tasklet useless. [o-takashi: avoid stall due to a call of hrtimer_cancel() on a callback of hrtimer] Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Signed-off-by: Anna-Maria Gleixner <anna-maria(a)linutronix.de> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Cc: alsa-devel(a)alsa-project.org Link: http://lkml.kernel.org/r/20170905161820.jtysvxtfleunbbmf@breakpoint.cc --- On 2017-09-06 01:05:43 [+0900], Takashi Sakamoto wrote: > As Iwai-san mentioned, in this function, .trigger can be called in two > cases; XRUN occurs and draining is done. Thus, let you change the comment as > 'In cases of XRUN and draining, this calls .trigger to stop PCM substream.'. > I'm sorry to trouble you. > > snd_pcm_period_elapsed() > ->snd_pcm_update_hw_ptr0() > ->snd_pcm_update_state() > ->snd_pcm_drain_done() > ... > ->.trigger(TRIGGER_STOP) > ->xrun() > ->snd_pcm_stop() > ... > ->.trigger(TRIGGER_STOP) > I think you asked me just to update the comment. Did I do it right? v2...v3: updated the comment as per Takashi Sakamoto's suggestion. v1...v2: merged Takashi Sakamoto fixup of the original patch into v2. sound/drivers/dummy.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -376,17 +376,9 @@ struct dummy_hrtimer_pcm { ktime_t period_time; atomic_t running; struct hrtimer timer; - struct tasklet_struct tasklet; struct snd_pcm_substream *substream; }; -static void dummy_hrtimer_pcm_elapsed(unsigned long priv) -{ - struct dummy_hrtimer_pcm *dpcm = (struct dummy_hrtimer_pcm *)priv; - if (atomic_read(&dpcm->running)) - snd_pcm_period_elapsed(dpcm->substream); -} - static enum hrtimer_restart dummy_hrtimer_callback(struct hrtimer *timer) { struct dummy_hrtimer_pcm *dpcm; @@ -394,7 +386,14 @@ static enum hrtimer_restart dummy_hrtime dpcm = container_of(timer, struct dummy_hrtimer_pcm, timer); if (!atomic_read(&dpcm->running)) return HRTIMER_NORESTART; - tasklet_schedule(&dpcm->tasklet); + /* + * In cases of XRUN and draining, this calls .trigger to stop PCM + * substream. + */ + snd_pcm_period_elapsed(dpcm->substream); + if (!atomic_read(&dpcm->running)) + return HRTIMER_NORESTART; + hrtimer_forward_now(timer, dpcm->period_time); return HRTIMER_RESTART; } @@ -404,7 +403,7 @@ static int dummy_hrtimer_start(struct sn struct dummy_hrtimer_pcm *dpcm = substream->runtime->private_data; dpcm->base_time = hrtimer_cb_get_time(&dpcm->timer); - hrtimer_start(&dpcm->timer, dpcm->period_time, HRTIMER_MODE_REL); + hrtimer_start(&dpcm->timer, dpcm->period_time, HRTIMER_MODE_REL_SOFT); atomic_set(&dpcm->running, 1); return 0; } @@ -414,14 +413,14 @@ static int dummy_hrtimer_stop(struct snd struct dummy_hrtimer_pcm *dpcm = substream->runtime->private_data; atomic_set(&dpcm->running, 0); - hrtimer_cancel(&dpcm->timer); + if (!hrtimer_callback_running(&dpcm->timer)) + hrtimer_cancel(&dpcm->timer); return 0; } static inline void dummy_hrtimer_sync(struct dummy_hrtimer_pcm *dpcm) { hrtimer_cancel(&dpcm->timer); - tasklet_kill(&dpcm->tasklet); } static snd_pcm_uframes_t @@ -466,12 +465,10 @@ static int dummy_hrtimer_create(struct s if (!dpcm) return -ENOMEM; substream->runtime->private_data = dpcm; - hrtimer_init(&dpcm->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); + hrtimer_init(&dpcm->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT); dpcm->timer.function = dummy_hrtimer_callback; dpcm->substream = substream; atomic_set(&dpcm->running, 0); - tasklet_init(&dpcm->tasklet, dummy_hrtimer_pcm_elapsed, - (unsigned long)dpcm); return 0; }

2 1

[alsa-devel] [PATCH v3] ALSA: hda: Abort capability probe on invalid capability
by Rakesh Ughreja 24 Oct '17

24 Oct '17

On reading wrong capability pointer values driver may crash, so whenever driver discovers unknown HDA capability, log it as error and stop traversing the link list further. Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja(a)intel.com> --- sound/hda/hdac_controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 978dc18..8f7d0d9 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus) break; default: - dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap); + dev_err(bus->dev, "Unknown capability %d\n", cur_cap); + cur_cap = 0; break; } -- 2.7.4

3 2

[alsa-devel] how to dynamic link one cpu dai to codec dai?
by Gou, Kylin 24 Oct '17

24 Oct '17

Hi Sir, I registered 2 codec dai and 1 cpu dai . However , I want to link cpu dai to different codec dai , can we dynamic link cpu dai to each codec dai? I didn't find any document for it. Thanks, Kylin ******************************* IMPORTANT MESSAGE ****************************** This transmission may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. ********************************************************************************

1 0

[alsa-devel] Prague Audio miniconference - topics for discussion?
by Mark Brown 23 Oct '17

23 Oct '17

As previously announced[1] by Takashi our annual Linux audio miniconference will be held this year at the SuSE offices in Prague on 27th October (the week of ELC-E). Thanks again to SuSe for sponsoring this. As with previous years let's pull together an agenda through a mailing list discussion - if people could reply to this mail with any topics they'd like to discuss we can take it from there. Of course if we can sort things out more quickly via the mailing list that's even better! I'll start things off by mentining the TLV issues that Sakamoto-san was raising - do we have any better ideas to handle larger binary controls than what's currently being done? [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124623.html

6 6

[alsa-devel] [PATCH] ASoC: Intel: Add depends on X86
by Vinod Koul 23 Oct '17

23 Oct '17

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Make all Intel audio drivers dependent on X86 to avoid compilation errors for s390 and xtensa architectures. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reported-by: kbuild test robot <fengguang.wu(a)intel.com> Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> --- sound/soc/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 1dcc9e456610..a59dda39007e 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -31,6 +31,7 @@ config SND_SOC_ACPI_INTEL_MATCH config SND_SOC_INTEL_SST_TOPLEVEL tristate "Intel ASoC SST drivers" + depends on X86 select SND_SOC_INTEL_MACH select SND_SOC_INTEL_COMMON -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget
by Carlo Caione 23 Oct '17

23 Oct '17

From: Carlo Caione <carlo(a)endlessm.com> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. Signed-off-by: Carlo Caione <carlo(a)endlessm.com> --- sound/soc/codecs/rt5651.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index da60b28ba3df..28f7210cec91 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -883,8 +883,8 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { /* micbias */ SND_SOC_DAPM_SUPPLY("LDO", RT5651_PWR_ANLG1, RT5651_PWR_LDO_BIT, 0, NULL, 0), - SND_SOC_DAPM_MICBIAS("micbias1", RT5651_PWR_ANLG2, - RT5651_PWR_MB1_BIT, 0), + SND_SOC_DAPM_SUPPLY("micbias1", RT5651_PWR_ANLG2, + RT5651_PWR_MB1_BIT, 0, NULL, 0), /* Input Lines */ SND_SOC_DAPM_INPUT("MIC1"), SND_SOC_DAPM_INPUT("MIC2"), -- 2.14.2

3 3