August 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Alsamixer: missing Speakers entry in analog output choice (chipset AV200)
by Germano Massullo 08 Jan '17

08 Jan '17

I have a Asus Xonar Essence ST soundboard (Chip: AV200) on Fedora 23 kernel 4.4.5-300.fc23.x86_64 The audiocard has 3 different outputs - Speakers - Headphones - FP Headphones that have mutual exclusion, so that when you are using one of them, you cannot use the others. Sometimes the Speakers output disappears from alsamixer. By restarting the computer, the system gets back to its normal behaviour. I attach 3 logs taken when the problem was occurring. The problem happened also in past years, but in last a 1-2 years it happened less frequently

3 3

[alsa-devel] [PATCH - alsa-lib 1/1] Change card/pid get functions to return -ENOSYS if the kernel is too old
by Adam Goode 03 Jan '17

03 Jan '17

When trying to get the pid or card of a client, the get functions will return -1 if there is no pid or card for a client. Clients have zero or one of these, so -1 is correct for these cases. But we also need to detect the case where the kernel cannot tell us if there is a card or pid, so that userspace can fallback to probing this information in the old way. Signed-off-by: Adam Goode <agoode(a)google.com> diff --git a/src/seq/seq.c b/src/seq/seq.c index 4405e68..7de1e81 100644 --- a/src/seq/seq.c +++ b/src/seq/seq.c @@ -1522,9 +1522,10 @@ int snd_seq_client_info_get_error_bounce(const snd_seq_client_info_t *info) } /** - * \brief Get the sound card number. + * \brief Get the sound card number if the kernel supports this. * \param info client_info container - * \return card number or -1 if value is not available. + * \return card number, -1 if there is no card for this client, + * or \c -ENOSYS if the kernel does not have support for this operation * * Only available for SND_SEQ_KERNEL_CLIENT clients. */ @@ -1535,9 +1536,10 @@ int snd_seq_client_info_get_card(const snd_seq_client_info_t *info) } /** - * \brief Get the owning PID. + * \brief Get the owning PID if the kernel supports this. * \param info client_info container - * \return pid or -1 if value is not available. + * \return pid, -1 if there is no PID for this client, + * or \c -ENOSYS if the kernel does not have support for this operation * * Only available for SND_SEQ_USER_CLIENT clients. */ diff --git a/src/seq/seq_hw.c b/src/seq/seq_hw.c index 578ef12..a1d1e4a 100644 --- a/src/seq/seq_hw.c +++ b/src/seq/seq_hw.c @@ -102,8 +102,8 @@ static int snd_seq_hw_get_client_info(snd_seq_t *seq, snd_seq_client_info_t * in return -errno; } if (hw->version < SNDRV_PROTOCOL_VERSION(1, 0, 2)) { - info->card = -1; - info->pid = -1; + info->card = -ENOSYS; + info->pid = -ENOSYS; } return 0; } @@ -374,8 +374,8 @@ static int snd_seq_hw_query_next_client(snd_seq_t *seq, snd_seq_client_info_t *i return -errno; } if (hw->version < SNDRV_PROTOCOL_VERSION(1, 0, 2)) { - info->card = -1; - info->pid = -1; + info->card = -ENOSYS; + info->pid = -ENOSYS; } return 0; } -- 2.8.0.rc3.226.g39d4020

5 16

[alsa-devel] [alsa-utils] alsaucm should come with a man page
by Antonio Ospite 02 Dec '16

02 Dec '16

Hi, I used alsaucm to test mixer use cases for an Intel Baytrail tablet, I wanted to use bare alsa before bringing pulseaudio in, and it took some time to get my head around it. The output from the "alsaucm --help" is too terse, I had to look at the alsa-lib code[1] to see the possible IDENTIFIERs, and even then it was not clear to me that some operations, like for instance "list _devices", can only work after setting a _verb in the same _execution_, for instance this sequence doesn't work: # alsaucm -c bytcr-rt5640 set _verb HiFi # alsaucm -c bytcr-rt5640 list _devices But this command does: # alsaucm -c bytcr-rt5640 -b - <<EOM set _verb HiFi list _devces EOM Now that I know something more it makes sense: UCM just operates on mixer settings, it does not have its own external state. However, my point is that a man page explaining these things can make the life easier to new users. It would be better if alsa/UCM developers wrote the man page, but if no one steps up I guess I could draft a first version myself. Thanks, Antonio [1] http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=include/use-case.h -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?

3 9

[alsa-devel] [PATCH v5 1/2] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem
by Sylwester Nawrocki 01 Dec '16

01 Dec '16

This patch adds DT binding documentation for Exnos5433 based TM2 and TM2E boards sound subsystem. Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> Acked-by: Rob Herring <robh(a)kernel.org> --- Changes since v4: - indentation changes. Changes since v2: - none. Changes since initial version: - dropped clocks, clock-names properties, instead properties from the CODEC node will be used, - property renames: 'samsung,model' -> 'model', 'samsung,i2s-controller' -> 'i2s-controller', 'samsung,speaker-amplifier' -> 'audio-amplifier', - added 'audio-codec' property. --- .../bindings/sound/samsung,tm2-audio.txt | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt new file mode 100644 index 0000000..94442e5 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt @@ -0,0 +1,38 @@ +Samsung Exynos5433 TM2(E) audio complex with WM5110 codec + +Required properties: + + - compatible : "samsung,tm2-audio" + - model : the user-visible name of this sound complex + - audio-codec : the phandle of the wm5110 audio codec node, + as described in ../mfd/arizona.txt + - i2s-controller : the phandle of the I2S controller + - audio-amplifier : the phandle of the MAX98504 amplifier + - samsung,audio-routing : a list of the connections between audio components; + each entry is a pair of strings, the first being the + connection's sink, the second being the connection's + source; valid names for sources and sinks are the + WM5110's and MAX98504's pins and the jacks on the + board: HP, SPK, Main Mic, Sub Mic, Third Mic, + Headset Mic + - mic-bias-gpios : GPIO pin that enables the Main Mic bias regulator + + +Example: + +sound { + compatible = "samsung,tm2-audio"; + audio-codec = <&wm5110>; + i2s-controller = <&i2s0>; + audio-amplifier = <&max98504>; + mic-bias-gpios = <&gpr3 2 0>; + model = "wm5110"; + samsung,audio-routing = + "HP", "HPOUT1L", + "HP", "HPOUT1R", + "SPK", "SPKOUT", + "SPKOUT", "HPOUT2L", + "SPKOUT", "HPOUT2R", + "Main Mic", "MICBIAS2", + "IN1R", "Main Mic"; +}; -- 1.9.1

4 8

[alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get()
by Kuninori Morimoto 30 Nov '16

30 Nov '16

This is based on devm_clk_get() Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- v1 -> v2 - added "static" and "inline" on header drivers/clk/clkdev.c | 26 ++++++++++++++++++++++++++ include/linux/clk.h | 7 +++++++ 2 files changed, 33 insertions(+) diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 89cc700..93a613b 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -55,6 +55,32 @@ struct clk *of_clk_get(struct device_node *np, int index) } EXPORT_SYMBOL(of_clk_get); +static void devm_of_clk_release(struct device *dev, void *res) +{ + clk_put(*(struct clk **)res); +} + +struct clk *devm_of_clk_get(struct device *dev, + struct device_node *np, int index) +{ + struct clk **ptr, *clk; + + ptr = devres_alloc(devm_of_clk_release, sizeof(*ptr), GFP_KERNEL); + if (!ptr) + return ERR_PTR(-ENOMEM); + + clk = of_clk_get(np, index); + if (!IS_ERR(clk)) { + *ptr = clk; + devres_add(dev, ptr); + } else { + devres_free(ptr); + } + + return clk; +} +EXPORT_SYMBOL(devm_of_clk_get); + static struct clk *__of_clk_get_by_name(struct device_node *np, const char *dev_id, const char *name) diff --git a/include/linux/clk.h b/include/linux/clk.h index a89ba4e..33cd540 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -502,6 +502,8 @@ struct of_phandle_args; #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) struct clk *of_clk_get(struct device_node *np, int index); +struct clk *devm_of_clk_get(struct device *dev, + struct device_node *np, int index); struct clk *of_clk_get_by_name(struct device_node *np, const char *name); struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec); #else @@ -509,6 +511,11 @@ static inline struct clk *of_clk_get(struct device_node *np, int index) { return ERR_PTR(-ENOENT); } +static inline struct clk *devm_of_clk_get(struct device *dev, + struct device_node *np, int index) +{ + return ERR_PTR(-ENOENT); +} static inline struct clk *of_clk_get_by_name(struct device_node *np, const char *name) { -- 1.9.1

4 15

[alsa-devel] [RFC 00/17] clk: Add per-controller locks to fix deadlocks
by Krzysztof Kozlowski 11 Nov '16

11 Nov '16

Hi, RFC, please, do not apply, maybe except patch #1 which is harmless. Introduction ============ The patchset brings new entity: clock controller representing a hardware block. The clock controller comes with its own prepare lock which is used then in many places. The idea is to fix the deadlock mentioned in commit 10ff4c5239a1 ("i2c: exynos5: Fix possible ABBA deadlock by keeping I2C clock prepared") and commit 34e81ad5f0b6 ("i2c: s3c2410: fix ABBA deadlock by keeping clock prepared"). Disclaimer ========== Request for comments, so: 1. Only exynos_defconfig builds, 2. A lot of FIXME/TODO note still, 3. Checkpatch not run, lines not aligned, 4. Other (non-exynos) drivers not converted, 5. Probably not yet bisectable, 6. Locking became quite complex. The previous one lock was simple. Inefficient and dead-lock prone but simple. Because of clock hierarchy spanning through controllers, the new locking became quite complicated. I don't like it but... Details ======= In Exynos-based boards case the deadlock occurs between clock's prepare_lock and regmap-i2c's lock: CPU #0: CPU #1: lock(regmap) s2mps11-clk: clk_prepare_lock() i2c-exynos: clk_prepare_lock() - wait lock(regmap) - wait The clk_prepare_lock() on both CPUs come from different clock drivers and components: 1. I2C clock is part of SoC block and is required by i2c-s3c2410/i2c-exynos5 driver, 2. S2MPS11 clock is separate device, however driver uses I2C regmap. The deadlock was reported by lockdep (always) and was happening in 20% of boots of Odroid XU3 with multi_v7 defconfig. Workaround for deadlock was implemented by removing prepare/unprepare calls from I2C transfers. However these are just workarounds... which after applying this patch can be reverted. Additionally Marek Szyprowski's work on domains/clocks/pinctrl exposed the deadlock again in different configuration. Comments as usual are welcomed. Best regards, Krzysztof Krzysztof Kozlowski (17): clk: bcm2835: Rename clk_register to avoid name conflict clk: Add clock controller to fine-grain the prepare lock clk: s2mps11: Switch to new clock controller API clk: samsung: Allocate a clock controller in context clk: fixed-rate: Switch to new clock controller API clk: gate: Switch to new clock controller API clk: mux: Switch to new clock controller API clk: fixed-factor: Switch to new clock controller API clk: divider: Switch to new clock controller API clk: composite: Switch to new clock controller API clk: gpio: Switch to new clock controller API ASoC: samsung: Switch to new clock controller API clk: samsung: audss: samsung: Switch to new clock controller API clk: samsung: clkout: samsung: Switch to new clock controller API clk: Use per-controller locking Revert "i2c: exynos5: Fix possible ABBA deadlock by keeping I2C clock prepared" Revert "i2c: s3c2410: fix ABBA deadlock by keeping clock prepared" drivers/clk/bcm/clk-bcm2835.c | 8 +- drivers/clk/clk-composite.c | 8 +- drivers/clk/clk-divider.c | 10 +- drivers/clk/clk-fixed-factor.c | 11 +- drivers/clk/clk-fixed-rate.c | 28 +- drivers/clk/clk-fractional-divider.c | 5 +- drivers/clk/clk-gate.c | 8 +- drivers/clk/clk-gpio.c | 29 +- drivers/clk/clk-mux.c | 32 ++- drivers/clk/clk-s2mps11.c | 10 +- drivers/clk/clk.c | 456 +++++++++++++++++++++++++++----- drivers/clk/samsung/clk-exynos-audss.c | 30 ++- drivers/clk/samsung/clk-exynos-clkout.c | 11 +- drivers/clk/samsung/clk.c | 25 +- drivers/clk/samsung/clk.h | 1 + drivers/i2c/busses/i2c-exynos5.c | 24 +- drivers/i2c/busses/i2c-s3c2410.c | 23 +- include/linux/clk-provider.h | 88 ++++-- include/linux/clk.h | 1 + sound/soc/samsung/i2s.c | 13 +- 20 files changed, 612 insertions(+), 209 deletions(-) -- 1.9.1

7 27

[alsa-devel] [PATCH v4 0/3] ASoC/ARM: tegra: apalis t30/tk1/colibri t30: sgtl5000 audio
by Marcel Ziswiler 07 Nov '16

07 Nov '16

This series adds/integrates Freescale SGTL5000 analogue audio codec support. Changes in v4: - simple-audio-card does still not allow for more advanced use cases like Tegra SoCs - further platform drivers have been accepted since my last attempt (e.g. rt5677 one) - relevance for one further board the new Toradex Apalis TK1 - drop unused sound/jack.h include - in tegra_sgtl5000_driver_remove() pass return value of snd_soc_unregister_card() on to caller - no longer set owner property in platform_driver to THIS_MODULE - re-based/resend Changes in v3: - revert to not using simple-audio-card being incompatible with tegra - rebased to for-next Changes in v2: - using simple-audio-card as suggested by Fabio Marcel Ziswiler (3): ASoC: tegra: add tegra sgtl5000 machine driver ARM: tegra: apalis/colibri t30: integrate audio ARM: tegra: enable sgtl5000 audio .../bindings/sound/nvidia,tegra-audio-sgtl5000.txt | 42 ++++ arch/arm/boot/dts/tegra30-apalis.dtsi | 49 +++++ arch/arm/boot/dts/tegra30-colibri.dtsi | 49 +++++ arch/arm/configs/tegra_defconfig | 1 + sound/soc/tegra/Kconfig | 11 ++ sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_sgtl5000.c | 212 +++++++++++++++++++++ 7 files changed, 366 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-sgtl5000.txt create mode 100644 sound/soc/tegra/tegra_sgtl5000.c -- 2.5.5

4 5

Re: [alsa-devel] Intel Cherry Trail platform sound issue
by Zhihe Tu 05 Nov '16

05 Nov '16

Can anyone give some suggestions? Thanks Tu 发件人: 涂治河 [mailto:tuzhihe@pcasl.com] 发送时间: 2015年11月5日 19:37 收件人: 'alsa-devel(a)alsa-project.org' 主题: Intel Cherry Trail platform sound issue Hi All, I get cherry trail tablet, and install ubuntu14.04.3, Kernel verison is 3.19. The table using rt5672 codec with no sound output in ubuntu, but it works in win8. I get intel sst firmware fw_sst_22a8.bin from https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tr… The driver load the firmware successfully and I change some alsa mixer items: amixer -c0 sset 'codec_out0 mix 0 pcm0_in' on amixer -c0 sset 'media0_out mix 0 media1_in' on amixer -c0 sset 'media1_in Gain 0' 80% amixer -c0 sset 'media1_in Gain 0 Ramp Delay' 50 amixer -c0 sset 'media1_in Gain 0' off amixer -c0 sset 'pcm0_in Gain 0' 80% amixer -c0 sset 'pcm0_in Gain 0 Ramp Delay' 50 amixer -c0 sset 'pcm0_in Gain 0' off amixer -c0 sset 'codec_out0 Gain 0' 80% amixer -c0 sset 'codec_out0 Gain 0 Ramp Delay' 50 amixer -c0 sset 'codec_out0 Gain 0' off But there are some errors with dmesg: [ 16.359646] Audio Port: ASoC: no backend DAIs enabled for Audio Port … [ 16.382156] sst-mfld-platform sst-mfld-platform: Enter: enable=0 port_name=ssp2-port [ 16.383984] sst-mfld-platform sst-mfld-platform: Enter: enable=1 port_name=ssp2-port [ 16.541809] intel_sst_acpi 808622A8:00: Alloc for str 1 pipe 0x90 [ 17.545512] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x2 [ 17.555207] intel_sst_acpi 808622A8:00: fw returned err -16 [ 18.605859] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3 [ 18.615908] intel_sst_acpi 808622A8:00: fw returned err -16 [ 19.621943] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x2 fw_state 0x3 [ 19.631499] intel_sst_acpi 808622A8:00: fw returned err -16 [ 20.637527] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x2 fw_state 0x3 [ 20.647083] intel_sst_acpi 808622A8:00: fw returned err -16 [ 20.682979] sst-mfld-platform sst-mfld-platform: Enter: enable=0 port_name=ssp2-port [ 21.681280] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x2 fw_state 0x3 [ 21.690836] intel_sst_acpi 808622A8:00: fw returned err -16 [ 21.697087] intel_sst_acpi 808622A8:00: free stream returned err -19 [ 22.757082] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3 [ 22.766640] intel_sst_acpi 808622A8:00: fw returned err -16 [ 23.772867] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3 [ 23.782432] intel_sst_acpi 808622A8:00: fw returned err -16 [ 23.857938] sst-mfld-platform sst-mfld-platform: Enter: enable=1 port_name=ssp2-port [ 23.989254] intel_sst_acpi 808622A8:00: Alloc for str 1 pipe 0x90 [ 23.989491] intel_sst_acpi 808622A8:00: FW sent error response 0x40034 [ 23.996864] intel_sst_acpi 808622A8:00: FW alloc failed ret -4 [ 24.003399] intel_sst_acpi 808622A8:00: sst_get_stream returned err -5 [ 24.010737] sst-mfld-platform sst-mfld-platform: ASoC: DAI prepare error: -5 [ 24.018652] Audio Port: ASoC: prepare FE Audio Port failed [ 25.024622] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3 [ 25.034180] intel_sst_acpi 808622A8:00: fw returned err -16 [ 26.040399] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3 [ 26.049955] intel_sst_acpi 808622A8:00: fw returned err -16 [ 27.056333] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x2 fw_state 0x3 [ 27.065890] intel_sst_acpi 808622A8:00: fw returned err -16 [ 28.072032] intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x2 fw_state 0x3 [ 28.081591] intel_sst_acpi 808622A8:00: fw returned err -16 [ 28.117427] Audio Port: sst: error code = -22 [ 28.122401] snd_pcm_update_hw_ptr0: 120 callbacks suppressed [ 28.122409] cht-bsw-rt5672 cht-bsw-rt5672: BUG: , pos = -22, buffer size = 96000, period size = 48000 [ 28.132784] Audio Port: sst: error code = -22 [ 28.137749] cht-bsw-rt5672 cht-bsw-rt5672: BUG: , pos = -22, buffer size = 96000, period size = 48000 [ 28.372967] Audio Port: sst: error code = -22 [ 28.377946] cht-bsw-rt5672 cht-bsw-rt5672: BUG: , pos = -22, buffer size = 96000, period size = 48000 [ 28.388317] Audio Port: sst: error code = -22 [ 28.393289] cht-bsw-rt5672 cht-bsw-rt5672: BUG: , pos = -22, buffer size = 96000, period size = 48000 [ 28.403687] Audio Port: sst: error code = -22 lsmod info: snd_soc_sst_cht_bsw_rt5672 16384 0 snd_intel_sst_acpi 16384 1 snd_intel_sst_core 73728 1 snd_intel_sst_acpi snd_soc_sst_mfld_platform 77824 3 snd_intel_sst_core snd_soc_rt5670 106496 1 snd_soc_rl6231 16384 1 snd_soc_rt5670 snd_soc_core 196608 4 snd_soc_rt5670,snd_soc_sst_cht_bsw_rt5672,snd_soc_sst_mfld_platform snd_seq_midi 16384 0 snd_seq_midi_event 16384 1 snd_seq_midi snd_compress 20480 1 snd_soc_core snd_pcm_dmaengine 16384 1 snd_soc_core snd_rawmidi 32768 1 snd_seq_midi snd_pcm 106496 5 snd_soc_rt5670,snd_soc_core,snd_soc_sst_cht_bsw_rt5672,snd_soc_sst_mfld_platform,snd_pcm_dmaengine snd_seq 65536 2 snd_seq_midi_event,snd_seq_midi snd_seq_device 16384 3 snd_seq,snd_rawmidi,snd_seq_midi snd_timer 32768 2 snd_pcm,snd_seq snd 86016 10 snd_soc_core,snd_timer,snd_pcm,snd_seq,snd_rawmidi,snd_soc_sst_mfld_platform,snd_seq_device,snd_compress soundcore 16384 1 snd I have no idea with the next step, so can anyone give a look? Thanks Tu __________ Information from ESET Smart Security, version of virus signature database 4468 (20090929) __________ The message was checked by ESET Smart Security. http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 4468 (20090929) __________ The message was checked by ESET Smart Security. http://www.eset.com

2 1

[alsa-devel] [PATCH v1 1/2] sound: lpass-cpu: add module licence and description
by Srinivas Kandagatla 31 Oct '16

31 Oct '16

This patch adds module licence to lpass-cpu driver, without this patch lpass-cpu module would taint with below error, while insmod/modprobe. snd_soc_lpass_cpu: module license 'unspecified' taints kernel. Disabling lock debugging due to kernel taint snd_soc_lpass_cpu: Unknown symbol regmap_write (err 0) snd_soc_lpass_cpu: Unknown symbol devm_kmalloc (err 0) ... Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- sound/soc/qcom/lpass-cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 3cde9fb..eff3f9a 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -586,3 +586,6 @@ int asoc_qcom_lpass_cpu_platform_remove(struct platform_device *pdev) return 0; } EXPORT_SYMBOL_GPL(asoc_qcom_lpass_cpu_platform_remove); + +MODULE_DESCRIPTION("QTi LPASS CPU Driver"); +MODULE_LICENSE("GPL v2"); -- 2.8.3

3 3

[alsa-devel] [PATCH 0/13] ALSA: Deletion of some unnecessary checks
by SF Markus Elfring 26 Oct '16

26 Oct '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sun, 4 Jan 2015 11:50:12 +0100 Further update suggestions were taken into account after several patches were applied from static source code analysis. Markus Elfring (3): seq: Deletion of unnecessary checks before the function call "snd_midi_event_free" oss: Deletion of unnecessary checks before the function call "vfree" emu10k1: Delete an unnecessary check before the function call "kfree" oxygen: Delete an unnecessary check before the function call "snd_pcm_suspend" emux: Delete an unnecessary check before the function call "snd_sf_free" ASoC: Intel: Delete an unnecessary check before the function call "sst_dma_free" ASoC: fsi: Deletion of unnecessary checks before the function call "clk_enable" ASoC: Intel: Delete an unnecessary check before the function call "release_firmware" i2sbus: Delete an unnecessary check before the function call "snd_pcm_suspend_all" sb: Delete an unnecessary check before the function call "snd_emux_free" Deletion of checks before the function call "iounmap" msnd: One function call less in snd_msnd_attach() after error detection msnd: Fix centralized exiting from snd_msnd_attach() sound/aoa/soundbus/i2sbus/core.c | 13 ++++++------- sound/arm/aaci.c | 4 ++-- sound/drivers/ml403-ac97cr.c | 3 +-- sound/isa/msnd/msnd_pinnacle.c | 31 ++++++++++++++++--------------- sound/parisc/harmony.c | 4 +--- sound/pci/ad1889.c | 5 +---- sound/pci/asihpi/hpioctl.c | 6 ++---- sound/pci/atiixp.c | 3 +-- sound/pci/atiixp_modem.c | 3 +-- sound/pci/aw2/aw2-alsa.c | 4 +--- sound/pci/bt87x.c | 3 +-- sound/pci/cs4281.c | 6 ++---- sound/pci/cs46xx/cs46xx_lib.c | 4 ++-- sound/pci/ctxfi/cthw20k1.c | 5 +---- sound/pci/ctxfi/cthw20k2.c | 5 +---- sound/pci/echoaudio/echoaudio.c | 6 +----- sound/pci/hda/hda_intel.c | 3 +-- sound/pci/lola/lola.c | 6 ++---- sound/pci/mixart/mixart.c | 7 +++---- sound/pci/nm256/nm256.c | 6 ++---- sound/pci/rme9652/hdsp.c | 4 +--- sound/pci/rme9652/hdspm.c | 4 +--- sound/pci/rme9652/rme9652.c | 3 +-- sound/pci/sis7019.c | 5 +---- sound/pci/ymfpci/ymfpci_main.c | 3 +-- sound/ppc/pmac.c | 15 +++++---------- 26 files changed, 58 insertions(+), 103 deletions(-) -- 2.2.1

5 25