July 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [GIT PULL] ASoC fixes for v4.7
by Mark Brown 03 Jul '16

03 Jul '16

The following changes since commit 4c2e07c6a29e0129e975727b9f57eede813eea85: Linux 4.7-rc5 (2016-06-26 17:52:03 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v4.7-rc5 for you to fetch changes up to 7c5eec4edf4693aa61f3ee78bf28621dfe33d9f0: Merge remote-tracking branches 'asoc/fix/rcar', 'asoc/fix/rt5670' and 'asoc/fix/wm8940' into asoc-linus (2016-07-01 18:05:34 +0200) ---------------------------------------------------------------- ASoC: Fixes for v4.7 A small clutch of hardware specific fixes for various ASoC devices, all small individually and important if you have that device but not otherwise. ---------------------------------------------------------------- Ajit Pandey (1): ASoC: wm5110: Add missing route from OUT3R to SYSCLK Alan Cox (1): ASoC: Intel: atom: fix missing breaks that would cause the wrong operation to execute Alexander Shiyan (1): ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode Arnd Bergmann (1): ASoC: hdmi-codec: select CONFIG_HDMI Bard Liao (2): ASoC: rt5670: fix HP Playback Volume control ASoC: rt5645: fix reg-2f default value. Charles Keepax (1): ASoC: wm5102: Correct supported channels on trace compressed DAI Fabio Estevam (1): ASoC: ak4613: Remove owner assignment from platform_driver Geert Uytterhoeven (2): ASoC: wm8940: Enable cache usage to fix crashes on resume ASoC: ak4613: Enable cache usage to fix crashes on resume Janusz Krzysztofik (1): ASoC: cx20442: set tty->receiver_room in v253_open Kuninori Morimoto (1): ASoC: rsnd: open 31bit of SSICKR mask Mark Brown (4): Merge remote-tracking branch 'asoc/fix/intel' into asoc-linus Merge remote-tracking branch 'asoc/fix/rt5645' into asoc-linus Merge remote-tracking branches 'asoc/fix/ak4613', 'asoc/fix/arizona', 'asoc/fix/cx20442', 'asoc/fix/davinci', 'asoc/fix/fsl-ssi' and 'asoc/fix/hdmi' into asoc-linus Merge remote-tracking branches 'asoc/fix/rcar', 'asoc/fix/rt5670' and 'asoc/fix/wm8940' into asoc-linus Peter Ujfalusi (1): ASoC: davinci-mcasp: Fix dra7 DMA offset when using CFG port Vinod Koul (2): ASoC: hdac_hdmi: Fix potential NULL dereference ASoC: Intel: Skylake: Initialize module list for Broxton sound/soc/codecs/Kconfig | 7 +-- sound/soc/codecs/ak4613.c | 2 +- sound/soc/codecs/cx20442.c | 1 + sound/soc/codecs/hdac_hdmi.c | 20 ++++++++ sound/soc/codecs/rt5645.c | 2 +- sound/soc/codecs/rt5670.c | 2 +- sound/soc/codecs/wm5102.c | 2 +- sound/soc/codecs/wm5110.c | 1 + sound/soc/codecs/wm8940.c | 1 + sound/soc/davinci/davinci-mcasp.c | 56 +++++++++++++++++++++-- sound/soc/davinci/davinci-mcasp.h | 4 +- sound/soc/fsl/fsl_ssi.c | 12 ++--- sound/soc/intel/atom/sst-mfld-platform-compress.c | 9 +++- sound/soc/intel/skylake/bxt-sst.c | 1 + sound/soc/sh/rcar/adg.c | 2 +- 15 files changed, 100 insertions(+), 22 deletions(-)

2 1

[alsa-devel] [PATCH] drm: mediatek: fix prototypes after API change
by Arnd Bergmann 02 Jul '16

02 Jul '16

The newly added mediatek HDMI driver clashes with an API change for struct hdmi_codec_ops, causing an 'allmodconfig' build to fail: drivers/gpu/drm/mediatek/mtk_hdmi.c:1653:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1654:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1655:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1656:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1657:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] This changes the API accordingly for the mediatek driver. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Fixes: efc9194bcff8 ("ASoC: hdmi-codec: callback function will be called with private data") --- The new driver is currently part of Dave Airlie's drm-next tree, while the API change is in Mark Brown's asoc-next tree, so my fix has to be done on top of both. I can see two ways out of this: a) Stephen Rothwell could add my fixup on top of linux-next as a merge fix, and the fix gets sent to Linus Torvalds along with the second of the two branches b) efc9194bcff8 gets merged into drm-next along with my change in the merge commit. It is currently a standalone patch in its own branch in the ASoC tree. --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index ba812ef2c9d1..334562d06731 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1535,7 +1535,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, * HDMI audio codec callbacks */ -static int mtk_hdmi_audio_hw_params(struct device *dev, +static int mtk_hdmi_audio_hw_params(struct device *dev, void *data, struct hdmi_codec_daifmt *daifmt, struct hdmi_codec_params *params) { @@ -1604,7 +1604,7 @@ static int mtk_hdmi_audio_hw_params(struct device *dev, return 0; } -static int mtk_hdmi_audio_startup(struct device *dev) +static int mtk_hdmi_audio_startup(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1615,7 +1615,7 @@ static int mtk_hdmi_audio_startup(struct device *dev) return 0; } -static void mtk_hdmi_audio_shutdown(struct device *dev) +static void mtk_hdmi_audio_shutdown(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1624,7 +1624,7 @@ static void mtk_hdmi_audio_shutdown(struct device *dev) mtk_hdmi_audio_disable(hdmi); } -int mtk_hdmi_audio_digital_mute(struct device *dev, bool enable) +int mtk_hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1638,7 +1638,7 @@ int mtk_hdmi_audio_digital_mute(struct device *dev, bool enable) return 0; } -static int mtk_hdmi_audio_get_eld(struct device *dev, uint8_t *buf, size_t len) +static int mtk_hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, size_t len) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); -- 2.9.0

4 3

[alsa-devel] [PATCH] ASoC: cs4270: fix DAPM stream name mismatch
by murray foster 02 Jul '16

02 Jul '16

Mismatching stream names in DAPM route and widget definitions are causing compilation errors. Fixing these names allows the cs4270 driver to compile and function. Signed-off-by: Murray Foster <mrafoster(a)gmail.com> --- sound/soc/codecs/cs4270.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index e07807d..4ffdca4 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -1,4 +1,4 @@ -/* +s/* * CS4270 ALSA SoC (ASoC) codec driver * * Author: Timur Tabi <timur(a)freescale.com> @@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"), }; static const struct snd_soc_dapm_route cs4270_dapm_routes[] = { - { "Capture", NULL, "AINA" }, - { "Capture", NULL, "AINB" }, + { "Capture", NULL, "AINL" }, + { "Capture", NULL, "AINR" }, - { "AOUTA", NULL, "Playback" }, - { "AOUTB", NULL, "Playback" }, + { "AOUTL", NULL, "Playback" }, + { "AOUTR", NULL, "Playback" }, }; /** -- 2.4.9

1 0

[alsa-devel] [GIT PULL] Broxton fw update
by Vinod Koul 01 Jul '16

01 Jul '16

Please PULL to receive the latest Broxton fw. The following changes since commit 3ef7857d511ce6a91c5ce609da76c4702651cfa5: amdgpu: update polaris ucode (2016-06-28 14:31:11 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git apl for you to fetch changes up to 040c24514b94fcdbd6308d986d1bde59a704a21a: linux-firmware: intel: Update Broxton audio firmware (2016-06-29 14:20:20 +0530) ---------------------------------------------------------------- Vinod Koul (1): linux-firmware: intel: Update Broxton audio firmware WHENCE | 4 ++-- intel/dsp_fw_bxtn.bin | 2 +- intel/dsp_fw_bxtn_v702.bin | Bin 0 -> 505608 bytes 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 intel/dsp_fw_bxtn_v702.bin Thanks -- ~Vinod

2 1

[alsa-devel] [PATCH 0/3 v2] ALSA: ctl: add dimension information validator
by Takashi Sakamoto 01 Jul '16

01 Jul '16

Hi, This patchset is revised version of my previous one. [alsa-devel] [PATCH 0/3] ALSA: add dimension information validator http://mailman.alsa-project.org/pipermail/alsa-devel/2016-June/109811.html The main purpose of this patchset is the same, just including some changes below. * Add arithmetic overflow check * Add negative value check of first dimension level * Change function name of the validator and name of local variable so that the aim is clear. Takashi Sakamoto (3): ALSA: echoaudio: purge contradictions between dimension matrix members and total number of members ALSA: control: add dimension validator for userspace element ALSA: control: add dimension validator for kernel driver sound/core/control.c | 87 +++++++++++++++++++++++++++++++++-------- sound/pci/echoaudio/echoaudio.c | 6 +-- 2 files changed, 74 insertions(+), 19 deletions(-) -- 2.7.4

2 10

[alsa-devel] Assertion failure in alsa-lib crashing applications (snd_pcm_area_copy: Assertion `dst < src || dst >= src + bytes' failed)
by Baptiste Jonglez 01 Jul '16

01 Jul '16

Hi, When using Ring [1], an audio-video application, it sometimes crashes because of an assertion in libasound.so: pcm.c:2758: snd_pcm_area_copy: Assertion `dst < src || dst >= src + bytes' failed. The complete upstream bug report is at [2]. The (not-so-useful) stack trace is the following: #0 0x00007fc356e462a8 raise (libc.so.6) #1 0x00007fc356e4772a abort (libc.so.6) #2 0x00007fc356e3f1b7 __assert_fail_base (libc.so.6) #3 0x00007fc356e3f262 __assert_fail (libc.so.6) #4 0x00007fc35ba65c84 snd_pcm_area_copy (libasound.so.2) #5 0x00007fc35ba65ebc snd_pcm_areas_copy (libasound.so.2) #6 0x00007fc35baa6d95 n/a (libasound.so.2) #7 0x00007fc35ba77c1f n/a (libasound.so.2) #8 0x00007fc35ba77a59 n/a (libasound.so.2) #9 0x000000000051ba97 n/a (dring) #10 0x000000000051c118 n/a (dring) #11 0x000000000051cfad n/a (dring) #12 0x00007fc357787c40 execute_native_thread_routine (libstdc++.so.6) #13 0x00007fc359ec2424 start_thread (libpthread.so.0) #14 0x00007fc356efacbd __clone (libc.so.6) The next time it crashes, I will have debug symbols in dring. I can also recompile alsa-lib with debug symbols, what is the best way to do that? Looking around, it seems other projects have run into the same issue: https://aur.archlinux.org/packages/ultrastardx-git/?comments=all#comment-43… https://aur.archlinux.org/packages/zoom/#comment-544696 http://ubuntuforums.org/showthread.php?t=2248373 https://github.com/js-platform/node-webrtc/issues/110 https://fedorahosted.org/fldigi/ticket/70 The output of the alsa-info.sh script on my system is at [3]. What else can I provide to debug this issue further? Thanks, Baptiste [1] https://ring.cx [2] https://tuleap.ring.cx/plugins/tracker/?aid=502 [3] http://www.alsa-project.org/db/?f=0dd2ba1021b3d535f30f07c55dc18e2ef60db26d

2 9

[alsa-devel] [PATCH 1/2] ASoC: rt5645: patch reg-0x8a
by Bard Liao 01 Jul '16

01 Jul '16

reg-8a assign the tracking source for each ASRC tracker. The default value is 0x0000 which means all ASRC trackers will track LRCK1. But in most cases, we wish each ASRC tracker track the corresponding LRCK. i.e. ASRC1 tracks LRCK1, ASRC2 tracks LRCK2 and so on. So, we rewrite reg-8a as 0x0120. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 1f457d3..c21e41c 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -64,6 +64,7 @@ static const struct reg_sequence init_list[] = { {RT5645_PR_BASE + 0x21, 0x4040}, {RT5645_PR_BASE + 0x23, 0x0004}, {RT5645_PR_BASE + 0x00, 0x0a2a}, + {RT5645_ASRC_4, 0x0120}, }; static const struct reg_sequence rt5650_init_list[] = { @@ -159,7 +160,7 @@ static const struct reg_default rt5645_reg[] = { { 0x83, 0x0000 }, { 0x84, 0x0000 }, { 0x85, 0x0000 }, - { 0x8a, 0x0000 }, + { 0x8a, 0x0120 }, { 0x8e, 0x0004 }, { 0x8f, 0x1100 }, { 0x90, 0x0646 }, @@ -316,7 +317,7 @@ static const struct reg_default rt5650_reg[] = { { 0x83, 0x0000 }, { 0x84, 0x0000 }, { 0x85, 0x0000 }, - { 0x8a, 0x0000 }, + { 0x8a, 0x0120 }, { 0x8e, 0x0004 }, { 0x8f, 0x1100 }, { 0x90, 0x0646 }, -- 1.8.1.1.439.g50a6b54

2 2

[alsa-devel] [PATCH v2 1/2] ASoC: rt5645: fix reg-2f default value.
by Bard Liao 01 Jul '16

01 Jul '16

The default value of reg-2f in codec rt5650 is 0x5002, not 0x1002. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 3c6594d..d70847c 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -253,7 +253,7 @@ static const struct reg_default rt5650_reg[] = { { 0x2b, 0x5454 }, { 0x2c, 0xaaa0 }, { 0x2d, 0x0000 }, - { 0x2f, 0x1002 }, + { 0x2f, 0x5002 }, { 0x31, 0x5000 }, { 0x32, 0x0000 }, { 0x33, 0x0000 }, -- 1.8.1.1.439.g50a6b54

2 2

[alsa-devel] [asoc:topic/sunxi 2/2] sound/soc/sunxi/sun4i-i2s.c:624:2-3: Unneeded semicolon
by kbuild test robot 01 Jul '16

01 Jul '16

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/sunxi head: fa7c0d13cb26216f6dec5ef19e028e68b300530d commit: fa7c0d13cb26216f6dec5ef19e028e68b300530d [2/2] ASoC: sunxi: Add Allwinner A10 Digital Audio driver coccinelle warnings: (new ones prefixed by >>) >> sound/soc/sunxi/sun4i-i2s.c:624:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 3

[alsa-devel] [PATCH 1/2] ASoC: cs35l33: Fix testing return value of devm_gpiod_get_optional
by Axel Lin 01 Jul '16

01 Jul '16

devm_gpiod_get_optional() returns NULL when the gpio is not assigned. So the if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) test is always false. Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/cs35l33.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 622a111..aa5c0c5 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -1176,11 +1176,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client, /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset-gpios", GPIOD_OUT_HIGH); - - if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) { - dev_warn(&i2c_client->dev, - "%s WARNING: No reset gpio assigned\n", __func__); - } else if (IS_ERR(cs35l33->reset_gpio)) { + if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); return PTR_ERR(cs35l33->reset_gpio); -- 2.5.0

3 5