July 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning
by Arnd Bergmann 05 Jul '16

05 Jul '16

The awacs sound driver produces a false-positive warning in ppc64_defconfig: sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] I haven't come up with a good way to rewrite the code to avoid the warning, so here is a bad one: I initialize the variable before the conditionall initialization so gcc no longer has to worry about it. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/ppc/awacs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c index 09da7b52bc2e..1468e4b7bf93 100644 --- a/sound/ppc/awacs.c +++ b/sound/ppc/awacs.c @@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip) if (err < 0) return err; } + master_vol = NULL; if (pm7500) err = build_mixers(chip, ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500), -- 2.9.0

2 1

[alsa-devel] [PATCH v2 0/7] of_graph: prepare for ALSA graph support
by Kuninori Morimoto 05 Jul '16

05 Jul '16

Hi Rob These are v2 of of_graph patch-set Now OF graph is mainly used by V4L2 SoC, and ALSA SoC is using different style for SoC <-> Codec binding. But, for example, HDMI case, V4L2 <-> ALSA need to collaborate, and then ALSA SoC needs to adjust to OF graph. OTOH, V4L2's "OF graph" position is same as ALSA SoC "sound card" position. And ALSA SoC side want to keep existing supported feature on new OF graph style. I'm posting this on ALSA SoC ML now. Now, current of_graph is indicating port/endpoint, but there is no way to understand that it is for video port ? or sound port ? or other device port ? For example, HDMI has video port, and sound port. Because of this reason, ALSA SoC side can't handle OF graph correctly. Thus, this patch-set tries to add new "type" on OF graph. And this patch-set includes small feature which are useful for ALSA SoC side OF graph support. Kuninori Morimoto (7): Documentation: of: add type property of_graph: add of_graph_get_remote_endpoint() of_graph: add of_graph_port_type_is() of_graph: add of_graph_get_port_parent() of_graph: add of_graph_get_top_port() of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() of_graph: add of_graph_get_endpoint_count() Documentation/devicetree/bindings/graph.txt | 21 ++++ drivers/of/base.c | 164 ++++++++++++++++++++++++++-- include/linux/of_graph.h | 61 +++++++++++ 3 files changed, 236 insertions(+), 10 deletions(-) -- 1.9.1

3 12

[alsa-devel] [PATCH] ASoC: rockchip: implement system suspend/resume for spdif
by Sugar Zhang 05 Jul '16

05 Jul '16

restore hw registers after power loss during a suspend/resume cycle. Signed-off-by: Sugar Zhang <sugar.zhang(a)rock-chips.com> --- sound/soc/rockchip/rockchip_spdif.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockchip_spdif.c index 100781e..00ae0e5 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -392,9 +392,35 @@ static int rk_spdif_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int rockchip_spdif_suspend(struct device *dev) +{ + struct rk_spdif_dev *spdif = dev_get_drvdata(dev); + + regcache_mark_dirty(spdif->regmap); + + return 0; +} + +static int rockchip_spdif_resume(struct device *dev) +{ + struct rk_spdif_dev *spdif = dev_get_drvdata(dev); + int ret; + + ret = pm_runtime_get_sync(dev); + if (ret < 0) + return ret; + ret = regcache_sync(spdif->regmap); + pm_runtime_put(dev); + + return ret; +} +#endif + static const struct dev_pm_ops rk_spdif_pm_ops = { SET_RUNTIME_PM_OPS(rk_spdif_runtime_suspend, rk_spdif_runtime_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(rockchip_spdif_suspend, rockchip_spdif_resume) }; static struct platform_driver rk_spdif_driver = { -- 1.9.1

1 0

[alsa-devel] atmel_ssc_dai.c, use of dai->id
by Peter Meerwald-Stadler 05 Jul '16

05 Jul '16

Hello, I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained board (4.1 kernel, but close to mainline) c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC fixes an issue with cpu_dai id being always 0, while the ssc id should have been used (or the platform_device id) I think there is a remaining issue with DMA parameters in atmel_ssc_startup(): line 324: dma_params = &ssc_dma_params[dai->id][dir]; I think it should be dma_params = &ssc_dma_params[pdev->id][dir]; I am new to this platform, please comment I can submit a formal patch later-on of course thanks, regards, p. -- Peter Meerwald-Stadler +43-664-2444418 (mobile)

2 1

[alsa-devel] [PATCH] drm: sti: fix prototypes after API change
by Arnd Bergmann 05 Jul '16

05 Jul '16

Like the mediatek hdmi driver, the sti driver now suffers from an API change in linux-next: drivers/gpu/drm/sti/sti_hdmi.c:1250:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .hw_params = hdmi_audio_hw_params, ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/sti/sti_hdmi.c:1250:15: note: (near initialization for 'audio_codec_ops.hw_params') This follows the API change, adding the extra function arguments. I suppose we want this to be part of the ASoC merge in linux-next for now too. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Fixes: 2c348e505328 ("drm: sti: Add ASoC generic hdmi codec support.") Fixes: efc9194bcff8 ("ASoC: hdmi-codec: callback function will be called with private data") Link: https://lkml.org/lkml/2016/6/29/441 --- drivers/gpu/drm/sti/sti_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 927e2b2e5af2..fedc17f98d9b 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1169,7 +1169,7 @@ static int hdmi_audio_configure(struct sti_hdmi *hdmi, return hdmi_audio_infoframe_config(hdmi); } -static void hdmi_audio_shutdown(struct device *dev) +static void hdmi_audio_shutdown(struct device *dev, void *data) { struct sti_hdmi *hdmi = dev_get_drvdata(dev); int audio_cfg; @@ -1186,6 +1186,7 @@ static void hdmi_audio_shutdown(struct device *dev) } static int hdmi_audio_hw_params(struct device *dev, + void *data, struct hdmi_codec_daifmt *daifmt, struct hdmi_codec_params *params) { @@ -1221,7 +1222,7 @@ static int hdmi_audio_hw_params(struct device *dev, return 0; } -static int hdmi_audio_digital_mute(struct device *dev, bool enable) +static int hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) { struct sti_hdmi *hdmi = dev_get_drvdata(dev); @@ -1235,7 +1236,7 @@ static int hdmi_audio_digital_mute(struct device *dev, bool enable) return 0; } -static int hdmi_audio_get_eld(struct device *dev, uint8_t *buf, size_t len) +static int hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, size_t len) { struct sti_hdmi *hdmi = dev_get_drvdata(dev); struct drm_connector *connector = hdmi->drm_connector; -- 2.9.0

5 8

[alsa-devel] Alsa driver for Tascam US-16x08
by Detlef Urban 04 Jul '16

04 Jul '16

Hi, I'm a former application developer at a big IT company. Most of my private time I spend with semi-professional studio recording using Ubuntu Studio (Ardour). I bought a nice external sound device from Tascam called US-16x08 and it works very well. This device also contains some signal processing capabilities like a compressor and a parametric equalizer. But unfortunately there was no Linux driver available from the manufacturer and so I cant use there functionalities. So I started with a nightmare of re-engineering by monitoring USB communication via usbmon and wireshark. Now after 3-4 weeks I'm able to completely control this device with a customized snd-usb-audio kernel module. Additionally I developed a tiny GUI mixer application to test my driver. But I'm not very familiar with non-coding aspects of driver deployment (documentation, deployment etc.). Can some please help me with some hints/links, so that other users can benefit of my work? regards Detlef

1 0

[alsa-devel] [PATCH -next] ASoC: cs35l33: Remove unused including <linux/version.h>
by weiyj_lk＠163.com 04 Jul '16

04 Jul '16

From: Wei Yongjun <weiyj.lk(a)gmail.com> Remove including <linux/version.h> that don't need it. Signed-off-by: Wei Yongjun <weiyj.lk(a)gmail.com> --- sound/soc/codecs/cs35l33.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 622a111..c20edd4 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -12,7 +12,6 @@ */ #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/version.h> #include <linux/kernel.h> #include <linux/init.h> #include <linux/delay.h>

2 1

[alsa-devel] [PATCH 0/7] ASoC: rockchip: Fix audio on Veyron.
by Enric Balletbo i Serra 04 Jul '16

04 Jul '16

Hi all, This patch series adds support and fixes the audio support for Veyron devices. With these patches I'm able to playback from speakers and headphones, and record from the microphone on a Veyron Jerry Chromebook. Patches 1/7 and 2/7 were already sent by John Keeping,[1] [2], but I think it's interesting have them included here. Patches from 1/7 to 5/7 should go through the Mark Brown ASoC tree. Patches 6/7 and 7/7 should go through the Heiko Stuebner rockchip tree. [1] https://patchwork.kernel.org/patch/9017491/ [2] https://patchwork.kernel.org/patch/9017501/ Enric Balletbo i Serra (5): ASoC: rockchip-max98090: Fix NULL pointer de reference while accessing to jack ASoC: rockchip-max98090: Fix the Headset Mic route. ASoC: rockchip-max98090: Fix DAPM unknown pin for Headset Jack ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards ARM: dts: rockchip: veyron: Add analog audio codecs. John Keeping (2): ASoC: rockchip: Revert "ASoC: rockchip: i2s: remove unused variables" ASoC: rockchip: Revert "ASoC: rockchip: i2s: separate capture and playback" arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 102 ++++++++++++++++++++++ arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 + sound/soc/rockchip/rockchip_i2s.c | 87 +++++++++++------- sound/soc/rockchip/rockchip_max98090.c | 54 ++++++------ 4 files changed, 187 insertions(+), 57 deletions(-) create mode 100644 arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi -- 2.1.0

3 14

[alsa-devel] [PATCH -next] ASoC: sunxi: remove redundant dev_err call in sun4i_i2s_probe()
by weiyj_lk＠163.com 04 Jul '16

04 Jul '16

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/sunxi/sun4i-i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index fab5234..687a8f8 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -599,10 +599,8 @@ static int sun4i_i2s_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(regs)) { - dev_err(&pdev->dev, "Can't request IO region\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } irq = platform_get_irq(pdev, 0); if (irq < 0) {

1 0

[alsa-devel] [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource
by Amitoj Kaur Chawla 04 Jul '16

04 Jul '16

Remove unneeded error handling on the result of a call to platform_get_resource when the value is passed to devm_ioremap_resource. The Coccinelle semantic patch that makes this change is as follows: // <smpl> @@ expression pdev,res,n,e,e1; expression ret != 0; identifier l; @@ - res = platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res - if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // </smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606(a)gmail.com> --- sound/soc/atmel/atmel-classd.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c index 6107de9..6d9b8b4 100644 --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -593,11 +593,6 @@ static int atmel_classd_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "no memory resource\n"); - return -ENXIO; - } - io_base = devm_ioremap_resource(dev, res); if (IS_ERR(io_base)) { ret = PTR_ERR(io_base); -- 1.9.1

3 6