July 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/7] ASoC: simple: dailink_name and card_name
by Kuninori Morimoto 16 Jul '16

16 Jul '16

Hi Mark These are for dailink_name and card_name cleanup for simple-card. 1) - 3) : for dailink_name 4) : tidyup 5) - 7) : for card_name Kuninori Morimoto (7): 1) ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name() 2) ASoC: simple-card: use asoc_simple_card_parse_dailink_name() 3) ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name() 4) ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai 5) ASoC: simple-card-utils: add asoc_simple_card_parse_card_name() 6) ASoC: simple-card: use asoc_simple_card_parse_card_name() 7) ASoC: rsrc-card: use asoc_simple_card_parse_card_name() include/sound/simple_card_utils.h | 5 +++ sound/soc/generic/simple-card-utils.c | 43 +++++++++++++++++++++++++ sound/soc/generic/simple-card.c | 28 +++++------------ sound/soc/sh/rcar/rsrc-card.c | 59 ++++++++++++++--------------------- 4 files changed, 80 insertions(+), 55 deletions(-) -- 1.9.1

2 12

[alsa-devel] [PATCH 0/7 v2] ASoC: simple: dailink_name and card_name
by Kuninori Morimoto 16 Jul '16

16 Jul '16

Hi Mark These are v2 of dailink_name and card_name cleanup patches for simple-card. 1) - 3) : for dailink_name 4) : tidyup 5) - 7) : for card_name Kuninori Morimoto (7): 1) ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name() 2) ASoC: simple-card: use asoc_simple_card_parse_dailink_name() 3) ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name() 4) ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai 5) ASoC: simple-card-utils: add asoc_simple_card_parse_card_name() 6) ASoC: simple-card: use asoc_simple_card_parse_card_name() 7) ASoC: rsrc-card: use asoc_simple_card_parse_card_name() include/sound/simple_card_utils.h | 5 +++ sound/soc/generic/simple-card-utils.c | 43 +++++++++++++++++++++++++ sound/soc/generic/simple-card.c | 28 +++++------------ sound/soc/sh/rcar/rsrc-card.c | 59 ++++++++++++++--------------------- 4 files changed, 80 insertions(+), 55 deletions(-) -- 1.9.1

2 8

[alsa-devel] [PATCH 00/39 v2] ASoC: add simple-card-core and standardize "simple" card
by Kuninori Morimoto 16 Jul '16

16 Jul '16

Hi Mark These are v2 of simple-card cleanup patches. Main purpose of these patches are - cleanup simple-card - rename rsrc-card to simple-dpcm-card Main diff v1 <-> v2 are - remove duplicate header patch - rename simple-card-core.c -> simple-card-utils.c - remove dpcm function from simple-card-utils. - remove jack/pin/gpio/ function from simple-card-utils. - remove widgets/route function from simple-card-utils. I removed widgets/routing related function. it was very thin cosmetic functions. About jack/pin/gpio on simple-card, it is still have same method, but keeping it as static function. dpcm related function too, it is keeping static. 1) - 3) cleaup patch as prepare 4) - 14) simple-card-utils 15) - 24) simple-card 25) - 36) rsrc-card 37) - 39) rsrc-card -> simple-dpcm-card Kuninori Morimoto (39): 1) ASoC: rsrc-card: remove unused dai_num 2) ASoC: simple-card: use common PREFIX for each DT property 3) ASoC: simple-card: add new asoc_simple_jack and use it 4) ASoC: add new simple-card-utils.c 5) ASoC: simple-card-utils: add asoc_simple_card_parse_tdm() 6) ASoC: simple-card-utils: add asoc_simple_card_parse_dailink_name() 7) ASoC: simple-card-utils: add asoc_simple_card_parse_card_name() 8) ASoC: simple-card-utils: add asoc_simple_card_parse_card_prefix() 9) ASoC: simple-card-utils: add asoc_simple_card_parse_clk() 10) ASoC: simple-card-utils: add asoc_simple_card_parse_endpoint() 11) ASoC: simple-card-utils: add asoc_simple_card_init_dai() 12) ASoC: simple-card-utils: add asoc_simple_card_canonicalize_dailink() 13) ASoC: simple-card-utils: add asoc_simple_card_canonicalize_cpu() 14) ASoC: simple-card-utils: add asoc_simple_card_clean_reference() 15) ASoC: simple-card: use asoc_simple_card_parse_daifmt() 16) ASoC: simple-card: use asoc_simple_card_parse_clk() 17) ASoC: simple-card: use asoc_simple_card_parse_endpoint() 18) ASoC: simple-card: use asoc_simple_card_parse_tdm() 19) ASoC: simple-card: use asoc_simple_card_parse_card_name() 20) ASoC: simple-card: use asoc_simple_card_parse_dailink_name() 21) ASoC: simple-card: use asoc_simple_card_init_dai() 22) ASoC: simple-card: use asoc_simple_card_canonicalize_dailink() 23) ASoC: simple-card: use asoc_simple_card_canonicalize_cpu() 24) ASoC: simple-card: use asoc_simple_card_clean_reference() 25) ASoC: rsrc-card: use asoc_simple_card_parse_daifmt() 26) ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name() 27) ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai 28) ASoC: rsrc-card: use asoc_simple_card_parse_clk() 29) ASoC: rsrc-card: use asoc_simple_card_parse_endpoint() 30) ASoC: rsrc-card: use asoc_simple_card_parse_card_name() 31) ASoC: rsrc-card: use asoc_simple_card_parse_card_prefix() 32) ASoC: rsrc-card: use asoc_simple_card_parse_tdm() 33) ASoC: rsrc-card: use asoc_simple_card_init_dai() 34) ASoC: rsrc-card: use asoc_simple_card_canonicalize_cpu() 35) ASoC: rsrc-card: use asoc_simple_card_canonicalize_dailink() 36) ASoC: rsrc-card: use asoc_simple_card_clean_reference() 37) ASoC: rsrc-card: rename rsrc-card to simple-dpcm-card phase1 38) ASoC: rsrc-card: rename rsrc-card to simple-dpcm-card phase2 39) ASoC: rsrc-card: rename rsrc-card to simple-dpcm-card phase3 Documentation/devicetree/bindings/sound/renesas,rsrc-card.txt | 75 -------------- Documentation/devicetree/bindings/sound/simple-dpcm-card.txt | 79 +++++++++++++++ include/sound/simple_card.h | 11 +-- include/sound/simple_card_utils.h | 77 +++++++++++++++ sound/soc/generic/Kconfig | 10 ++ sound/soc/generic/Makefile | 4 + sound/soc/generic/simple-card-utils.c | 288 +++++++++++++++++++++++++++++++++++++++++++++++++++++ sound/soc/generic/simple-card.c | 424 ++++++++++++++++++++++++------------------------------------------------------ sound/soc/generic/simple-dpcm-card.c | 351 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ sound/soc/sh/Kconfig | 5 - sound/soc/sh/rcar/Makefile | 3 - sound/soc/sh/rcar/rsrc-card.c | 529 -------------------------------------------------------------------------------------------------- 12 files changed, 937 insertions(+), 919 deletions(-)

2 67

[alsa-devel] USB audio (AOAv2) - retire_capture_urb messages
by arv 16 Jul '16

16 Jul '16

Hi All, I am trying to playback audio from Android phone using USB AOAv2. (PCM audio, 16bit, 44.1 KHz, stereo) on a Wandboard Quad (i.MX6) board running Ubuntu 14.04. The detection of phone is fine and playback via alsa commands/gstreamer is successful. But during playback, there are distortions in the sound. dmesg prints as follows, retire_capture_urb: x callbacks suppressed ----->[x is around 41 to 300] retire_capture_urb: x callbacks suppressed retire_capture_urb: x callbacks suppressed retire_capture_urb: x callbacks suppressed arecord command prints underrun occurred. So each time, retire_capture_urb is printed, there is a distortion. I tried the same program on different machines. Following are the results, On Wandboard, the distortions happen each 40 seconds or so. On a Linux server PC running Ubuntu 14.04 the audio breaks are more frequent. On a Linux PC running Ubuntu 12.02 the audio breaks are less frequent. Could anyone guide me on how retire_capture_urb be prevented or how can a smooth playback be achieved ? Should there be any special configurations done at USB driver ? lsusb -v print is as follows, The synch type for the endpoint appears to be enumerated as Synchronous. Could the synch type be modified using libusb, is this the cause of underrun? Bus 001 Device 004: ID 18d1:2d02 Google Inc. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x18d1 Google Inc. idProduct 0x2d02 bcdDevice ff.ff iManufacturer 1 motorola iProduct 2 MotoG3-TE iSerial 3 ZY222WB7TT bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 110 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 1 Control Device bInterfaceProtocol 0 iInterface 0 AudioControl Interface Descriptor: bLength 10 bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdADC 1.00 wTotalLength 40 bInCollection 2 baInterfaceNr( 0) 0 baInterfaceNr( 1) 1 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Microphone bAssocTerminal 0 bNrChannels 2 wChannelConfig 0x0003 Left Front (L) Right Front (R) iChannelNames 0 iTerminal 0 AudioControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 3 wTerminalType 0x0101 USB Streaming bAssocTerminal 2 bSourceID 2 iTerminal 0 AudioControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 6 (FEATURE_UNIT) bUnitID 2 bSourceID 1 bControlSize 2 bmaControls( 0) 0x00 bmaControls( 0) 0x00 iFeature 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 AudioStreaming Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 1 bDelay 1 frames wFormatTag 1 PCM AudioStreaming Interface Descriptor: bLength 11 bDescriptorType 36 bDescriptorSubtype 2 (FORMAT_TYPE) bFormatType 1 (FORMAT_TYPE_I) bNrChannels 2 bSubframeSize 2 bBitResolution 16 bSamFreqType 1 Discrete tSamFreq[ 0] 44100 Endpoint Descriptor: bLength 9 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 13 Transfer Type Isochronous Synch Type Synchronous Usage Type Data wMaxPacketSize 0x0100 1x 256 bytes bInterval 4 bRefresh 0 bSynchAddress 0 AudioControl Endpoint Descriptor: bLength 7 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x01 Sampling Frequency bLockDelayUnits 1 Milliseconds wLockDelay 1 Milliseconds Device Qualifier (for other device speed): bLength 10 bDescriptorType 6 bcdUSB 2.00 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 bNumConfigurations 1 Device Status: 0x0000 (Bus Powered) Thanks for the help..

1 0

[alsa-devel] [PATCH 0/4] Qualcomm IPQ4019 Audio driver addition
by njaigane＠codeaurora.org 15 Jul '16

15 Jul '16

From: Jaiganesh Narayanan <njaigane(a)codeaurora.org> These patches add the support for Qualcomm IPQ4019 ASoC with the ALSA based audio drivers. The patches are broken 1. Device Tree support 2. Audio clock driver support 3. TLMM / Pinctrl support 4. ALSA based audio drivers Jaiganesh Narayanan (4): qcom: ipq4019: Add ipq4019 ASoC device tree changes qcom: ipq4019: ASoC clock driver support qcom: ipq4019: ASoC tlmm/pinctrl support qcom: ipq4019: Add ASoC driver modules .../bindings/sound/qca,ipq4019-audio-adss.txt | 20 + .../bindings/sound/qca,ipq4019-audio.txt | 13 + .../bindings/sound/qca,ipq4019-codec.txt | 15 + .../devicetree/bindings/sound/qca,ipq4019-i2s.txt | 33 + .../devicetree/bindings/sound/qca,ipq4019-i2s1.txt | 29 + .../devicetree/bindings/sound/qca,ipq4019-i2s2.txt | 29 + .../devicetree/bindings/sound/qca,ipq4019-mbox.txt | 23 + .../bindings/sound/qca,ipq4019-pcm-i2s.txt | 15 + .../bindings/sound/qca,ipq4019-pcm-i2s1.txt | 15 + .../bindings/sound/qca,ipq4019-pcm-i2s2.txt | 15 + .../bindings/sound/qca,ipq4019-pcm-spdif.txt | 15 + .../bindings/sound/qca,ipq4019-pcm-tdm.txt | 15 + .../bindings/sound/qca,ipq4019-spdif.txt | 35 + .../bindings/sound/qca,ipq4019-stereo.txt | 17 + .../devicetree/bindings/sound/qca,ipq4019-tdm.txt | 33 + arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 195 ++++- arch/arm/boot/dts/qcom-ipq4019.dtsi | 247 +++++- drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 2 + drivers/clk/qcom/adcc-ipq4019.c | 700 +++++++++++++++++ drivers/clk/qcom/clk-qcapll.c | 197 +++++ drivers/clk/qcom/clk-qcapll.h | 60 ++ drivers/clk/qcom/clk-rcg.h | 68 +- drivers/clk/qcom/clk-rcg2.c | 699 ++++++++++++++++- drivers/clk/qcom/common.c | 9 +- drivers/clk/qcom/common.h | 3 +- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 116 ++- include/dt-bindings/clock/qca,adcc-ipq4019.h | 45 ++ include/dt-bindings/clock/qcom,gcc-ipq4019.h | 4 +- include/dt-bindings/sound/ipq4019-audio.h | 37 + sound/soc/qcom/Kconfig | 47 ++ sound/soc/qcom/Makefile | 1 + sound/soc/qcom/ipq4019/Makefile | 16 + sound/soc/qcom/ipq4019/ipq4019-adss.c | 407 ++++++++++ sound/soc/qcom/ipq4019/ipq4019-adss.h | 432 +++++++++++ sound/soc/qcom/ipq4019/ipq4019-codec.c | 475 ++++++++++++ sound/soc/qcom/ipq4019/ipq4019-codec.h | 91 +++ sound/soc/qcom/ipq4019/ipq4019-cpu-dai.c | 687 +++++++++++++++++ sound/soc/qcom/ipq4019/ipq4019-mbox.c | 825 +++++++++++++++++++++ sound/soc/qcom/ipq4019/ipq4019-mbox.h | 146 ++++ sound/soc/qcom/ipq4019/ipq4019-pcm-i2s.c | 609 +++++++++++++++ sound/soc/qcom/ipq4019/ipq4019-pcm-spdif.c | 664 +++++++++++++++++ sound/soc/qcom/ipq4019/ipq4019-pcm-tdm.c | 609 +++++++++++++++ sound/soc/qcom/ipq4019/ipq4019-pcm.h | 37 + sound/soc/qcom/ipq4019/ipq4019-stereo.c | 313 ++++++++ sound/soc/qcom/ipq4019/ipq4019.c | 121 +++ 46 files changed, 8135 insertions(+), 57 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-audio-adss.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-audio.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-codec.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-i2s.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-i2s1.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-i2s2.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-mbox.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-pcm-i2s.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-pcm-i2s1.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-pcm-i2s2.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-pcm-spdif.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-pcm-tdm.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-spdif.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-stereo.txt create mode 100644 Documentation/devicetree/bindings/sound/qca,ipq4019-tdm.txt create mode 100644 drivers/clk/qcom/adcc-ipq4019.c create mode 100644 drivers/clk/qcom/clk-qcapll.c create mode 100644 drivers/clk/qcom/clk-qcapll.h create mode 100644 include/dt-bindings/clock/qca,adcc-ipq4019.h create mode 100644 include/dt-bindings/sound/ipq4019-audio.h create mode 100644 sound/soc/qcom/ipq4019/Makefile create mode 100644 sound/soc/qcom/ipq4019/ipq4019-adss.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-adss.h create mode 100644 sound/soc/qcom/ipq4019/ipq4019-codec.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-codec.h create mode 100644 sound/soc/qcom/ipq4019/ipq4019-cpu-dai.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-mbox.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-mbox.h create mode 100644 sound/soc/qcom/ipq4019/ipq4019-pcm-i2s.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-pcm-spdif.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-pcm-tdm.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019-pcm.h create mode 100644 sound/soc/qcom/ipq4019/ipq4019-stereo.c create mode 100644 sound/soc/qcom/ipq4019/ipq4019.c -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 6

[alsa-devel] [PATCH] ASoC: nau8825: drop redundant idiom when converting integer to boolean
by John Hsu 15 Jul '16

15 Jul '16

Thanks Mark and Anatol for the discussion. According to the result, the standard C will translate any non-zero value into true, or false otherwise. QUOTE: "6.3.1.2 Boolean type When any scalar value is converted to _Bool, the result is 0 if the value compares equal to 0; otherwise, the result is 1 " Thus, the "!!" idiom is removed. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> --- sound/soc/codecs/nau8825.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index a97418d..5c9707a 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1349,9 +1349,9 @@ static bool nau8825_is_jack_inserted(struct regmap *regmap) int status, jkdet; regmap_read(regmap, NAU8825_REG_JACK_DET_CTRL, &jkdet); - active_high = !!(jkdet & NAU8825_JACK_POLARITY); + active_high = jkdet & NAU8825_JACK_POLARITY; regmap_read(regmap, NAU8825_REG_I2C_DEVICE_ID, &status); - is_high = !!(status & NAU8825_GPIO2JD1); + is_high = status & NAU8825_GPIO2JD1; /* return jack connection status according to jack insertion logic * active high or active low. */ -- 2.6.4

2 1

[alsa-devel] [alsa-lib][PATCH 00/29] mixer: replace usage of alloca() with automatic variables
by Takashi Sakamoto 15 Jul '16

15 Jul '16

Hi, A batch of this patchset is to apply the same idea to mixer feature as I posted in this thread. http://mailman.alsa-project.org/pipermail/alsa-devel/2016-July/110196.html In short, replacement of alloca() with automatic variables brings us some advantages; better execution performance and saving local storages just for a little. I can see below effect on my environment (Ubuntu 16.04, amd64) $ git checkout master $ git show HEAD commit 33e946fdd32da2b918e88750fcfd78014ae3e079 ... $ ./gitcompile --with-plugindir=/usr/lib/x86_64-linux-gnu/alsa-lib/ ... $ ls -l src/.libs/libasound.so.2.0.0 -rwxrwxr-x 1 mocchi mocchi 4783080 7月 15 09:08 src/.libs/libasound.so.2.0.0 $ git checkout remove-alloca-mixer $ make ... $ ls -l src/.libs/libasound.so.2.0.0 -rwxrwxr-x 1 mocchi mocchi 4780152 7月 15 09:09 src/.libs/libasound.so.2.0.0 $ gcc -v ... gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.1) Takashi Sakamoto (29): mixer: include library local header to find layout of structures mixer: change code formatting for elem_read_volume() mixer: remove alloca() from elem_read_volume() mixer: change code formatting for elem_read_route() mixer: remove alloca() from elem_read_route() mixer: change code formatting for elem_read_enum() mixer: remove alloca() from elem_read_enum() mixer: change code formatting for selem_read() mixer: remove alloca() from selem_read() mixer: change code formatting for elem_write_volume() mixer: remove alloca() from elem_write_volume() mixer: change code formatting for elem_write_switch() mixer: remove alloca() from elem_write_switch() mixer: remove alloca() from elem_write_switch_constant() mixer: change code formatting for elem_write_enum() mixer: remove alloca() from elem_write_enum() mixer: change code formatting for elem_write_route() mixer: remove alloca() from elem_write_route() mixer: change code formatting for selem_write_main() mixer: remove alloca() from selem_write_main() mixer: change code formatting for init_db_range() mixer: remove alloca() from init_db_range() mixer: remove alloca() from enum_item_name_ops() mixer: remove alloca() from get_enum_item_ops() mixer: remove alloca() from set_enum_item_ops() mixer: change code formatting for simple_add1() mixer: remove alloca() from simple_add1() mixer: change code formatting for simple_event_add() mixer: remove alloca() from simple_event_add() src/mixer/simple_none.c | 208 ++++++++++++++++++++++++------------------------ 1 file changed, 106 insertions(+), 102 deletions(-) -- 2.7.4

2 30

Re: [alsa-devel] [PATCH 2/3] ALSA - hda: Add support for link audio time reporting
by Vinod Koul 15 Jul '16

15 Jul '16

On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote: > Hi, > > [auto build test ERROR on sound/for-next] > [also build test ERROR on v4.7-rc7 next-20160711] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-fo… > base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > config: arm-multi_v7_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/m… -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > >> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory > compilation terminated. Okay i think I need to move this bit into the intel code. Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that? Thanks > 24 #include <linux/delay.h> > 25 #include <linux/interrupt.h> > 26 #include <linux/kernel.h> > 27 #include <linux/module.h> > 28 #include <linux/pm_runtime.h> > 29 #include <linux/slab.h> > > 30 #include <asm/tsc.h> > 31 #include <sound/core.h> > 32 #include <sound/initval.h> > 33 #include "hda_controller.h" -- ~Vinod

2 7

[alsa-devel] [PATCH] ASoC: nau8825: jack connection decision with different insertion logic
by John Hsu 14 Jul '16

14 Jul '16

The original design only covers the jack insertion logic is active low. Add more condition to cover no matter the logic is active low and high. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> --- sound/soc/codecs/nau8825.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 3f30e6e..a97418d 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1345,10 +1345,17 @@ EXPORT_SYMBOL_GPL(nau8825_enable_jack_detect); static bool nau8825_is_jack_inserted(struct regmap *regmap) { - int status; + bool active_high, is_high; + int status, jkdet; + regmap_read(regmap, NAU8825_REG_JACK_DET_CTRL, &jkdet); + active_high = !!(jkdet & NAU8825_JACK_POLARITY); regmap_read(regmap, NAU8825_REG_I2C_DEVICE_ID, &status); - return !(status & NAU8825_GPIO2JD1); + is_high = !!(status & NAU8825_GPIO2JD1); + /* return jack connection status according to jack insertion logic + * active high or active low. + */ + return active_high == is_high; } static void nau8825_restart_jack_detection(struct regmap *regmap) -- 2.6.4

2 1

[alsa-devel] [PATCH] ASoC: rt5514-spi: Convert to use devm_* API
by Axel Lin 14 Jul '16

14 Jul '16

Use devm_* API to simplify the code. This patch also fixes the return value in probe error paths. Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/rt5514-spi.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 8a9382e..e1b326d 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -409,33 +409,21 @@ static int rt5514_spi_probe(struct spi_device *spi) rt5514_spi = spi; - ret = snd_soc_register_platform(&spi->dev, &rt5514_spi_platform); + ret = devm_snd_soc_register_platform(&spi->dev, &rt5514_spi_platform); if (ret < 0) { dev_err(&spi->dev, "Failed to register platform.\n"); - goto err_plat; + return ret; } - ret = snd_soc_register_component(&spi->dev, &rt5514_spi_dai_component, - &rt5514_spi_dai, 1); + ret = devm_snd_soc_register_component(&spi->dev, + &rt5514_spi_dai_component, + &rt5514_spi_dai, 1); if (ret < 0) { dev_err(&spi->dev, "Failed to register component.\n"); - goto err_comp; + return ret; } return 0; -err_comp: - snd_soc_unregister_platform(&spi->dev); -err_plat: - - return 0; -} - -static int rt5514_spi_remove(struct spi_device *spi) -{ - snd_soc_unregister_component(&spi->dev); - snd_soc_unregister_platform(&spi->dev); - - return 0; } static const struct of_device_id rt5514_of_match[] = { @@ -450,7 +438,6 @@ static struct spi_driver rt5514_spi_driver = { .of_match_table = of_match_ptr(rt5514_of_match), }, .probe = rt5514_spi_probe, - .remove = rt5514_spi_remove, }; module_spi_driver(rt5514_spi_driver); -- 2.5.0

2 1