June 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [alsa-lib][PATCH 0/5] ctl: support extra information for user-defined element set
by Takashi Sakamoto 30 Jun '16

30 Jun '16

Hi, This patchset adds support extra information to the type-specific for user-defined element set. Currently, 'dimension' is such an extra information. In ALSA kernel/userspace interface, information to an element is described in this structure. struct snd_ctl_elem_info { struct snd_ctl_elem_id id; unsigned int access; unsigned int count; pid_t owner; union value; union dimen; unsigned char reserved[64 - 4 * sizeof(unsigned short)]; }; This structure includes reserved fields, thus it's possible to add more fields for future extension. Currently, APIs to add user-defined element set don't support such extra fields. Meanwhile, supporting just the dimension field is not good as stable library APIs. This patchset changes prototype of the APIs with 'snd_ctl_elem_info_t' instead of adding more parameters. Callers are expected to fill the parameter with identification information and the extra information. Takashi Sakamoto (5): ctl: support extra information in user-defined element set ctl: add an API to set dimension levels to element information ctl: optimize a test for user-defined element set to older kernels ctl: optimize a test for user-defined element set to changes of APIs ctl: support dimension test for user-defined element set include/control.h | 12 ++- src/control/control.c | 219 +++++++++++++++++++++++--------------------- src/pcm/pcm_softvol.c | 10 +- test/user-ctl-element-set.c | 122 ++++++++++++++++++------ 4 files changed, 220 insertions(+), 143 deletions(-) -- 2.7.4

2 8

[alsa-devel] [PATCH] ALSA: riptide: Use DIV_ROUND_UP
by Amitoj Kaur Chawla 30 Jun '16

30 Jun '16

The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)) but is perhaps more readable. The Coccinelle script used to make this change is as follows: @haskernel@ @@ #include <linux/kernel.h> @depends on haskernel@ expression n,d; @@ ( - (n + d - 1) / d + DIV_ROUND_UP(n,d) | - (n + (d - 1)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla <amitoj1606(a)gmail.com> --- sound/pci/riptide/riptide.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index 94639d6..067a912 100644 --- a/sound/pci/riptide/riptide.c +++ b/sound/pci/riptide/riptide.c @@ -1496,7 +1496,7 @@ static int snd_riptide_prepare(struct snd_pcm_substream *substream) f = PAGE_SIZE; while ((size + (f >> 1) - 1) <= (f << 7) && (f << 1) > period) f = f >> 1; - pages = (size + f - 1) / f; + pages = DIV_ROUND_UP(size, f); data->size = size; data->pages = pages; snd_printdd -- 1.9.1

3 2

Re: [alsa-devel] [PATCH 2/2] ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode
by Nicolin Chen 29 Jun '16

29 Jun '16

On Wed, Jun 29, 2016 at 09:50:24PM +0300, Alexander Shiyan wrote: > >Среда, 29 июня 2016, 21:26 +03:00 от Nicolin Chen <nicoleotsuka(a)gmail.com>: > > > >On Wed, Jun 29, 2016 at 10:52:01AM +0300, Alexander Shiyan wrote: > > > >> >your failed case. Could you please tell me what were the FSclk, > >> >BITclk and size of your case? > > > >> Here is my oscillograms with/without patch: > >> Bclk=12 MHz, sound is just a "cat /dev/urandom > /dev/dsp", i.e. FS=8 KHz, MONO. > >> Upper (yellow) line is TXDATA, Lower (blue) is FS. > >> > >> Measurement without patch: https://cloud.mail.ru/public/Rcsv/xr88V5Sa1 > >> Measurement with patch: https://cloud.mail.ru/public/NCwn/DQnzioQEL > > > >Thanks for the reply. So in the case without patch, it looks like > >SSI just sent the data ignoring the slot size right? > > I could be wrong, but think that WL (word length) still point to number of valid > data bits within 32bit chunk (as defined for I2S-Master mode), > but since DC=0, this cause to send next word to the channel again and again. I see. Thanks for the fix.

1 0

[alsa-devel] [PATCH v3 0/6] ASoC: samsung: Sound support for Exynos5433 TM2(E) boards
by Sylwester Nawrocki 29 Jun '16

29 Jun '16

This patch series adds sound support for the Exynos 5433 based TM2 and TM2E board. It includes minimal drivers for the Low Power Audio Subsystem (LPASS) and the MAX98504 class D speaker amplifier as well as the actual asoc machine driver. The changes since v2 are listed in individual patches, I didn't add any Acked-by tag to the max98504 DT binding patch as there was significant change since v2. Inha Song (1): ASoC: samsung: Add Samsung Low Power Audio Subsystem driver Sylwester Nawrocki (5): ASoC: samsung: Add DT bindings documentation for LPASS ASoC: Add DT bindings documentation for max98504 amplifier ASoC: max98504: Add max98504 speaker amplifier driver ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem ASoC: samsung: Add machine driver for Exynos5433 based TM2 board .../devicetree/bindings/sound/max98504.txt | 44 ++ .../bindings/sound/samsung,exynos5433-lpass.txt | 8 + .../bindings/sound/samsung,tm2-audio.txt | 36 ++ sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/max98504.c | 383 ++++++++++++++ sound/soc/codecs/max98504.h | 59 +++ sound/soc/samsung/Kconfig | 13 + sound/soc/samsung/Makefile | 4 + sound/soc/samsung/lpass.c | 162 ++++++ sound/soc/samsung/lpass.h | 47 ++ sound/soc/samsung/tm2_wm5110.c | 579 +++++++++++++++++++++ 12 files changed, 1341 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98504.txt create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt create mode 100644 Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt create mode 100644 sound/soc/codecs/max98504.c create mode 100644 sound/soc/codecs/max98504.h create mode 100644 sound/soc/samsung/lpass.c create mode 100644 sound/soc/samsung/lpass.h create mode 100644 sound/soc/samsung/tm2_wm5110.c -- 1.9.1

2 8

[alsa-devel] [PATCH v4 0/9] ASoC: Mediatek: Add support for MT2701 SOC
by Garlic Tseng 29 Jun '16

29 Jun '16

Sorry for submitting new version in a short time. I find some comment style error and fix it. please ignore v3 and directly review v4. This patch adds basic support for Mediatek AFE for MT2701 SoC. The patch is based on broonie tree "for-next" branch. Change since v3: * fix comments style. Change since v2: * fix comments style. * replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL * reduce debug message * move mutex lock for irq-allocated to AFE struct * remove func mtk_simple_isr and call snd_pcm_period_elapsed directly * mt2701 driver probe will fail if clock initial error * fix dapm on/off switch control naming Change since v1: implement common private structure, fe dai and platform driver. let mt8173 and mt2701 use the common structure. Garlic Tseng (9): ASoC: mediatek: Refine mt8173 driver and change config option ASoC: mediatek: implement mediatek common structure ASoC: mediatek: let mt8173 use mediatek common structure ASoC: mediatek: add documents for mt2701 ASoC: mediatek: add structure define and clock control for 2701 ASoC: mediatek: add mt2701 platform driver implementation. ASoC: bt-sco: extend rate and add a general compatible string ASoC: mediatek: add BT implementation ASoC: mediatek: Add mt2701-cs42448 driver and config option. Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- .../devicetree/bindings/sound/mt2701-afe-pcm.txt | 150 ++ .../devicetree/bindings/sound/mt2701-cs42448.txt | 43 + sound/soc/codecs/bt-sco.c | 5 +- sound/soc/mediatek/Kconfig | 44 +- sound/soc/mediatek/Makefile | 11 +- sound/soc/mediatek/common/Makefile | 17 + sound/soc/mediatek/common/mtk-afe-fe-dai.c | 379 +++++ sound/soc/mediatek/common/mtk-afe-fe-dai.h | 45 + .../soc/mediatek/common/mtk-afe-platform-driver.c | 90 ++ .../soc/mediatek/common/mtk-afe-platform-driver.h | 23 + sound/soc/mediatek/common/mtk-base-afe.h | 104 ++ sound/soc/mediatek/mt2701/Makefile | 19 + sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c | 464 ++++++ sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h | 38 + sound/soc/mediatek/mt2701/mt2701-afe-common.h | 181 +++ sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 1698 ++++++++++++++++++++ sound/soc/mediatek/mt2701/mt2701-cs42448.c | 422 +++++ sound/soc/mediatek/mt2701/mt2701-reg.h | 186 +++ sound/soc/mediatek/mt8173/Makefile | 7 + sound/soc/mediatek/mt8173/mt8173-afe-common.h | 73 + .../{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} | 921 +++++------ sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c | 4 +- sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c | 2 +- sound/soc/mediatek/mtk-afe-common.h | 101 -- 27 files changed, 4399 insertions(+), 634 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt create mode 100644 Documentation/devicetree/bindings/sound/mt2701-cs42448.txt create mode 100644 sound/soc/mediatek/common/Makefile create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.c create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.h create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.c create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.h create mode 100644 sound/soc/mediatek/common/mtk-base-afe.h create mode 100644 sound/soc/mediatek/mt2701/Makefile create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-common.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-reg.h create mode 100644 sound/soc/mediatek/mt8173/Makefile create mode 100644 sound/soc/mediatek/mt8173/mt8173-afe-common.h rename sound/soc/mediatek/{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} (51%) rename sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c (99%) delete mode 100644 sound/soc/mediatek/mtk-afe-common.h -- 1.9.1

3 14

[alsa-devel] [PATCH v2 0/9] ASoC: Mediatek: Add support for MT2701 SOC
by Garlic Tseng 29 Jun '16

29 Jun '16

This patch adds basic support for Mediatek AFE for MT2701 SoC. The patch is based on broonie tree "for-next" branch. Change since v1: implement common private structure, fe dai and platform driver. let mt8173 and mt2701 use the common structure. Garlic Tseng (9): ASoC: mediatek: Refine mt8173 driver and change config option ASoC: mediatek: implement mediatek common structure ASoC: mediatek: let mt8173 use mediatek common structure ASoC: mediatek: add documents for mt2701 ASoC: mediatek: add structure define and clock control for 2701 ASoC: mediatek: add mt2701 platform driver implementation. ASoC: bt-sco: extend rate and add a general compatible string ASoC: mediatek: add BT implementation ASoC: mediatek: Add mt2701-cs42448 driver and config option. Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- .../devicetree/bindings/sound/mt2701-afe-pcm.txt | 150 ++ .../devicetree/bindings/sound/mt2701-cs42448.txt | 43 + sound/soc/codecs/bt-sco.c | 5 +- sound/soc/mediatek/Kconfig | 44 +- sound/soc/mediatek/Makefile | 11 +- sound/soc/mediatek/common/Makefile | 17 + sound/soc/mediatek/common/mtk-afe-fe-dai.c | 387 +++++ sound/soc/mediatek/common/mtk-afe-fe-dai.h | 47 + .../soc/mediatek/common/mtk-afe-platform-driver.c | 90 ++ .../soc/mediatek/common/mtk-afe-platform-driver.h | 23 + sound/soc/mediatek/common/mtk-base-afe.h | 103 ++ sound/soc/mediatek/mt2701/Makefile | 19 + sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c | 357 +++++ sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h | 33 + sound/soc/mediatek/mt2701/mt2701-afe-common.h | 185 +++ sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 1664 ++++++++++++++++++++ sound/soc/mediatek/mt2701/mt2701-cs42448.c | 422 +++++ sound/soc/mediatek/mt2701/mt2701-reg.h | 186 +++ sound/soc/mediatek/mt8173/Makefile | 7 + sound/soc/mediatek/mt8173/mt8173-afe-common.h | 73 + .../{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} | 923 +++++------ sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c | 4 +- sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c | 2 +- sound/soc/mediatek/mtk-afe-common.h | 101 -- 27 files changed, 4267 insertions(+), 635 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt create mode 100644 Documentation/devicetree/bindings/sound/mt2701-cs42448.txt create mode 100644 sound/soc/mediatek/common/Makefile create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.c create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.h create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.c create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.h create mode 100644 sound/soc/mediatek/common/mtk-base-afe.h create mode 100644 sound/soc/mediatek/mt2701/Makefile create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-common.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-reg.h create mode 100644 sound/soc/mediatek/mt8173/Makefile create mode 100644 sound/soc/mediatek/mt8173/mt8173-afe-common.h rename sound/soc/mediatek/{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} (51%) rename sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c (99%) delete mode 100644 sound/soc/mediatek/mtk-afe-common.h -- 1.9.1

2 18

[alsa-devel] [PATCH v3 0/9] ASoC: Mediatek: Add support for MT2701 SOC
by Garlic Tseng 29 Jun '16

29 Jun '16

This patch adds basic support for Mediatek AFE for MT2701 SoC. The patch is based on broonie tree "for-next" branch. Change since v2: * fix comments style. * replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL * reduce debug message * move mutex lock for irq-allocated to AFE struct * remove func mtk_simple_isr and call snd_pcm_period_elapsed directly * mt2701 driver probe will fail if clock initial error * fix dapm on/off switch control naming Change since v1: implement common private structure, fe dai and platform driver. let mt8173 and mt2701 use the common structure. Garlic Tseng (9): ASoC: mediatek: Refine mt8173 driver and change config option ASoC: mediatek: implement mediatek common structure ASoC: mediatek: let mt8173 use mediatek common structure ASoC: mediatek: add documents for mt2701 ASoC: mediatek: add structure define and clock control for 2701 ASoC: mediatek: add mt2701 platform driver implementation. ASoC: bt-sco: extend rate and add a general compatible string ASoC: mediatek: add BT implementation ASoC: mediatek: Add mt2701-cs42448 driver and config option. Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- .../devicetree/bindings/sound/mt2701-afe-pcm.txt | 150 ++ .../devicetree/bindings/sound/mt2701-cs42448.txt | 43 + sound/soc/codecs/bt-sco.c | 5 +- sound/soc/mediatek/Kconfig | 44 +- sound/soc/mediatek/Makefile | 11 +- sound/soc/mediatek/common/Makefile | 17 + sound/soc/mediatek/common/mtk-afe-fe-dai.c | 379 +++++ sound/soc/mediatek/common/mtk-afe-fe-dai.h | 45 + .../soc/mediatek/common/mtk-afe-platform-driver.c | 90 ++ .../soc/mediatek/common/mtk-afe-platform-driver.h | 23 + sound/soc/mediatek/common/mtk-base-afe.h | 104 ++ sound/soc/mediatek/mt2701/Makefile | 19 + sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c | 464 ++++++ sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h | 38 + sound/soc/mediatek/mt2701/mt2701-afe-common.h | 181 +++ sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 1698 ++++++++++++++++++++ sound/soc/mediatek/mt2701/mt2701-cs42448.c | 422 +++++ sound/soc/mediatek/mt2701/mt2701-reg.h | 186 +++ sound/soc/mediatek/mt8173/Makefile | 7 + sound/soc/mediatek/mt8173/mt8173-afe-common.h | 73 + .../{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} | 921 +++++------ sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c | 4 +- sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c | 2 +- sound/soc/mediatek/mtk-afe-common.h | 101 -- 27 files changed, 4399 insertions(+), 634 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt create mode 100644 Documentation/devicetree/bindings/sound/mt2701-cs42448.txt create mode 100644 sound/soc/mediatek/common/Makefile create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.c create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.h create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.c create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.h create mode 100644 sound/soc/mediatek/common/mtk-base-afe.h create mode 100644 sound/soc/mediatek/mt2701/Makefile create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-common.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-reg.h create mode 100644 sound/soc/mediatek/mt8173/Makefile create mode 100644 sound/soc/mediatek/mt8173/mt8173-afe-common.h rename sound/soc/mediatek/{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} (51%) rename sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c (99%) delete mode 100644 sound/soc/mediatek/mtk-afe-common.h -- 1.9.1

2 10

Re: [alsa-devel] DPCM: skip DAPM_STREAM_STOP event to BE, if still used by other FE
by Kai Chieh Chuang 29 Jun '16

29 Jun '16

> If this isn't happening that seems like a bug, I'm a bit surprised > nobody else ran into it? Shouldn't the counts of stream events that > happen be symmetric (ie, we get as many stops as starts), or are we > possibly missing some from things being switched in and out or something? This idea is same as the DPCM BE state control, in int dpcm_be_dai_hw_free(..) { ...... /* do not free hw if this BE is used by other FE */ if (be->dpcm[stream].users > 1) continue; and int dpcm_be_dai_shutdown(...) { .... if (--be->dpcm[stream].users != 0) continue; The BE receiving SND_SOC_DAPM_STREAM_STOP event, while still used by a FE who is in STREAM_START state. The DAPM will just inactive BE related widget/dai without checking. This just doesn't seems right. And the last FE using the BE calls in to dpcm_fe_dai_shutdown(), will run the process normally. Actually, i trace the log, when one of the FE sent stop event to "still in use BE", the BE power state will not be changed. Until the system goes into SNDRV_CTL_POWER_D3cold, the BE will be shutdown (i did set the ignore_suspend=1). I didn't check why the BE is not turned off at the point when receiving the stop event. I'm also curious why no one seems to have the same issue. Probably there is not much DPCM architecture system yet on the Linux?

2 1

Re: [alsa-devel] DPCM: skip DAPM_STREAM_STOP event to BE, if still used by other FE
by Mark Brown 29 Jun '16

29 Jun '16

On Fri, Jun 24, 2016 at 02:21:34PM +0800, KaiChieh Chuang wrote: > Is there any comment on this? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway.

1 0

Re: [alsa-devel] [PATCH 2/2] ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode
by Nicolin Chen 29 Jun '16

29 Jun '16

On Tue, Jun 28, 2016 at 10:59:32PM +0300, Alexander Shiyan wrote: > >Вторник, 28 июня 2016, 21:20 +03:00 от Nicolin Chen <nicoleotsuka(a)gmail.com>: > > > >On Sat, Jun 25, 2016 at 07:59:22AM +0300, Alexander Shiyan wrote: > >> The i.MX51 datasheet says: > >> Chapter 56.1.2.4 I2S Mode > >> ... > >> When I2S modes are entered (I2S master (01) or I2S slave (10)), > >> the following settings are recommended: > >> ... > >> - TX Frame Rate should be 2 i.e. (STCCR[12:8] = 1) > >> - RX Frame Rate should be 2 i.e. (SRCCR[12:8] = 1) > >> > >> Chapter 56.3.3.12 SSI Transmit and Receive Clock Control Registers (STCCR & SRCCR) > >> ... > >> Bits 12-8 DC4-DC0 > >> Frame Rate Divider Control. These bits are used to control the divide ratio > >> for the programmable frame rate dividers. The divide ratio works on the word > >> clock. In Normal mode, this ratio determines the word transfer rate. > >> In Network mode, this ratio sets the number of words per frame. The divide > >> ratio ranges from 1 to 32 in Normal mode and from 2 to 32 in Network mode. > >> In Normal mode, a divide ratio of 1 (DC=00000) provides continuous periodic > >> data word transfer. A bit-length frame sync must be used in this case. > >> > >> Function fsl_ssi_hw_params() setup Normal mode for MONO output, > >> so with DC=0, SSI enters to continuous periodic data word transfer. > >> To fix this, setup DC for any I2S mode. > > > >The change looks fine and didn't show any problem when I tested it. > >But I am wondering what's the failed user case here so we need this > >patch to fix? (The mono playback works without this patch as well.) > > Probably this works fine without patch if FSclk == BITclk * size. I acked this patch since it's more likely a correct configuration according to the reference manual while still want to know what's your failed case. Could you please tell me what were the FSclk, BITclk and size of your case? Thanks Nicolin

2 2