June 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/7] ASoC: rockchip: Fix audio on Veyron.
by Enric Balletbo i Serra 04 Jul '16

04 Jul '16

Hi all, This patch series adds support and fixes the audio support for Veyron devices. With these patches I'm able to playback from speakers and headphones, and record from the microphone on a Veyron Jerry Chromebook. Patches 1/7 and 2/7 were already sent by John Keeping,[1] [2], but I think it's interesting have them included here. Patches from 1/7 to 5/7 should go through the Mark Brown ASoC tree. Patches 6/7 and 7/7 should go through the Heiko Stuebner rockchip tree. [1] https://patchwork.kernel.org/patch/9017491/ [2] https://patchwork.kernel.org/patch/9017501/ Enric Balletbo i Serra (5): ASoC: rockchip-max98090: Fix NULL pointer de reference while accessing to jack ASoC: rockchip-max98090: Fix the Headset Mic route. ASoC: rockchip-max98090: Fix DAPM unknown pin for Headset Jack ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards ARM: dts: rockchip: veyron: Add analog audio codecs. John Keeping (2): ASoC: rockchip: Revert "ASoC: rockchip: i2s: remove unused variables" ASoC: rockchip: Revert "ASoC: rockchip: i2s: separate capture and playback" arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 102 ++++++++++++++++++++++ arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 + sound/soc/rockchip/rockchip_i2s.c | 87 +++++++++++------- sound/soc/rockchip/rockchip_max98090.c | 54 ++++++------ 4 files changed, 187 insertions(+), 57 deletions(-) create mode 100644 arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi -- 2.1.0

3 14

[alsa-devel] [PATCH] ASoC: codecs: Allow user to select WM9713 codec
by Alexander Shiyan 04 Jul '16

04 Jul '16

Add simple description and necessary options to allow to select Wolfson WM9713 codec. Signed-off-by: Alexander Shiyan <shc_work(a)mail.ru> --- sound/soc/codecs/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 4d82a58..6721427 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1010,8 +1010,9 @@ config SND_SOC_WM9712 tristate config SND_SOC_WM9713 - tristate + tristate "Wolfson Microelectronics WM9713 codec" select REGMAP_AC97 + select SND_SOC_AC97_BUS # Amp config SND_SOC_LM4857 -- 2.4.9

2 1

[alsa-devel] [PATCH v5 0/9] ASoC: Mediatek: Add support for MT2701 SOC
by Garlic Tseng 04 Jul '16

04 Jul '16

This patch adds basic support for Mediatek AFE for MT2701 SoC. The patch is based on broonie tree "for-next" branch. Change since v4: * remove SND_SOC_MEDIATEK config prompt * fix config prompt to meaningful one for SND_SOC_MT2701_CS42448 * remove some unnecessary random space change Change since v3: * fix comments style. Change since v2: * fix comments style. * replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL * reduce debug message * move mutex lock for irq-allocated to AFE struct * remove func mtk_simple_isr and call snd_pcm_period_elapsed directly * mt2701 driver probe will fail if clock initial error * fix dapm on/off switch control naming Change since v1: implement common private structure, fe dai and platform driver. let mt8173 and mt2701 use the common structure. Garlic Tseng (9): ASoC: mediatek: Refine mt8173 driver and change config option ASoC: mediatek: implement mediatek common structure ASoC: mediatek: let mt8173 use mediatek common structure ASoC: mediatek: add documents for mt2701 ASoC: mediatek: add structure define and clock control for 2701 ASoC: mediatek: add mt2701 platform driver implementation. ASoC: bt-sco: extend rate and add a general compatible string ASoC: mediatek: add BT implementation ASoC: mediatek: Add mt2701-cs42448 driver and config option. Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- .../devicetree/bindings/sound/mt2701-afe-pcm.txt | 150 ++ .../devicetree/bindings/sound/mt2701-cs42448.txt | 43 + sound/soc/codecs/bt-sco.c | 5 +- sound/soc/mediatek/Kconfig | 37 +- sound/soc/mediatek/Makefile | 10 +- sound/soc/mediatek/common/Makefile | 16 + sound/soc/mediatek/common/mtk-afe-fe-dai.c | 379 +++++ sound/soc/mediatek/common/mtk-afe-fe-dai.h | 45 + .../soc/mediatek/common/mtk-afe-platform-driver.c | 90 ++ .../soc/mediatek/common/mtk-afe-platform-driver.h | 23 + sound/soc/mediatek/common/mtk-base-afe.h | 104 ++ sound/soc/mediatek/mt2701/Makefile | 19 + sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c | 464 ++++++ sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h | 38 + sound/soc/mediatek/mt2701/mt2701-afe-common.h | 181 +++ sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 1698 ++++++++++++++++++++ sound/soc/mediatek/mt2701/mt2701-cs42448.c | 422 +++++ sound/soc/mediatek/mt2701/mt2701-reg.h | 186 +++ sound/soc/mediatek/mt8173/Makefile | 7 + sound/soc/mediatek/mt8173/mt8173-afe-common.h | 73 + .../{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} | 921 +++++------ sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c | 2 +- .../mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c | 4 +- sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c | 2 +- sound/soc/mediatek/mtk-afe-common.h | 101 -- 27 files changed, 4390 insertions(+), 634 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt create mode 100644 Documentation/devicetree/bindings/sound/mt2701-cs42448.txt create mode 100644 sound/soc/mediatek/common/Makefile create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.c create mode 100644 sound/soc/mediatek/common/mtk-afe-fe-dai.h create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.c create mode 100644 sound/soc/mediatek/common/mtk-afe-platform-driver.h create mode 100644 sound/soc/mediatek/common/mtk-base-afe.h create mode 100644 sound/soc/mediatek/mt2701/Makefile create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-common.h create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-reg.h create mode 100644 sound/soc/mediatek/mt8173/Makefile create mode 100644 sound/soc/mediatek/mt8173/mt8173-afe-common.h rename sound/soc/mediatek/{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} (51%) rename sound/soc/mediatek/{ => mt8173}/mt8173-max98090.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5514.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650-rt5676.c (99%) rename sound/soc/mediatek/{ => mt8173}/mt8173-rt5650.c (99%) delete mode 100644 sound/soc/mediatek/mtk-afe-common.h -- 1.9.1

3 19

[alsa-devel] [PATCH] drm: mediatek: fix prototypes after API change
by Arnd Bergmann 02 Jul '16

02 Jul '16

The newly added mediatek HDMI driver clashes with an API change for struct hdmi_codec_ops, causing an 'allmodconfig' build to fail: drivers/gpu/drm/mediatek/mtk_hdmi.c:1653:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1654:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1655:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1656:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/drm/mediatek/mtk_hdmi.c:1657:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] This changes the API accordingly for the mediatek driver. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Fixes: efc9194bcff8 ("ASoC: hdmi-codec: callback function will be called with private data") --- The new driver is currently part of Dave Airlie's drm-next tree, while the API change is in Mark Brown's asoc-next tree, so my fix has to be done on top of both. I can see two ways out of this: a) Stephen Rothwell could add my fixup on top of linux-next as a merge fix, and the fix gets sent to Linus Torvalds along with the second of the two branches b) efc9194bcff8 gets merged into drm-next along with my change in the merge commit. It is currently a standalone patch in its own branch in the ASoC tree. --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index ba812ef2c9d1..334562d06731 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1535,7 +1535,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, * HDMI audio codec callbacks */ -static int mtk_hdmi_audio_hw_params(struct device *dev, +static int mtk_hdmi_audio_hw_params(struct device *dev, void *data, struct hdmi_codec_daifmt *daifmt, struct hdmi_codec_params *params) { @@ -1604,7 +1604,7 @@ static int mtk_hdmi_audio_hw_params(struct device *dev, return 0; } -static int mtk_hdmi_audio_startup(struct device *dev) +static int mtk_hdmi_audio_startup(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1615,7 +1615,7 @@ static int mtk_hdmi_audio_startup(struct device *dev) return 0; } -static void mtk_hdmi_audio_shutdown(struct device *dev) +static void mtk_hdmi_audio_shutdown(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1624,7 +1624,7 @@ static void mtk_hdmi_audio_shutdown(struct device *dev) mtk_hdmi_audio_disable(hdmi); } -int mtk_hdmi_audio_digital_mute(struct device *dev, bool enable) +int mtk_hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); @@ -1638,7 +1638,7 @@ int mtk_hdmi_audio_digital_mute(struct device *dev, bool enable) return 0; } -static int mtk_hdmi_audio_get_eld(struct device *dev, uint8_t *buf, size_t len) +static int mtk_hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, size_t len) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); -- 2.9.0

4 3

[alsa-devel] Assertion failure in alsa-lib crashing applications (snd_pcm_area_copy: Assertion `dst < src || dst >= src + bytes' failed)
by Baptiste Jonglez 01 Jul '16

01 Jul '16

Hi, When using Ring [1], an audio-video application, it sometimes crashes because of an assertion in libasound.so: pcm.c:2758: snd_pcm_area_copy: Assertion `dst < src || dst >= src + bytes' failed. The complete upstream bug report is at [2]. The (not-so-useful) stack trace is the following: #0 0x00007fc356e462a8 raise (libc.so.6) #1 0x00007fc356e4772a abort (libc.so.6) #2 0x00007fc356e3f1b7 __assert_fail_base (libc.so.6) #3 0x00007fc356e3f262 __assert_fail (libc.so.6) #4 0x00007fc35ba65c84 snd_pcm_area_copy (libasound.so.2) #5 0x00007fc35ba65ebc snd_pcm_areas_copy (libasound.so.2) #6 0x00007fc35baa6d95 n/a (libasound.so.2) #7 0x00007fc35ba77c1f n/a (libasound.so.2) #8 0x00007fc35ba77a59 n/a (libasound.so.2) #9 0x000000000051ba97 n/a (dring) #10 0x000000000051c118 n/a (dring) #11 0x000000000051cfad n/a (dring) #12 0x00007fc357787c40 execute_native_thread_routine (libstdc++.so.6) #13 0x00007fc359ec2424 start_thread (libpthread.so.0) #14 0x00007fc356efacbd __clone (libc.so.6) The next time it crashes, I will have debug symbols in dring. I can also recompile alsa-lib with debug symbols, what is the best way to do that? Looking around, it seems other projects have run into the same issue: https://aur.archlinux.org/packages/ultrastardx-git/?comments=all#comment-43… https://aur.archlinux.org/packages/zoom/#comment-544696 http://ubuntuforums.org/showthread.php?t=2248373 https://github.com/js-platform/node-webrtc/issues/110 https://fedorahosted.org/fldigi/ticket/70 The output of the alsa-info.sh script on my system is at [3]. What else can I provide to debug this issue further? Thanks, Baptiste [1] https://ring.cx [2] https://tuleap.ring.cx/plugins/tracker/?aid=502 [3] http://www.alsa-project.org/db/?f=0dd2ba1021b3d535f30f07c55dc18e2ef60db26d

2 9

[alsa-devel] [PATCH 1/2] ASoC: rt5645: patch reg-0x8a
by Bard Liao 01 Jul '16

01 Jul '16

reg-8a assign the tracking source for each ASRC tracker. The default value is 0x0000 which means all ASRC trackers will track LRCK1. But in most cases, we wish each ASRC tracker track the corresponding LRCK. i.e. ASRC1 tracks LRCK1, ASRC2 tracks LRCK2 and so on. So, we rewrite reg-8a as 0x0120. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 1f457d3..c21e41c 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -64,6 +64,7 @@ static const struct reg_sequence init_list[] = { {RT5645_PR_BASE + 0x21, 0x4040}, {RT5645_PR_BASE + 0x23, 0x0004}, {RT5645_PR_BASE + 0x00, 0x0a2a}, + {RT5645_ASRC_4, 0x0120}, }; static const struct reg_sequence rt5650_init_list[] = { @@ -159,7 +160,7 @@ static const struct reg_default rt5645_reg[] = { { 0x83, 0x0000 }, { 0x84, 0x0000 }, { 0x85, 0x0000 }, - { 0x8a, 0x0000 }, + { 0x8a, 0x0120 }, { 0x8e, 0x0004 }, { 0x8f, 0x1100 }, { 0x90, 0x0646 }, @@ -316,7 +317,7 @@ static const struct reg_default rt5650_reg[] = { { 0x83, 0x0000 }, { 0x84, 0x0000 }, { 0x85, 0x0000 }, - { 0x8a, 0x0000 }, + { 0x8a, 0x0120 }, { 0x8e, 0x0004 }, { 0x8f, 0x1100 }, { 0x90, 0x0646 }, -- 1.8.1.1.439.g50a6b54

2 2

[alsa-devel] [asoc:topic/sunxi 2/2] sound/soc/sunxi/sun4i-i2s.c:624:2-3: Unneeded semicolon
by kbuild test robot 01 Jul '16

01 Jul '16

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/sunxi head: fa7c0d13cb26216f6dec5ef19e028e68b300530d commit: fa7c0d13cb26216f6dec5ef19e028e68b300530d [2/2] ASoC: sunxi: Add Allwinner A10 Digital Audio driver coccinelle warnings: (new ones prefixed by >>) >> sound/soc/sunxi/sun4i-i2s.c:624:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 3

[alsa-devel] [PATCH 1/2] ASoC: cs35l33: Fix testing return value of devm_gpiod_get_optional
by Axel Lin 01 Jul '16

01 Jul '16

devm_gpiod_get_optional() returns NULL when the gpio is not assigned. So the if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) test is always false. Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/cs35l33.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 622a111..aa5c0c5 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -1176,11 +1176,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client, /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset-gpios", GPIOD_OUT_HIGH); - - if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) { - dev_warn(&i2c_client->dev, - "%s WARNING: No reset gpio assigned\n", __func__); - } else if (IS_ERR(cs35l33->reset_gpio)) { + if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); return PTR_ERR(cs35l33->reset_gpio); -- 2.5.0

3 5

[alsa-devel] [PATCH 0/3] ASoC: Reduce audio related kernel spew.
by vedang.patel＠intel.com 01 Jul '16

01 Jul '16

From: Vedang Patel <vedang.patel(a)intel.com> There have been complaints regarding audio related kernel messages flooding dmesg. This series tries to address those complaints. Also, I have created 3 different patches for this because they touch different drivers. But, I can combine those to reduce the number of patches. Vedang Patel (3): ASoC: hdac_hdmi: Increase loglevel of hex dump printed ASoC: Intel: common: increase the loglevel of debug message. ASoC: Intel: Skylake: Increase loglevel of debug message. sound/soc/codecs/hdac_hdmi.c | 2 ++ sound/soc/intel/common/sst-dsp.c | 2 +- sound/soc/intel/skylake/skl-messages.c | 2 ++ sound/soc/intel/skylake/skl-sst-ipc.c | 7 +++++-- 4 files changed, 10 insertions(+), 3 deletions(-) -- 2.1.2

6 26

[alsa-devel] [PATCH 0/3] ALSA: add dimension information validator
by Takashi Sakamoto 30 Jun '16

30 Jun '16

Hi, This patchset is to add a validator of dimension information for drivers in kernel/userspace. The dimension information was added to ALSA control interface. With the information, members in an element compose multi-dimensional matrix. For example, this matrix can be used for row/column table with values. In this case, dimension level 1 and 2 are utilized to describe the number of rows and columns by element member unit. When dimension information has no contradictions to the number of members in an element, there's no problem. Once it has, it can cause an issue. In worst case, it can cause buffer-overrun in userspace. The aim of this patchset is to prevent this situation. Takashi Sakamoto (3): ALSA: echoaudio: purge contradictions between dimension matrix members and total number of members ALSA: control: add dimension validator for userspace element ALSA: control: add dimension validator for kernel driver sound/core/control.c | 77 ++++++++++++++++++++++++++++++++--------- sound/pci/echoaudio/echoaudio.c | 6 ++-- 2 files changed, 64 insertions(+), 19 deletions(-) -- 2.7.4

2 5