February 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] Revert "ASoC: fsl_ssi: remove explicit register defaults"
by Fabio Estevam 07 Mar '16

07 Mar '16

From: Fabio Estevam <fabio.estevam(a)nxp.com> Commit 5c408fee2546 ("ASoC: fsl_ssi: remove explicit register defaults") causes the driver to fail to probe: fsl-ssi-dai 2028000.ssi: No cache defaults, reading back from HW fsl-ssi-dai 2028000.ssi: Failed to init register map fsl-ssi-dai: probe of 2028000.ssi failed with error -22 , so revert this commit. Cc: Maciej S. Szmigiero <mail(a)maciej.szmigiero.name> Reported-by: Mika Penttilä <mika.penttila(a)nextfour.com> Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- Maciej, As this currently breaks SSI on 4.5-rc we should better revert it for this cycle. We can then add it back to 4.7 when Mark's patch 3245d460a1eb55 ("regmap: cache: Fall back to register by register read for cache defaults") will be available and then the driver will work fine with your patch. sound/soc/fsl/fsl_ssi.c | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ed8de10..40dfd8a 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -112,6 +112,20 @@ struct fsl_ssi_rxtx_reg_val { struct fsl_ssi_reg_val tx; }; +static const struct reg_default fsl_ssi_reg_defaults[] = { + {CCSR_SSI_SCR, 0x00000000}, + {CCSR_SSI_SIER, 0x00003003}, + {CCSR_SSI_STCR, 0x00000200}, + {CCSR_SSI_SRCR, 0x00000200}, + {CCSR_SSI_STCCR, 0x00040000}, + {CCSR_SSI_SRCCR, 0x00040000}, + {CCSR_SSI_SACNT, 0x00000000}, + {CCSR_SSI_STMSK, 0x00000000}, + {CCSR_SSI_SRMSK, 0x00000000}, + {CCSR_SSI_SACCEN, 0x00000000}, + {CCSR_SSI_SACCDIS, 0x00000000}, +}; + static bool fsl_ssi_readable_reg(struct device *dev, unsigned int reg) { switch (reg) { @@ -176,7 +190,8 @@ static const struct regmap_config fsl_ssi_regconfig = { .val_bits = 32, .reg_stride = 4, .val_format_endian = REGMAP_ENDIAN_NATIVE, - .num_reg_defaults_raw = CCSR_SSI_SACCDIS / sizeof(uint32_t) + 1, + .reg_defaults = fsl_ssi_reg_defaults, + .num_reg_defaults = ARRAY_SIZE(fsl_ssi_reg_defaults), .readable_reg = fsl_ssi_readable_reg, .volatile_reg = fsl_ssi_volatile_reg, .precious_reg = fsl_ssi_precious_reg, @@ -186,7 +201,6 @@ static const struct regmap_config fsl_ssi_regconfig = { struct fsl_ssi_soc_data { bool imx; - bool imx21regs; /* imx21-class SSI - no SACC{ST,EN,DIS} regs */ bool offline_config; u32 sisr_write_mask; }; @@ -289,7 +303,6 @@ static struct fsl_ssi_soc_data fsl_ssi_mpc8610 = { static struct fsl_ssi_soc_data fsl_ssi_imx21 = { .imx = true, - .imx21regs = true, .offline_config = true, .sisr_write_mask = 0, }; @@ -573,12 +586,8 @@ static void fsl_ssi_setup_ac97(struct fsl_ssi_private *ssi_private) */ regmap_write(regs, CCSR_SSI_SACNT, CCSR_SSI_SACNT_AC97EN | CCSR_SSI_SACNT_FV); - - /* no SACC{ST,EN,DIS} regs on imx21-class SSI */ - if (!ssi_private->soc->imx21regs) { - regmap_write(regs, CCSR_SSI_SACCDIS, 0xff); - regmap_write(regs, CCSR_SSI_SACCEN, 0x300); - } + regmap_write(regs, CCSR_SSI_SACCDIS, 0xff); + regmap_write(regs, CCSR_SSI_SACCEN, 0x300); /* * Enable SSI, Transmit and Receive. AC97 has to communicate with the @@ -1388,7 +1397,6 @@ static int fsl_ssi_probe(struct platform_device *pdev) struct resource *res; void __iomem *iomem; char name[64]; - struct regmap_config regconfig = fsl_ssi_regconfig; of_id = of_match_device(fsl_ssi_ids, &pdev->dev); if (!of_id || !of_id->data) @@ -1436,25 +1444,15 @@ static int fsl_ssi_probe(struct platform_device *pdev) return PTR_ERR(iomem); ssi_private->ssi_phys = res->start; - if (ssi_private->soc->imx21regs) { - /* - * According to datasheet imx21-class SSI - * don't have SACC{ST,EN,DIS} regs. - */ - regconfig.max_register = CCSR_SSI_SRMSK; - regconfig.num_reg_defaults_raw = - CCSR_SSI_SRMSK / sizeof(uint32_t) + 1; - } - ret = of_property_match_string(np, "clock-names", "ipg"); if (ret < 0) { ssi_private->has_ipg_clk_name = false; ssi_private->regs = devm_regmap_init_mmio(&pdev->dev, iomem, - &regconfig); + &fsl_ssi_regconfig); } else { ssi_private->has_ipg_clk_name = true; ssi_private->regs = devm_regmap_init_mmio_clk(&pdev->dev, - "ipg", iomem, &regconfig); + "ipg", iomem, &fsl_ssi_regconfig); } if (IS_ERR(ssi_private->regs)) { dev_err(&pdev->dev, "Failed to init register map\n"); -- 1.9.1

3 6

[alsa-devel] Trouble about Roland UA-11 UA-33 UA-55 and snd-usb-audio module
by FirebUntU 07 Mar '16

07 Mar '16

Hi guys, I write you about support of snd-usb-audio module and a relatively-new gamma of devices from Roland/Edirol: DUO CAPTURE, TRI CAPTURE and QUAD CAPTURE respectively: UA-11, UA-33, UA-55 These aren't not listed in the Alsa db. I have searched a solution for a week and I haven't found a trick to make UA-11 to work under Alsa 1.25.0 then I downloaded the driver for try to patch it and I found these devices is not listed in the tricks table In despair I have played with the switch button called "EXT * **" in the bottom of the unit of UA-11 and magically the device ID is transformed from * 0582:012b to ** 0582:0137 Image: https://dl.dropbox.com/u/32759898/output.jpg (Rear of the UA-11 unit, from the manual) *Before* (Recognized from udev - Unknown from alsa): http://www.alsa-project.org/db/?f=502ee68cf31882ba9ef23525fd66452c34d329e1 *After* (Recognized from udev - Recognized from alsa): http://www.alsa-project.org/db/?f=b2ae3e4331fb3fe613ba71e7aba1ad2e0e6dcd29 In the tricks table header of ALSA the 0582:0137 stay for PM-1000 in /TODO/ statement. I understand the EXT switch, undiscovered in the manual of the DUO CAPTURE is - as the fact - the Advanced Mode. Now the peripherical running both in playback and recording in 16 and 24 bit and without any mixer options in alsamixer. Can you update future releases with this gamma of devices? Awaiting for your positive response :) Thanks. Best regards, Leonardo

9 16

[alsa-devel] [PATCH 1/2] ASoC: cs35l32: avoid uninitialized variable access
by Arnd Bergmann 06 Mar '16

06 Mar '16

gcc warns about the possibilty of accessing a property read from devicetree in cs35l32_i2c_probe() when it has not been initialized because CONFIG_OF is disabled: sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe': sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] The code is actually correct because it checks the dev->of_node variable first and we know this is NULL here, but by adding a check for IS_ENABLED(CONFIG_OF), we can let the compiler know as well, and also generate smaller object code. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/codecs/cs35l32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 44c30fe3e315..52ffaa8eb02b 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -372,7 +372,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, dev_err(&i2c_client->dev, "could not allocate pdata\n"); return -ENOMEM; } - if (i2c_client->dev.of_node) { + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) { ret = cs35l32_handle_of_data(i2c_client, &cs35l32->pdata); if (ret != 0) -- 2.7.0

5 7

[alsa-devel] [RFC v2 0/6] ASoC: Add mediatek HDMI codec support
by Philipp Zabel 05 Mar '16

05 Mar '16

Hi, this time we add an interface for Jyri's generic hdmi-codec driver [1] to the mediatek hdmi bridge driver. In place of a separate machine driver, the existing mt8173-rt5650-rt5676 driver is extended to link to the hdmi-codec instance provided by the hdmi bridge driver. The alsa jack support, previously implemented by the custom mediatek hdmi codec and machine drivers, is bolted on top of hdmi-codec using Russell's HDMI notifier prototype. It's all still a bit rough, but I could use some feedback at this point. Have we achieved consensus to go forward with the hdmi-codec approach? Is it ok to use an alsa jack for HDMI HPD status reporting? The mediatek drm patches apply on top of https://patchwork.kernel.org/patch/7949021/ ("drm/mediatek: Add HDMI support") the asoc patches depend on these two patches: https://patchwork.kernel.org/patch/7215121/ ("ALSA: pcm: add IEC958 channel status helper for hw_params") [1] https://patchwork.kernel.org/patch/7215271/ ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders") best regards Philipp Koro Chen (1): ASoC: mediatek: Add HDMI dai-links in the machine driver Philipp Zabel (5): drm/mediatek: hdmi: Add audio interface to the hdmi-codec driver ASoC: mediatek: address dai link array entries by enum video: rmk's HDMI notification prototype drm/mediatek: hdmi: issue notifications ASoC: hdmi-codec: Use HDMI notifications to add jack support .../bindings/sound/mt8173-rt5650-rt5676.txt | 5 +- drivers/gpu/drm/mediatek/Kconfig | 1 + drivers/gpu/drm/mediatek/mtk_cec.c | 5 + drivers/gpu/drm/mediatek/mtk_drm_hdmi_drv.c | 192 +++++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_hdmi.c | 26 +++ drivers/gpu/drm/mediatek/mtk_hdmi.h | 4 + drivers/video/Makefile | 2 +- drivers/video/hdmi-not.c | 61 +++++++ include/linux/hdmi-not.h | 39 +++++ include/sound/hdmi-codec.h | 6 + sound/soc/codecs/hdmi-codec.c | 72 +++++++- sound/soc/mediatek/mt8173-rt5650-rt5676.c | 66 ++++++- 12 files changed, 470 insertions(+), 9 deletions(-) create mode 100644 drivers/video/hdmi-not.c create mode 100644 include/linux/hdmi-not.h -- 2.6.2

5 18

[alsa-devel] [PATCH v2 0/2] ASoC: ads117x: Add device tree support for TI ADS117x
by Florian Vaussard 05 Mar '16

05 Mar '16

Hello, This series adds device tree support for Texas Instruments ADS117x ADC chip. The first patch adds the binding documentation, while the second patch adds the compatible string into the driver. No further properties are necessary. Best regards, Florian --- Since v1: - Updated topic for the documentation patch - Removed wildcard in compatible string --- Florian Vaussard (2): ASoC: ads117x: Add bindings documentation for TI ADS117x ADC ASoC: ads117x: Add device tree compatible string Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++ sound/soc/codecs/ads117x.c | 12 ++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt -- 2.1.0

3 7

[alsa-devel] [PATCH] ASoC: dapm: Remove unneeded variable ret returning 0
by Rajan Vaja 05 Mar '16

05 Mar '16

This patch fixes coccicheck report: Unneeded variable: "ret". Return "0" on line 2817 Remove unneccesary variable ret created to return zero. Signed-off-by: Rajan Vaja <rajan.vaja(a)gmail.com> --- sound/soc/soc-dapm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 5a2812f..8dc395f 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2805,7 +2805,7 @@ EXPORT_SYMBOL_GPL(snd_soc_dapm_add_routes); int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm, const struct snd_soc_dapm_route *route, int num) { - int i, ret = 0; + int i; mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_INIT); for (i = 0; i < num; i++) { @@ -2814,7 +2814,7 @@ int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm, } mutex_unlock(&dapm->card->dapm_mutex); - return ret; + return 0; } EXPORT_SYMBOL_GPL(snd_soc_dapm_del_routes); -- 1.7.9.5

2 1

[alsa-devel] [PATCH 0/6] ASoC: rsnd: add CTU support
by Kuninori Morimoto 05 Mar '16

05 Mar '16

Hi Mark These patches adds CTU (= Channel Transfer Unit) support to Renesas R-Car sound driver. It can exchange channel order ex) channel {0,1,2,3} -> channel {3,2,1,0} And it can add/reduce each channels sound ex) (input 0th ch x 0.5) + (input 2nd ch x 0.5) = output 1st ch You need to check R-Car datasheet for each detail settings, or check 6) patch Kuninori Morimoto (6): 1) ASoC: rsnd: don't call update callback if it was NULL 2) ASoC: rsrc-card: add convert channels support 3) ASoC: rsnd: tidyup rsnd_ssiu_init_gen2() 4) ASoC: rsnd: add CTU basic support 5) ASoC: rsnd: add rsnd_runtime_channel_xxx() 6) ASoC: rsnd: add CTU support Documentation/devicetree/bindings/sound/renesas,rsrc-card.txt | 1 + sound/soc/sh/rcar/core.c | 71 ++++++++++++++---------- sound/soc/sh/rcar/ctu.c | 287 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- sound/soc/sh/rcar/dvc.c | 2 +- sound/soc/sh/rcar/mix.c | 2 +- sound/soc/sh/rcar/rsnd.h | 9 +++- sound/soc/sh/rcar/rsrc-card.c | 22 +++++--- sound/soc/sh/rcar/src.c | 2 +- sound/soc/sh/rcar/ssi.c | 15 +++--- sound/soc/sh/rcar/ssiu.c | 11 ++-- 10 files changed, 330 insertions(+), 92 deletions(-) Best regards --- Kuninori Morimoto

3 14

[alsa-devel] [PATCH 0/4] Fix headphone detection on Acer Chromebook 13
by Jonathan Tinkham 04 Mar '16

04 Mar '16

Headphone output works, but headphone detection does not. The problem is improper inversion of the jack gpio, and improper naming of the DAPM switch. With these changes, headphone insertion and removal is picked up by userspace, and the switch properly toggled. Jonathan Tinkham (4): soc/sound: tegra_max98090: do not invert headphone jack sound/soc: tegra_max98090: rename headphone jack DAPM sound/soc: tegra_max98090: document headphone jack rename soc/sound: tegra_max98090: update dts affected by rename .../devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt | 6 +++--- arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++-- arch/arm/boot/dts/tegra124-venice2.dts | 4 ++-- sound/soc/tegra/tegra_max98090.c | 10 +++++----- 4 files changed, 12 insertions(+), 12 deletions(-) -- 2.7.0

4 37

[alsa-devel] writing an alsa driver
by Michele Curti 04 Mar '16

04 Mar '16

Hi all, I'm going to *try* to "write" a driver for the sound card on my new laptop, an asus x205ta. To be fair I have almost no experience but I'm hoping that all the code is already present and it only needs some adaptations. The cpu is a intel bay trail z3735f, the sound card is a realtek rt5648 that has the same product Id of the rt5645 (0x6308). I see in kernel sources: - the codec driver sound/soc/codecs/rt5645.c - a baytrail board that uses the rt5640 sound/soc/intel/boards/byt-rt5640.c - a braswell board that uses the rt5645 sound/soc/intel/boards/cht_bsw_rt5645.c What do you think? Is it feasible, given a good amount of free-time? :p Thanks, Michele

10 46

[alsa-devel] Creative ca0132 on Gigabyte Z170X Gaming 7 motherboard: no sound
by Scott Doty 04 Mar '16

04 Mar '16

Hello, Didn't see a response on alsa-user, so thought I'd better roll up my sleeves and get to work. :) The ca0132 codec seems to do everything on my Gigabyte Z170X Gaming 7 motherboard but make sound. I can see the mixer settings, change them, even see the DSP settings -- but no sound out, either with HP or SPDIF. http://www.alsa-project.org/db/?f=6373811de293125e4e8c345c0c2d4a736c1fc2b8 I do see this in the startup messages: [ 9.314893] snd_hda_intel 0000:01:00.1: Handle vga_switcheroo audio client [ 9.321116] snd_hda_intel 0000:00:1f.3: failed to add i915 component master (-19) I've tried all the fixes I could find reference to, as well as using iecset, but no joy. I also tried editing the driver to disable the "vga_switcheroo" flag, but that didn't work either. (Which is too bad, I thought that would be a quick fix that I could report. :/ ) If someone could point me in the right direction, I think I can investigate this and get it working. Any assistance greatly appreciated. Thanks, -Scott

2 2