November 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [MINUTES] Linux Plumbers Audio Mini Conference - Santa Fe 2016
by Liam Girdwood 16 Nov '16

16 Nov '16

Minutes below. Comments, corrections and omissions welcomed. We are missing some links to some of the slides presented. Please reply with a link if you have one. Audio Mini Conference Minutes - Santa Fe 2016 ============================================= Present: Mark, Rakesh, Liam, Vinod, Mengdong, Pierre, Patrick, Takashi S, Javilars, Takashi I, Eric, Dylan, Mauro, Shuah, Charles, Matthew, Lars, Sagar and others. Android USB Audio - Eric ======================== USB audio is becoming more important as analog jack can be removed. USB stack is difficult to optimise for low power/latency audio (too many wake ups with USB 1ms tick). Aim to add no_irq (no IRQ for each period) and mmap support in USB 3.0 stack to improve power and latency. USB playback and capture with synchronised start API is missing from stack/ALSA. Some patches were posted for synchronised endpoint but never made it to the list, Pierre is going to resend. USB currently defines simple audio endpoints. Support is needed to define more complex USB audio endpoints rather than just "playback" and "capture". Sub 10ms latency (round trip ?) is difficult to achieve on USB due to stack and drivers. Mmap may help reduce latency by removing buffer copies. Inter Device Dependencies ========================= Kernel Summit joined for this discussion. There is complexity between devices, more than just a parent/child relationship for some devices making it difficult to order probing and PM ops. Rafael, has created patch set to solve dependences for PM ops in Gregs tree, the patches could also be used for probing. The patches add an API to allow device relationships to be established as a graph. This API supports non parent/child relationships to and allows PM ops to run in a deterministic sequence. Relationship dependency discovery needs to come from DT/ACPI and will need standardised bindings. Mark described the current audio workarounds where the machine driver specifies relationships and deferred probe is used to manage the probing sequence. Some people do not like the high number deferred probe messages in dmesg. Relation graphs must be ordered so that cycles to do not exist. Next steps are to use Rafaels patches for probe ordering. AV Sync - Eric =============== A few frame counters are 32 bit (compressed API) and should be 64 bit. Vinod will update compressed API to 64 bit. Timers should also consider boot time and suspend/resume time as it's currently difficult to keep AV syn over suspend/resume cycles. AV sync on TV's hacky atm, we need AV sync API in ALSA. Takashi noted this was long time problem that needs solution. Some options for AV sync were pseudo transport streams (like existing mpeg format) but these were difficult for mmap(). Other devices had used runtime PLL updating with patches sent in the past ? Compressed API could be used to send transport stream for AV sync. HDMI/DP glue to GFX - Vinod =========================== Currently several interlaces exist to pass DP/HDMI events and information between audio and GFX stacks/drivers. ARM devices using pdata interface, i915 has another solution, BYT uses another interface. Needs to be consistent for user space ELD notification, jack detection/mapping. Currently HDA drivers have hack to assist userspace (PCM5). There are also difficulties mapping PCMs, channels and jacks to multiple HDMI/DP devices. Tikashi and Vinod to investigate best solutions. DP-MST - Vinod =============== Jack notifications more difficult with MST (extra complexity). How do we map multiple jacks from multiple monitors, disable unused pins when not rendering ? The 5.1 use case for gaming has to split channels to multiple monitors. Decision is that new devices would export topology to userpace so that userspace know the jack, channel mappings. Soundwire Support - Rakesh and Pierre ===================================== Soundwire new hardware interface for audio devices. Needs new subsystem support for soundwire master and slave devices. Hardik has posted initial RFC to the list for review. Rakesh presented slides . Link to the slides ? Some people had reviewed the RFC. Some changes to strct device/driver usage required to make it more like other subsystems upstream. There is also need to deal with devices that can power off after or before enumeration. Some confusion over the terminology used too, compared to other bus systems like I2C. Master should be device and not driver. Top level feedback is that it does not look like bus code. There is also a need to consider objects in DT/ACPI. AR Vinod, to look at STIO. Topology and UCM file deployment - Vinod, Mengdong, Liam ======================================================== Difficult to release and deploy topology/ucm updates with alsa-lib cadence. Distros to be contacted for best deployment where cadence can be faster than alsa-lib. Liam and Vinod to contact distro package maintainers. UCM - Liam, Mengdong ==================== Which driver card name string to change, there are 3 - long, short and driver. CRAS uses the string in the []. Not sure about PA. Liam to create patch that includes machine name in card name string. Mengdong has added #include and #define like support to topology. Mengdong will port this to UCM too so that a library of codecs can be built up and included by the machine ucm files. e.g. Asus T100 UCM would include rt5640 codec and baytrail DSP UCM configs. Tracepoint for audio - Lars, Takashi S ====================================== Lars and Takashi S have similar patchsets. Easy to make tooling for parsing traceout. This could replace printk and snd_printk, but builds bigger binary. Option to disable can be added to reduce size. Uses ftrace output and timestamp. Used in the PCM operations. Patches are still WiP and will be posted as RFC when ready. Dropping Dice Driver - Takashi S ================================ Dice hardware has serious problems making it unusable. Takashi S to discuss with Clemens regarding any potential work around for HW issue. If no work around is found then it could be marked as broken or moved to staging ? Sound Open Firmware - Liam ========================== Liam introduced SOF and took QA. Liam is also working on an ELF executable firmware image that can run on the developers host PC. http://alsa-project.org/main/index.php/Firmware Paravirtualisation of Audio Drivers - Rakesh ============================================ Safety critical systems have requirements to play safety critcal sounds (like alarms, warnings) and regular non safety critical sound like media. Rakesh proposed a Xen hypervisor method to guarantee the safety critical audio would always take precedence over the non safety critical audio. Xen would run a privileged OS (for safety critical) and unprivileged OS (for non safety critical audio). A para virtualised audio driver would allow the Unprivileged OS to play audio on the privileged OS. Lars suggested Libvirt and KVM may make this task far easier and less restricted than using Xen. Rakesh to investigate further. Userspace driver for Firewire - Takashi S ========================================= Need to represent mixers for some USB and FW devices in userspace. Why ?. Possibility of using topology for userspace. Nobody keen on exposing kernel APIs as userspavce ABIs. Possibility of looking at libvirt interfaces for userspace drivers many similarities. Kernel component, already use FW sound card. Mixer API not suitable, many bus so use control API. ALSA Stream Configuration Domains - Lars ======================================== ALSA has powerful but complex system to configure and constrain stream configurations at runtime but it does not scale well on modern ASoC based sound devices with multiple components and DAIs. Lars presented a solution that can break complex sound cards down to simple domains where configuration can be set by userspace to exactly match each use case. Userspace would also be able to read the configuration in each domain. New APIs calls would be needed in alsa-lib to achieve this. Lars also requested that ASoC become a first class citizen with ALSA since most new sound cards are ASoC based. Proposal was accepted.

6 7

[alsa-devel] Alsa io plugin crash question
by Hermes Zhang 16 Nov '16

16 Nov '16

Hi all, I am try to write a plugin in alsa io plugin mode static snd_pcm_sframes_t my_read (snd_pcm_ioplug_t * io, const snd_pcm_channel_area_t * areas, snd_pcm_uframes_t offset, snd_pcm_uframes_t size) { } In above function, I will copy the audio data to areas with calculate the offset like this: memcpy((char *) areas->addr + (areas->first + areas->step * offset) / 8, data, size); But after serveral calls, the application crash, and I print the "offset" value, it seem always increase, when reach one number (e.g. 66560) it crash. So my question is: is the "offset" value always increase is expected? Or does it should like a ring buffer, so it should start from begin again? I see there is hw_pointer and app_pointer, but they are both read_only, right? How could we adjust the read pointer? Thanks. BTW, I test the plugin in this way: arecord -D my_plug -c 1 -f S16_LE raw Best Regards, Hermes

1 0

[alsa-devel] [RFC PATCH 0/3] Add support for component devices
by mengdong.lin＠linux.intel.com 16 Nov '16

16 Nov '16

From: Mengdong Lin <mengdong.lin(a)linux.intel.com> Sound cards are defined by machines. And off-soc codecs and DSPs embedded in DSP can be taken as the components and resued by different machines/ sound cards. This series allows codec and SOC vendors to install UCM configuration files for a specific codec or DSP, and sound card verb files can just include these conf files of components, and trigger enable/ disable sequence defined by the component devices. Component devices will not be exposed to applications for backward compatibility. So audio servers like PulseAudio and CRAS still only see the machine devices. Mengdong Lin (3): ucm: Skip component directories when scanning sound card configuration files ucm: Parse sequence of component devices ucm: Execute sequence of component devices src/ucm/main.c | 98 ++++++++++++++++++++++++++++++++++++----- src/ucm/parser.c | 122 +++++++++++++++++++++++++++++++++++++++++++++++++++- src/ucm/ucm_local.h | 11 +++++ src/ucm/utils.c | 1 + 4 files changed, 220 insertions(+), 12 deletions(-) -- 2.7.4

3 10

[alsa-devel] [PATCH v9 0/3] ASoC: MT8173 HDMI jack detection
by Philipp Zabel 16 Nov '16

16 Nov '16

Hi, now that a new HDMI state notifier RFC has been posted [1], I've updated this series to use it instead of the previous prototype. I've also sent the drm/mediatek part of this series separately [2], which is needed to actually generate the events the hdmi-codec driver listens for. Changes since v8: - Dropped the HDMI notification prototype patch - Rebased onto the "video: add HDMI state notifier support" patch by Hans Verkuil, based on Russell King's earlier version. - Dropped the drm/mediatek patch regards Philipp [1] https://patchwork.linuxtv.org/patch/38109/ [2] https://patchwork.kernel.org/patch/9430337/ Philipp Zabel (3): ASoC: hdmi-codec: use HDMI state notifier to add jack support ASoC: mediatek: Add jack detection support to mt8173-rt5650-rt5676 machine driver ASoC: mediatek: Add jack detection support to the mt8173-rt5650 machine driver include/sound/hdmi-codec.h | 7 ++ sound/soc/codecs/Kconfig | 1 + sound/soc/codecs/hdmi-codec.c | 107 +++++++++++++++++++++-- sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c | 42 +++++++++ sound/soc/mediatek/mt8173/mt8173-rt5650.c | 42 +++++++++ 5 files changed, 191 insertions(+), 8 deletions(-) -- 2.10.2

2 5

[alsa-devel] [PATCH v3 00/17] ASoC: add OF graph base simple-card
by Kuninori Morimoto 16 Nov '16

16 Nov '16

Hi Rob, Mark These are v3 of OF graph base simple-card patch-set. 1) - 5) : soc-core prepare for OF graph base simple-card 6) - 10) : OF graph new feature 11) - 17) : OF graph base simple-card (depends on above 2 patch-set) >> Mark I could success to apply 1) - 5) on your topic/core and topic/simple, both. Please let me know if you can't do it. *** BLURB HERE *** Kuninori Morimoto (17): 1) ASoC: soc-core: adjust for graph on snd_soc_of_parse_card_name 2) ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_simple_widgets 3) ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_routing 4) ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_prefix 5) ASoC: soc-core: snd_soc_get_dai_name() become non static 6) of_graph: add of_graph_get_remote_endpoint() 7) of_graph: add of_graph_get_port_parent() 8) of_graph: add of_graph_get_top_port() 9) of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() 10) of_graph: add of_graph_get_port/endpoint_count() 11) ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai() 12) ASoC: simple-card-utils: add asoc_simple_card_try_to_probe_graph_card() 13) ASoC: simple-card-utils: adjust for graph on asoc_simple_card_parse_card_name 14) ASoC: add simple-graph-card document 15) ASoC: add simple-graph-card support 16) ASoC: add simple-graph-scu-card document 17) ASoC: add simple-graph-scu-card support .../bindings/sound/simple-graph-card.txt | 65 +++ .../bindings/sound/simple-graph-scu-card.txt | 65 +++ drivers/of/base.c | 160 ++++++- include/linux/of_graph.h | 54 +++ include/sound/simple_card_utils.h | 19 + include/sound/soc.h | 32 +- sound/soc/generic/Kconfig | 15 + sound/soc/generic/Makefile | 4 + sound/soc/generic/simple-card-utils.c | 98 ++++- sound/soc/generic/simple-card.c | 2 +- sound/soc/generic/simple-graph-card.c | 462 +++++++++++++++++++++ sound/soc/generic/simple-graph-scu-card.c | 417 +++++++++++++++++++ sound/soc/generic/simple-scu-card.c | 2 +- sound/soc/soc-core.c | 41 +- 14 files changed, 1401 insertions(+), 35 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/simple-graph-card.txt create mode 100644 Documentation/devicetree/bindings/sound/simple-graph-scu-card.txt create mode 100644 sound/soc/generic/simple-graph-card.c create mode 100644 sound/soc/generic/simple-graph-scu-card.c -- 1.9.1

2 19

[alsa-devel] [PATCH] ASoC: wm8580: tidyup Kconfig tristate title
by Kuninori Morimoto 16 Nov '16

16 Nov '16

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> It is WM8580, not WM8523 Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c67667b..f1c48d2 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -914,7 +914,7 @@ config SND_SOC_WM8523 depends on I2C config SND_SOC_WM8580 - tristate "Wolfson Microelectronics WM8523 CODEC" + tristate "Wolfson Microelectronics WM8580 CODEC" depends on I2C config SND_SOC_WM8711 -- 1.9.1

3 3

[alsa-devel] [PATCH] ASoC: rl6231: add 19.2M to 4.096M pll preset table
by Bard Liao 15 Nov '16

15 Nov '16

Add a pll mapping table for 19.2M in and 4.096M out. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rl6231.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rl6231.c b/sound/soc/codecs/rl6231.c index 1dc68ab..7b447d0 100644 --- a/sound/soc/codecs/rl6231.c +++ b/sound/soc/codecs/rl6231.c @@ -102,6 +102,7 @@ struct pll_calc_map { }; static const struct pll_calc_map pll_preset_table[] = { + {19200000, 4096000, 23, 14, 1, false}, {19200000, 24576000, 3, 30, 3, false}, }; -- 1.8.1.1.439.g50a6b54

2 1

[alsa-devel] [PATCH 0/2] ASoC: omap-twl4030: remove legacy code
by Nicolae Rosia 15 Nov '16

15 Nov '16

This patch series removes the omap-twl4030 platform data since all users are now device tree based. These patches are based on Tony's omap-for-v4.10/legacy branch [0] and also on [1]. [0] https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=o… [1] https://patchwork.kernel.org/patch/9424067/ Nicolae Rosia (2): ASoC: omap-twl4030: rework probing for device tree only mfd: twl4030-audio: make module DT only drivers/mfd/twl4030-audio.c | 46 ++-------- include/linux/i2c/twl.h | 23 ----- include/linux/platform_data/omap-twl4030.h | 58 ------------- sound/soc/codecs/twl4030.c | 8 ++ sound/soc/omap/omap-twl4030.c | 133 ++++++++++------------------- 5 files changed, 61 insertions(+), 207 deletions(-) delete mode 100644 include/linux/platform_data/omap-twl4030.h -- 2.7.4

4 6

[alsa-devel] [asoc:topic/rt5616 2/2] sound/soc/codecs/rt5665.c:4590:3-9: preceding lock on line 4553
by Julia Lawall 15 Nov '16

15 Nov '16

It looks from the code like a mutex_unlock may be needed on line 4590. There is a warning about the same issue with respect to like 4609, although that is not shown. julia ---------- Forwarded message ---------- Date: Tue, 15 Nov 2016 08:39:41 +0800 From: kbuild test robot <fengguang.wu(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: [asoc:topic/rt5616 2/2] sound/soc/codecs/rt5665.c:4590:3-9: preceding lock on line 4553 CC: kbuild-all(a)01.org CC: alsa-devel(a)alsa-project.org TO: Bard Liao <bardliao(a)realtek.com> CC: Mark Brown <broonie(a)kernel.org> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rt5616 head: 33ada14a26c8f174dac8765f4236ca66c64ae5be commit: 33ada14a26c8f174dac8765f4236ca66c64ae5be [2/2] ASoC: add rt5665 codec driver :::::: branch date: 13 hours ago :::::: commit date: 13 hours ago >> sound/soc/codecs/rt5665.c:4590:3-9: preceding lock on line 4553 >> sound/soc/codecs/rt5665.c:4590:3-9: preceding lock on line 4553 sound/soc/codecs/rt5665.c:4609:3-9: preceding lock on line 4553 git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git git remote update asoc git checkout 33ada14a26c8f174dac8765f4236ca66c64ae5be vim +4590 sound/soc/codecs/rt5665.c 33ada14a Bard Liao 2016-11-14 4547 } 33ada14a Bard Liao 2016-11-14 4548 33ada14a Bard Liao 2016-11-14 4549 static void rt5665_calibrate(struct rt5665_priv *rt5665) 33ada14a Bard Liao 2016-11-14 4550 { 33ada14a Bard Liao 2016-11-14 4551 int value, count; 33ada14a Bard Liao 2016-11-14 4552 33ada14a Bard Liao 2016-11-14 @4553 mutex_lock(&rt5665->calibrate_mutex); 33ada14a Bard Liao 2016-11-14 4554 33ada14a Bard Liao 2016-11-14 4555 regcache_cache_bypass(rt5665->regmap, true); 33ada14a Bard Liao 2016-11-14 4556 33ada14a Bard Liao 2016-11-14 4557 regmap_write(rt5665->regmap, RT5665_RESET, 0); 33ada14a Bard Liao 2016-11-14 4558 regmap_write(rt5665->regmap, RT5665_BIAS_CUR_CTRL_8, 0xa602); 33ada14a Bard Liao 2016-11-14 4559 regmap_write(rt5665->regmap, RT5665_HP_CHARGE_PUMP_1, 0x0c26); 33ada14a Bard Liao 2016-11-14 4560 regmap_write(rt5665->regmap, RT5665_MONOMIX_IN_GAIN, 0x021f); 33ada14a Bard Liao 2016-11-14 4561 regmap_write(rt5665->regmap, RT5665_MONO_OUT, 0x480a); 33ada14a Bard Liao 2016-11-14 4562 regmap_write(rt5665->regmap, RT5665_PWR_MIXER, 0x083f); 33ada14a Bard Liao 2016-11-14 4563 regmap_write(rt5665->regmap, RT5665_PWR_DIG_1, 0x0180); 33ada14a Bard Liao 2016-11-14 4564 regmap_write(rt5665->regmap, RT5665_EJD_CTRL_1, 0x4040); 33ada14a Bard Liao 2016-11-14 4565 regmap_write(rt5665->regmap, RT5665_HP_LOGIC_CTRL_2, 0x0000); 33ada14a Bard Liao 2016-11-14 4566 regmap_write(rt5665->regmap, RT5665_DIG_MISC, 0x0001); 33ada14a Bard Liao 2016-11-14 4567 regmap_write(rt5665->regmap, RT5665_MICBIAS_2, 0x0380); 33ada14a Bard Liao 2016-11-14 4568 regmap_write(rt5665->regmap, RT5665_GLB_CLK, 0x8000); 33ada14a Bard Liao 2016-11-14 4569 regmap_write(rt5665->regmap, RT5665_ADDA_CLK_1, 0x1000); 33ada14a Bard Liao 2016-11-14 4570 regmap_write(rt5665->regmap, RT5665_CHOP_DAC, 0x3030); 33ada14a Bard Liao 2016-11-14 4571 regmap_write(rt5665->regmap, RT5665_CALIB_ADC_CTRL, 0x3c05); 33ada14a Bard Liao 2016-11-14 4572 regmap_write(rt5665->regmap, RT5665_PWR_ANLG_1, 0xaa3e); 33ada14a Bard Liao 2016-11-14 4573 usleep_range(15000, 20000); 33ada14a Bard Liao 2016-11-14 4574 regmap_write(rt5665->regmap, RT5665_PWR_ANLG_1, 0xfe7e); 33ada14a Bard Liao 2016-11-14 4575 regmap_write(rt5665->regmap, RT5665_HP_CALIB_CTRL_2, 0x0321); 33ada14a Bard Liao 2016-11-14 4576 33ada14a Bard Liao 2016-11-14 4577 regmap_write(rt5665->regmap, RT5665_HP_CALIB_CTRL_1, 0xfc00); 33ada14a Bard Liao 2016-11-14 4578 count = 0; 33ada14a Bard Liao 2016-11-14 4579 while (true) { 33ada14a Bard Liao 2016-11-14 4580 regmap_read(rt5665->regmap, RT5665_HP_CALIB_STA_1, &value); 33ada14a Bard Liao 2016-11-14 4581 if (value & 0x8000) 33ada14a Bard Liao 2016-11-14 4582 usleep_range(10000, 10005); 33ada14a Bard Liao 2016-11-14 4583 else 33ada14a Bard Liao 2016-11-14 4584 break; 33ada14a Bard Liao 2016-11-14 4585 33ada14a Bard Liao 2016-11-14 4586 if (count > 60) { 33ada14a Bard Liao 2016-11-14 4587 pr_err("HP Calibration Failure\n"); 33ada14a Bard Liao 2016-11-14 4588 regmap_write(rt5665->regmap, RT5665_RESET, 0); 33ada14a Bard Liao 2016-11-14 4589 regcache_cache_bypass(rt5665->regmap, false); 33ada14a Bard Liao 2016-11-14 @4590 return; 33ada14a Bard Liao 2016-11-14 4591 } 33ada14a Bard Liao 2016-11-14 4592 33ada14a Bard Liao 2016-11-14 4593 count++; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 0/3] ALSA: emu10k1: EMU1010 dock code cleanup
by Takashi Iwai 15 Nov '16

15 Nov '16

Hi, this is a short series of patches to clean up the EMU1010 dock handling code. The primary goal is to replace kthread usage with work, but it resulted in a couple of more useful cleanups / fixes. Takashi === Takashi Iwai (3): ALSA: emu10k1: Fix emu1010 dock attach check ALSA: emu10k1: Simplify firmware loader code ALSA: emu10k1: Use workqueue instead of kthread for emu1010 fw polling include/sound/emu10k1.h | 3 +- sound/pci/emu10k1/emu10k1.c | 9 ++ sound/pci/emu10k1/emu10k1_main.c | 228 ++++++++++++++++----------------------- 3 files changed, 104 insertions(+), 136 deletions(-) -- 2.10.2

1 3