August 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] EAPD enable for HP ALC221
by Kailang 03 Aug '15

03 Aug '15

Hi Takashi, HP ALC221 platform needs to enable EAPD for speaker output. Attach patch was enable the EAPD for speaker. Thanks. BR, Kailang

2 6

[alsa-devel] [PATCH] ALSA: hda - remove no physical connection pins from pin_quirk table
by Hui Wang 03 Aug '15

03 Aug '15

To cleanup the pin_quirk table: - rewrite the pin_config_match(), comparing all pins on the machine with the corresponding pins in the quirk table. - remove all 0x4xxxxxxx pin configurations from pin_quirk table - after removing the 0x4xxxxxxx pin configurations, some pin tables are exactly same, so removing the redudant pin tables. Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/hda_auto_parser.c | 27 +++- sound/pci/hda/patch_realtek.c | 299 ++++------------------------------------ 2 files changed, 48 insertions(+), 278 deletions(-) diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 03b7399..7f57a14 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -887,11 +887,32 @@ EXPORT_SYMBOL_GPL(snd_hda_apply_fixup); static bool pin_config_match(struct hda_codec *codec, const struct hda_pintbl *pins) { - for (; pins->nid; pins++) { - u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid); - if (pins->val != def_conf) + int i; + + for (i = 0; i < codec->init_pins.used; i++) { + struct hda_pincfg *pin = snd_array_elem(&codec->init_pins, i); + hda_nid_t nid = pin->nid; + u32 cfg = pin->cfg; + const struct hda_pintbl *t_pins; + int found; + + t_pins = pins; + found = 0; + for (; t_pins->nid; t_pins++) { + if (t_pins->nid == nid) { + found = 1; + if (t_pins->val == cfg) + break; + else if ((cfg & 0xf0000000) == 0x40000000 && (t_pins->val & 0xf0000000) == 0x40000000) + break; + else + return false; + } + } + if (!found && (cfg & 0xf0000000) != 0x40000000) return false; } + return true; } diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 18ae17e..d9a8b9f 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5386,399 +5386,192 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {} }; -#define ALC255_STANDARD_PINS \ - {0x18, 0x411111f0}, \ - {0x19, 0x411111f0}, \ - {0x1a, 0x411111f0}, \ - {0x1b, 0x411111f0}, \ - {0x1e, 0x411111f0} - #define ALC256_STANDARD_PINS \ {0x12, 0x90a60140}, \ {0x14, 0x90170110}, \ - {0x19, 0x411111f0}, \ - {0x1a, 0x411111f0}, \ - {0x1b, 0x411111f0}, \ {0x21, 0x02211020} #define ALC282_STANDARD_PINS \ - {0x14, 0x90170110}, \ - {0x18, 0x411111f0}, \ - {0x1a, 0x411111f0}, \ - {0x1b, 0x411111f0}, \ - {0x1e, 0x411111f0} - -#define ALC288_STANDARD_PINS \ - {0x17, 0x411111f0}, \ - {0x18, 0x411111f0}, \ - {0x19, 0x411111f0}, \ - {0x1a, 0x411111f0}, \ - {0x1e, 0x411111f0} + {0x14, 0x90170110} #define ALC290_STANDARD_PINS \ - {0x12, 0x99a30130}, \ - {0x13, 0x40000000}, \ - {0x16, 0x411111f0}, \ - {0x17, 0x411111f0}, \ - {0x19, 0x411111f0}, \ - {0x1b, 0x411111f0}, \ - {0x1e, 0x411111f0} + {0x12, 0x99a30130} #define ALC292_STANDARD_PINS \ {0x14, 0x90170110}, \ - {0x15, 0x0221401f}, \ - {0x1a, 0x411111f0}, \ - {0x1b, 0x411111f0}, \ - {0x1d, 0x40700001} - -#define ALC298_STANDARD_PINS \ - {0x18, 0x411111f0}, \ - {0x19, 0x411111f0}, \ - {0x1a, 0x411111f0}, \ - {0x1e, 0x411111f0}, \ - {0x1f, 0x411111f0} + {0x15, 0x0221401f} static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, - {0x12, 0x40300000}, {0x14, 0x90170110}, - {0x17, 0x411111f0}, - {0x1d, 0x40538029}, {0x21, 0x02211020}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60140}, {0x14, 0x90170110}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211020}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60160}, {0x14, 0x90170120}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - {0x12, 0x40000000}, {0x14, 0x90170130}, - {0x17, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, {0x1b, 0x01014020}, - {0x1d, 0x4054c029}, - {0x1e, 0x411111f0}, {0x21, 0x0221103f}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - {0x12, 0x40000000}, {0x14, 0x90170150}, - {0x17, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, {0x1b, 0x02011020}, - {0x1d, 0x4054c029}, - {0x1e, 0x411111f0}, {0x21, 0x0221105f}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - {0x12, 0x40000000}, {0x14, 0x90170110}, - {0x17, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, {0x1b, 0x01014020}, - {0x1d, 0x4054c029}, - {0x1e, 0x411111f0}, {0x21, 0x0221101f}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, {0x12, 0x90a60160}, {0x14, 0x90170120}, {0x17, 0x90170140}, - {0x18, 0x40000000}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x41163b05}, - {0x1e, 0x411111f0}, {0x21, 0x0321102f}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60160}, {0x14, 0x90170130}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211040}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60160}, {0x14, 0x90170140}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211050}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60170}, {0x14, 0x90170120}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60170}, {0x14, 0x90170130}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211040}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60170}, {0x14, 0x90170140}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211050}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell Inspiron 5548", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60180}, {0x14, 0x90170130}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211040}), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC255_STANDARD_PINS, {0x12, 0x90a60160}, {0x14, 0x90170120}, - {0x17, 0x40000000}, - {0x1d, 0x40700001}, {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC256_STANDARD_PINS, - {0x13, 0x40000000}, - {0x1d, 0x40700001}, - {0x1e, 0x411111f0}), - SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC256_STANDARD_PINS, - {0x13, 0x411111f0}, - {0x1d, 0x40700001}, - {0x1e, 0x411111f0}), - SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC256_STANDARD_PINS, - {0x13, 0x411111f0}, - {0x1d, 0x4077992d}, - {0x1e, 0x411111ff}), + ALC256_STANDARD_PINS), SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4, {0x12, 0x90a60130}, - {0x13, 0x40000000}, {0x14, 0x90170110}, {0x15, 0x0421101f}, - {0x16, 0x411111f0}, - {0x17, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x04a11020}, - {0x1b, 0x411111f0}, - {0x1d, 0x40748605}, - {0x1e, 0x411111f0}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC269_FIXUP_HP_GPIO_MIC1_LED, {0x12, 0x90a60140}, - {0x13, 0x40000000}, {0x14, 0x90170110}, {0x15, 0x0421101f}, - {0x16, 0x411111f0}, - {0x17, 0x411111f0}, {0x18, 0x02811030}, - {0x19, 0x411111f0}, {0x1a, 0x04a1103f}, - {0x1b, 0x02011020}, - {0x1d, 0x40700001}, - {0x1e, 0x411111f0}), + {0x1b, 0x02011020}), SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP 15 Touchsmart", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC282_STANDARD_PINS, {0x12, 0x99a30130}, - {0x17, 0x40000000}, {0x19, 0x03a11020}, - {0x1d, 0x40f41905}, {0x21, 0x0321101f}), SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC282_STANDARD_PINS, {0x12, 0x99a30130}, - {0x17, 0x40020008}, {0x19, 0x03a11020}, - {0x1d, 0x40e00001}, {0x21, 0x03211040}), SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC282_STANDARD_PINS, {0x12, 0x99a30130}, - {0x17, 0x40000000}, {0x19, 0x03a11030}, - {0x1d, 0x40e00001}, {0x21, 0x03211020}), SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC282_STANDARD_PINS, {0x12, 0x99a30130}, - {0x17, 0x40000000}, - {0x19, 0x03a11030}, - {0x1d, 0x40f00001}, - {0x21, 0x03211020}), - SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, - ALC282_STANDARD_PINS, - {0x12, 0x99a30130}, - {0x17, 0x40000000}, {0x19, 0x04a11020}, - {0x1d, 0x40f00001}, {0x21, 0x0421101f}), - SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, - ALC282_STANDARD_PINS, - {0x12, 0x99a30130}, - {0x17, 0x40000000}, - {0x19, 0x03a11030}, - {0x1d, 0x40f00001}, - {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0282, 0x103c, "HP", ALC269_FIXUP_HP_LINE1_MIC1_LED, ALC282_STANDARD_PINS, {0x12, 0x90a60140}, - {0x17, 0x40000000}, {0x19, 0x04a11030}, - {0x1d, 0x40f00001}, {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0283, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC282_STANDARD_PINS, {0x12, 0x90a60130}, - {0x17, 0x40020008}, - {0x19, 0x411111f0}, - {0x1d, 0x40e00001}, {0x21, 0x0321101f}), SND_HDA_PIN_QUIRK(0x10ec0283, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, {0x12, 0x90a60160}, {0x14, 0x90170120}, - {0x17, 0x40000000}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x40700001}, - {0x1e, 0x411111f0}, {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0283, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC282_STANDARD_PINS, {0x12, 0x90a60130}, - {0x17, 0x40020008}, {0x19, 0x03a11020}, - {0x1d, 0x40e00001}, {0x21, 0x0321101f}), SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL_XPS_13_GPIO6, - ALC288_STANDARD_PINS, {0x12, 0x90a60120}, - {0x13, 0x40000000}, {0x14, 0x90170110}, - {0x1d, 0x4076832d}, {0x21, 0x0321101f}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, - {0x14, 0x411111f0}, {0x15, 0x04211040}, {0x18, 0x90170112}, - {0x1a, 0x04a11020}, - {0x1d, 0x4075812d}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, - {0x14, 0x411111f0}, {0x15, 0x04211040}, {0x18, 0x90170110}, - {0x1a, 0x04a11020}, - {0x1d, 0x4075812d}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, - {0x14, 0x411111f0}, {0x15, 0x0421101f}, - {0x18, 0x411111f0}, - {0x1a, 0x04a11020}, - {0x1d, 0x4075812d}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, - {0x14, 0x411111f0}, {0x15, 0x04211020}, - {0x18, 0x411111f0}, - {0x1a, 0x04a11040}, - {0x1d, 0x4076a12d}), + {0x1a, 0x04a11040}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, {0x14, 0x90170110}, {0x15, 0x04211020}, - {0x18, 0x411111f0}, - {0x1a, 0x04a11040}, - {0x1d, 0x4076a12d}), + {0x1a, 0x04a11040}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, {0x14, 0x90170110}, {0x15, 0x04211020}, - {0x18, 0x411111f0}, - {0x1a, 0x04a11020}, - {0x1d, 0x4076a12d}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, {0x14, 0x90170110}, {0x15, 0x0421101f}, - {0x18, 0x411111f0}, - {0x1a, 0x04a11020}, - {0x1d, 0x4075812d}), + {0x1a, 0x04a11020}), SND_HDA_PIN_QUIRK(0x10ec0292, 0x1028, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x12, 0x90a60140}, - {0x13, 0x411111f0}, {0x16, 0x01014020}, - {0x18, 0x411111f0}, - {0x19, 0x01a19030}, - {0x1e, 0x411111f0}), + {0x19, 0x01a19030}), SND_HDA_PIN_QUIRK(0x10ec0292, 0x1028, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x12, 0x90a60140}, - {0x13, 0x411111f0}, {0x16, 0x01014020}, {0x18, 0x02a19031}, - {0x19, 0x01a1903e}, - {0x1e, 0x411111f0}), + {0x19, 0x01a1903e}), SND_HDA_PIN_QUIRK(0x10ec0292, 0x1028, "Dell", ALC269_FIXUP_DELL3_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, - {0x12, 0x90a60140}, - {0x13, 0x411111f0}, - {0x16, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1e, 0x411111f0}), + {0x12, 0x90a60140}), SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, - {0x12, 0x40000000}, {0x13, 0x90a60140}, {0x16, 0x21014020}, - {0x18, 0x411111f0}, - {0x19, 0x21a19030}, - {0x1e, 0x411111f0}), + {0x19, 0x21a19030}), SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, - {0x12, 0x40000000}, - {0x13, 0x90a60140}, - {0x16, 0x411111f0}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1e, 0x411111f0}), - SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC292_STANDARD_PINS, - {0x12, 0x40000000}, - {0x13, 0x90a60140}, - {0x16, 0x21014020}, - {0x18, 0x411111f0}, - {0x19, 0x21a19030}, - {0x1e, 0x411111ff}), + {0x13, 0x90a60140}), SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC298_STANDARD_PINS, {0x12, 0x90a60130}, - {0x13, 0x40000000}, - {0x14, 0x411111f0}, {0x17, 0x90170140}, - {0x1d, 0x4068a36d}, {0x21, 0x03211020}), {} }; @@ -6672,77 +6465,33 @@ static const struct hda_model_fixup alc662_fixup_models[] = { static const struct snd_hda_pin_quirk alc662_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0662, 0x1028, "Dell", ALC662_FIXUP_DELL_MIC_NO_PRESENCE, - {0x12, 0x4004c000}, {0x14, 0x01014010}, - {0x15, 0x411111f0}, - {0x16, 0x411111f0}, {0x18, 0x01a19020}, - {0x19, 0x411111f0}, {0x1a, 0x0181302f}, - {0x1b, 0x0221401f}, - {0x1c, 0x411111f0}, - {0x1d, 0x4054c601}, - {0x1e, 0x411111f0}), + {0x1b, 0x0221401f}), SND_HDA_PIN_QUIRK(0x10ec0668, 0x1028, "Dell", ALC668_FIXUP_AUTO_MUTE, {0x12, 0x99a30130}, {0x14, 0x90170110}, {0x15, 0x0321101f}, - {0x16, 0x03011020}, - {0x18, 0x40000008}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x41000001}, - {0x1e, 0x411111f0}, - {0x1f, 0x411111f0}), + {0x16, 0x03011020}), SND_HDA_PIN_QUIRK(0x10ec0668, 0x1028, "Dell", ALC668_FIXUP_AUTO_MUTE, {0x12, 0x99a30140}, {0x14, 0x90170110}, {0x15, 0x0321101f}, - {0x16, 0x03011020}, - {0x18, 0x40000008}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x41000001}, - {0x1e, 0x411111f0}, - {0x1f, 0x411111f0}), + {0x16, 0x03011020}), SND_HDA_PIN_QUIRK(0x10ec0668, 0x1028, "Dell", ALC668_FIXUP_AUTO_MUTE, {0x12, 0x99a30150}, {0x14, 0x90170110}, {0x15, 0x0321101f}, - {0x16, 0x03011020}, - {0x18, 0x40000008}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x41000001}, - {0x1e, 0x411111f0}, - {0x1f, 0x411111f0}), + {0x16, 0x03011020}), SND_HDA_PIN_QUIRK(0x10ec0668, 0x1028, "Dell", ALC668_FIXUP_AUTO_MUTE, - {0x12, 0x411111f0}, {0x14, 0x90170110}, {0x15, 0x0321101f}, - {0x16, 0x03011020}, - {0x18, 0x40000008}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x41000001}, - {0x1e, 0x411111f0}, - {0x1f, 0x411111f0}), + {0x16, 0x03011020}), SND_HDA_PIN_QUIRK(0x10ec0668, 0x1028, "Dell XPS 15", ALC668_FIXUP_AUTO_MUTE, {0x12, 0x90a60130}, {0x14, 0x90170110}, - {0x15, 0x0321101f}, - {0x16, 0x40000000}, - {0x18, 0x411111f0}, - {0x19, 0x411111f0}, - {0x1a, 0x411111f0}, - {0x1b, 0x411111f0}, - {0x1d, 0x40d6832d}, - {0x1e, 0x411111f0}, - {0x1f, 0x411111f0}), + {0x15, 0x0321101f}), {} }; -- 1.9.1

2 1

Re: [alsa-devel] [PATCH] Fix logical-not-parentheses warning
by Takashi Iwai 03 Aug '15

03 Aug '15

On Sun, 02 Aug 2015 11:08:57 +0200, Tomer Barletz wrote: > > This fixes the following warning, that is seen with gcc 5.1: > warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. > > Signed-off-by: Tomer Barletz <barletz(a)gmail.com> Applied, thanks. Takashi > --- > sound/pci/oxygen/oxygen_mixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c > index 6492bca..4ca1266 100644 > --- a/sound/pci/oxygen/oxygen_mixer.c > +++ b/sound/pci/oxygen/oxygen_mixer.c > @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl, > int changed; > > mutex_lock(&chip->mutex); > - changed = !value->value.integer.value[0] != chip->dac_mute; > + changed = (!value->value.integer.value[0]) != chip->dac_mute; > if (changed) { > chip->dac_mute = !value->value.integer.value[0]; > chip->model.update_dac_mute(chip); > -- > 2.4.3 > >

1 0

[alsa-devel] Beaglebone black : Audio cap & Linux version 4.1.3-ti-r6.2
by Micka 03 Aug '15

03 Aug '15

HI everyone, I'm trying to test the sound output with the driver tlv320aic3104. I'm stuck somewhere and I can't figure it out ! I Put a lot of printk and I don't know where to put other printk. Do you know who call the function soc_pcm_prepare ? 693 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L693> */**694 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L694> * * Called by ALSA when the PCM substream is prepared, can set format, sample*695 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L695> * * rate, etc. This function is non atomic and can be called multiple times,*696 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L696> * * it can refer to the runtime info.*697 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L697> * */*698 <http://lxr.free-electrons.com/source/sound/soc/soc-pcm.c#L698> static int soc_pcm_prepare <http://lxr.free-electrons.com/ident?i=soc_pcm_prepare>(struct snd_pcm_substream <http://lxr.free-electrons.com/ident?i=snd_pcm_substream> *substream) Looks like that it's ALSA, but I can't find where ? I tried to find a line in the kernel calling the function: rtd->ops <http://lxr.free-electrons.com/ident?i=ops>.prepare(.... ) can't find it .... my trace : [ 550.269286] ASoC: tlv320aic3x-hifi <-> 48038000.mcasp info: [ 550.269363] ASoC: rate mask 0x7fe [ 550.269398] ASoC: min ch 2 max ch 2 [ 550.269431] ASoC: min rate 8000 max rate 96000 [ 550.275809] tlv aic3x_hw_params [ 550.275862] snd_soc_read: snd soc component read: ret 0 reg 9 val 64 [ 550.275934] snd_soc_component_write reg 9 val 64 [ 550.275987] snd_soc_component_write reg 101 val 0 [ 550.276030] snd_soc_component_write reg 7 val 10 [ 550.276063] snd_soc_component_write reg 2 val 0 [ 550.289260] snd_soc_component_write reg 11 val 1 [ 550.289339] snd_soc_component_write reg 4 val 32 [ 550.289375] snd_soc_component_write reg 5 val 30 [ 550.289407] snd_soc_component_write reg 6 val 0 [ 550.289952] soc_pcm_prepare [ 550.290003] snd_soc_component_write reg 10 val 0 [ 550.290043] soc_dapm_stream_event 1 [ 550.290107] soc_dapm_stream_event: dapm_power_widgets:start dapm_power_widgets 1 [ 550.290150] trace_snd_soc_dapm_start [ 550.290176] dapm reset [ 550.290226] trace_snd_soc_dapm_widget_power [ 550.290257] trace_snd_soc_dapm_widget_power [ 550.290284] trace_snd_soc_dapm_widget_power [ 550.290311] trace_snd_soc_dapm_widget_power [ 550.290339] trace_snd_soc_dapm_widget_power [ 550.290370] trace_snd_soc_dapm_widget_power [ 550.290395] trace_snd_soc_dapm_widget_power [ 550.290423] trace_snd_soc_dapm_widget_power [ 550.290448] trace_snd_soc_dapm_widget_power [ 550.290477] trace_snd_soc_dapm_widget_power [ 550.290503] trace_snd_soc_dapm_widget_power [ 550.290531] trace_snd_soc_dapm_widget_power [ 550.290557] trace_snd_soc_dapm_widget_power [ 550.290582] trace_snd_soc_dapm_widget_power [ 550.290608] trace_snd_soc_dapm_widget_power [ 550.290634] trace_snd_soc_dapm_widget_power [ 550.290659] trace_snd_soc_dapm_widget_power [ 550.290686] trace_snd_soc_dapm_widget_power [ 550.290712] trace_snd_soc_dapm_widget_power [ 550.290738] trace_snd_soc_dapm_widget_power [ 550.290765] trace_snd_soc_dapm_widget_power [ 550.290791] trace_snd_soc_dapm_widget_power [ 550.290817] trace_snd_soc_dapm_widget_power [ 550.290842] trace_snd_soc_dapm_widget_power [ 550.290879] dap set bias to off [ 550.290910] dapm_pre_sequence_async off [ 550.290937] snd soc dapm set bias level 1 [ 550.290962] trace_snd_soc_bias_level_start 1 [ 550.290988] trace_snd_soc_bias_level_done 1 [ 550.291011] dapm_pre_sequence_async onsnd soc dapm set bias level 2 [ 550.291047] trace_snd_soc_bias_level_start 2 [ 550.291073] trace_snd_soc_bias_level_done 2 [ 550.291318] dapm_pre_sequence_async off [ 550.291354] snd soc dapm set bias level 1 [ 550.291381] trace_snd_soc_bias_level_start 1 [ 550.291405] soc set bias level [ 550.291432] tlv set bias level 1 [ 550.291456] tlv standby [ 550.291480] tlv set power [ 550.300504] snd_soc_read: snd soc component read: ret 0 reg 5 val 30 [ 550.300583] snd_soc_read: snd soc component read: ret 0 reg 6 val 0 [ 550.300631] snd_soc_component_write reg 5 val 30 [ 550.301103] snd_soc_component_write reg 6 val 0 [ 550.301577] trace_snd_soc_bias_level_done 1 [ 550.301611] dapm_pre_sequence_async onsnd soc dapm set bias level 2 [ 550.301650] trace_snd_soc_bias_level_start 2 [ 550.301675] soc set bias level [ 550.301701] tlv set bias level 2 [ 550.301724] tlv prepare [ 550.301757] trace_snd_soc_bias_level_done 2 [ 550.301864] dapm event WILL_PMU [ 550.301897] dapm event WILL_PMU [ 550.301923] dapm event WILL_PMU [ 550.301948] dapm event WILL_PMU [ 550.301972] dapm event WILL_PMU [ 550.301997] dapm event WILL_PMU [ 550.302021] dapm event WILL_PMU [ 550.302045] dapm event WILL_PMU [ 550.302069] dapm event WILL_PMU [ 550.302094] dapm event WILL_PMU [ 550.302119] dapm event WILL_PMU [ 550.302143] dapm event WILL_PMU [ 550.302168] dapm event WILL_PMU [ 550.302192] dapm event WILL_PMU [ 550.302216] dapm event WILL_PMU [ 550.302240] dapm event WILL_PMU [ 550.302265] dapm event WILL_PMU [ 550.302289] dapm event WILL_PMU [ 550.302313] dapm event WILL_PMU [ 550.302337] dapm event WILL_PMU [ 550.302362] dapm event WILL_PMU [ 550.302386] dapm event WILL_PMU [ 550.302410] dapm event WILL_PMU [ 550.302435] dapm event WILL_PMU [ 550.302460] dapm sq run 1 [ 550.302489] dapm sq run 1 [ 550.302523] dapm event PRE_PMU [ 550.302550] dapm event PRE_PMD [ 550.302575] dapm event PRE_PMU [ 550.302599] dapm event PRE_PMD [ 550.302623] dapm event PRE_PMU [ 550.302647] dapm event PRE_PMD [ 550.302671] dapm event PRE_PMU [ 550.302696] dapm event PRE_PMD [ 550.302720] dapm event PRE_PMU [ 550.302744] dapm event PRE_PMD [ 550.302769] dapm event PRE_PMU [ 550.302793] dapm event PRE_PMD [ 550.302817] dapm event POST_PMU [ 550.302842] dapm event POST_PMD [ 550.302867] dapm event POST_PMU [ 550.302891] dapm event POST_PMD [ 550.302915] dapm event POST_PMU [ 550.302939] dapm event POST_PMD [ 550.302964] dapm event POST_PMU [ 550.302988] dapm event POST_PMD [ 550.303012] dapm event POST_PMU [ 550.303036] dapm event POST_PMD [ 550.303060] dapm event POST_PMU [ 550.303084] dapm event POST_PMD [ 550.303110] dapm event PRE_PMU [ 550.303134] dapm event PRE_PMD [ 550.303159] dapm event POST_PMU [ 550.303183] dapm event POST_PMD [ 550.303209] dapm event PRE_PMU [ 550.303234] dapm event PRE_PMD [ 550.303258] dapm event PRE_PMU [ 550.303282] dapm event PRE_PMD [ 550.303306] dapm event PRE_PMU [ 550.303331] dapm event PRE_PMD [ 550.303355] dapm event PRE_PMU [ 550.303379] dapm event PRE_PMD [ 550.303403] dapm event POST_PMU [ 550.303427] dapm event POST_PMD [ 550.303451] dapm event POST_PMU [ 550.303475] dapm event POST_PMD [ 550.303499] dapm event POST_PMU [ 550.303524] dapm event POST_PMD [ 550.303548] dapm event POST_PMU [ 550.303572] dapm event POST_PMD [ 550.303598] dapm event PRE_PMU [ 550.303622] dapm event PRE_PMD [ 550.303647] dapm event PRE_PMU [ 550.303671] dapm event PRE_PMD [ 550.304162] dapm event POST_PMU [ 550.304199] dapm event POST_PMD [ 550.304226] dapm event POST_PMU [ 550.304250] dapm event POST_PMD [ 550.304278] dapm event PRE_PMU [ 550.304303] dapm event PRE_PMD [ 550.304328] dapm event PRE_PMU [ 550.304352] dapm event PRE_PMD [ 550.304377] dapm event PRE_PMU [ 550.304401] dapm event PRE_PMD [ 550.304426] dapm event PRE_PMU [ 550.304450] dapm event PRE_PMD [ 550.304474] dapm event POST_PMU [ 550.304499] dapm event POST_PMD [ 550.304523] dapm event POST_PMU [ 550.304547] dapm event POST_PMD [ 550.304572] dapm event POST_PMU [ 550.304596] dapm event POST_PMD [ 550.304620] dapm event POST_PMU [ 550.304644] dapm event POST_PMD [ 550.304670] dapm event PRE_PMU [ 550.304695] dapm event PRE_PMD [ 550.305156] dapm event POST_PMU [ 550.305191] dapm event POST_PMD [ 550.305219] dapm event PRE_PMU [ 550.305245] dapm event PRE_PMD [ 550.305696] dapm event POST_PMU [ 550.305730] dapm event POST_PMD [ 550.305757] dapm event PRE_PMU [ 550.305782] dapm event PRE_PMD [ 550.306275] dapm event POST_PMU [ 550.306312] dapm event POST_PMD [ 550.306341] dapm event PRE_PMU [ 550.306366] dapm event PRE_PMD [ 550.306849] dapm event POST_PMU [ 550.306885] dapm event POST_PMD [ 550.306914] dapm event PRE_PMU [ 550.306939] dapm event PRE_PMD [ 550.317926] dapm event POST_PMU [ 550.317958] dapm event POST_PMD [ 550.317977] dapm event PRE_PMU [ 550.317991] dapm event PRE_PMD [ 550.318401] dapm event POST_PMU [ 550.318422] dapm event POST_PMD [ 550.318439] dapm event PRE_PMU [ 550.318454] dapm event PRE_PMD [ 550.318467] dapm event POST_PMU [ 550.318480] dapm event POST_PMD [ 550.318496] dapm_power_widgets run all the bias changes in parrallel [ 550.321470] dapm_post_sequence_async prepare 1 [ 550.321498] snd soc dapm set bias level 3 [ 550.321513] trace_snd_soc_bias_level_start 3 [ 550.321527] soc set bias level [ 550.321543] tlv set bias level 3 [ 550.321555] tlv bias on [ 550.321570] trace_snd_soc_bias_level_done 3 [ 550.321649] dapm_power_widgets dapm_power_widgets [ 550.321666] DAPM sequencing finished [ 550.321680] trace_snd_soc_dapm_done [ 550.321695] pcm prepare call snd_soc_dai_digital_mute [ 550.321711] snd_soc_dai_digital_mute 0 0 [ 550.321725] tlv aic3x_mute [ 550.321739] snd_soc_read: snd soc component read: ret 0 reg 43 val 168 [ 550.321772] snd_soc_read: snd soc component read: ret 0 reg 44 val 168 [ 550.321798] snd_soc_component_write reg 43 val 40 [ 550.322224] snd_soc_component_write reg 44 val 40 [ 550.322630] pcm prepare call snd_soc_dai_digital_mute for cpu_dai [ 550.322651] snd_soc_dai_digital_mute 0 0 > >

1 1

[alsa-devel] [PATCH] ALSA: hda - Fix a wrong busy check in alt PCM open
by Takashi Iwai 03 Aug '15

03 Aug '15

Currently, the alt PCM open callback returns -EBUSY when an independent HP is turned off, supposing that it conflicts with the main PCM. However, obviously, this check is wrong when the independent HP itself isn't enabled but the alt PCM was explicitly created via alc_dac_nid by a codec driver. Reported-and-tested-by: Kailang Yang <kailang(a)realtek.com> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index ac0db1679f09..b077bb644434 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -5175,7 +5175,7 @@ static int alt_playback_pcm_open(struct hda_pcm_stream *hinfo, int err = 0; mutex_lock(&spec->pcm_mutex); - if (!spec->indep_hp_enabled) + if (spec->indep_hp && !spec->indep_hp_enabled) err = -EBUSY; else spec->active_streams |= 1 << STREAM_INDEP_HP; -- 2.4.5

2 3

[alsa-devel] [PATCH] ALSA: hda - Add pin quirk for the headset mic jack detection on Dell laptop
by woodrow.shen＠canonical.com 03 Aug '15

03 Aug '15

From: Woodrow Shen <woodrow.shen(a)canonical.com> The new Dell laptop with codec 256 can't detect headset mic when headset was inserted on the machine. From alsa-info, we check init_pin_configs and need to define the new register value for pin 0x1d & 0x1e because the original macro ALC256_STANDARD_PINS can't match pin definition. Also, the macro ALC256_STANDARD_PINS is simplified by removing them. This makes headset mic works on laptop. Codec: Realtek ALC256 Vendor Id: 0x10ec0256 Subsystem Id: 0x102806f2 BugLink: https://bugs.launchpad.net/bugs/1478497 Signed-off-by: Woodrow Shen <woodrow.shen(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d94c0e3..4ae877c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5398,8 +5398,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {0x19, 0x411111f0}, \ {0x1a, 0x411111f0}, \ {0x1b, 0x411111f0}, \ - {0x1d, 0x40700001}, \ - {0x1e, 0x411111f0}, \ {0x21, 0x02211020} #define ALC282_STANDARD_PINS \ @@ -5556,10 +5554,19 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, ALC256_STANDARD_PINS, - {0x13, 0x40000000}), + {0x13, 0x40000000}, + {0x1d, 0x40700001}, + {0x1e, 0x411111f0}), SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, ALC256_STANDARD_PINS, - {0x13, 0x411111f0}), + {0x13, 0x411111f0}, + {0x1d, 0x40700001}, + {0x1e, 0x411111f0}), + SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC256_STANDARD_PINS, + {0x13, 0x411111f0}, + {0x1d, 0x4077992d}, + {0x1e, 0x411111ff}), SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4, {0x12, 0x90a60130}, {0x13, 0x40000000}, -- 2.1.4

3 6

[alsa-devel] [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates
by Maciej S. Szmigiero 02 Aug '15

02 Aug '15

AC'97 bus can support asymmetric playback/capture rates so enable them in this case in fsl_ssi driver. Signed-off-by: Maciej Szmigiero <mail(a)maciej.szmigiero.name> --- sound/soc/fsl/fsl_ssi.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index a83b900..7f4f0b9 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1377,7 +1377,9 @@ static int fsl_ssi_probe(struct platform_device *pdev) /* Are the RX and the TX clocks locked? */ if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { - ssi_private->cpu_dai_drv.symmetric_rates = 1; + if (!fsl_ssi_is_ac97(ssi_private)) + ssi_private->cpu_dai_drv.symmetric_rates = 1; + ssi_private->cpu_dai_drv.symmetric_channels = 1; ssi_private->cpu_dai_drv.symmetric_samplebits = 1; }

2 4

[alsa-devel] [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC
by Maciej S. Szmigiero 02 Aug '15

02 Aug '15

Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. Signed-off-by: Maciej Szmigiero <mail(a)maciej.szmigiero.name> --- sound/soc/fsl/fsl_ssi.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 154bcf6..8e5ff5e 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1460,6 +1460,27 @@ done: _fsl_ssi_set_dai_fmt(&pdev->dev, ssi_private, ssi_private->dai_fmt); + if (fsl_ssi_is_ac97(ssi_private)) { + u32 ssi_idx; + + ret = of_property_read_u32(np, "cell-index", &ssi_idx); + if (ret) { + dev_err(&pdev->dev, "cannot get SSI index property\n"); + goto error_sound_card; + } + + ssi_private->pdev = + platform_device_register_data(NULL, + "ac97-codec", ssi_idx, NULL, 0); + if (IS_ERR(ssi_private->pdev)) { + ret = PTR_ERR(ssi_private->pdev); + dev_err(&pdev->dev, + "failed to register AC97 codec platform: %d\n", + ret); + goto error_sound_card; + } + } + return 0; error_sound_card:

2 3

Re: [alsa-devel] [PATCH] Fix logical-not-parentheses warning
by Joe Perches 02 Aug '15

02 Aug '15

On Sun, 2015-08-02 at 02:08 -0700, Tomer Barletz wrote: > This fixes the following warning, that is seen with gcc 5.1: > warning: logical not is only applied to the left hand side of > comparison [-Wlogical-not-parentheses]. [] > diff --git a/sound/pci/oxygen/oxygen_mixer.c [] > @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl, > int changed; > > mutex_lock(&chip->mutex); > - changed = !value->value.integer.value[0] != chip->dac_mute; > + changed = (!value->value.integer.value[0]) != chip->dac_mute; It seems this is because dac_mute's value is inverted 0 means true, 1 is false. I think it'd be simpler if dac_mute was converted to a standard bool (or perhaps renamed to not_muted) and this test was rewritten. Using !!value->value.integer.value[0] would also be more readable and intelligible.

1 0

Re: [alsa-devel] [PATCH] Fix logical-not-parentheses warning
by Takashi Iwai 02 Aug '15

02 Aug '15

On Sun, 02 Aug 2015 07:43:22 +0200, Tomer Barletz wrote: > > Signed-off-by: Tomer Barletz <barletz(a)gmail.com> This is rather a gcc5 problem that doesn't recognize the expression correctly. Though, this change make things worse, so I'm willing to take it. But please give the warning message itself in changelog to show exactly what is the issue. The subject doesn't enough to understand why this change is needed. thanks, Takashi > --- > sound/pci/oxygen/oxygen_mixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c > index 6492bca..4ca1266 100644 > --- a/sound/pci/oxygen/oxygen_mixer.c > +++ b/sound/pci/oxygen/oxygen_mixer.c > @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl, > int changed; > > mutex_lock(&chip->mutex); > - changed = !value->value.integer.value[0] != chip->dac_mute; > + changed = (!value->value.integer.value[0]) != chip->dac_mute; > if (changed) { > chip->dac_mute = !value->value.integer.value[0]; > chip->model.update_dac_mute(chip); > -- > 2.4.3 > >

1 0