August 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 29/31] sound/oxfw: use kmemdup rather than duplicating its implementation
by Andrzej Hajda 07 Aug '15

07 Aug '15

The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> --- sound/firewire/oxfw/oxfw-stream.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/firewire/oxfw/oxfw-stream.c b/sound/firewire/oxfw/oxfw-stream.c index 873d40f..77ad5b9 100644 --- a/sound/firewire/oxfw/oxfw-stream.c +++ b/sound/firewire/oxfw/oxfw-stream.c @@ -512,12 +512,11 @@ assume_stream_formats(struct snd_oxfw *oxfw, enum avc_general_plug_dir dir, if (err < 0) goto end; - formats[eid] = kmalloc(*len, GFP_KERNEL); + formats[eid] = kmemdup(buf, *len, GFP_KERNEL); if (formats[eid] == NULL) { err = -ENOMEM; goto end; } - memcpy(formats[eid], buf, *len); /* apply the format for each available sampling rate */ for (i = 0; i < ARRAY_SIZE(oxfw_rate_table); i++) { @@ -531,12 +530,11 @@ assume_stream_formats(struct snd_oxfw *oxfw, enum avc_general_plug_dir dir, continue; eid++; - formats[eid] = kmalloc(*len, GFP_KERNEL); + formats[eid] = kmemdup(buf, *len, GFP_KERNEL); if (formats[eid] == NULL) { err = -ENOMEM; goto end; } - memcpy(formats[eid], buf, *len); formats[eid][2] = avc_stream_rate_table[i]; } @@ -594,12 +592,11 @@ static int fill_stream_formats(struct snd_oxfw *oxfw, if (err < 0) break; - formats[eid] = kmalloc(len, GFP_KERNEL); + formats[eid] = kmemdup(buf, len, GFP_KERNEL); if (formats[eid] == NULL) { err = -ENOMEM; break; } - memcpy(formats[eid], buf, len); /* get next entry */ len = AVC_GENERIC_FRAME_MAXIMUM_BYTES; -- 1.9.1

2 1

[alsa-devel] [PATCH 30/31] sound/atom: use kmemdup rather than duplicating its implementation
by Andrzej Hajda 07 Aug '15

07 Aug '15

The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> --- sound/soc/intel/atom/sst/sst_ipc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 5a27861..3dc7358 100644 --- a/sound/soc/intel/atom/sst/sst_ipc.c +++ b/sound/soc/intel/atom/sst/sst_ipc.c @@ -352,10 +352,9 @@ void sst_process_reply_mrfld(struct intel_sst_drv *sst_drv_ctx, * copy from mailbox **/ if (msg_high.part.large) { - data = kzalloc(msg_low, GFP_KERNEL); + data = kmemdup((void *)msg->mailbox_data, msg_low, GFP_KERNEL); if (!data) return; - memcpy(data, (void *) msg->mailbox_data, msg_low); /* Copy command id so that we can use to put sst to reset */ dsp_hdr = (struct ipc_dsp_hdr *)data; cmd_id = dsp_hdr->cmd_id; -- 1.9.1

2 2

[alsa-devel] [PATCH 31/31] sound/soc: use kmemdup rather than duplicating its implementation
by Andrzej Hajda 07 Aug '15

07 Aug '15

The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> --- sound/soc/soc-topology.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 4dadb5e..a5da91b 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -831,12 +831,12 @@ static int soc_tplg_denum_create_values(struct soc_enum *se, if (ec->items > sizeof(*ec->values)) return -EINVAL; - se->dobj.control.dvalues = - kmalloc(ec->items * sizeof(u32), GFP_KERNEL); + se->dobj.control.dvalues = kmemdup(ec->values, + ec->items * sizeof(u32), + GFP_KERNEL); if (!se->dobj.control.dvalues) return -ENOMEM; - memcpy(se->dobj.control.dvalues, ec->values, ec->items * sizeof(u32)); return 0; } -- 1.9.1

2 1

[alsa-devel] [GIT PULL] ASoC fixes for v4.2
by Mark Brown 07 Aug '15

07 Aug '15

The following changes since commit 74d33293e467df61de1b1d8b2fbe29e550dec33b: Linux 4.2-rc5 (2015-08-02 18:34:55 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v4.2-rc5 for you to fetch changes up to d00a9e02178401433fc386e69c936f2039f07b57: Merge remote-tracking branches 'asoc/fix/cs4265', 'asoc/fix/intel' and 'asoc/fix/topology' into asoc-linus (2015-08-06 12:39:07 +0100) ---------------------------------------------------------------- ASoC: Fixes for v4.2 There are a couple of small driver specific fixes here but the overwhelming bulk of these changes are fixes to the topology ABI that has been newly introduced in v4.2. Once this makes it into a release we will have to firm this up but for now getting enhancements in before they've made it into a release is the most expedient thing. ---------------------------------------------------------------- Axel Lin (1): ASoC: cs4265: Fix setting dai format for Left/Right Justified Bard Liao (1): ASoC: rt5645: Fix lost pin setting for DMIC1 Jie Yang (2): ASoC: Intel: haswell: fix initialize 'NULL device *' issue ASoC: Intel: sst_byt: fix initialize 'NULL device *' issue Liam Girdwood (1): ASoC: topology: Add private data type and bump ABI version to 3 Mark Brown (3): Merge tag 'asoc-fix-v4.2-rc3' into asoc-fix-topology Merge remote-tracking branch 'asoc/fix/rt5645' into asoc-linus Merge remote-tracking branches 'asoc/fix/cs4265', 'asoc/fix/intel' and 'asoc/fix/topology' into asoc-linus Mengdong Lin (3): ASoC: topology: fix typo in soc_tplg_kcontrol_bind_io() ASoC: topology: Update TLV support so we can support more TLV types ASoC: topology: Add ops support to byte controls UAPI Subhransu S. Prusty (1): ASoC: topology: Add subsequence in topology Vinod Koul (1): ASoC: topology: add private data to manifest include/uapi/sound/asoc.h | 35 +++++++++++------ sound/soc/codecs/cs4265.c | 10 ++--- sound/soc/codecs/rt5645.c | 2 + sound/soc/codecs/rt5645.h | 4 ++ sound/soc/intel/baytrail/sst-baytrail-ipc.c | 2 + sound/soc/intel/haswell/sst-haswell-ipc.c | 2 + sound/soc/soc-topology.c | 61 ++++++++++++++++++++--------- 7 files changed, 82 insertions(+), 34 deletions(-)

2 1

[alsa-devel] [PATCH 00/42] ASoC: Replace users of TLV_DB_RANGE_HEAD
by Lars-Peter Clausen 07 Aug '15

07 Aug '15

Usage of TLV_DB_RANGE_HEAD() is deprecated in favor of DECLARE_TLV_DB_RANGE(). The reason for this is that the former requires to specify the number of items inside the range container while the later is able to calculate this automatically and hence leaves less room for error. While non of the current users of TLV_DB_RANGE_HEAD() gets it wrong it still makes sense to clean this up since existing drivers are often used as templates for new drivers. As an added bonus the code is also slightly shorter. There are also a few drivers which use TLV_DB_RANGE_HEAD() with only a single sub-item. Those are updated to not use a range container at all since it is not necessary. Most of the conversion was auto-generated using the following coccinelle script: // <smpl> @@ declarer name DECLARE_TLV_DB_RANGE; identifier tlv; constant x; @@ -unsigned int tlv[] = { - TLV_DB_RANGE_HEAD(x), +DECLARE_TLV_DB_RANGE(tlv, ... -}; +); // </smpl> - Lars Lars-Peter Clausen (42): ASoC: 88pm860x: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: ab8500: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: adau1373: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: alc5623: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: alc5632: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: cs42l52: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: cs42l56: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: cs42l73: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: da7210: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: da7213: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: da9055: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: jz4740: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max9768: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max98088: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max98090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max98095: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max9850: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: max9877: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5631: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5640: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5645: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5651: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5670: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: rt5677: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: sgtl5000: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: ssm2602: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: tpa6130a2: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: twl4030: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: uda1380: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8350: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8400: Don't use range container for TLV with one entry ASoC: wm8737: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8753: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8961: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8962: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm8990: Don't use range container for TLV with one entry ASoC: wm8991: Don't use range container for TLVs with one entry ASoC: wm8993: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm9081: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm9090: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm9713: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE ASoC: wm_hubs: Replace TLV_DB_RANGE_HEAD with DECLARE_TLV_DB_RANGE sound/soc/codecs/88pm860x-codec.c | 28 +++++++++------------ sound/soc/codecs/ab8500-codec.c | 7 +++--- sound/soc/codecs/adau1373.c | 21 +++++++--------- sound/soc/codecs/alc5623.c | 7 +++--- sound/soc/codecs/alc5632.c | 7 +++--- sound/soc/codecs/cs42l52.c | 7 +++--- sound/soc/codecs/cs42l56.c | 21 +++++++--------- sound/soc/codecs/cs42l73.c | 14 +++++------ sound/soc/codecs/da7210.c | 22 +++++++---------- sound/soc/codecs/da7213.c | 15 +++++------ sound/soc/codecs/da9055.c | 15 +++++------ sound/soc/codecs/jz4740.c | 7 +++--- sound/soc/codecs/max9768.c | 7 +++--- sound/soc/codecs/max98088.c | 23 ++++++++--------- sound/soc/codecs/max98090.c | 42 ++++++++++++++----------------- sound/soc/codecs/max98095.c | 35 +++++++++++--------------- sound/soc/codecs/max9850.c | 7 +++--- sound/soc/codecs/max9877.c | 14 +++++------ sound/soc/codecs/rt5631.c | 7 +++--- sound/soc/codecs/rt5640.c | 7 +++--- sound/soc/codecs/rt5645.c | 7 +++--- sound/soc/codecs/rt5651.c | 7 +++--- sound/soc/codecs/rt5670.c | 7 +++--- sound/soc/codecs/rt5677.c | 7 +++--- sound/soc/codecs/sgtl5000.c | 7 +++--- sound/soc/codecs/ssm2602.c | 7 +++--- sound/soc/codecs/tpa6130a2.c | 14 +++++------ sound/soc/codecs/twl4030.c | 7 +++--- sound/soc/codecs/uda1380.c | 14 +++++------ sound/soc/codecs/wm8350.c | 7 +++--- sound/soc/codecs/wm8400.c | 5 +--- sound/soc/codecs/wm8737.c | 7 +++--- sound/soc/codecs/wm8753.c | 7 +++--- sound/soc/codecs/wm8961.c | 7 +++--- sound/soc/codecs/wm8962.c | 14 +++++------ sound/soc/codecs/wm8990.c | 5 +--- sound/soc/codecs/wm8991.c | 52 +++++++-------------------------------- sound/soc/codecs/wm8993.c | 7 +++--- sound/soc/codecs/wm9081.c | 7 +++--- sound/soc/codecs/wm9090.c | 21 +++++++--------- sound/soc/codecs/wm9713.c | 7 +++--- sound/soc/codecs/wm_hubs.c | 7 +++--- 42 files changed, 216 insertions(+), 327 deletions(-) -- 2.1.4

6 91

[alsa-devel] External plugin question
by Mina Almasry 07 Aug '15

07 Aug '15

I'm new to alsa dev and I'm trying to write a very simple external pcm plugin. I want my pcm plugin to output sound to multiple slave pcms when sound is being writei'd to it. So: snd_pcm_myplugin_writei(pcm, buffer, size) { foreach slave pcm { snd_pcm_writei(slave_pcm, buffer, size); } } I'm having trouble implementing this plugin because the external plugin sdk does not allow me to define the writei function for my plugin, but lets me define the transfer function which has a very different signature than writei: transfer(snd_pcm_ioplug_t *io, const snd_pcm_channel_area_t *areas, snd_pcm_uframes_t offset, snd_pcm_uframes_t size) how do I extract buffer and size from these arguments? Any tips on how I write my plugin. Mina

2 1

[alsa-devel] External plugin question
by Mina Almasry 07 Aug '15

07 Aug '15

I'm new to alsa dev and I'm trying to write a very simple external pcm plugin. I want my pcm plugin to output sound to multiple slave pcms when sound is being writei'd to it. So: snd_pcm_myplugin_writei(pcm, buffer, size) { foreach slave pcm { snd_pcm_writei(slave_pcm, buffer, size); } } I'm having trouble implementing this plugin because the external plugin sdk does not allow me to define the writei function for my plugin, but lets me define the transfer function which has a very different signature than writei: transfer(snd_pcm_ioplug_t <http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m___i_o_plug.html…> *io, const snd_pcm_channel_area_t <http://www.alsa-project.org/alsa-doc/alsa-lib/structsnd__pcm__channel__area…> *areas, snd_pcm_uframes_t <http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gab01fcfe9…> offset, snd_pcm_uframes_t <http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gab01fcfe9…> size) how do I extract buffer and size from these arguments? Any tips on how I write my plugin. (I'm aware of the multi plugin but I don't wont to use that. I want to write my own and introduce custom logic later.) Mina

1 0

[alsa-devel] [PATCH 2/2] ASoC: max98090: Enforce correct device sequencing when configuring a new
by yang.a.fang＠intel.com 07 Aug '15

07 Aug '15

From: "Fang, Yang A" <yang.a.fang(a)intel.com> audio route when there is an existing active audio route(s). This patch fixed recording noise issue while playback is active. We have some registers which require the device to be in full shutdown or to enter full shutdown before the register settings will take effect. Currently the driver is not shutting down the device when a new audio route is created. If a new audio route is made active while there is already an active audio route, then the required register sequencing is violated. A hardware shutdown toggle when creating a new audio route corrects the sequencing error. The device must remain in hardware shutdown for 40ms to allow the internal hardware core to fully shutdown. Signed-off-by: Fang, Yang A <yang.a.fang(a)intel.com> Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> --- sound/soc/codecs/max98090.c | 46 +++++++++++++++++++++++++++++++++++++------ sound/soc/codecs/max98090.h | 1 + 2 files changed, 41 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 91c9f9f..1516c6b 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -850,6 +850,19 @@ static int max98090_micinput_event(struct snd_soc_dapm_widget *w, return 0; } +static int max98090_shdn_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) +{ + struct snd_soc_codec *codec = snd_soc_dapm_to_codec(w->dapm); + struct max98090_priv *max98090 = snd_soc_codec_get_drvdata(codec); + + if (event & SND_SOC_DAPM_POST_PMU) + max98090->shdn_pending = TRUE; + + return 0; + +} + static const char *mic1_mux_text[] = { "IN12", "IN56" }; static SOC_ENUM_SINGLE_DECL(mic1_mux_enum, @@ -1158,9 +1171,11 @@ static const struct snd_soc_dapm_widget max98090_dapm_widgets[] = { SND_SOC_DAPM_SUPPLY("SDOEN", M98090_REG_IO_CONFIGURATION, M98090_SDOEN_SHIFT, 0, NULL, 0), SND_SOC_DAPM_SUPPLY("DMICL_ENA", M98090_REG_DIGITAL_MIC_ENABLE, - M98090_DIGMICL_SHIFT, 0, NULL, 0), + M98090_DIGMICL_SHIFT, 0, max98090_shdn_event, + SND_SOC_DAPM_POST_PMU), SND_SOC_DAPM_SUPPLY("DMICR_ENA", M98090_REG_DIGITAL_MIC_ENABLE, - M98090_DIGMICR_SHIFT, 0, NULL, 0), + M98090_DIGMICR_SHIFT, 0, max98090_shdn_event, + SND_SOC_DAPM_POST_PMU), SND_SOC_DAPM_SUPPLY("AHPF", M98090_REG_FILTER_CONFIG, M98090_AHPF_SHIFT, 0, NULL, 0), @@ -1205,10 +1220,12 @@ static const struct snd_soc_dapm_widget max98090_dapm_widgets[] = { &max98090_right_adc_mixer_controls[0], ARRAY_SIZE(max98090_right_adc_mixer_controls)), - SND_SOC_DAPM_ADC("ADCL", NULL, M98090_REG_INPUT_ENABLE, - M98090_ADLEN_SHIFT, 0), - SND_SOC_DAPM_ADC("ADCR", NULL, M98090_REG_INPUT_ENABLE, - M98090_ADREN_SHIFT, 0), + SND_SOC_DAPM_ADC_E("ADCL", NULL, M98090_REG_INPUT_ENABLE, + M98090_ADLEN_SHIFT, 0, max98090_shdn_event, + SND_SOC_DAPM_POST_PMU), + SND_SOC_DAPM_ADC_E("ADCR", NULL, M98090_REG_INPUT_ENABLE, + M98090_ADREN_SHIFT, 0, max98090_shdn_event, + SND_SOC_DAPM_POST_PMU), SND_SOC_DAPM_AIF_OUT("AIFOUTL", "HiFi Capture", 0, SND_SOC_NOPM, 0, 0), @@ -2539,9 +2556,26 @@ static int max98090_remove(struct snd_soc_codec *codec) return 0; } +static void max98090_seq_notifier(struct snd_soc_dapm_context *dapm, + enum snd_soc_dapm_type event, int subseq, bool power_up) +{ + struct snd_soc_codec *codec = snd_soc_dapm_to_codec(dapm); + struct max98090_priv *max98090 = snd_soc_codec_get_drvdata(codec); + + if (max98090->shdn_pending && power_up) { + snd_soc_update_bits(codec, M98090_REG_DEVICE_SHUTDOWN, + M98090_SHDNN_MASK, 0); + msleep(40); + snd_soc_update_bits(codec, M98090_REG_DEVICE_SHUTDOWN, + M98090_SHDNN_MASK, M98090_SHDNN_MASK); + max98090->shdn_pending = FALSE; + } +} + static struct snd_soc_codec_driver soc_codec_dev_max98090 = { .probe = max98090_probe, .remove = max98090_remove, + .seq_notifier = max98090_seq_notifier, .set_bias_level = max98090_set_bias_level, }; diff --git a/sound/soc/codecs/max98090.h b/sound/soc/codecs/max98090.h index 21ff743..bc610d9 100644 --- a/sound/soc/codecs/max98090.h +++ b/sound/soc/codecs/max98090.h @@ -1543,6 +1543,7 @@ struct max98090_priv { unsigned int pa2en; unsigned int sidetone; bool master; + bool shdn_pending; }; int max98090_mic_detect(struct snd_soc_codec *codec, -- 1.7.9.5

1 0

[alsa-devel] [asoc:fix/topology 5/7] sound/soc/soc-topology.c:596:14: sparse: incorrect type in assignment (different base types)
by kbuild test robot 06 Aug '15

06 Aug '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git fix/topology head: c7bcf8777a539e64dafc7417c00047aee6eb8909 commit: 28a87eebcad40101b1b273cbd4f2a02c104f9367 [5/7] ASoC: topology: Update TLV support so we can support more TLV types reproduce: # apt-get install sparse git checkout 28a87eebcad40101b1b273cbd4f2a02c104f9367 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) sound/soc/soc-topology.c:1696:45: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:190:28: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:191:39: sparse: incorrect type in return expression (different base types) sound/soc/soc-topology.c:191:39: expected int sound/soc/soc-topology.c:191:39: got restricted __le32 [usertype] reg sound/soc/soc-topology.c:203:28: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:204:39: sparse: incorrect type in return expression (different base types) sound/soc/soc-topology.c:204:39: expected int sound/soc/soc-topology.c:204:39: got restricted __le32 [usertype] shift sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:228:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:248:20: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:519:42: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:521:42: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:523:42: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:534:61: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:536:61: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:538:62: sparse: restricted __le32 degrades to integer >> sound/soc/soc-topology.c:596:14: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:596:14: expected unsigned int [unsigned] <noident> sound/soc/soc-topology.c:596:14: got restricted __le32 [usertype] min sound/soc/soc-topology.c:597:22: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:609:17: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:612:15: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:616:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:667:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:677:27: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:677:27: expected unsigned int [unsigned] [addressable] [assigned] access sound/soc/soc-topology.c:677:27: got restricted __le32 [usertype] access sound/soc/soc-topology.c:679:26: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:679:26: expected int [signed] max sound/soc/soc-topology.c:679:26: got restricted __le32 [usertype] max sound/soc/soc-topology.c:748:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:758:27: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:758:27: expected unsigned int [unsigned] [addressable] [assigned] access sound/soc/soc-topology.c:758:27: got restricted __le32 [usertype] access sound/soc/soc-topology.c:770:25: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:770:25: expected int [signed] max sound/soc/soc-topology.c:770:25: got restricted __le32 [usertype] max sound/soc/soc-topology.c:771:25: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:771:25: expected int [signed] min sound/soc/soc-topology.c:771:25: got restricted __le32 [usertype] min sound/soc/soc-topology.c:772:28: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:772:28: expected unsigned int [unsigned] invert:1 sound/soc/soc-topology.c:772:28: got restricted __le32 [usertype] invert sound/soc/soc-topology.c:773:34: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:773:34: expected int [signed] platform_max sound/soc/soc-topology.c:773:34: got restricted __le32 [usertype] platform_max sound/soc/soc-topology.c:824:44: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:828:27: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:855:15: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:859:27: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:863:9: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:887:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:905:27: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:905:27: expected unsigned int [unsigned] [addressable] [assigned] access sound/soc/soc-topology.c:905:27: got restricted __le32 [usertype] access sound/soc/soc-topology.c:913:27: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:913:27: expected unsigned int [unsigned] items sound/soc/soc-topology.c:913:27: got restricted __le32 [usertype] items sound/soc/soc-topology.c:914:26: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:914:26: expected unsigned int [unsigned] mask sound/soc/soc-topology.c:914:26: got restricted __le32 [usertype] mask sound/soc/soc-topology.c:920:36: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:920:36: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:920:36: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:920:36: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:920:36: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:994:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:994:45: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1001:28: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1013:60: sparse: incorrect type in argument 3 (different base types) sound/soc/soc-topology.c:1013:60: expected unsigned long [unsigned] [usertype] size sound/soc/soc-topology.c:1013:60: got restricted __le32 [usertype] payload_size sound/soc/soc-topology.c:1020:59: sparse: incorrect type in argument 3 (different base types) sound/soc/soc-topology.c:1020:59: expected unsigned long [unsigned] [usertype] size sound/soc/soc-topology.c:1020:59: got restricted __le32 [usertype] payload_size sound/soc/soc-topology.c:1023:60: sparse: incorrect type in argument 3 (different base types) sound/soc/soc-topology.c:1023:60: expected unsigned long [unsigned] [usertype] size sound/soc/soc-topology.c:1023:60: got restricted __le32 [usertype] payload_size sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1005:41: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1040:24: sparse: incorrect type in initializer (different base types) sound/soc/soc-topology.c:1040:24: expected int [signed] count sound/soc/soc-topology.c:1040:24: got restricted __le32 [usertype] count sound/soc/soc-topology.c:1043:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1043:45: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1049:27: sparse: incorrect type in argument 4 (different base types) sound/soc/soc-topology.c:1049:27: expected unsigned long [unsigned] [usertype] bytes sound/soc/soc-topology.c:1049:27: got restricted __le32 [usertype] payload_size sound/soc/soc-topology.c:1107:33: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1120:30: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:1120:30: expected unsigned int [unsigned] access sound/soc/soc-topology.c:1120:30: got restricted __le32 [usertype] access sound/soc/soc-topology.c:1132:25: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:1132:25: expected int [signed] max sound/soc/soc-topology.c:1132:25: got restricted __le32 [usertype] max sound/soc/soc-topology.c:1133:25: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:1133:25: expected int [signed] min sound/soc/soc-topology.c:1133:25: got restricted __le32 [usertype] min sound/soc/soc-topology.c:1134:28: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:1134:28: expected unsigned int [unsigned] invert:1 sound/soc/soc-topology.c:1134:28: got restricted __le32 [usertype] invert sound/soc/soc-topology.c:1135:34: sparse: incorrect type in assignment (different base types) sound/soc/soc-topology.c:1135:34: expected int [signed] platform_max sound/soc/soc-topology.c:1135:34: got restricted __le32 [usertype] platform_max sound/soc/soc-topology.c:1179:25: sparse: restricted __le32 degrades to integer sound/soc/soc-topology.c:1200:20: sparse: incorrect type in assignment (different base types) vim +596 sound/soc/soc-topology.c 580 return 0; 581 } 582 583 584 static int soc_tplg_create_tlv_db_scale(struct soc_tplg *tplg, 585 struct snd_kcontrol_new *kc, struct snd_soc_tplg_tlv_dbscale *scale) 586 { 587 unsigned int item_len = 2 * sizeof(unsigned int); 588 unsigned int *p; 589 590 p = kzalloc(item_len + 2 * sizeof(unsigned int), GFP_KERNEL); 591 if (!p) 592 return -ENOMEM; 593 594 p[0] = SNDRV_CTL_TLVT_DB_SCALE; 595 p[1] = item_len; > 596 p[2] = scale->min; 597 p[3] = (scale->step & TLV_DB_SCALE_MASK) 598 | (scale->mute ? TLV_DB_SCALE_MUTE : 0); 599 600 kc->tlv.p = (void *)p; 601 return 0; 602 } 603 604 static int soc_tplg_create_tlv(struct soc_tplg *tplg, --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 1/2] ASoC: wm8731: Drop wm8731_writeable function
by Axel Lin 06 Aug '15

06 Aug '15

When .max_register is set and .writeable_reg is not implement, registers between 0 and .max_register are writeable. This is the same as current implementation of wm8731_writeable(), so just drop implementation for .writeable_reg callback. Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/wm8731.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index c862232..ace8645 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -79,11 +79,6 @@ static bool wm8731_volatile(struct device *dev, unsigned int reg) return reg == WM8731_RESET; } -static bool wm8731_writeable(struct device *dev, unsigned int reg) -{ - return reg <= WM8731_RESET; -} - #define wm8731_reset(m) regmap_write(m, WM8731_RESET, 0) static const char *wm8731_input_select[] = {"Line In", "Mic"}; @@ -655,7 +650,6 @@ static const struct regmap_config wm8731_regmap = { .max_register = WM8731_RESET, .volatile_reg = wm8731_volatile, - .writeable_reg = wm8731_writeable, .cache_type = REGCACHE_RBTREE, .reg_defaults = wm8731_reg_defaults, -- 2.1.0

3 5