November 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: da7219: Use logical instead of bitwise OR for boolean expression
by Axel Lin 02 Nov '15

02 Nov '15

Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index abba4b3..86c528a 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1306,7 +1306,7 @@ static int da7219_hw_params(struct snd_pcm_substream *substream, } channels = params_channels(params); - if ((channels < 1) | (channels > DA7219_DAI_CH_NUM_MAX)) { + if ((channels < 1) || (channels > DA7219_DAI_CH_NUM_MAX)) { dev_err(codec->dev, "Invalid number of channels, only 1 to %d supported\n", DA7219_DAI_CH_NUM_MAX); -- 2.1.4

3 2

[alsa-devel] [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci warnings
by Julia Lawall 02 Nov '15

02 Nov '15

Move constant to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Signed-off-by: Fengguang Wu <fengguang.wu(a)intel.com> Signed-off-by: Julia Lawall <julia.lawall(a)lip6.fr> --- Depends on personal taste, but the modified version does look a little nicer to me, since one can better see the relationship between the fdf and sfc fields. amdtp-am824.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/amdtp-am824.c +++ b/sound/firewire/amdtp-am824.c @@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am if (err < 0) return err; - s->fdf = AMDTP_FDF_AM824 | s->sfc; + s->fdf = s->sfc | AMDTP_FDF_AM824; /* * In IEC 61883-6, one data block represents one event. In ALSA, one

2 4

[alsa-devel] ALSA: USB-audio: Add quirk for Zoom R16/24 playback
by Alain 02 Nov '15

02 Nov '15

Hello, First of all, sorry for my english I'm French speaking. Some time ago I was planning to buy a ZOOM R24 but after some research on internet I saw that machine was not fully functional under linux. till some nice people took care with that problem. As I can see, but i'm not sure, the problem is fixed Can you confirm me the ZOOM R16/24 is ok for 8 inputs/2 outputs ? Is the next kernel version will include the modifications? or should I do the modifications (compliling kernel is a big chalenge for me) ? Thanks for your job Alain

2 1

[alsa-devel] [PATCH] snd-maestro3: Fix Allegro mute until master volume/mute is touched
by Ondrej Zary 02 Nov '15

02 Nov '15

ESS Allegro (marked ES1989S), [125d:1988] (rev 10) is mute after loading snd-maestro3 and running alsactl restore. Touching master volume or mute makes it work. Looks like a bug in the AC'97 codec integrated into the chip. Write AC97_MASTER register twice to work-around the problem. Signed-off-by: Ondrej Zary <linux(a)rainbow-software.org> --- sound/pci/maestro3.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c index 965d5c6..17ae926 100644 --- a/sound/pci/maestro3.c +++ b/sound/pci/maestro3.c @@ -1929,6 +1929,16 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val) return; snd_m3_outw(chip, val, CODEC_DATA); snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + /* + * Workaround for buggy ES1988 integrated AC'97 codec. It remains silent + * until the MASTER volume or mute is touched (alsactl restore does not + * work). + */ + if (ac97->id == 0x45838308 && reg == AC97_MASTER) { + snd_m3_ac97_wait(chip); + snd_m3_outw(chip, val, CODEC_DATA); + snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + } } -- Ondrej Zary

2 1

[alsa-devel] [PATCH] snd-maestro3: Enable docking support for Dell Latitude C810
by Ondrej Zary 01 Nov '15

01 Nov '15

Enable I2S docking for Dell Latitude C810. This allows the audio output on C/Port II to work (and probably also the audio inputs on C/Dock II). The volume can't be adjusted - none of the mixer controls currently supported affects the I2S output (they belong to the STAC9721/23 AC'97 codec responsible for the laptop internal connectors & speakers). Signed-off-by: Ondrej Zary <linux(a)rainbow-software.org> --- sound/pci/maestro3.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c index 72e89ce..965d5c6 100644 --- a/sound/pci/maestro3.c +++ b/sound/pci/maestro3.c @@ -1932,12 +1932,19 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val) } -static void snd_m3_remote_codec_config(int io, int isremote) +static void snd_m3_remote_codec_config(struct snd_m3 *chip, int isremote) { + int io = chip->iobase; + u16 tmp; + isremote = isremote ? 1 : 0; - outw((inw(io + RING_BUS_CTRL_B) & ~SECOND_CODEC_ID_MASK) | isremote, - io + RING_BUS_CTRL_B); + tmp = inw(io + RING_BUS_CTRL_B) & ~SECOND_CODEC_ID_MASK; + /* enable dock on Dell Latitude C810 */ + if (chip->pci->subsystem_vendor == 0x1028 && + chip->pci->subsystem_device == 0x00e5) + tmp |= M3I_DOCK_ENABLE; + outw(tmp | isremote, io + RING_BUS_CTRL_B); outw((inw(io + SDO_OUT_DEST_CTRL) & ~COMMAND_ADDR_OUT) | isremote, io + SDO_OUT_DEST_CTRL); outw((inw(io + SDO_IN_DEST_CTRL) & ~STATUS_ADDR_IN) | isremote, @@ -1989,7 +1996,7 @@ static void snd_m3_ac97_reset(struct snd_m3 *chip) if (!chip->irda_workaround) dir |= 0x10; /* assuming pci bus master? */ - snd_m3_remote_codec_config(io, 0); + snd_m3_remote_codec_config(chip, 0); outw(IO_SRAM_ENABLE, io + RING_BUS_CTRL_A); udelay(20); -- Ondrej Zary

2 1

Re: [alsa-devel] Fwd: Re: Gmail thinks most alsa-devel mail is spam
by A. C. Censi 01 Nov '15

01 Nov '15

Jaroslav We are still getting alsa-dev email classiified as possible by gmail and others. It seems that your DNS entries still misses a PTR record. You can check with digweb http://www.digwebinterface.com/?hostnames=2002%3A4d30%3Ae0f1%3A1%3A5054%3Af… or dnsquery.org ... We've got referrals (ns1.bravonet.cz., ns2.dkm.cz.) from queries on previous step. We'll query them now, until we got an authoritative result 153.67 msns1.bravonet.cz. [77.48.224.1] (Dubne, Jihocesky Kraj, Czech Republic) ;;Authority 224.48.77.in-addr.arpa. 86400 undefined NS ns1.bravonet.cz. 224.48.77.in-addr.arpa. 86400 undefined NS ns2.dkm.cz. ;;Answer 243.224.48.77.in-addr.arpa. 86400 undefined PTR alsa0.perex.cz ;;Additional ns1.bravonet.cz. 86400 undefined A 77.48.224.1 We got authoritative results from ns1.bravonet.cz. Thanks A C Censi On Wed, Oct 28, 2015 at 8:36 PM, Timur Tabi <timur(a)codeaurora.org> wrote: > On Thu, Oct 22, 2015 at 2:43 AM, Jaroslav Kysela <perex(a)perex.cz> wrote: > > > > OK. The outgoing e-mails should be from IPv4 now which has registered > > reverse DNS record. You may check. > > It doesn't appear to be working. I still get lots of alsa-devel posts > in my Spam folder, with the same reason. > > Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) > by mx.google.com with ESMTP id > qo10si41235490wjc.143.2015.10.26.17.34.56; > Mon, 26 Oct 2015 17:34:56 -0700 (PDT) > > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project. > -- A. C. Censi accensi [em] gmail [ponto] com accensi [em] montreal [ponto] com [ponto] br

1 0

[alsa-devel] [Minutes] ELCE Audio mini conf.
by Liam Girdwood 01 Nov '15

01 Nov '15

I've written up the minutes here below (including Vinod's minutes after I left for my flight). Please do feel free to correct or add any missing items. If you intend to reply and discuss a topic in detail then it would probably be helpful to include the topic in the $SUBJECT (so that it's easy to track multiple topics that may arise from the minutes). Jaroslav, I have some PDF slides from a few delegates. Can I post them on to the Wiki ? This failed last time I tried after the Edinburgh audio conference (Wiki could not upload PDFs ??). Soundwire: Pierre ================= - Slides to be posted. - Shadow registers required for regamp. Mark: need to make sure we can commit changes, and rules for witting. Reuse of codec drivers since reg mapping should be similar to i2c regmaps. - Some devices wont support run time clock changes. Need compatible devices on bus. - Each device has unique ID set by HW. Device enumeration can be auto discovered. Can detect device but not capabilities. - Device capabilities can come from hard coded driver data or ACPI/DT data. Windows may use inf files for capabilities. - Define bus api for master "controller". - Grouped triggers can be used for start duplex streams for similtanious capture and playback. - DAI is physical connection, logical links need to be worked out with Routing config Mark: Redefining of ports/slots at runtime i.e. Leave up to userspace for handling supported configurations of ports. Energy efficiency: Alexander (Minutes also supplied by Alexander). ================================================================== Power consumption of a SandyBridge-based Sony laptop has been measured with a workload that does only audio playback. To ensure a reproducible workload, the whole system has been constructed by a script using debootstrap, and placed into an initramfs. Various versions of PulseAudio were compared to CRAS and to the use of ALSA hw device, at latencies 7 ms, 28 ms and 448 ms. Even in the best case (ALSA), going from 448 to 28 ms means using extra 300 mW. For PulseAudio, the overhead of using low latency is even higher, presumably because of a chatty protocol. In version 7, there was some work (srbchannel) with the aim to reduce this overhead, but there is still more way to go. There was a suggestion to use perf to analyze the problem further. It should be noted that latencies as high as 448 ms are not usable without the ability to rewind, which PulseAudio posesses (at the cost of more complex, and actually incorrect, code) and CRAS doesn't. So CRAS decision to never do rewinds costs it 300 mW (448 ms latency is usable only for benchmarking purposes). Note: at least two people in the audience misunderstood this statement as originally formulated (thinko?), and got it as "PulseAudio decision to do rewinds costs it 300 mW", which is of course wrong. The cost of rewinds is in code complexity, real user-reported bugs and "how to test this code path" questions from developers, which, in the opinion of Alexander Patrakov, may outweigh the gains in energy efficiency (Arun Raghavan disagrees). A proposal was made by P.-L. Bossart to introduce a hw param that the application would set if it intends to never do rewinds, with the implication that a SkyLake driver can use this information for codec-side power saving (by prefetching audio data and powering the link off). Arun Raghavan (presumably due to the above misunderstanding) disagreed and instead proposed to make the device non-rewindable if this means power savings. Alexander is in favor of the hw param, because it would be useful for CRAS, but harmful for the current PulseAudio (it would force abandoning high latency). A future version of PulseAudio could, though, use a separate DSP stream for a music application (if there is only one), and, because a new application never appears, and the hardware volume is precise enough, there would never be a need to rewind. This, though, would need eliminating the support for rewinds from the client API (the last two parameters for pa_stream_write()), which can be done by ignoring these parameters. Documentation: Takashi ====================== - Patches that introduce new functionality should also include documentation. - Caretaker required for docs. Who ? - Uploading materials, in central location, ask kernel.org. - Charles and Rakesh voluntered to write some docs. Alsa-lib: release schedule: Vinod. ================================== - Request for more frequent release. Release inline with 1 - 2 kernel releases. - Integrate tinycompress into alsa release. Testing/QA: Liam, Takashi, Mark, Pierre ======================================= - BAT tool: Now upstream, WiP for review comments docs and new features. - Mark doing brute force tool for kcontrol testing. Kcontrol status can be watched via debubFS. Multiple threads. - Takashi: Need unit testing codec drivers. Some codec vendors have tools for this but something generic would be good. QA unit test could use topology readback to check topology in userspace. - Pierre: Latency testing, USB device to toggle GPIO (to indicate stream start) and audio latency measured from this point. Available on 01.org latency tools. To be extended to BAT. HDA/gfx: relevant people not in room. ===================================== - Pierre: Hotplug DP over USB C required. Needs input from GFX folks. BATCH flag for USB: Arun. ========================= - Flag does not respond to reality, lets deprecate it. no users. - Dylan: need to know transfer size for CRAS (uses extra samples for buffering). - BATCH flag means period size transfers, applications that use new granularity API can ignore batch flag. Pierre: to implement. Splitting out controls: Takashi =============================== - Restricted access. Consensus to restrict access to some controls due to possibility of breaking HW at kernel level. i.e. prevent feeding digital Mic into HP amp to prevent speaker over heating. - Some clamping APIs already exist, but these should be extended to include DAPM. Simple card: ACPI support. Vinod ================================ - Clock drivers required alongside helper functions to help initialise DAI links etc. - Vinod to publish spec as RFC in Q4. - Doubts of using DMI names for differentiation. Topology: Liam, Mengdong ======================== - Proposals to use debugFS/ioctl/media controller for exporting topology data to userspace. Drawbacks with all three approaches, but are aimed at different end users i.e. debugFS aimed at kernel audio developers/integrators/testers and media aimed at userspace developers and end users. Will probably support both debugFS (or other kernel file) and media API. Mark to discuss at Media team in Seoul. ASoC internals to gather data for debugFS and Media API will be the same code so nothing blocking initial development. Tiny-fication. Keyon, Liam ========================== - IoT devices have tight memory footprints so audio kernel and userspace can be very limited. - Userspace is fine with tinyalsa. - Currently Keyon has worked on some IoT device options to disable ALSA functions. e.g. code saving of 13k for refinement, but some IoT options can break existing userpsace. - Suggestion is to research tinycompress API for general PCM usage. - Look at removing DAPM strings (will need topology dump tool to automate this though). - Some structures can also be shrunk. Android configuration consolidation =================================== - different configuration formats XML, ucm, This tool takes Android XML and converts to UCM - uses Sony Xperia - generates UCM file from XML - Android: Try to converge to a HAL, but diverges quickly. Quirks for modem etc cant be represented well. - Arun will send the link to his work HDA Restructuring: Vinod & Rakesh ================================= - Discussed HW and SW overview - Future HDA work and codec conversion discussion <dont have detailed notes here as I was talking> DPMST: Mengdong ================ - One DVI port can be used to transmit multiple independent streams. - Three display pipelines in HW, so at most 3 streams can be supported across all ports - Need to modify representation to have stream on device rather than per pin. - While moving the monitor can be incompatible so should be modified - display should tell us unplug/plug on move. Sound server reacts to it. - This notification thru Component fwk. - Various options are discussed. Needs more offline discussion on approach and to solve this issue ALSA Core Challenges: ====================== - ALSA Core locking is complicated. Core code is quite difficult to understand. - PCM linking makes things complex - Add documentation for locks. - Controls can be hidden in UI tools through iface_cards. - DPCM hidden PCMs should not be shown in usermode, hide them from Usermode Multi Channel ASoC Controls; ============================= - channel maps dont make sense for ASoC as asoc paths dont have channel information - conclusion: add channel maps on HDMI edge. - we can add multi-channel controls to the asoc Liam

12 35