November 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/4 V3] Arndale: Adding Sound Machine Driver for ALC5631 Codec
by Krishna Mohan Dani 24 Nov '14

24 Nov '14

These patches add machine driver to instantiate I2S based realtek's ALC5631 based sound card on Arndale board. There are other variants of Audio Daughter Cards for Arndale Board for which support already exists but there is no support for Realtek's alc5631 codec based card hence support for ALC5631 based machine driver is being added. Most of the code has been pulled from insignal's git for Arndale and modified to suit the maintain syntax. Machine driver has been made DT compatible. Changes done: - Removed ifdef for of_device_id structure as commented by Mark Brown - Supporting both variants of device name:alc5631 and rt5631 as commented by Mark Brown - Added "return -EINVAL" if cpu_of_node or codec_of_node is not found in dtb, as commented by Anil Kumar - Removed i2s specific changes - Added signed off of claude - Removed CONFIG_OF check from rt5631.c codec driver and other changes Krishna Mohan Dani (4): ASoC: ALC5631/RT5631: Add device tree binding documentation ASoC: Samsung: Add arndale_rt5631 machine driver Sound: Kconfig: Adding the description of the codec ASoC: rt5631: Adding Device Tree compatibility to Realtek's ALC5631/RT5631 codec driver Documentation/devicetree/bindings/sound/rt5631.txt | 48 +++++++ sound/soc/codecs/Kconfig | 3 +- sound/soc/codecs/rt5631.c | 9 ++ sound/soc/samsung/Kconfig | 6 + sound/soc/samsung/Makefile | 2 + sound/soc/samsung/arndale_rt5631.c | 150 ++++++++++++++++++++ 6 files changed, 217 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt create mode 100644 sound/soc/samsung/arndale_rt5631.c -- 1.7.9.5

3 9

[alsa-devel] [PATCH] ASoC: soc-pcm: skip dpcm path checking with incapable/unready FE
by Qiao Zhou 24 Nov '14

24 Nov '14

Skip dpcm path checking for playback or capture, if corresponding FE doesn't support playback or capture, or currently is not ready. It can reduce the unnecessary cost to search connected widgets. Signed-off-by: Qiao Zhou <zhouqiao(a)marvell.com> --- sound/soc/soc-pcm.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 002311a..3b068d4 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2248,7 +2248,13 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card) fe->dai_link->name); /* skip if FE doesn't have playback capability */ - if (!fe->cpu_dai->driver->playback.channels_min) + if (!fe->cpu_dai->driver->playback.channels_min + || !fe->codec_dai->driver->playback.channels_min) + goto capture; + + /* skip if FE doesn't do playback */ + if (!fe->cpu_dai->playback_active + || !fe->codec_dai->playback_active) goto capture; paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_PLAYBACK, &list); @@ -2278,7 +2284,13 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card) dpcm_path_put(&list); capture: /* skip if FE doesn't have capture capability */ - if (!fe->cpu_dai->driver->capture.channels_min) + if (!fe->cpu_dai->driver->capture.channels_min + || !fe->codec_dai->driver->capture.channels_min) + continue; + + /* skip if FE doesn't do capture */ + if (!fe->cpu_dai->capture_active + || !fe->codec_dai->capture_active) continue; paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_CAPTURE, &list); -- 1.7.9.5

2 2

[alsa-devel] Debian Bug#770122: patch as workaround/solution
by Elimar Riesebieter 23 Nov '14

23 Nov '14

Hi, Iam forwarding this Debian bug to alsa-devel due to a not maintained BugTracker at alsa project. Could one please have a look at it? Thanks Elimar -- Alles was viel bedacht wird ist bedenklich!;-) Friedrich Nietzsche

1 1

[alsa-devel] [PATCH 0/10] fix error return code
by Julia Lawall 23 Nov '14

23 Nov '14

These patches fix cases where the return code appears to be unintentially nonnegative. The complete semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @ok exists@ identifier f,ret,i; expression e; constant c; @@ f(...) { <+... ( return -c@i; | ret = -c@i; ... when != ret = e return ret; | if (ret < 0) { ... return ret; } ) ...+> } @r exists@ identifier ret,l,ok.f; expression e1,e2,e3; statement S; position p1,p2,p3; @@ f(...) { ... when any ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret ( if (<+... ret = e3 ...+>) S | if (<+... &ret ...+>) S | if@p2(...) { ... when != ret = e2 when forall return@p3 ret; } ) ... when any } @bad exists@ position r.p1,r.p2; statement S1,S2; identifier r.ret; expression e1; @@ ( if@p1 (\(ret < 0\|ret != 0\)) S1 | ret@p1 = 0 ) ... when any ret = e1 ... when any if@p2(...) S2 @bad2@ position r.p1,r.p2; identifier r.ret; expression e1; statement S2; @@ ret@p1 = 0 ... when != if (...) { ... ret = e1 ... return ret; } when any if@p2(...) S2 @script:python depends on !bad && !bad2@ p1 << r.p1; p2 << r.p2; p3 << r.p3; @@ cocci.print_main("",p1) cocci.print_secs("",p2) cocci.print_secs("",p3) // </smpl>

2 12

[alsa-devel] Debian Bug#770122: patch as workaround/solution
by Elimar Riesebieter 23 Nov '14

23 Nov '14

Hi, I am forwarding this Debian bug [0] to alsa-devel due to a not maintained BugTracker at alsa project. Could one please have a look at it? [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770122 Thanks Elimar -- Alles was viel bedacht wird ist bedenklich!;-) Friedrich Nietzsche

1 0

[alsa-devel] [PATCH 1/2] amixer: Make "dB" case-insensitive in set commands
by Takashi Iwai 23 Nov '14

23 Nov '14

We don't have to be necessarily too strict about case-sensitivity of "dB" suffix used in set commands. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- amixer/amixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amixer/amixer.c b/amixer/amixer.c index cf82892bfa2f..6a2fdb96c62f 100644 --- a/amixer/amixer.c +++ b/amixer/amixer.c @@ -346,7 +346,7 @@ static int set_volume_simple(snd_mixer_elem_t *elem, if (*p == '%') { percent = 1; p++; - } else if (p[0] == 'd' && p[1] == 'B') { + } else if (toupper(p[0]) == 'D' && toupper(p[1]) == 'B') { vol_type = VOL_DB; p += 2; scale = 100; -- 2.1.3

1 1

[alsa-devel] [PATCH 00/10] ALSA: asihpi: updates
by eliot＠blennerhassett.gen.nz 23 Nov '14

23 Nov '14

From: Eliot Blennerhassett <eliot(a)blennerhassett.gen.nz> Major change - Add support for interrupt driven 'low latency' mode PCM streams on some AudioScience adapters. Various other minor updates from AudioScience Eliot Blennerhassett (10): ALSA: asihpi: Minor string and dead code cleanup ALSA: asihpi: New I/O types - AVB & BLUlink, DAB Rf receiver ALSA: asihpi: Logging format improvements ALSA: asihpi: Use CONFIG_64BIT directly ALSA: asihpi: Refactor control cache code. ALSA: asihpi: Add support for stream interrupt. ALSA: asihpi: Turn off msg/resp logging after DSP has crashed. ALSA: asihpi: Use standard printk helpers ALSA: asihpi: don't fail probe if adapter mode read fails ALSA: asihpi: used parts of message/response are zeroed before use sound/pci/asihpi/asihpi.c | 326 +++++++++++++++++++++++++++------------- sound/pci/asihpi/hpi.h | 16 +- sound/pci/asihpi/hpi6205.c | 43 +++++- sound/pci/asihpi/hpi_internal.h | 20 ++- sound/pci/asihpi/hpicmn.c | 107 +++++++------ sound/pci/asihpi/hpicmn.h | 19 ++- sound/pci/asihpi/hpimsginit.c | 30 ++-- sound/pci/asihpi/hpimsgx.c | 15 +- sound/pci/asihpi/hpioctl.c | 123 +++++++++++++-- sound/pci/asihpi/hpios.h | 8 +- 10 files changed, 508 insertions(+), 199 deletions(-) -- 1.9.1

3 12

[alsa-devel] randconfig errors in ts3a227e.c
by devendra.aaru 23 Nov '14

23 Nov '14

Hello All, While testing the build, i have got the following errors: sound/soc/codecs/ts3a227e.c: In function ‘ts3a227e_enable_jack_detect’: sound/soc/codecs/ts3a227e.c:223:2: error: implicit declaration of function ‘snd_jack_set_key’ [-Werror=implicit-function-declaration] snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); ^ cc1: some warnings being treated as errors make[3]: *** [sound/soc/codecs/ts3a227e.o] Error 1 The CONFIG_SND_JACK is not enabled in the .config and the #else portion of include/sound/jack.h doesn't contain snd_jack_set_key stub. This resulting in the build error. I am unsure if adding stub in include/sound/jack.h or adding a Kconfig knob to deselect the ts3a227e.c fixes the issue ? full randconfig attached. (sorry about the 55k file size)

1 1

[alsa-devel] [patch] sound: oss: uart401: remove unneeded NULL check
by Dan Carpenter 22 Nov '14

22 Nov '14

"devc" can't be NULL here so there is no need to check. Also I removed the "devc = NULL" assignment because devc is stored on stack so it's a no-op. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/oss/uart401.c b/sound/oss/uart401.c index 279bc56..dae4d43 100644 --- a/sound/oss/uart401.c +++ b/sound/oss/uart401.c @@ -412,13 +412,10 @@ void unload_uart401(struct address_info *hw_config) if (!devc->share_irq) free_irq(devc->irq, devc); - if (devc) - { - kfree(midi_devs[devc->my_dev]->converter); - kfree(midi_devs[devc->my_dev]); - kfree(devc); - devc = NULL; - } + kfree(midi_devs[devc->my_dev]->converter); + kfree(midi_devs[devc->my_dev]); + kfree(devc); + /* This kills midi_devs[x] */ sound_unload_mididev(hw_config->slots[4]); }

2 1

[alsa-devel] Headset jack and intel based Macmini6,2
by Marco 22 Nov '14

22 Nov '14

/cc David Henningsson that has done something like that for some Dell HW and might have some suggestions Hello, even if poorly advertised, recent mac.* have an headset jack (amplified) along with the non amplified line jack. For example, for MacMini, from: apple.com/mac-mini/specs/ > Support for Apple iPhone headset with microphone Where iPhone headset means a simple headset not preamplified, really. I own a MacMini6,2 (the october 2012 one) and with Mac OSX it works... under linux... well... it is a simple out jack. This jeopardize the ability to use any video conference software (who doesn't today?) on linux if you don't own a USB audio device (or you don't want that extra piece of relatively large hw) The card is a HDA based Cirrus Logic CS4206/4207 and the two specific models do not work (imac27 and mbp55) while auto works (except the headset of course :) I tried to change the pinconfig but on the intel HDA documentation it is not really clear how the code for an headset jack (in/out) would look like. I saw that for card ALC269/270/275/276/28x/29x there are models that support the headset codes but... well.. they don't really seem "standard" intel codes I tried to look if it was possible to extract these codes from OSX but I haven't found anything interesting (but I might have missed something) Any suggestion dear esteemed Alsa developers? :) Any help appreciated, Thanks! Marco

1 0