June 2013 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH V6 6/6] clk: exynos5250: Add enum entries for divider clock of i2s1 and i2s2
by Padma Venkat 21 Jun '13

21 Jun '13

Hi Mike, On Wed, Jun 12, 2013 at 10:15 PM, Mike Turquette <mturquette(a)linaro.org> wrote: > Quoting Padmavathi Venna (2013-06-12 01:07:43) >> This patch adds enum entries for div_i2s1 and div_i2s2 which are >> required for i2s1 and i2s2 controllers. >> >> Signed-off-by: Padmavathi Venna <padma.v(a)samsung.com> > > Looks good. Did you want me to take the clk patches or just gathering > Acks? Please take the patches :). Thanks Padma > > Regards, > Mike > >> --- >> drivers/clk/samsung/clk-exynos5250.c | 5 +++-- >> 1 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c >> index 5c97e75..7c68850 100644 >> --- a/drivers/clk/samsung/clk-exynos5250.c >> +++ b/drivers/clk/samsung/clk-exynos5250.c >> @@ -87,6 +87,7 @@ enum exynos5250_clks { >> sclk_mmc0, sclk_mmc1, sclk_mmc2, sclk_mmc3, sclk_sata, sclk_usb3, >> sclk_jpeg, sclk_uart0, sclk_uart1, sclk_uart2, sclk_uart3, sclk_pwm, >> sclk_audio1, sclk_audio2, sclk_spdif, sclk_spi0, sclk_spi1, sclk_spi2, >> + div_i2s1, div_i2s2, >> >> /* gate clocks */ >> gscl0 = 256, gscl1, gscl2, gscl3, gscl_wa, gscl_wb, smmu_gscl0, >> @@ -291,8 +292,8 @@ struct samsung_div_clock exynos5250_div_clks[] __initdata = { >> DIV(none, "div_pcm1", "sclk_audio1", DIV_PERIC4, 4, 8), >> DIV(none, "div_audio2", "mout_audio2", DIV_PERIC4, 16, 4), >> DIV(none, "div_pcm2", "sclk_audio2", DIV_PERIC4, 20, 8), >> - DIV(none, "div_i2s1", "sclk_audio1", DIV_PERIC5, 0, 6), >> - DIV(none, "div_i2s2", "sclk_audio2", DIV_PERIC5, 8, 6), >> + DIV(div_i2s1, "div_i2s1", "sclk_audio1", DIV_PERIC5, 0, 6), >> + DIV(div_i2s2, "div_i2s2", "sclk_audio2", DIV_PERIC5, 8, 6), >> DIV(sclk_pixel, "div_hdmi_pixel", "sclk_vpll", DIV_DISP1_0, 28, 4), >> DIV_A(none, "armclk", "div_arm", DIV_CPU0, 28, 3, "armclk"), >> DIV_F(none, "div_mipi1_pre", "div_mipi1", >> -- >> 1.7.4.4

3 3

[alsa-devel] mint 13 mate + ATI IXP SB4x0 High Definition Audio Controller (rev 01)
by Pavel 20 Jun '13

20 Jun '13

Hello! i have a big problem - no sound after install linux mint 13 mate. well, sometimes if i reboot - i have it, but after nex reboot - no sound no more, seems like pulseaudio don't see my sound card. Laptop: Manufacturer: FUJITSU SIEMENS Product Name: AMILO Pa 1510 Product Version: Not Applicable Firmware Version: 1.07C soundcard: 00:14.2 Audio device: Advanced Micro Devices [AMD] nee ATI IXP SB4x0 High Definition Audio Controller (rev 01) kernel 3.2.0-48-generic dmesg: http://pastebin.com/KF8ABwnY alsa-info: http://pastebin.com/QYBYNJi9 i read this topic: https://bugzilla.kernel.org/show_bug.cgi?id=18512 and tried to add "options snd-hda-intel model=6stack-dig single_cmd=1" to alsa-base.conf - it helped, after reboot i has sound, till i reboot - now no sound no more.. i tried everything i found in the google, even alsa-update - http://www.stchman.com/alsa_update.html nothing can help me, but i understand that's the problem is in the driver.. can someone pls help me to fix the problem? thank you.

1 0

[alsa-devel] mint 13 mate + ATI IXP SB4x0 High Definition Audio Controller (rev 01)
by Pavel 20 Jun '13

20 Jun '13

Hello! i have a big problem - no sound after install linux mint 13 mate. well, sometimes if i reboot - i have it, but after nex reboot - no sound no more, seems like pulseaudio don't see my sound card. Laptop: Manufacturer: FUJITSU SIEMENS Product Name: AMILO Pa 1510 Product Version: Not Applicable Firmware Version: 1.07C soundcard: 00:14.2 Audio device: Advanced Micro Devices [AMD] nee ATI IXP SB4x0 High Definition Audio Controller (rev 01) kernel 3.2.0-48-generic dmesg: http://pastebin.com/KF8ABwnY alsa-info: http://pastebin.com/QYBYNJi9 i read this topic: https://bugzilla.kernel.org/show_bug.cgi?id=18512 and tried to add "options snd-hda-intel model=6stack-dig single_cmd=1" to alsa-base.conf - it helped, after reboot i has sound, till i reboot - now no sound no more.. i tried everything i found in the google, even alsa-update - http://www.stchman.com/alsa_update.html nothing can help me, but i understand that's the problem is in the driver.. can someone pls help me to fix the problem? thank you.

1 0

[alsa-devel] cs42l52 alsa driver broken beep volume control
by Lars-Peter Clausen 20 Jun '13

20 Jun '13

Hi, I stumbled upon this while making some changes to the SOC_SINGLE_VALUE macro. For the Beep Volume control the cs42l52 driver sets the invert field to 7, which doesn't make much sense and is causing a build warning with my changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max 0x7 is right either. Also according to the datasheet the tlv dB info seems to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps. - Lars

2 2

[alsa-devel] [PATCH v8 00/11] ASoC: fsl-ssi: ac97-slave support
by Markus Pargmann 20 Jun '13

20 Jun '13

Hi, This series adds DT support for phycore-ac97. Beside ac97 support, the series adds imx-pcm-fiq and generic DMA bindings to fsl-ssi. In version 8 I fixed the build issues by seperating the DT capable ac97 phycore driver from the old driver. Regards, Markus Changes in v8: - Fix build issues in phycore-ac97. Changes in v7: - Only one soc_ac97_ops struct for both ssi drivers (fsl-ssi and imx-ssi) to make it possible to compile a kernel with both drivers. - Other small bug/style fixes described in the changelogs of the patches. Changes in v6: - Rebased onto 3.10-rc3 with Shawn's pcm cleanup patches - Setup of reset functions moved to phycore-ac97.c Changes in v5: - Pass of_node via parent device to imx-pcm-dma. Changes in v4: - phycore-ac97 uses the iomux functions based on audmux phandle now. - fsl-ssi imx-pcm-fiq got some new comments about problems with imx-ssi and incompatible codecs Changes in v3: - Rebased onto pcm dma cleanup patches - A lot of cleanups for the fsl-ssi ac97 integration - Some small changes which are listed in the notes of the patches. Markus Pargmann (11): ASoC: imx-pcm-dma: DT support ASoC: imx-pcm-fiq: Introduce pcm-fiq-params ASoC: fsl: Move soc_ac97_ops from imx-ssi to fsl_ssi ASoC: fsl-ssi: Add support for imx-pcm-fiq ASoC: fsl-ssi: Use generic DMA bindings if possible ASoC: fsl-ssi: imx ac97 support ARM: imx: Export ac97 reset functions ASoC: Add phycore-ac97-dt driver ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 ASoC: fsl: Move fsl-ssi binding doc to sound/ ASoC: fsl: Update fsl-ssi binding doc .../{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} | 10 + .../bindings/sound/phytec,phycore-ac97.txt | 14 + arch/arm/mach-imx/mach-pca100.c | 7 +- arch/arm/mach-imx/mach-pcm043.c | 7 +- sound/soc/fsl/Kconfig | 20 +- sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_ssi.c | 450 +++++++++++++++++---- sound/soc/fsl/fsl_ssi.h | 7 + sound/soc/fsl/imx-pcm-dma.c | 1 - sound/soc/fsl/imx-pcm-fiq.c | 18 +- sound/soc/fsl/imx-pcm.h | 15 +- sound/soc/fsl/imx-ssi.c | 14 +- sound/soc/fsl/imx-ssi.h | 1 + sound/soc/fsl/phycore-ac97-dt.c | 243 +++++++++++ sound/soc/fsl/phycore-ac97.c | 13 +- 15 files changed, 706 insertions(+), 116 deletions(-) rename Documentation/devicetree/bindings/{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} (88%) create mode 100644 Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt create mode 100644 sound/soc/fsl/phycore-ac97-dt.c

3 16

[alsa-devel] [PATCH] ASoC: SPEAr: Add device tree support + SPEAr machine driver
by Rajeev Kumar 20 Jun '13

20 Jun '13

The patch adds device tree support + SPEAr machine driver Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar(a)st.com> --- .../devicetree/bindings/sound/spear-evb.txt | 20 +++ sound/soc/spear/spear_evb.c | 135 ++++++++++++++++++++ 2 files changed, 155 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/spear-evb.txt create mode 100644 sound/soc/spear/spear_evb.c diff --git a/Documentation/devicetree/bindings/sound/spear-evb.txt b/Documentation/devicetree/bindings/sound/spear-evb.txt new file mode 100644 index 0000000..cb011b4 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/spear-evb.txt @@ -0,0 +1,20 @@ +* SPEAr audio sta529 codec + +Required properties: +- compatible: "spear,spear-evb" +- audio-controllers: The phandle list of synopsys audio i2s controller +- audio-codec: The phandle of the sta529 audio codec +- codec_dai_name: DAI name for codec. +- stream_name: stream name. + +Example: + +sound { + compatible = "spear,spear-evb"; + audio-controllers = <&i2s0 &i2s1>; + audio-codecs = <&sta529 &sta529>; + codec_dai_name = "sta529-audio", "sta529-audio"; + stream_name = "i2s-play", "i2s-cap"; + dai_name = "i2s0-pcm", "i2s1-pcm"; +}; + diff --git a/sound/soc/spear/spear_evb.c b/sound/soc/spear/spear_evb.c new file mode 100644 index 0000000..6da1732 --- /dev/null +++ b/sound/soc/spear/spear_evb.c @@ -0,0 +1,135 @@ +/* + * ASoC machine driver for SPEAr evaluation boards + * + * sound/soc/spear/spear_evb.c + * + * Copyright (C) 2010 ST Microelectronics + * Rajeev Kumar<rajeev-dlh.kumar(a)st.com> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +#include <linux/io.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/module.h> + +#include <sound/pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/spear_dma.h> + +struct snd_soc_card spear_soc_card; + +static int spear_evb_probe(struct platform_device *pdev) +{ + struct snd_soc_dai_link *evb_dai; + struct device_node *np = pdev->dev.of_node; + struct device_node *spear_audio_np, *codec_np; + int i, nr_controllers, ret = 0; + + if (!np) + return -EINVAL; /* no device tree */ + + of_property_read_u32(np, "nr_controllers", &nr_controllers); + + evb_dai = devm_kzalloc(&pdev->dev, + (nr_controllers * sizeof(*evb_dai)), GFP_KERNEL); + if (!evb_dai) { + dev_warn(&pdev->dev, "kzalloc fail for evb_dai\n"); + return -ENOMEM; + } + + for (i = 0; i < nr_controllers ; i++) { + spear_audio_np = of_parse_phandle(np, "audio-controllers", i); + codec_np = of_parse_phandle(np, "audio-codecs", i); + if (!spear_audio_np || !codec_np) { + dev_err(&pdev->dev, "phandle missing or invalid\n"); + return -EINVAL; + } + + ret = of_property_read_string_index(np, "dai_names", i, + &evb_dai[i].name); + if (ret < 0) { + dev_err(&pdev->dev, "Cannot parse names: %d\n", ret); + goto err; + } + + ret = of_property_read_string_index(np, "codec_dai_names", i, + &evb_dai[i].codec_dai_name); + if (ret < 0) { + dev_err(&pdev->dev, "Can't parse codec-dai-names: %d\n", + ret); + goto err; + } + ret = of_property_read_string_index(np, "stream_names", i, + &evb_dai[i].stream_name); + if (ret < 0) { + dev_err(&pdev->dev, "Cannot parse stream names: %d\n", + ret); + goto err; + } + + evb_dai[i].cpu_dai_name = NULL; + evb_dai[i].cpu_of_node = spear_audio_np; + evb_dai[i].platform_of_node = np; + evb_dai[i].codec_name = NULL; + evb_dai[i].codec_of_node = codec_np; + if (!(strcmp(evb_dai[i].codec_dai_name, "sta529-audio"))) + evb_dai[i].dai_fmt = SND_SOC_DAIFMT_I2S | + SND_SOC_DAIFMT_CBS_CFM; + of_node_put(spear_audio_np); + of_node_put(codec_np); + } + + spear_soc_card.name = "spear-evb"; + spear_soc_card.dai_link = evb_dai; + spear_soc_card.num_links = nr_controllers; + + spear_soc_card.dev = &pdev->dev; + platform_set_drvdata(pdev, &spear_soc_card); + + ret = snd_soc_register_card(&spear_soc_card); + if (ret) { + dev_err(&pdev->dev, "snd_soc_register_card failed: %d\n", ret); + goto err; + } + + return 0; +err: + return ret; +} + +static int spear_evb_remove(struct platform_device *pdev) +{ + struct snd_soc_card *spear_soc_card = platform_get_drvdata(pdev); + + snd_soc_unregister_card(spear_soc_card); + + return 0; +} + +static const struct of_device_id spear_evb_dt_ids[] = { + { .compatible = "spear,spear-evb", }, + { } +}; +MODULE_DEVICE_TABLE(of, spear_evb_dt_ids); + +static struct platform_driver spear_evb_driver = { + .driver = { + .name = "spear-evb", + .owner = THIS_MODULE, + .pm = &snd_soc_pm_ops, + .of_match_table = spear_evb_dt_ids, + }, + .probe = spear_evb_probe, + .remove = spear_evb_remove, +}; + +module_platform_driver(spear_evb_driver); + +MODULE_AUTHOR("Rajeev Kumar <rajeev-dlh.kumar(a)st.com>"); +MODULE_DESCRIPTION("ST SPEAr EVB ASoC driver"); +MODULE_LICENSE("GPL"); -- 1.6.0.2

2 1

[alsa-devel] [PATCH] sound: using strlcpy instead of strncpy
by Zhao Hongjiang 20 Jun '13

20 Jun '13

for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Zhao Hongjiang <zhaohongjiang(a)huawei.com> --- sound/oss/soundcard.c | 2 +- sound/soc/codecs/88pm860x-codec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c index e778034..53ac987 100644 --- a/sound/oss/soundcard.c +++ b/sound/oss/soundcard.c @@ -99,7 +99,7 @@ int *load_mixer_volumes(char *name, int *levels, int present) } n = num_mixer_volumes++; - strncpy(mixer_vols[n].name, name, 32); + strlcpy(mixer_vols[n].name, name, sizeof(mixer_vols[n].name)); if (present) mixer_vols[n].num = n; diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c index 60159c0..6b2e6b3 100644 --- a/sound/soc/codecs/88pm860x-codec.c +++ b/sound/soc/codecs/88pm860x-codec.c @@ -1447,7 +1447,7 @@ static int pm860x_codec_probe(struct platform_device *pdev) goto out; } pm860x->irq[i] = res->start + chip->irq_base; - strncpy(pm860x->name[i], res->name, MAX_NAME_LEN); + strlcpy(pm860x->name[i], res->name, sizeof(pm860x->name[i])); } ret = snd_soc_register_codec(&pdev->dev, &soc_codec_dev_pm860x, -- 1.7.1

2 1

[alsa-devel] [PATCH] ALSA: hda - Make Thinkpad X220-tablet use generic parser
by David Henningsson 20 Jun '13

20 Jun '13

Like the X220, this quirk was added to support docking station, so enable the fixup instead. According to Jan, the generic parser works equal or better than the current parser. This was tested under a 3.9 kernel. Reported-by: Jan Alexander Steffens <jan.steffens(a)gmail.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_conexant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index b314d3e..de00ce1 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -2947,7 +2947,6 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD), SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD), SND_PCI_QUIRK(0x17aa, 0x21c6, "Thinkpad Edge 13", CXT5066_ASUS), - SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT5066_THINKPAD), SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo U350", CXT5066_ASUS), SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS), {} @@ -3318,6 +3317,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x17aa, 0x21ce, "Lenovo T420", CXT_PINCFG_LENOVO_TP410), SND_PCI_QUIRK(0x17aa, 0x21cf, "Lenovo T520", CXT_PINCFG_LENOVO_TP410), SND_PCI_QUIRK(0x17aa, 0x21da, "Lenovo X220", CXT_PINCFG_LENOVO_TP410), + SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT_PINCFG_LENOVO_TP410), SND_PCI_QUIRK(0x17aa, 0x3975, "Lenovo U300s", CXT_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x17aa, 0x3977, "Lenovo IdeaPad U310", CXT_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x17aa, 0x397b, "Lenovo S205", CXT_FIXUP_STEREO_DMIC), -- 1.7.9.5

2 1

[alsa-devel] [alsa-ucm] segfault at __list_del function in list.h
by sajeesh sidharthan 20 Jun '13

20 Jun '13

Hello. I am testing pulseaudio ucm. I have faced a crash when active ucm device list empty. Please let me know if following fix can be checked in alsa-lib-1.0.25/include/list.h old code: static __inline__ void list_del(struct list_head *entry) { __list_del(entry->prev, entry->next); } new code: static __inline__ void list_del(struct list_head *entry) { if(entry->prev && entry->next) __list_del(entry->prev, entry->next); } Sajeesh

1 0

Re: [alsa-devel] [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA
by Mark Brown 20 Jun '13

20 Jun '13

On Wed, Jun 19, 2013 at 09:32:44PM +0200, Tomasz Figa wrote: > On Wednesday 19 of June 2013 20:22:11 Mark Brown wrote: > > No, I didn't - that's most likely it, I didn't really investigate. I > > didn't test the watchdog stuff as the clocks didn't get sent to me. > I always try to keep you on Cc of my patches for s3c64xx, as you are the > most active user of this platform (if not the only one other than me) and > this was the case for clock patches as well, just checked that. Yes, I had the clock patches but they depended on something or other I think. I did test a previous verion IIRC. There are other users I'm aware of (you can probably take a wild guess where from the board) though they tend not to be terribly active upstream.

1 0