April 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] How to create and verify verb tables for coreboot?
by Paul Menzel 02 Apr '13

02 Apr '13

Dear ALSA folks, coreboot is a free replacement for the traditional BIOS [1]. Therefore coreboot is also responsible for providing the correct verb table [2]. According to Jens the Verb Table format is not documented and is created by for example Realtek [3]. Could you give some more information about the verb table and how this can be created from scratch? Our developer Rudolf suggests to take the values from /sys/class/sound/hwC1D0/init_pin_configs when running the vendor BIOS [2]. How can a correct verb table be verified? As for the ASRock E350M1 [4][5], I attach the output of `alsa-info.sh` [6] when running coreboot. The one running with the vendor BIOS is uploaded to the server [7] due to the size limit of this mailing list. $ wdiff vendorbios coreboot # init_pin_configs 0x11 [-0x411111f0-] {+0x411110f0+} 0x12 0x411111f0 0x14 [-0x01014010-] {+0x01014030+} 0x15 [-0x01011012-] {+0x01011031+} 0x16 [-0x01016011-] {+0x01016032+} 0x17 [-0x411111f0-] {+0x01012033+} 0x18 [-0x01a19840-] {+0x01a19850+} 0x19 [-0x02a19950-] {+0x02a19c80+} 0x1a [-0x0181304f-] {+0x01813051+} 0x1b [-0x02214120-] {+0x02214c40+} 0x1c [-0x411111f0-] {+0x9933105f+} 0x1d [-0x4005e601-] {+0x00000100+} 0x1e [-0x01452130-] {+0x01441070+} 0x1f [-0x411111f0-] {+0x41c46060+} Thanks, Paul [1] http://www.coreboot.org/ [2] http://www.coreboot.org/pipermail/coreboot/2013-March/075547.html [3] http://review.coreboot.org/#/c/2553/1/src/mainboard/lippert/frontrunner-af/… [4] http://www.coreboot.org/ASRock_E350M1 [5] http://www.coreboot.org/pipermail/coreboot/2013-March/075557.html [6] http://alsa-project.org/main/index.php/Help_To_Debug [7] http://www.alsa-project.org/db/?f=96ff75103a48ab8e58a216bd12f65d2755679cdc

2 1

[alsa-devel] [PATCH v2 2/2] ALSA: hda - bug fix on HDMI ELD debug message
by mengdong.lin＠intel.com 02 Apr '13

02 Apr '13

From: Mengdong Lin <mengdong.lin(a)intel.com> This patch let ELD debug message show 'pin_eld->monitor_present' which reflects the real pin response to verb GET_PIN_SENSE. 'eld->monitor_present' should not be used here because 'eld' is a temp structure now and so its "monitor_present" is not set. Signed-off-by: Mengdong Lin <mengdong.lin(a)intel.com> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 78e1827..de8ac5c 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1196,7 +1196,7 @@ static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll) _snd_printd(SND_PR_VERBOSE, "HDMI status: Codec=%d Pin=%d Presence_Detect=%d ELD_Valid=%d\n", - codec->addr, pin_nid, eld->monitor_present, eld->eld_valid); + codec->addr, pin_nid, pin_eld->monitor_present, eld->eld_valid); if (eld->eld_valid) { if (snd_hdmi_get_eld(codec, pin_nid, eld->eld_buffer, -- 1.7.10.4

3 2

[alsa-devel] [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info
by mengdong.lin＠intel.com 02 Apr '13

02 Apr '13

From: Mengdong Lin <mengdong.lin(a)intel.com> In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0. Otherwise it will be returned uninitialized as non-zero after ELD info is got successfully. Thus hdmi_present_sense() will always assume ELD info is invalid by mistake, and /proc file system cannot show the proper ELD info. Signed-off-by: Mengdong Lin <mengdong.lin(a)intel.com> diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c index 7dd8463..d0d7ac1 100644 --- a/sound/pci/hda/hda_eld.c +++ b/sound/pci/hda/hda_eld.c @@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid, unsigned char *buf, int *eld_size) { int i; - int ret; + int ret = 0; int size; /* -- 1.7.10.4

3 2

[alsa-devel] ASoC updates for v3.9
by Mark Brown 02 Apr '13

02 Apr '13

The following changes since commit 8bb9660418e05bb1845ac1a2428444d78e322cc7: Linux 3.9-rc4 (2013-03-23 16:52:44 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v3.9-rc4 for you to fetch changes up to 40bac28eb1e39f229a94ad72e2ca8cdeef3ba31a: Merge remote-tracking branch 'asoc/fix/spear' into asoc-next (2013-03-26 14:08:07 +0000) ---------------------------------------------------------------- ASoC: Fixes for v3.9 A few more fixes here and there, including quite a few nasty driver specific ones, but nothing that has a major general impact. ---------------------------------------------------------------- Axel Lin (1): ASoC: si476x: Add missing break for SNDRV_PCM_FORMAT_S8 switch case Joe Perches (1): ASoC:: max98090: Remove executable bit Lars-Peter Clausen (2): ASoC: spear_pcm: Update to new pcm_new() API ASoC: dma-sh7760: Fix compile error Mark Brown (9): ASoC: dapm: Fix handling of loops Merge remote-tracking branch 'asoc/fix/adsp' into asoc-next Merge remote-tracking branch 'asoc/fix/core' into asoc-next Merge remote-tracking branch 'asoc/fix/dapm' into asoc-next Merge remote-tracking branch 'asoc/fix/fsl' into asoc-next Merge remote-tracking branch 'asoc/fix/max98090' into asoc-next Merge remote-tracking branch 'asoc/fix/sh' into asoc-next Merge remote-tracking branch 'asoc/fix/si476x' into asoc-next Merge remote-tracking branch 'asoc/fix/spear' into asoc-next Markus Pargmann (1): ASoC: pcm030 audio fabric: remove __init from probe Peter Ujfalusi (1): ASoC: dapm: Fix pointer dereference in is_connected_output_ep() Sascha Hauer (1): ASoC: imx-ssi: Fix occasional AC97 reset failure Silviu-Mihai Popescu (1): ASoC: core: fix invalid free of devm_ allocated data Wei Yongjun (2): ASoC: wm_adsp: fix possible memory leak in wm_adsp_load_coeff() ASoC: core: fix possible memory leak in snd_soc_bytes_put() include/sound/soc-dapm.h | 1 + sound/soc/codecs/si476x.c | 1 + sound/soc/codecs/wm_adsp.c | 5 +++-- sound/soc/fsl/imx-ssi.c | 5 +++++ sound/soc/fsl/pcm030-audio-fabric.c | 2 +- sound/soc/sh/dma-sh7760.c | 4 ++-- sound/soc/soc-core.c | 8 ++++---- sound/soc/soc-dapm.c | 14 ++++++++++++++ sound/soc/spear/spear_pcm.c | 12 ++++++------ 9 files changed, 37 insertions(+), 15 deletions(-) mode change 100755 => 100644 include/sound/max98090.h mode change 100755 => 100644 sound/soc/codecs/max98090.c mode change 100755 => 100644 sound/soc/codecs/max98090.h

2 2

[alsa-devel] [PATCH] ALSA: hda/ca0132 - Delay HP amp turnon.
by Dylan Reid 02 Apr '13

02 Apr '13

From: Chih-Chung Chang <chihchung(a)chromium.org> Turing on the headphone amp interferes with the impedance measurement used to detect a TRRS style headset microphone. Delay the HP turn on until 500ms after the jack is detected, allowing the mic detection state machine to run to completion. Signed-off-by: Chih-Chung Chang <chihchung(a)chromium.org> Signed-off-by: Dylan Reid <dgreid(a)chromium.org> --- sound/pci/hda/patch_ca0132.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 0792b57..12eb21a 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -741,6 +741,9 @@ struct ca0132_spec { long voicefx_val; long cur_mic_boost; + struct hda_codec *codec; + struct delayed_work unsol_hp_work; + #ifdef ENABLE_TUNING_CONTROLS long cur_ctl_vals[TUNING_CTLS_COUNT]; #endif @@ -3227,6 +3230,14 @@ exit: return err < 0 ? err : 0; } +static void ca0132_unsol_hp_delayed(struct work_struct *work) +{ + struct ca0132_spec *spec = container_of( + to_delayed_work(work), struct ca0132_spec, unsol_hp_work); + ca0132_select_out(spec->codec); + snd_hda_jack_report_sync(spec->codec); +} + static void ca0132_set_dmic(struct hda_codec *codec, int enable); static int ca0132_mic_boost_set(struct hda_codec *codec, long val); static int ca0132_effects_set(struct hda_codec *codec, hda_nid_t nid, long val); @@ -4399,8 +4410,7 @@ static void ca0132_process_dsp_response(struct hda_codec *codec) static void ca0132_unsol_event(struct hda_codec *codec, unsigned int res) { - snd_printdd(KERN_INFO "ca0132_unsol_event: 0x%x\n", res); - + struct ca0132_spec *spec = codec->spec; if (((res >> AC_UNSOL_RES_TAG_SHIFT) & 0x3f) == UNSOL_TAG_DSP) { ca0132_process_dsp_response(codec); @@ -4412,8 +4422,13 @@ static void ca0132_unsol_event(struct hda_codec *codec, unsigned int res) switch (res) { case UNSOL_TAG_HP: - ca0132_select_out(codec); - snd_hda_jack_report_sync(codec); + /* Delay enabling the HP amp, to let the mic-detection + * state machine run. + */ + cancel_delayed_work_sync(&spec->unsol_hp_work); + queue_delayed_work(codec->bus->workq, + &spec->unsol_hp_work, + msecs_to_jiffies(500)); break; case UNSOL_TAG_AMIC1: ca0132_select_mic(codec); @@ -4588,6 +4603,7 @@ static void ca0132_free(struct hda_codec *codec) { struct ca0132_spec *spec = codec->spec; + cancel_delayed_work_sync(&spec->unsol_hp_work); snd_hda_power_up(codec); snd_hda_sequence_write(codec, spec->base_exit_verbs); ca0132_exit_chip(codec); @@ -4653,6 +4669,7 @@ static int patch_ca0132(struct hda_codec *codec) if (!spec) return -ENOMEM; codec->spec = spec; + spec->codec = codec; spec->num_mixers = 1; spec->mixers[0] = ca0132_mixer; @@ -4663,6 +4680,8 @@ static int patch_ca0132(struct hda_codec *codec) spec->init_verbs[1] = ca0132_init_verbs1; spec->num_init_verbs = 2; + INIT_DELAYED_WORK(&spec->unsol_hp_work, ca0132_unsol_hp_delayed); + ca0132_init_chip(codec); ca0132_config(codec); -- 1.8.1.3.605.g02339dd

2 1

Re: [alsa-devel] [PATCH] sound: oss: sb_common: Used kmemdup instead of kmalloc and memcpy
by Takashi Iwai 02 Apr '13

02 Apr '13

At Mon, 25 Mar 2013 15:50:34 +0200, Alexandru Gheorghiu wrote: > > Used kmemdup instead of replicating it's behaviour with kmalloc followed > by memcpy. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu <gheorghiuandru(a)gmail.com> Thanks, applied. Takashi > --- > sound/oss/sb_common.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/oss/sb_common.c b/sound/oss/sb_common.c > index 7d42c54..851a1da 100644 > --- a/sound/oss/sb_common.c > +++ b/sound/oss/sb_common.c > @@ -626,13 +626,12 @@ int sb_dsp_detect(struct address_info *hw_config, int pci, int pciio, struct sb_ > */ > > > - detected_devc = kmalloc(sizeof(sb_devc), GFP_KERNEL); > + detected_devc = kmemdup(devc, sizeof(sb_devc), GFP_KERNEL); > if (detected_devc == NULL) > { > printk(KERN_ERR "sb: Can't allocate memory for device information\n"); > return 0; > } > - memcpy(detected_devc, devc, sizeof(sb_devc)); > MDB(printk(KERN_INFO "SB %d.%02d detected OK (%x)\n", devc->major, devc->minor, hw_config->io_base)); > return 1; > } > -- > 1.7.9.5 >

1 0

Re: [alsa-devel] [PATCH] sound: oss: uart401: Used kmemdup instead of kmalloc and memcpy
by Takashi Iwai 02 Apr '13

02 Apr '13

At Mon, 25 Mar 2013 15:46:49 +0200, Alexandru Gheorghiu wrote: > > Used kmemdup instead of replicating it's behaviour with kmalloc followed > by memcpy. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu <gheorghiuandru(a)gmail.com> Thanks, applied. Takashi > --- > sound/oss/uart401.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/sound/oss/uart401.c b/sound/oss/uart401.c > index 8e514a6..5433c6f 100644 > --- a/sound/oss/uart401.c > +++ b/sound/oss/uart401.c > @@ -352,23 +352,26 @@ int probe_uart401(struct address_info *hw_config, struct module *owner) > goto cleanup_irq; > } > conf_printf(name, hw_config); > - midi_devs[devc->my_dev] = kmalloc(sizeof(struct midi_operations), GFP_KERNEL); > + midi_devs[devc->my_dev] = kmemdup(&uart401_operations, > + sizeof(struct midi_operations), > + GFP_KERNEL); > if (!midi_devs[devc->my_dev]) { > printk(KERN_ERR "uart401: Failed to allocate memory\n"); > goto cleanup_unload_mididev; > } > - memcpy(midi_devs[devc->my_dev], &uart401_operations, sizeof(struct midi_operations)); > > if (owner) > midi_devs[devc->my_dev]->owner = owner; > > midi_devs[devc->my_dev]->devc = devc; > - midi_devs[devc->my_dev]->converter = kmalloc(sizeof(struct synth_operations), GFP_KERNEL); > + midi_devs[devc->my_dev]->converter = kmemdup(&std_midi_synth, > + sizeof(struct synth_operations), > + GFP_KERNEL); > + > if (!midi_devs[devc->my_dev]->converter) { > printk(KERN_WARNING "uart401: Failed to allocate memory\n"); > goto cleanup_midi_devs; > } > - memcpy(midi_devs[devc->my_dev]->converter, &std_midi_synth, sizeof(struct synth_operations)); > strcpy(midi_devs[devc->my_dev]->info.name, name); > midi_devs[devc->my_dev]->converter->id = "UART401"; > midi_devs[devc->my_dev]->converter->midi_dev = devc->my_dev; > -- > 1.7.9.5 >

1 0

[alsa-devel] [PATCH] USB-audio: Add "HP Digital Stereo Headset" to SPDIF blacklist
by David Henningsson 02 Apr '13

02 Apr '13

Yet another headset without digital I/O. Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- src/conf/cards/USB-Audio.conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf index 177a7af..71c2971 100644 --- a/src/conf/cards/USB-Audio.conf +++ b/src/conf/cards/USB-Audio.conf @@ -39,7 +39,8 @@ USB-Audio.pcm.iec958_device { # The below don't have digital in/out, so prevent them from being opened. "Blue Snowball" 999 - "Logitech Speaker Lapdesk N700" 999 + "HP Digital Stereo Headset" 999 + "Logitech Speaker Lapdesk N700" 999 "Logitech USB Headset" 999 "Logitech Wireless Headset" 999 "Plantronics GameCom 780" 999 -- 1.7.9.5

2 1

Re: [alsa-devel] [PATCH] ASoC: codecs: remove hidden prompt
by Mark Brown 01 Apr '13

01 Apr '13

On Tue, Mar 12, 2013 at 09:08:38PM +0100, Paul Bolle wrote: > The Kconfig symbol SND_SOC_OF_SIMPLE got removed in commit > f0fba2ad1b6b53d5360125c41953b7afcd6deff0 ("ASoC: multi-component - ASoC > Multi-Component Support"). But that commit missed one instance. Remove > it now, together with the prompt it has effectively hidden ever since. Applied, thanks.

1 0

[alsa-devel] [PATCH] ASoC: dapm: Remove redundant clear_walk() for supply widgets
by Mark Brown 01 Apr '13

01 Apr '13

From: Ryo Tsutsui <Ryo.Tsutsui(a)wolfsonmicro.com> We already clear the walked state in dapm_widget_power_check(), no need to do it again. Signed-off-by: Ryo Tsutsui <Ryo.Tsutsui(a)wolfosonmicro.com> Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/soc-dapm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 1896a70..0a395eb 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -1179,8 +1179,6 @@ static int dapm_supply_check_power(struct snd_soc_dapm_widget *w) return 1; } - dapm_clear_walk(w->dapm); - return 0; } -- 1.7.10.4

2 1