April 2011 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: WM8903: Implement DMIC support
by Stephen Warren 14 Oct '11

14 Oct '11

In addition to the currently supported analog capture path, the WM8903 also supports digital mics. The analog and digital capture paths are exclusive; a mux is present to select the capture source. Logically, the mux exists to select the decimator's input, from either the ADC or DMIC block outputs. However, the ADC power domain also includes the DMIC interface. Consequently, this change represents the mux as existing immediately before the ADC, and selecting between the Input PGA and DMIC block outputs. An alternative might be to represent the mux in its correct location, and associate the ADC power enable controls with both the real ADC, and a fake ADC for the DMIC? Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- sound/soc/codecs/wm8903.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index d53f206..f3cab84 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -634,6 +634,13 @@ static const struct soc_enum lsidetone_enum = static const struct soc_enum rsidetone_enum = SOC_ENUM_SINGLE(WM8903_DAC_DIGITAL_0, 0, 3, sidetone_text); +static const char *adcinput_text[] = { + "ADC", "DMIC" +}; + +static const struct soc_enum adcinput_enum = + SOC_ENUM_SINGLE(WM8903_CLOCK_RATE_TEST_4, 9, 2, adcinput_text); + static const char *aif_text[] = { "Left", "Right" }; @@ -767,6 +774,9 @@ static const struct snd_kcontrol_new lsidetone_mux = static const struct snd_kcontrol_new rsidetone_mux = SOC_DAPM_ENUM("DACR Sidetone Mux", rsidetone_enum); +static const struct snd_kcontrol_new adcinput_mux = + SOC_DAPM_ENUM("ADC Input", adcinput_enum); + static const struct snd_kcontrol_new lcapture_mux = SOC_DAPM_ENUM("Left Capture Mux", lcapture_enum); @@ -817,6 +827,7 @@ SND_SOC_DAPM_INPUT("IN2L"), SND_SOC_DAPM_INPUT("IN2R"), SND_SOC_DAPM_INPUT("IN3L"), SND_SOC_DAPM_INPUT("IN3R"), +SND_SOC_DAPM_INPUT("DMICDAT"), SND_SOC_DAPM_OUTPUT("HPOUTL"), SND_SOC_DAPM_OUTPUT("HPOUTR"), @@ -842,6 +853,9 @@ SND_SOC_DAPM_MUX("Right Input Mode Mux", SND_SOC_NOPM, 0, 0, &rinput_mode_mux), SND_SOC_DAPM_PGA("Left Input PGA", WM8903_POWER_MANAGEMENT_0, 1, 0, NULL, 0), SND_SOC_DAPM_PGA("Right Input PGA", WM8903_POWER_MANAGEMENT_0, 0, 0, NULL, 0), +SND_SOC_DAPM_MUX("Left ADC Input", SND_SOC_NOPM, 0, 0, &adcinput_mux), +SND_SOC_DAPM_MUX("Right ADC Input", SND_SOC_NOPM, 0, 0, &adcinput_mux), + SND_SOC_DAPM_ADC("ADCL", NULL, WM8903_POWER_MANAGEMENT_6, 1, 0), SND_SOC_DAPM_ADC("ADCR", NULL, WM8903_POWER_MANAGEMENT_6, 0, 0), @@ -979,6 +993,11 @@ static const struct snd_soc_dapm_route wm8903_intercon[] = { { "Left Input PGA", NULL, "Left Input Mode Mux" }, { "Right Input PGA", NULL, "Right Input Mode Mux" }, + { "Left ADC Input", "ADC", "Left Input PGA" }, + { "Left ADC Input", "DMIC", "DMICDAT" }, + { "Right ADC Input", "ADC", "Right Input PGA" }, + { "Right ADC Input", "DMIC", "DMICDAT" }, + { "Left Capture Mux", "Left", "ADCL" }, { "Left Capture Mux", "Right", "ADCR" }, @@ -988,9 +1007,9 @@ static const struct snd_soc_dapm_route wm8903_intercon[] = { { "AIFTXL", NULL, "Left Capture Mux" }, { "AIFTXR", NULL, "Right Capture Mux" }, - { "ADCL", NULL, "Left Input PGA" }, + { "ADCL", NULL, "Left ADC Input" }, { "ADCL", NULL, "CLK_DSP" }, - { "ADCR", NULL, "Right Input PGA" }, + { "ADCR", NULL, "Right ADC Input" }, { "ADCR", NULL, "CLK_DSP" }, { "Left Playback Mux", "Left", "AIFRXL" }, -- 1.7.1

4 4

[alsa-devel] [ASoc] TDM over one SSC channel on AT91 possible?
by Friedrich Lobenstock 24 Jun '11

24 Jun '11

Hello! The background: I'm just designing an ATMEL AT91RM9200 based board which got two TLV320AIC33 on board. It is either possible to hook up the two TLV320AIC33 to a separate SSC (synchronous serial control) channel each or use one SSC channel and configure it for TDM (time division multiplex) mode. There is already a driver for TLV320AIC14k/TLV320AIC2k in the development tree, so adding support for the TLV320AIC33 should be feasible. What I'm not sure about is the fact if ASOC is prepared for using channels, especially SSC, in TDM mode. Is the core ASOC structure prepared to handle that? Would we be better off instantiate one drive twice each time with different parameters for the SSC channel? Thanks for any feedback. -- MfG / Regards Friedrich Lobenstock _________________________________________________________ SCOTTY Group Austria GmbH a SCOTTY Group plc company, http://www.scottygroup.com/ _________________________________________________________

4 3

Re: [alsa-devel] [PATCH] ASoC: Add support for Cirrus Logic CS42L52 Lowpower Stereo Codec
by Mark Brown 22 Jun '11

22 Jun '11

On Thu, Feb 25, 2010 at 06:07:35PM -0600, Brian wrote: This is a quick first pass review only. It'd be best if you could include a Signed-off-by line in submissions so that they can be merged if they're OK, even if you expect problems you may be surprised! Overall this looks fairly good - there's a lot of comments below but the vast majority of them are stylistic issues or needing to update to current APIs rather than major structural problems with the code. The main thing I don't really follow is the register access code, there's quite a bit of stuff going on in there. > + * published by the Free Software Foundation. > + * Revision history > + * Nov 2007 Initial version. > + * Oct 2008 Updated to 2.6.26 > + * Feb 2010 Updated to latest asoc git tree Please remove the changelog, once things are merged git takes care of that. > + */ > +#define DEBUG Not by default in mainline :) > +#ifdef DEBUG > +#define SOCDBG(fmt, arg...) printk(KERN_ERR "%s: %s() " fmt, SOC_CS42L52_NAME, __FUNCTION__, ##arg) > +#else > +#define SOCDBG(fmt, arg...) > +#endif > +#define SOCINF(fmt, args...) printk(KERN_INFO "%s: " fmt, SOC_CS42L52_NAME, ##args) > +#define SOCERR(fmt, args...) printk(KERN_ERR "%s: " fmt, SOC_CS42L52_NAME, ##args) Please convert the driver to use the standard dev_ and pr_ macros for this (where possible the dev_ ones are better). > +static int soc_cs42l52_set_bias_level(struct snd_soc_codec *codec, > + enum snd_soc_bias_level level); > +static int soc_cs42l52_pcm_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai); > +static int soc_cs42l52_set_sysclk(struct snd_soc_dai *codec_dai, > + int clk_id, u_int freq, int dir); > +static int soc_cs42l52_digital_mute(struct snd_soc_dai *dai, int mute); > +static int soc_cs42l52_set_fmt(struct snd_soc_dai *codec_dai, > + u_int fmt); > + > +static unsigned int soc_cs42l52_read(struct snd_soc_codec *codec, > + u_int reg); Please use 'unsigned int' rather than 'u_int' for consistency with the rest of ASoC. It's a bit surprising that you need the forward declarations at all but they do no harm. > +/** > + * snd_soc_get_volsw - single mixer get callback > + * @kcontrol: mixer control > + * @uinfo: control element information > + * > + * Callback to get the value of a single mixer control. > + * > + * Returns 0 for success. > + */ > +int snd_soc_cs42l5x_get_volsw(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); > + int reg = kcontrol->private_value & 0xff; The indentation looks wrong - should be tabs for indenting the code blocks. scripts/checkpatch.pl is a pretty good check for this sort of stuff, I'll not mention other issues. > + int shift = (kcontrol->private_value >> 8) & 0x0f; > + int rshift = (kcontrol->private_value >> 12) & 0x0f; > + int max = (kcontrol->private_value >> 16) & 0xff; > + int mask = (1 << fls(max)) - 1; > + int min = (kcontrol->private_value >> 24) & 0xff; > + > + ucontrol->value.integer.value[0] = > + ((snd_soc_read(codec, reg) >> shift) - min) & mask; > + if (shift != rshift) > + ucontrol->value.integer.value[1] = > + ((snd_soc_read(codec, reg) >> rshift) - min) & mask; This and most of the other custom control stuff looks an awful lot like it should be done by adding a SND_SOC_DOUBLE_SIGNED() or something along the lines of the existing _S8() but I didn't read entirely closely. I was speaking to someone on IRC only the other day who needed some of those types for a different device. These should also be updated to use struct soc_mixer_control for the private value rather than shifting everything into the private value, it allows wider ranges and is less error prone. > +static const u8 soc_cs42l52_reg_default[] = { > + 0x00, 0xE0, 0x01, 0x07, 0x05, /*4*/ > + 0xa0, 0x00, 0x00, 0x81, /*8*/ Very nitpicky but you're using a mix of upper and lower case for the letters in the hex digits. > +static inline int soc_cs42l52_read_reg_cache(struct snd_soc_codec *codec, > + u_int reg) > +{ > + u8 *cache = codec->reg_cache; > + > + return reg > SOC_CS42L52_REG_NUM ? -EINVAL : cache[reg]; > +} You should be able to replace all your register I/O code with use of soc-cache.c with 8 bit data, 8 bit register. Except... > + if(info->flags & SOC_CS42L52_ALL_IN_ONE) > + { > + for(i = 0; i < codec->num_dai; i++) > + { > + if(info->machine_handler) > + info->machine_handler(i); ...I'm not sure what's going on here but it could really use an explanation? I'm not sure what ALL_IN_ONE is supposed to do, or what the machine_handler() function is for. > + if(info->flags & SOC_CS42L52_CHIP_SWICTH) > + { > + num = info->flags & SOC_CS42L52_CHIP_MASK; > + if(info->machine_handler) > + info->machine_handler(num); > + } This too. There's a lot of unusual code using this machine handler function. I suspect this can all use ASoC standard stuff. > +static inline int soc_cs42l52_get_revison(struct snd_soc_codec *codec) > +{ > + u8 data; > + u8 addr; > + int num, ret = 0; > + struct soc_codec_cs42l52 *info = (struct soc_codec_cs42l52*)codec->private_data; No need to cast away from void (quite a few examples of this in the code). > + return ret < 0 ? ret : data; I'm not a big fan of the ternery operator... > +static unsigned int soc_cs42l52_read(struct snd_soc_codec *codec, > + u_int reg) > +{ > + u8 data; > + u8 addr; > + int i, ret = 0; > + struct soc_codec_cs42l52 *info = (struct soc_codec_cs42l52*)codec->private_data; > +#ifndef CONFIG_CS42L52_DEBUG > + if(reg == CODEC_CS42L52_SPK_STATUS) > + { > +#endif This really shouldn't be ifdefed. If you need to handle registers that report status from the device with the soc-cache stuff use the volatile_register() callback in the CODEC, any registers that need a CODEC read will call through to the hardware rather than using the cache. > +static const char *cs42l52_adc_mux[] = {"AIN1", "AIN2", "AIN3", "AIN4", "PGA"}; > +static const char *cs42l52_mic_mux[] = {"MIC1", "MIC2"}; > +static const char *cs42l52_stereo_mux[] = {"Mono", "Stereo"}; > +static const char *cs42l52_off[] = {"On", "Off"}; > +static const char *cs42l52_hpmux[] = {"Off", "On"}; > + > +static const struct soc_enum soc_cs42l52_enum[] = { > +SOC_ENUM_DOUBLE(CODEC_CS42L52_ANALOG_HPF_CTL, 4, 6, 2, cs42l52_hpf_freeze), /*0*/ > +SOC_ENUM_SINGLE(CODEC_CS42L52_ADC_HPF_FREQ, 0, 4, cs42l52_hpf_corner_freq), Don't use an array of enums, define individual variables for them. Some drivers use the arrays for historical reasons - they're quite painful to work with if you ever want to change anything in the middle and we've found a few off by one errors in the referencing into the arrays before :/. > +static const struct snd_kcontrol_new soc_cs42l52_controls[] = { > + > +SOC_ENUM("Mic VA Capture Switch", soc_cs42l52_enum[18]), /*0*/ enums shouldn't be called Switch - Switch has a specific meaning to ALSA (see Documentation/sound/alsa/ControlNames.txt, there's quite a few other controls could do with having the components of the name reordered and various other things following that). Normally just omit the ' Switch' from the name. > +SOC_DOUBLE("Analog SR Capture Switch", CODEC_CS42L52_ANALOG_HPF_CTL, 1, 3, 1, 1), > +SOC_DOUBLE("Analog ZC Capture Switch", CODEC_CS42L52_ANALOG_HPF_CTL, 0, 2, 1, 1), This'd normally be 'Capture ZC Switch' if it's for zero cross. > +SOC_ENUM("HPF corner freq Capture Switch", soc_cs42l52_enum[1]), /*5*/ > + > +SOC_SINGLE("Ganged Ctl Capture Switch", CODEC_CS42L52_ADC_MISC_CTL, 7, 1, 1), /* should be enabled init */ What does the comment mean here? > +SOC_SINGLE("HP Analog Gain Playback Volume", CODEC_CS42L52_PB_CTL1, 5, 7, 0), Just "Headphone Volume"? > +SOC_SINGLE("Playback B=A Volume Playback Switch", CODEC_CS42L52_PB_CTL1, 4, 1, 0), /*10*/ /*should be enabled init*/ If this is the mute for the headphone volume it should have the same name but with Switch instead of Volume so applications like alsamixer can display the two together. > +static int soc_cs42l52_add_controls(struct snd_soc_codec *codec) > +{ > + int i,ret = 0; > + > + for(i = 0; i < ARRAY_SIZE(soc_cs42l52_controls); i++) > + { > + ret = snd_ctl_add(codec->card, > + snd_soc_cnew(&soc_cs42l52_controls[i], codec, NULL)); > + if(ret < 0) > + { > + SOCDBG("add cs42l52 controls failed\n"); > + break; Replace this with snd_soc_add_controls(). > + /* Sum switches */ > + SND_SOC_DAPM_PGA("AIN1A Switch", CODEC_CS42L52_ADC_PGA_A, 0, 0, NULL, 0), Without having checked the datasheet I *suspect* most of these switches should be modelled as inputs to a mixer (possibly one with no power control of its own)? The "Switch" in the name certainly looks very out of place in the name of a DAPM control. > + /* Output path */ > + SND_SOC_DAPM_MUX("Passthrough Left Playback Switch", SND_SOC_NOPM, 0, 0, &cs42l52_hpa_mux), Normally "Bypass" instead of "Passthrough". > + /* Mic Bias */ > + {"Mic Bias Capture Switch", "On", "PGA MICA"}, > + {"Mic Bias Capture Switch", "On", "PGA MICB"}, > + {"Mic-Bias", NULL, "Mic Bias Capture Switch"}, > + {"Mic-Bias", NULL, "Mic Bias Capture Switch"}, > + {"ADC Mux Left Capture Switch", "PGA", "Mic-Bias"}, > + {"ADC Mux Right Capture Switch", "PGA", "Mic-Bias"}, > + {"Passthrough Left Playback Switch", "On", "Mic-Bias"}, > + {"Passthrough Right Playback Switch", "On", "Mic-Bias"}, This looks odd - normally the microphone bias would be connected to the microphone input externally and would not be hooked up as an input wihtin the CODEC? > + /* terminator */ > + {NULL, NULL, NULL}, Not needed any more (I'm vaugely surprised this doesn't generate an error). > +#define SOC_CS42L52_RATES ( SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 | \ > + SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 | \ > + SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | \ > + SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 | \ > + SNDRV_PCM_RATE_96000 ) /*refer to cs42l52 datasheet page35*/ This is equivalent to SNDRV_PCM_RATE_8000_96000 > +/* #define CONFIG_MANUAL_CLK */ This might use some comments (or should possibly be deleted)? > + soc_cs42l52_set_bias_level(soc_codec, SND_SOC_BIAS_OFF); > + soc_codec->bias_level = SND_SOC_BIAS_STANDBY; > + schedule_delayed_work(&soc_codec->delayed_work, msecs_to_jiffies(1000)); > + soc_cs42l52_required_setup(soc_codec); A comment about what the delayed work is up to wouldn't hurt? > + /*set hp default volume*/ > + soc_cs42l52_write(soc_codec, CODEC_CS42L52_HPA_VOL, DEFAULT_HP_VOL); > + soc_cs42l52_write(soc_codec, CODEC_CS42L52_HPB_VOL, DEFAULT_HP_VOL); For pretty much all the configuration you're doing here just let userspace set things up, there's no telling what's an appropriate setting on any given system and presumably the chip designers made a reasonable effort to ensure that the default state of the chip is at least not harmful. > +#ifdef CONFIG_MANUAL_CLK > + soc_cs42l52_write(soc_codec, CODEC_CS42L52_CLK_CTL, > + (soc_cs42l52_read(soc_codec, CODEC_CS42L52_CLK_CTL) > + & ~CLK_CTL_AUTODECT_ENABLE)); Pass this configuration in as platform data, this will allow multiple boards to build from the same kernel. > + ret = snd_soc_init_card(soc_dev); > + if(ret) > + { > + SOCERR("add snd card failed\n"); > + goto card_err; > + } Please develop against git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.35 (or whatever the latest kernel version branch is at any given time.) You should also be calling snd_soc_register_codec() and snd_soc_register_dai() from this function. > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) No need for the ifdefs if you only support I2C, the ifdefs are used by drivers that have multiple control interfaces (typically I2C plus SPI). > + } > + > + > + return ret; > +} > + > +static int cs42l52_i2c_remove(struct i2c_client *client) > +{ > + struct snd_soc_codec *soc_codec; > + if(client) > + { > + soc_codec = i2c_get_clientdata(client); > + if(soc_codec) > + kfree(soc_codec->reg_cache); > + } > + return 0; > +} This should be unregistering from ASoC as well, or refusing to remove if not implemented. > + case SND_SOC_DAIFMT_DSP_B: > + SOCINF("unsupported format\n"); > + ret = -EINVAL; > + goto done; > + default: > + SOCINF("invaild format\n"); > + ret = -EINVAL; > + goto done; Could just squash these together. > + case SND_SOC_DAIFMT_IB_IF: > + SOCDBG("codec dai fmt inversed sclk\n"); > + iface |= IFACE_CTL1_INV_SCLK; > + break; > + case SND_SOC_DAIFMT_IB_NF: > + iface |= IFACE_CTL1_INV_SCLK; > + break; It looks like the hardware only supports the inversion of one of the clocks so only two of the clock polarity combinations should be supported? > + info->format = iface; I'd really expect to see interaction with the hardware here? > + /* 96k */ > + {12288000, 96000, CLK_CTL_S_DS_MODE, CLK_CTL_NOT_32K, CLK_CTL_NOT_27M, CLK_CTL_RATIO_128, 0}, > + {18432000, 96000, CLK_CTL_S_DS_MODE, CLK_CTL_NOT_32K, CLK_CTL_NOT_27M, CLK_CTL_RATIO_128, 0},/*29*/ > + {12000000, 96000, CLK_CTL_S_DS_MODE, CLK_CTL_NOT_32K, CLK_CTL_NOT_27M, CLK_CTL_RATIO_125, 0}, > + {24000000, 96000, CLK_CTL_S_DS_MODE, CLK_CTL_NOT_32K, CLK_CTL_NOT_27M, CLK_CTL_RATIO_125, 1}, If you're feeling adventurous you should be able to use this data to set up constraints for the DAI in the startup() callback so only sample rates supported from the system clock can be used by userspace. > +static int soc_cs42l52_pcm_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai) > +{ > + int ret = 0; > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct snd_soc_device *soc_dev = rtd->socdev; > + struct snd_soc_codec *soc_codec = soc_dev->card->codec; > + struct soc_codec_cs42l52 *info = (struct soc_codec_cs42l52*)soc_codec->private_data; > + > + u32 clk = 0; > + int index = soc_cs42l52_get_clk(info->sysclk, params_rate(params)); > +static int soc_cs42l52_suspend(struct platform_device *pdev, pm_message_t state) > +{ > + struct snd_soc_device *soc_dev = (struct snd_soc_device*)platform_get_drvdata(pdev); > + struct snd_soc_codec *soc_codec = soc_dev->card->codec; > + > + soc_cs42l52_write(soc_codec, CODEC_CS42L52_PWCTL1, PWCTL1_PDN_CODEC); > + soc_cs42l52_set_bias_level(soc_codec, SND_SOC_BIAS_OFF); I'd expect that set_bias_level() would do what the explict write does? > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) > + if(soc_codec_data->i2c_addr) > + { > + ret = i2c_add_driver(&cs42l52_i2c_drv); > + > + if(ret) > + { > + SOCERR("register i2c driver failed\n"); > + goto out; > + > + } > + SOCINF("Cirrus Logic ALSA SoC codec cs42l52 driver verison 1.2 2/2010\n"); > + return ret; > + } This should be changed to use standard device model registration - see http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=commit;h=… for an example of doing the conversion. > +struct soc_codec_cs42l52_data{ > + u_short i2c_addr; > +}; With the device model stuff this won't be needed any more. > +/* > + *CS42L52 internal registers > + */ > +#define CODEC_CS42L52_CHIP 0x01 > +#define CHIP_ID 0xE0 > +#define CHIP_ID_MASK 0xF8 Many of the register names and other definitions for register fields and values need to be namespace to avoid collisions.

4 5

[alsa-devel] [PATCH V2 0/2] Add WM8994 PCM Machine driver for Exynos4210
by Sangbeom Kim 17 Jun '11

17 Jun '11

Hi, This is 2nd patchset for WM8994 pcm machine driver that supports PCM audio on SMDKV310, SMDKC210 and test is done. This is minor change version. AS jassi comment, I added new pcm structure for quirk handling. And added Liam's acked. Based on these patches WM8994 pcm machine driver supports followings: o Playback supports 8kHz sampling rates. o Capture supports 8kHz sampling rates. This patchset contains followings o To Kukjin Kim and Ben Dooks, [PATCH 1/2] ARM: EXYNOS4: Add PCM audio support for WM8994 o To Jassi Brar, Mark Brown and Liam Girdwood, [PATCH 2/2] ASoC: SAMSUNG: Add WM8580 PCM Machine driver Best Regards, SB Kim (Sangbeom Kim)

5 10

Re: [alsa-devel] Driver for TerraTec DMX 6Fire USB
by Takashi Iwai 16 Jun '11

16 Jun '11

At Tue, 18 Jan 2011 14:41:47 +0100, torsten.schenk wrote: > > Hello, > > (to all those who already got this mail: sorry, I sent the attachment accidentally in html format so it was ignored by alsa-devel ML distributor) > > i recently got a TerraTec DMX 6Fire USB. Since it's not supported by alsa, I decided to look into communications between the windows driver and the card. Here is the result. > > What should be revised: > - I was unsure about naming conventions, so please check the name of card/midi/pcm/module. > - Also the device needs firmware to be able to run, so I included the firmware from the windows driver in the attachment. I read about that Linus Torvalds doesn't like .ihex-parsing in drivers, but I cannot convert the files easily into a binary format because the offsets are not contiguous. Of course there could be alternate ways to be thought about, which would imply that original files from TT are not supported since they are in ihex. > - I didn't manage to create a configuration in /usr/share/alsa/cards. > > What is working: Everything except SPDIF > - Hardware Master volume > - PCM 44-192kHz@24 bits, 6 channels out, 4 channels in (analog) > - MIDI in/out > - firmware loading for coldplugged devices > - phono/line switching > > If anything else comes to your attention, just let me know. Sorry for the late reply. It took some time until I have free slot. First off, there are lots of coding-style issues to be fixed. Try to run scripts/checkpatch.pl once with your patch. Not all warnings have to be fixed (e.g. 80-chars) but would be nice if fixed. Here are some review comments through a very quirk glance: > +static int __devinit probe(struct usb_interface *intf, const struct usb_device_id *usb_id) Adding a short prefix (e.g. usb6fire_probe()) is better in general. Otherwise the stack trace would be difficult to read. Of course, too long names are also annoying, so it's a matter of taste. ... > + chip = (struct sfire_chip*)card->private_data; You can avoid cast here. > + chips[regidx] = chip; > + chip->dev = device; > + chip->regidx = regidx; > + chip->intf_count = 1; > + chip->card = card; > + chip->shutdown = FALSE; > + chip->midi = NULL; > + chip->comm = NULL; > + chip->control = NULL; > + chip->pcm = NULL; NULLs are automatically filled, so these can be skipped. > + ret = snd_usb_6fire_comm_init(chip); > + if(ret < 0) > + { > + snd_card_free(card); > + return ret; > + } > + > + ret = snd_usb_6fire_midi_init(chip); > + if(ret < 0) > + { > + snd_usb_6fire_comm_destroy(chip); > + snd_card_free(card); > + return ret; > + } > + > + ret = snd_usb_6fire_pcm_init(chip); > + if(ret < 0) > + { > + snd_usb_6fire_midi_destroy(chip); > + snd_usb_6fire_comm_destroy(chip); > + snd_card_free(card); > + return ret; > + } > + > + ret = snd_usb_6fire_control_init(chip); > + if(ret < 0) > + { > + snd_usb_6fire_pcm_destroy(chip); > + snd_usb_6fire_midi_destroy(chip); > + snd_usb_6fire_comm_destroy(chip); > + snd_card_free(card); > + return ret; > + } > + > + ret = snd_card_register(card); > + if(ret < 0) > + { > + snd_usb_6fire_pcm_destroy(chip); > + snd_usb_6fire_midi_destroy(chip); > + snd_usb_6fire_comm_destroy(chip); > + snd_usb_6fire_control_destroy(chip); > + snd_card_free(card); A general way for error-handling is either using goto or using a common destructor. In either way, you can call the *_free or *_destroy with the non-NULL check of each instance. It's a cleaner in general. > +static void disconnect(struct usb_interface *intf) > +{ > + struct sfire_chip *chip; > + struct snd_card *card; > + > + chip = usb_get_intfdata(intf); > + if(chip) //if !chip, fw upload has been performed so that we don't have a chip. > + { > + card = chip->card; > + chip->intf_count--; > + if (chip->intf_count == 0) > + { > + chip->shutdown = TRUE; > + snd_card_disconnect(card); > + snd_usb_6fire_comm_destroy(chip); > + snd_usb_6fire_control_destroy(chip); > + snd_usb_6fire_pcm_destroy(chip); > + snd_usb_6fire_midi_destroy(chip); > + snd_card_free(card); > + usb_set_intfdata(intf, NULL); The same destructor as in probe can be used here. > +static struct usb_device_id device_table[] = > +{ > + { > + .match_flags = USB_DEVICE_ID_MATCH_DEVICE, > + .idVendor = 0x0ccd, > + .idProduct = 0x0080 > + }, > + { } > +}; Usually MODULE_DEVICE_TABLE() follows just after the definition. > diff -Nur a/sound/usb/6fire/chip.h b/sound/usb/6fire/chip.h > --- a/sound/usb/6fire/chip.h 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/chip.h 2011-01-18 13:58:06.000000000 +0100 > @@ -0,0 +1,30 @@ > +/* > + * Linux driver for TerraTec DMX 6Fire USB > + * > + * Author: Torsten Schenk > + * Created: Jan 01, 2011 > + * Copyright: (C) Torsten Schenk > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > +#pragma once Don't use prgram. Also, add #ifdef xxx for protecting the double inclusion. > +#include "common.h" > + > +struct sfire_chip > +{ > + struct usb_device *dev; > + struct snd_card *card; > + int intf_count; //number of registered interfaces > + int regidx; //index in module parameter arrays > + BOOL shutdown; Don't use own bool type. Use the generic "bool" type, and use true/false instead of TRUE/FALSE (unless the size really matters). > diff -Nur a/sound/usb/6fire/comm.c b/sound/usb/6fire/comm.c > --- a/sound/usb/6fire/comm.c 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/comm.c 2011-01-18 13:58:21.000000000 +0100 ... > +static int write_02(struct comm_runtime *rt, __u8 reg, __u16 value) Use u8 and u16. > diff -Nur a/sound/usb/6fire/comm.h b/sound/usb/6fire/comm.h > --- a/sound/usb/6fire/comm.h 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/comm.h 2011-01-18 13:58:29.000000000 +0100 > @@ -0,0 +1,42 @@ > +/* > + * Linux driver for TerraTec DMX 6Fire USB > + * > + * Author: Torsten Schenk > + * Created: Jan 01, 2011 > + * Copyright: (C) Torsten Schenk > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > + > +#pragma once Ditto. No pragma and add ifdef. > diff -Nur a/sound/usb/6fire/common.h b/sound/usb/6fire/common.h > --- a/sound/usb/6fire/common.h 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/common.h 2011-01-18 13:58:38.000000000 +0100 > +#pragma once > + > +#include <linux/slab.h> > +#include <linux/usb.h> > +#include <sound/core.h> > + > +#define BOOL char > +#define TRUE 1 > +#define FALSE 0 Don't use these. > +#define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) > +#define MAX(X, Y) ((X) > (Y) ? (X) : (Y)) Use standard min() / max() macros. > +#define ERR KERN_ERR "6fire: " > +#define WARNING KERN_WARNING "6fire: " Hmm... These are also better to be avoided. At most, define "6fire: " as PREFIX or PFX or whatever. But KERN_ERR should be put plainly. > diff -Nur a/sound/usb/6fire/control.c b/sound/usb/6fire/control.c > --- a/sound/usb/6fire/control.c 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/control.c 2011-01-18 13:58:57.000000000 +0100 > diff -Nur a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c > --- a/sound/usb/6fire/firmware.c 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/firmware.c 2011-01-18 13:57:15.000000000 +0100 ... > +static inline int fpga_write(struct usb_device *device, char *data, int len) Avoid inline unless you really need it. Also add MODULE_FIRMWARE() definitions in this file. > diff -Nur a/sound/usb/6fire/Makefile b/sound/usb/6fire/Makefile > --- a/sound/usb/6fire/Makefile 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/Makefile 2011-01-16 23:14:22.000000000 +0100 > @@ -0,0 +1,13 @@ > +obj-m += snd-usb-6fire.o > +snd-usb-6fire-objs += chip.o comm.o midi.o control.o firmware.o pcm.o > + > +all: > + make CONFIG_DEBUG_SECTION_MISMATCH=y -C /lib/modules/$(shell uname -r)/build M=$(PWD) modules > + > +clean: > + make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean > + > +install: > + mkdir -p /lib/modules/$(shell uname -r)/extras > + cp snd-usb-6fire.ko /lib/modules/$(shell uname -r)/extras Remove all, clean, install things. > diff -Nur a/sound/usb/6fire/pcm.c b/sound/usb/6fire/pcm.c > --- a/sound/usb/6fire/pcm.c 1970-01-01 01:00:00.000000000 +0100 > +++ b/sound/usb/6fire/pcm.c 2011-01-18 13:59:57.000000000 +0100 > diff -Nur a/sound/usb/Kconfig b/sound/usb/Kconfig > --- a/sound/usb/Kconfig 2011-01-16 23:20:41.000000000 +0100 > +++ b/sound/usb/Kconfig 2011-01-16 23:14:22.000000000 +0100 > @@ -32,6 +32,17 @@ > To compile this driver as a module, choose M here: the module > will be called snd-ua101. > +config SND_USB_6FIRE > + tristate "TerraTec DMX 6Fire USB" > + depends on X86 > + select SND_HWDEP Do you really need hwdep? Rather select FW_LOADER, if any. > + select SND_PCM Missing SND_RAWMIDI dependency. > @@ -65,7 +76,6 @@ > * Native Instruments Guitar Rig Session I/O > * Native Instruments Guitar Rig mobile > * Native Instruments Traktor Kontrol X1 > - * Native Instruments Traktor Kontrol S4 > To compile this driver as a module, choose M here: the module > will be called snd-usb-caiaq. > @@ -83,7 +93,6 @@ > * Native Instruments Kore Controller > * Native Instruments Kore Controller 2 > * Native Instruments Audio Kontrol 1 > - * Native Instruments Traktor Kontrol S4 Don't bother others ;) thanks, Takashi

2 20

[alsa-devel] soc-dsp questions
by pl bossart 13 Jun '11

13 Jun '11

To prepare next week's ALSA-Asoc meeting, I reviewed Liam's dsp-upstream code, and I am a bit unclear on the 'no_host_mode' supported by some DAIs. Apparently these are regular ALSA PCM substreams, except that there are no data exchanges to/from the host. - If these substreams are known, an application can in theory open/close them. How would it know that no data is to be written/read? I would think additional changes are required in alsa-lib? - is this really important that such PCM devices be known in userspace? Or are they declared only so that ALSA controls are enabled for these streams? - along the same lines, how useful is the .pointer routine for such devices? Since no data will be provided by the host, is this really needed? I see it's only meaningful for the low-power playback mode, but I am unsure if the information provided would actually be used by anyone? - what is the meaning of the SND_SOC_DAI_LINK_OPT_HOST definition? It doesn't seem to be updated depending on which back-end is used, so it this really needed? Thanks -Pierre

5 10

[alsa-devel] [RFC PATCH] Add combined clock support to Atmel SoC audio
by Ryan Mallon 07 Jun '11

07 Jun '11

The following patch is one that has been floating around in various forms in our own internal trees for a while. The Atmel SSC peripheral has seperate TX and RX clocks which use separate pins from the the micro. TF (frame) and TK (clock) for transmit and RF and RK for receive. Not all codecs have separate frame and bit clocks for transmit and receive so we want to be able to do both playback and capture using a single set of pins. This patch introduces a combined clock mode for the Atmel SSC peripheral. Which allows playback and capture to use a single set of pins. Currently combined clock is only supported on the TF/TK pins (some incomplete support exists for using RF/RK). I have tested this patch on our AT91SAM9G45 + TLV320AIC26 platform. Playback and capture work individually. Simultaneous playback and capture have been tested by connecting a loopback cable on the linein and lineout jacks and then doing: arecord -c 2 -f S16_LE -r 44100 > recording.wav & aplay 500hz_sine.wav This patch is posted as RFC since the approach is incomplete and a bit hackish. I am mostly interested in knowing if this is a sensible approach, and could be cleaned up for mainline inclusion, or if there is a better way to do this. Signed-off-by: Ryan Mallon <ryan(a)bluewatersys.com> --- diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 5d230ce..ee00172 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -43,6 +43,7 @@ #include <sound/soc.h> #include <mach/hardware.h> +#include <asm/atomic.h> #include "atmel-pcm.h" #include "atmel_ssc_dai.h" @@ -246,7 +247,18 @@ static void atmel_ssc_shutdown(struct snd_pcm_substream *substream, dma_params = ssc_p->dma_params[dir]; if (dma_params != NULL) { - ssc_writel(ssc_p->ssc->regs, CR, dma_params->mask->ssc_disable); + if (ssc_p->combined_clock) { + /* + * When using a combined clock we only disable the + * clock once all substreams have completed + */ + if (atomic_dec_and_test(&ssc_p->substreams_running)) + ssc_writel(ssc_p->ssc->regs, CR, + dma_params->mask->ssc_disable); + } else { + ssc_writel(ssc_p->ssc->regs, CR, + dma_params->mask->ssc_disable); + } pr_debug("atmel_ssc_shutdown: %s disabled SSC_SR=0x%08x\n", (dir ? "receive" : "transmit"), ssc_readl(ssc_p->ssc->regs, SR)); @@ -328,6 +340,21 @@ static int atmel_ssc_set_dai_clkdiv(struct snd_soc_dai *cpu_dai, return 0; } +void atmel_ssc_setup_combined_clock(struct atmel_ssc_info *ssc_p, + int combined_clock) +{ + int i; + + ssc_p->combined_clock = combined_clock; + for (i = 0; i < ARRAY_SIZE(ssc_dma_params); i++) { + if (ssc_p->combined_clock == ATMEL_SSC_CLOCK_TX_ON_RX) + ssc_dma_params[i][0].mask->ssc_enable |= SSC_BIT(CR_RXEN); + else if (ssc_p->combined_clock == ATMEL_SSC_CLOCK_RX_ON_TX) + ssc_dma_params[i][1].mask->ssc_enable |= SSC_BIT(CR_TXEN); + } +} +EXPORT_SYMBOL(atmel_ssc_setup_combined_clock); + /* * Configure the SSC. */ @@ -548,6 +575,34 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, ssc_p->daifmt); return -EINVAL; } + + if (ssc_p->combined_clock == ATMEL_SSC_CLOCK_RX_ON_TX) { + /* RX clock is always running */ + rcmr &= ~SSC_BF(RCMR_CKO, 0x7); + rcmr |= SSC_BF(RCMR_CKO, SSC_CKO_CONTINUOUS); + + /* TX clock is always running */ + tcmr &= ~SSC_BF(TCMR_CKO, 0x7); + tcmr |= SSC_BF(TCMR_CKO, SSC_CKO_CONTINUOUS); + + /* RX clock is sourced from TK pin */ + rcmr &= ~SSC_BF(RCMR_CKS, 0x7); + rcmr |= SSC_BF(RCMR_CKS, SSC_CKS_CLOCK); + + /* Start RX on TX start */ + rcmr &= ~SSC_BF(RCMR_START, 0xf); + rcmr |= SSC_BF(RCMR_START, SSC_START_TX_RX); + + if (dir == 1) { + /* + * Set the TX clock period to the RX clock period + * FIXME - Is this okay if we are already doing TX? + */ + tcmr &= 0x00ffffff; + tcmr |= rcmr & 0xff000000; + } + } + pr_debug("atmel_ssc_hw_params: " "RCMR=%08x RFMR=%08x TCMR=%08x TFMR=%08x\n", rcmr, rfmr, tcmr, tfmr); @@ -581,6 +636,9 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, return ret; } + if (ssc_p->combined_clock) + atomic_set(&ssc_p->substreams_running, 0); + ssc_p->initialized = 1; } @@ -616,6 +674,21 @@ static int atmel_ssc_prepare(struct snd_pcm_substream *substream, ssc_writel(ssc_p->ssc->regs, CR, dma_params->mask->ssc_enable); + if (ssc_p->combined_clock) { + atomic_inc(&ssc_p->substreams_running); + + if (ssc_p->combined_clock == ATMEL_SSC_CLOCK_RX_ON_TX && + dir == 1) { + /* + * Jump start the dma for capture by loading the + * transmit holding register with a dummy value. + */ + pr_debug("Jump starting SSC RX DMA\n"); + if (!(ssc_readl(ssc_p->ssc->regs, SR) & (1 << 16))) + ssc_writel(ssc_p->ssc->regs, THR, 0); + } + } + pr_debug("%s enabled SSC_SR=0x%08x\n", dir ? "receive" : "transmit", ssc_readl(ssc_p->ssc->regs, SR)); diff --git a/sound/soc/atmel/atmel_ssc_dai.h b/sound/soc/atmel/atmel_ssc_dai.h index 5d4f0f9..6b20ee6 100644 --- a/sound/soc/atmel/atmel_ssc_dai.h +++ b/sound/soc/atmel/atmel_ssc_dai.h @@ -102,6 +102,8 @@ struct atmel_ssc_state { u32 ssc_imr; }; +#define ATMEL_SSC_CLOCK_RX_ON_TX 1 +#define ATMEL_SSC_CLOCK_TX_ON_RX 2 struct atmel_ssc_info { char *name; @@ -115,8 +117,14 @@ struct atmel_ssc_info { unsigned short rcmr_period; struct atmel_pcm_dma_params *dma_params[2]; struct atmel_ssc_state ssc_state; + + /* For combined clocks */ + int combined_clock; + atomic_t substreams_running; }; int atmel_ssc_set_audio(int ssc); +extern void atmel_ssc_setup_combined_clock(struct atmel_ssc_info *ssc_p, + int combined_clock); #endif /* _AT91_SSC_DAI_H */

3 6

[alsa-devel] [PATCH 2/2] ALSA: ASoc: putting together AT91SAM9260 and TLV320AIC3X
by Prchal Jiří 31 May '11

31 May '11

Hi, this patch is for example how to put together AT91SAM9260 and TLV320AIC3106 controlled via SPI. It tooks me a lot of time to make it working, so I think it could be helpfull for other people. In original source "snd-soc-afeb9260.c" which I use as example is BIG ERROR: In function "afeb9260_soc_init" is missing call of "atmel_ssc_set_audio(0);". It cause bug "PROBLEM: Asoc driver in 2.6.37.3 for AT91SAM9260 / TLV320AIC3X is broken" which I post some time ago. Depend on: [PATCH 1/2] ALSA: ASoc: TLV320AIC3X: ad SPI and clock on GPIO2 or BCLK Kernel version: 2.6.38 Signed-off-by: Jiri Prchal <jiri.prchal(a)aksignal.cz> --- diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/arch/arm/mach-at91/board-cdu.c /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/board-cdu.c --- linux-2.6.38-vanilla/arch/arm/mach-at91/board-cdu.c 1970-01-01 01:00:00.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/board-cdu.c 2011-03-24 09:15:23.852370981 +0100 @@ -0,0 +1,345 @@ +/* + * linux/arch/arm/mach-at91/board-cdu.c + * + * Copyright (C) 2005 SAN People + * Copyright (C) 2006 Atmel + * Copyright (C) 2011 AKsignal Brno + * jiri.prchal(a)aksignal.cz + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <linux/types.h> +#include <linux/init.h> +#include <linux/mm.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/spi/spi.h> +#include <linux/clk.h> +#include <linux/spi/mcp23s08.h> +#include <linux/dma-mapping.h> + +#include <mach/hardware.h> +#include <asm/setup.h> +#include <asm/mach-types.h> +#include <asm/irq.h> + +#include <asm/mach/arch.h> +#include <asm/mach/map.h> +#include <asm/mach/irq.h> + +#include <mach/board.h> +#include <mach/gpio.h> +#include <mach/at91sam9_smc.h> + +#include "sam9_smc.h" +#include "generic.h" + +static void __init cdu_map_io(void) +{ + /* Initialize processor: 6 MHz crystal */ + at91sam9260_initialize(6000000); + + /* DBGU on ttyS0. (Rx & Tx only) */ + at91_register_uart(0, 0, 0); + + /* USART0 on ttyS1. (Rx, Tx, CTS, RTS, DTR, DSR, DCD, RI) */ + at91_register_uart(AT91SAM9260_ID_US0, 1, ATMEL_UART_CTS | ATMEL_UART_RTS + | ATMEL_UART_DTR | ATMEL_UART_DSR | ATMEL_UART_DCD + | ATMEL_UART_RI); + + /* USART1 on ttyS2. (Rx, Tx, RTS) */ + at91_register_uart(AT91SAM9260_ID_US1, 2, ATMEL_UART_RTS); + + /* USART2 on ttyS3. (Rx, Tx, RTS) */ + at91_register_uart(AT91SAM9260_ID_US2, 3, ATMEL_UART_RTS); + + /* USART3 on ttyS4. (Rx, Tx, RTS) */ + at91_register_uart(AT91SAM9260_ID_US3, 4, ATMEL_UART_RTS); + + /* USART4 on ttyS5. (Tx) */ + /* EBUS - transmit audio, no rx */ + /*at91_register_uart(AT91SAM9260_ID_US4, 5, 0);*/ + + /* set serial console to ttyS0 (ie, DBGU) */ + at91_set_serial_console(0); +} + +static void __init cdu_init_irq(void) +{ + at91sam9260_init_interrupts(NULL); +} + +/* + * USB Host port + */ +static struct at91_usbh_data __initdata cdu_usbh_data = { + .ports = 2, +}; + +/* + * USB Device port + */ +static struct at91_udc_data __initdata cdu_udc_data = { + .vbus_pin = AT91_PIN_PC15, + .pullup_pin = 0, /* pull-up driven by UDC */ +}; + +/* + * SPI devices. + */ +#define MCP23S08_GPIO_BASE 128 + +static const struct mcp23s08_platform_data mcp23s08_gpio_info = { + .chip[0].is_present = true, + .chip[0].pullups = 0, + .base = MCP23S08_GPIO_BASE, +}; + +static struct spi_board_info cdu_spi_devices[] = { + { /* ADC LTC2488 */ + .modalias = "spidev", + .chip_select = 0, + .max_speed_hz = 1 * 1000 * 1000, + .bus_num = 1, + }, + { /* GPIO expander MCP23S08 */ + .modalias = "mcp23s08", + .chip_select = 1, + .max_speed_hz = 1000000, + .bus_num = 1, + .platform_data = &mcp23s08_gpio_info, + .mode = SPI_MODE_3, + }, + { /* non volatile memory (F-RAM) FM25VN10 */ + .modalias = "spidev", + .chip_select = 2, + .max_speed_hz = 1 * 1000 * 1000, + .bus_num = 1, + }, + { /* audiocodec TLV320AIC3106 */ + .modalias = "tlv320aic3x-codec", + .chip_select = 3, + .max_speed_hz = 1000000, + .bus_num = 1, + .mode = SPI_MODE_1, + }, +}; + +/* + * MACB Ethernet device + */ +static struct at91_eth_data __initdata cdu_macb_data = { + .phy_irq_pin = 0, //nc, + .is_rmii = 1, +}; + +/* + * NAND flash + */ +static struct mtd_partition __initdata cdu_nand_partition[] = { + { + .name = "bootstrap", + .offset = 0, + .size = 0x40000, + }, + { + .name = "uboot", + .offset = 0x40000, + .size = (0xc0000 - 0x40000), + }, + { + .name = "ubootenv", + .offset = 0xc0000, + .size = (0x100000 - 0xc0000), + }, + { + .name = "kernel", + .offset = 0x100000, + .size = (0x400000 - 0x100000), + }, + { + .name = "rootfs", + .offset = 0x400000, + .size = (0x8000000 - 0x400000), + }, +}; + +static struct mtd_partition * __init nand_partitions(int size, int *num_partitions) +{ + *num_partitions = ARRAY_SIZE(cdu_nand_partition); + return cdu_nand_partition; +} + +static struct atmel_nand_data __initdata cdu_nand_data = { + .ale = 21, + .cle = 22, +// .det_pin = ... not connected + .rdy_pin = AT91_PIN_PC13, + .enable_pin = AT91_PIN_PC14, + .partition_info = nand_partitions, + .bus_width_16 = 0, +}; + +static struct sam9_smc_config __initdata cdu_nand_smc_config = { + .ncs_read_setup = 0, + .nrd_setup = 1, + .ncs_write_setup = 0, + .nwe_setup = 1, + + .ncs_read_pulse = 3, + .nrd_pulse = 3, + .ncs_write_pulse = 3, + .nwe_pulse = 3, + + .read_cycle = 5, + .write_cycle = 5, + + .mode = AT91_SMC_READMODE | AT91_SMC_WRITEMODE | AT91_SMC_EXNWMODE_DISABLE, + .tdf_cycles = 2, +}; + +static void __init cdu_add_device_nand(void) +{ + /* setup bus-width (8 or 16) */ + if (cdu_nand_data.bus_width_16) + cdu_nand_smc_config.mode |= AT91_SMC_DBW_16; + else + cdu_nand_smc_config.mode |= AT91_SMC_DBW_8; + + /* configure chip-select 3 (NAND) */ + sam9_smc_configure(3, &cdu_nand_smc_config); + + at91_add_device_nand(&cdu_nand_data); +} + +/* +* MCI (SD/MMC) +*/ +static struct at91_mmc_data __initdata ek_mmc_data = { + .slot_b = 0, + .wire4 = 1, + // .det_pin = ... not connected + // .wp_pin = ... not connected + // .vcc_pin = ... not connected +}; + +/* + * LEDs + */ +static struct gpio_led cdu_leds[] = { + { + .name = "red", + .gpio = AT91_PIN_PC10, + .default_trigger = "timer", + }, + { + .name = "green", + .gpio = AT91_PIN_PA5, + .default_trigger = "heartbeat", + }, + { + .name = "yellow", + .gpio = AT91_PIN_PB20, + .active_low = 1, + .default_trigger = "mmc0", + }, + { + .name = "blue", + .gpio = AT91_PIN_PB21, + .active_low = 1, + .default_trigger = "nand-disk", + }, +}; + +/* + * GPIOs + */ +static struct gpio gpios[] = { + { AT91_PIN_PA0, GPIOF_OUT_INIT_LOW, "ebus_dir"}, + { AT91_PIN_PA1, GPIOF_OUT_INIT_LOW, "time_dir"}, + { AT91_PIN_PB12, GPIOF_OUT_INIT_LOW, "gsm_rst"}, + { AT91_PIN_PB13, GPIOF_OUT_INIT_LOW, "gsm_on"}, + { AT91_PIN_PC2, GPIOF_IN, "por"}, + { AT91_PIN_PC7, GPIOF_OUT_INIT_HIGH, "spk_shdn"}, + + { AT91_PIN_PC0, GPIOF_IN, "in13"}, + { AT91_PIN_PC1, GPIOF_IN, "in14"}, + { AT91_PIN_PA22, GPIOF_IN, "in17"}, + { AT91_PIN_PA23, GPIOF_IN, "in18"}, + { AT91_PIN_PA24, GPIOF_IN, "in19"}, + { AT91_PIN_PA25, GPIOF_IN, "in20"}, + + { AT91_PIN_PA26, GPIOF_OUT_INIT_LOW, "out15"}, + { AT91_PIN_PA27, GPIOF_OUT_INIT_LOW, "out16"}, + { AT91_PIN_PA28, GPIOF_OUT_INIT_LOW, "out17"}, + { AT91_PIN_PA29, GPIOF_OUT_INIT_LOW, "out18"}, + { AT91_PIN_PA30, GPIOF_OUT_INIT_LOW, "out19"}, + { AT91_PIN_PB29, GPIOF_OUT_INIT_LOW, "out20"}, + + { MCP23S08_GPIO_BASE + 0, GPIOF_IN, "busadrp"}, + { MCP23S08_GPIO_BASE + 2, GPIOF_IN, "busadr5"}, + { MCP23S08_GPIO_BASE + 3, GPIOF_IN, "busadr4"}, + { MCP23S08_GPIO_BASE + 4, GPIOF_IN, "busadr3"}, + { MCP23S08_GPIO_BASE + 5, GPIOF_IN, "busadr2"}, + { MCP23S08_GPIO_BASE + 6, GPIOF_IN, "busadr1"}, + { MCP23S08_GPIO_BASE + 7, GPIOF_IN, "busadr0"}, +}; + +static void __init cdu_add_gpio (void) +{ + int i; + + for (i = 0; i < ARRAY_SIZE (gpios); i++) { + gpio_request_one (gpios[i].gpio, gpios[i].flags, gpios[i].label); + } +} + +/* + * init + */ +static void __init cdu_board_init(void) +{ + /* Serial */ + at91_add_device_serial(); + /* USB Host */ + at91_add_device_usbh(&cdu_usbh_data); + /* USB Device */ + at91_add_device_udc(&cdu_udc_data); + /* SPI */ + at91_add_device_spi(cdu_spi_devices, ARRAY_SIZE(cdu_spi_devices)); + /* NAND */ + cdu_add_device_nand(); + /* Ethernet */ + at91_add_device_eth(&cdu_macb_data); + /* MMC */ + at91_add_device_mmc(0, &ek_mmc_data); + /* SSC */ + at91_add_device_ssc(AT91SAM9260_ID_SSC, (ATMEL_SSC_TF | ATMEL_SSC_TK | ATMEL_SSC_TD | ATMEL_SSC_RD)); + /* LEDs */ + at91_gpio_leds(cdu_leds, ARRAY_SIZE(cdu_leds)); + // GPIO + cdu_add_gpio (); +} + +MACHINE_START(AT91SAM9260EK, "CDU") + /* Maintainer: Atmel */ + .boot_params = AT91_SDRAM_BASE + 0x100, + .timer = &at91sam926x_timer, + .map_io = cdu_map_io, + .init_irq = cdu_init_irq, + .init_machine = cdu_board_init, +MACHINE_END diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/arch/arm/mach-at91/Kconfig /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/Kconfig --- linux-2.6.38-vanilla/arch/arm/mach-at91/Kconfig 2011-03-15 02:20:32.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/Kconfig 2011-03-16 09:19:40.000000000 +0100 @@ -213,6 +213,12 @@ config MACH_AT91SAM9260EK Select this if you are using Atmel's AT91SAM9260-EK or AT91SAM9XE Evaluation Kit <http://www.atmel.com/dyn/products/tools_card.asp?tool_id=3933> +config MACH_CDU + bool "CDU AKsignal board" + help + Select this if you are using AKsignal CDU board + <http://www.aksignal.cz> + config MACH_CAM60 bool "KwikByte KB9260 (CAM60) board" help diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/arch/arm/mach-at91/Makefile /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/Makefile --- linux-2.6.38-vanilla/arch/arm/mach-at91/Makefile 2011-03-15 02:20:32.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/arch/arm/mach-at91/Makefile 2011-03-16 09:19:40.000000000 +0100 @@ -40,6 +40,7 @@ obj-$(CONFIG_MACH_ECO920) += board-eco92 # AT91SAM9260 board-specific support obj-$(CONFIG_MACH_AT91SAM9260EK) += board-sam9260ek.o +obj-$(CONFIG_MACH_CDU) += board-cdu.o obj-$(CONFIG_MACH_CAM60) += board-cam60.o obj-$(CONFIG_MACH_SAM9_L9260) += board-sam9-l9260.o obj-$(CONFIG_MACH_USB_A9260) += board-usb-a9260.o diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/sound/soc/atmel/Kconfig /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/Kconfig --- linux-2.6.38-vanilla/sound/soc/atmel/Kconfig 2011-03-15 02:20:32.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/Kconfig 2011-03-22 09:46:46.751566158 +0100 @@ -50,3 +50,11 @@ config SND_AT91_SOC_AFEB9260 select SND_SOC_TLV320AIC23 help Say Y here to support sound on AFEB9260 board. + +config SND_AT91_SOC_CDU + tristate "SoC Audio support for CDU board" + depends on ARCH_AT91 && MACH_CDU && SND_ATMEL_SOC + select SND_ATMEL_SOC_SSC + select SND_SOC_TLV320AIC3X + help + Say Y here to support sound on CDU board. diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/sound/soc/atmel/Makefile /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/Makefile --- linux-2.6.38-vanilla/sound/soc/atmel/Makefile 2011-03-15 02:20:32.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/Makefile 2011-03-16 09:26:17.000000000 +0100 @@ -14,3 +14,4 @@ snd-soc-playpaq-objs := playpaq_wm8510.o obj-$(CONFIG_SND_AT91_SOC_SAM9G20_WM8731) += snd-soc-sam9g20-wm8731.o obj-$(CONFIG_SND_AT32_SOC_PLAYPAQ) += snd-soc-playpaq.o obj-$(CONFIG_SND_AT91_SOC_AFEB9260) += snd-soc-afeb9260.o +obj-$(CONFIG_SND_AT91_SOC_CDU) += snd-soc-cdu.o diff -uprN -X linux-2.6.38-vanilla/Documentation/dontdiff linux-2.6.38-vanilla/sound/soc/atmel/snd-soc-cdu.c /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/snd-soc-cdu.c --- linux-2.6.38-vanilla/sound/soc/atmel/snd-soc-cdu.c 1970-01-01 01:00:00.000000000 +0100 +++ /home/prchal/arm/fw-cdu/linux/linux-2.6.38/sound/soc/atmel/snd-soc-cdu.c 2011-03-24 09:27:55.404367652 +0100 @@ -0,0 +1,264 @@ +/* + * snd-soc-cdu -- SoC audio for AT91SAM9260-based + * AKsignal CDU board. + * + * Copyright (C) 2005 SAN People + * Copyright (C) 2008 Atmel + * Copyright (C) 2011 AK signal Brno + * + * Authors: Sedji Gaouaou <sedji.gaouaou(a)atmel.com> + * Jiri Prchal <jiri.prchal(a)aksignal.cz> + * + * Based on ati_b1_wm8731.c by: + * Frank Mandarino <fmandarino(a)endrelia.com> + * Copyright 2006 Endrelia Technologies Inc. + * Based on corgi.c by: + * Copyright 2005 Wolfson Microelectronics PLC. + * Copyright 2005 Openedhand Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <linux/module.h> +#include <linux/moduleparam.h> +#include <linux/kernel.h> +#include <linux/clk.h> +#include <linux/timer.h> +#include <linux/interrupt.h> +#include <linux/platform_device.h> +#include <linux/i2c.h> + +#include <linux/atmel-ssc.h> +#include <sound/core.h> +#include <sound/pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> + +#include <asm/mach-types.h> +#include <mach/hardware.h> +#include <mach/gpio.h> + +#include "../codecs/tlv320aic3x.h" +#include "atmel-pcm.h" +#include "atmel_ssc_dai.h" + +struct { + unsigned int channels; + snd_pcm_format_t format; + unsigned int rate; + unsigned int codecclk; + unsigned int cmrdiv; + unsigned int period; +} cdu_audio[] = { + /* 16 bit stereo modes */ + {2, SNDRV_PCM_FORMAT_S16_LE, 8000, 2096000, 25, 130,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 16000, 2496000, 21, 77,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 32000, 2496000, 21, 38,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 48000, 2016000, 26, 20,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 96000, 4032000, 13, 20,}, + + {2, SNDRV_PCM_FORMAT_S16_LE, 11025, 2381400, 22, 107,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 22050, 2381400, 22, 53,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 44100, 2381400, 22, 26,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 88200, 4762800, 11, 26,}, + + {2, SNDRV_PCM_FORMAT_S16_LE, 11520, 2626560, 20, 113,}, + {2, SNDRV_PCM_FORMAT_S16_LE, 23040, 2626560, 20, 56,}, + +}; + +static int cdu_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_dai *codec_dai = rtd->codec_dai; + struct snd_soc_dai *cpu_dai = rtd->cpu_dai; + int ret; + int i, found = 0; + snd_pcm_format_t format = params_format(params); + unsigned int rate = params_rate(params); + unsigned int channels = params_channels(params); + + /* set codec DAI configuration */ + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS); + if (ret < 0) + return ret; + + /* set cpu DAI configuration */ + ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS); + if (ret < 0) + return ret; + + /* find the correct audio parameters */ + for (i = 0; i < ARRAY_SIZE(cdu_audio); i++) { + if (rate == cdu_audio[i].rate && + format == cdu_audio[i].format && + channels == cdu_audio[i].channels) { + found = 1; + break; + } + } + if (!found) + return -EINVAL; + + /* Set the codec system clock for DAC and ADC */ + ret = snd_soc_dai_set_sysclk(codec_dai, CLKIN_BCLK, cdu_audio[i].codecclk, SND_SOC_CLOCK_IN); + if (ret < 0) { + printk(KERN_ERR "can't set codec system clock\n"); + return ret; + } + + /* Set the cpu clock dividers to BCLK */ + ret = snd_soc_dai_set_clkdiv(cpu_dai, ATMEL_SSC_CMR_DIV, cdu_audio[i].cmrdiv); + ret |= snd_soc_dai_set_clkdiv(cpu_dai, ATMEL_SSC_TCMR_PERIOD, cdu_audio[i].period); + ret |= snd_soc_dai_set_clkdiv(cpu_dai, ATMEL_SSC_RCMR_PERIOD, cdu_audio[i].period); + if (ret < 0) { + printk(KERN_ERR "can't set cpu system clock\n"); + return ret; + } + + return 0; +} + +static struct snd_soc_ops cdu_ops = { + .hw_params = cdu_hw_params, +}; + +static const struct snd_soc_dapm_widget cdu_dapm_widgets[] = { + SND_SOC_DAPM_HP("Headphone Jack", NULL), + SND_SOC_DAPM_LINE("Line Out", NULL), + SND_SOC_DAPM_MIC("Mic Jack", NULL), + SND_SOC_DAPM_LINE("Line In", NULL), +}; + +static const struct snd_soc_dapm_route intercon[] = { + /* Headphone connected to HPLOUT, HPROUT */ + {"Headphone Jack", NULL, "HPLOUT"}, + {"Headphone Jack", NULL, "HPROUT"}, + + /* Line Out connected to LLOUT, RLOUT */ + {"Line Out", NULL, "LLOUT"}, + {"Line Out", NULL, "RLOUT"}, + + /* Mic connected to (MIC3L | MIC3R) */ + {"MIC3L", NULL, "Mic Bias 2V"}, + {"MIC3R", NULL, "Mic Bias 2V"}, + {"Mic Bias 2V", NULL, "Mic Jack"}, + + /* Line In connected to (LINE1L | LINE2L), (LINE1R | LINE2R) */ + {"LINE1L", NULL, "Line In"}, + {"LINE2L", NULL, "Line In"}, + {"LINE1R", NULL, "Line In"}, + {"LINE2R", NULL, "Line In"}, +}; + +/* + * Logic for a aic3x as connected on a cdu board. + */ +static int cdu_aic3x_init(struct snd_soc_pcm_runtime *rtd) +{ + struct snd_soc_codec *codec = rtd->codec; + struct snd_soc_dai *codec_dai = rtd->codec_dai; + struct snd_soc_dapm_context *dapm = &codec->dapm; + int ret; + + printk(KERN_DEBUG "cdu_aic3x: cdu_aic3x_init called\n"); + + /* Add specific widgets */ + snd_soc_dapm_new_controls(dapm, cdu_dapm_widgets, + ARRAY_SIZE(cdu_dapm_widgets)); + /* Set up specific audio path interconnects */ + snd_soc_dapm_add_routes(dapm, intercon, ARRAY_SIZE(intercon)); + + /* always connected */ + snd_soc_dapm_enable_pin(dapm, "Headphone Jack"); + snd_soc_dapm_enable_pin(dapm, "Line Out"); + snd_soc_dapm_enable_pin(dapm, "Mic Jack"); + snd_soc_dapm_enable_pin(dapm, "Line In"); + + snd_soc_dapm_sync(dapm); + + return 0; +} + +static struct snd_soc_dai_link cdu_dai = { + .name = "TLV320AIC3106", + .stream_name = "PCM", + .cpu_dai_name = "atmel-ssc-dai.0", + .codec_dai_name = "tlv320aic3x-hifi", + .init = cdu_aic3x_init, + .platform_name = "atmel-pcm-audio", +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) + .codec_name = "tlv320aic3x-codec.0-001b", +#endif +#if defined(CONFIG_SPI_MASTER) + .codec_name = "spi1.3", +#endif + .ops = &cdu_ops, +}; + +static struct snd_soc_card snd_soc_cdu = { + .name = "TLV320AIC3106", + .dai_link = &cdu_dai, + .num_links = 1, +}; + +static struct platform_device *cdu_snd_device; + +static int __init cdu_init(void) +{ + struct clk *pllb; + int ret; + + ret = atmel_ssc_set_audio(0); + if (ret != 0) { + pr_err("Failed to set SSC 0 for audio: %d\n", ret); + return ret; + } + + cdu_snd_device = platform_device_alloc("soc-audio", -1); + if (!cdu_snd_device) { + printk(KERN_ERR "ASoC: Platform device allocation failed\n"); + ret = -ENOMEM; + } + + platform_set_drvdata(cdu_snd_device, &snd_soc_cdu); + + ret = platform_device_add(cdu_snd_device); + if (ret) { + printk(KERN_ERR "ASoC: Platform device allocation failed\n"); + goto err_device_add; + } + + return ret; + +err_device_add: + platform_device_put(cdu_snd_device); +err: + return ret; +} + +static void __exit cdu_exit(void) +{ + platform_device_unregister(cdu_snd_device); + cdu_snd_device = NULL; +} + +module_init(cdu_init); +module_exit(cdu_exit); + +/* Module information */ +MODULE_AUTHOR("Jiri Prchal <jiri.prchal(a)aksignal.cz>"); +MODULE_DESCRIPTION("ALSA SoC CDU_AIC3X"); +MODULE_LICENSE("GPL");

2 4

Re: [alsa-devel] alsa patch for Fantom G
by Jaroslav Kysela 26 May '11

26 May '11

On Tue, 29 Mar 2011, Axel Schmidt wrote: > Hello, > > I do not know if I make this request to the right person. > > I've seen a simple patch that should make the Roland Fantom G working. > http://www.mail-archive.com/alsa-user@lists.sourceforge.net/msg23584.html > This patch is more then 2 years old. Is there any way to integrate this > patch into the official alsa? Clemens, does the patch looks reasonable? Anyway, the right list for patch posting is the alsa-devel mailing list. Jaroslav ----- Jaroslav Kysela <perex(a)perex.cz> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.

3 2

[alsa-devel] Problems with snd_hda_intel in Linux kernel 2.6.38
by Svante Signell 24 May '11

24 May '11

Now I'm subscribed to the list. It does not seem possible to get a message in without subscription. Would be nice if alsa had and used bug reporting pages outside the mailing list. > Trying again to get this message to the alsa-devel list, as recommended > by the Debian maintainer of the kernel, without being subscribed. Does > alsa not have a bug report page? > > Booting kernel 2.6.38 hangs at: > During boot of kernel 2.6.38 (and 2.6.37) udev bugs out: > Waiting for /dev to be fully populated > BUG: Unable to handle kernel paging request at ffffc90013cd8000 > axz_probe+ ... [snd_hda_intel] > ...lots of output lost... > udevadm timeout 180 sec ... > udevd[390]: worker [439] failed while handling > '/devices/pci0000:80/0000:80:01.0' > > No sound card is recognized after the timeout of the boot as shown above. > According to the /proc/asound/cards there are no sound cards > > See bug Debian bug #619034 for more information. > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619034 > > This problem was also reported as Debian bug #613979, as kernel ticket > > https://bugzilla.kernel.org/show_bug.cgi?id=30552 > > and sent to this mailing list in February 2011. > > snd_hda_intel works properly with 2.6.32-5-amd64 (and earlier kernels). >

4 15