July 2010 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [LAD] FIxed alsa-tools' envy24control missing peak level meters and "Reset Peaks"
by Niels Mayer 14 Jul '10

14 Jul '10

On Tue, Jul 13, 2010 at 1:19 AM, <fons(a)kokkinizita.net> wrote: >On Mon, Jul 12, 2010 at 06:18:29PM -0700, Niels Mayer wrote: >> Speaking of making my brain hurt -- I really would not have done the >> meters as done in envy24control. I really hate the concept of >> emulating the look of real gear down to the level that you have to >> "quantize" to individual LED's... > > That is indeed quite absurd. Yes, the meters in envy24control -- http://git.alsa-project.org/?p=alsa-tools.git;a=blob_plain;f=envy24control/… -- are absurd! What's even more absurd, is to have the benefits of the ice1712's hardware metering squandered by drawing thousands of rectangles per second (each individual "LED" on each meter is a separate x draw-rectangle call). The existing envy24control meters are an abomination of inefficiency! Especially when used with a remote X display. As a second patch (coming soon), I've rewritten the meters in a more sensible fashion, drawing a single rectangle to represent the instantaneous level (2-3 X-primitive draws per meter total and one blit, versus hundreds of draws and a blit per value change per meter in the original code). I'm also being a little more careful about not needing to redraw the entire meter for each change -- using the monotonicity of the audio signal being represented to optimize the way you draw it; not redrawing if nothing has changed, etc. And since the hardware metering already quantizes to 256 levels -- there's no point in re-quantizing those to individual "virtual LEDs" as is done w/ the current envy24control. The result so far are promising: Here's 'top' output (*) using the new envy24control. Note the load is lower, and 'envy24control' and 'X' both use much less CPU. In fact running this meter lowers the system load. whereas running the old envy24control raises it (and makes the fans run faster!). top - 21:30:13 up 11:30, 9 users, load average: 0.02, 0.11, 0.06 2664 root 20 0 544m 134m 34m S 2.6 3.4 26:03.51 X 9404 npm 20 0 192m 9340 6908 S 0.7 0.2 0:01.72 envy24control The new metering gives 2.6% CPU for X, and 0.7% CPU for the new-metered envy24control; Versus 6.3% CPU for X and 2.7% for the old metering in envy24control (the one from my first patch): top - 21:25:57 up 11:25, 9 users, load average: 0.10, 0.09, 0.03 2664 root 20 0 544m 134m 34m S 6.3 3.4 25:50.67 X 9398 npm 20 0 192m 9368 6940 S 2.7 0.2 0:16.81 envy24control Now granted this is not a scientific test, and "top" is not exactly the best way to gauge performance. But it does suggest that the computational complexity caused by the bad metering algorithm directly translates to higher-power consumption, higher loads, and poorer performance. Compared to the existing envy24control metering -- It would probably me more efficient to actually compute RMS levels off the audio stream -- or even hook up jkmeter through jack -- instead of using the hardware metering data through these computationally wasteful level meters. -- Niels http://nielsmayer.com

2 2

[alsa-devel] [PATCH] wm8988: remove a redundant snd_soc_unregister_codec call in wm8988_register
by Axel Lin 14 Jul '10

14 Jul '10

snd_soc_unregister_codec is called twice if snd_soc_register_dai fail. Signed-off-by: Axel Lin <axel.lin(a)gmail.com> --- sound/soc/codecs/wm8988.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm8988.c b/sound/soc/codecs/wm8988.c index 0417dae..19ad590 100644 --- a/sound/soc/codecs/wm8988.c +++ b/sound/soc/codecs/wm8988.c @@ -885,7 +885,6 @@ static int wm8988_register(struct wm8988_priv *wm8988, ret = snd_soc_register_dai(&wm8988_dai); if (ret != 0) { dev_err(codec->dev, "Failed to register DAI: %d\n", ret); - snd_soc_unregister_codec(codec); goto err_codec; } -- 1.7.0.4

1 0

[alsa-devel] ASoC updates for-2.6.36
by Mark Brown 13 Jul '10

13 Jul '10

The following changes since commit 66b47fdb851924956b6e4696fb43a3496ae2c462: ASoC: Implement WM8994 OPCLK support (2010-07-09 08:50:12 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.36 Arnaud Patard (2): ASoC: Fix kirkwood i2s mono playback ASoC: kirkwood-i2s: Handle mute/unmute playback/record Joe Perches (2): ASoC: Remove unnecessary casts of private_data ASoC: Remove unnecessary casts of private_data Kuninori Morimoto (8): ASoC: fsi: fixup clock inversion operation ASoC: fsi: fixup wrong value setting order of TDM ASoC: fsi: modify format area definition on flags ASoC: fsi: remove un-used variable on fsi_dai_startup ASoC: fsi: remove noisy CR_FMT macro ASoC: fsi: Change struct fsi_regs to fsi_core ASoC: fsi: Add pr_err for noticing unsupported access ASoC: fsi: Fixup for master mode Manuel Lauss (1): ASoC: au1x: fix section mismatch in psc-i2s.c Mark Brown (1): Merge branch 'for-2.6.35' into for-2.6.36 include/sound/sh_fsi.h | 44 +++++++- sound/soc/au1x/psc-i2s.c | 2 +- sound/soc/blackfin/bf5xx-ac97.c | 6 +- sound/soc/blackfin/bf5xx-tdm.c | 6 +- sound/soc/davinci/davinci-pcm.c | 2 +- sound/soc/kirkwood/kirkwood-i2s.c | 27 ++++-- sound/soc/kirkwood/kirkwood.h | 3 + sound/soc/sh/fsi.c | 213 ++++++++++++++++++++++++++----------- 8 files changed, 219 insertions(+), 84 deletions(-)

2 1

[alsa-devel] ASoC updates for 2.6.35
by Mark Brown 13 Jul '10

13 Jul '10

The following changes since commit 1c5474a65bf15a4cb162dfff86d6d0b5a08a740c: Linux 2.6.35-rc5 (2010-07-12 14:55:33 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.35 Kuninori Morimoto (2): ASoC: fsi: fixup clock inversion operation ASoC: fsi: fixup wrong value setting order of TDM Small, targetted fixes for a specific platform. sound/soc/sh/fsi.c | 27 +++++++++++---------------- 1 files changed, 11 insertions(+), 16 deletions(-)

2 1

[alsa-devel] FIxed alsa-tools' envy24control missing peak level meters and "Reset Peaks"
by Niels Mayer 13 Jul '10

13 Jul '10

I've been long annoyed by alsa-tools' envy24control (*) lack of peak-level indication in it's metering, and the non-implementation of its "Reset Peaks" button: https://bugzilla.redhat.com/show_bug.cgi?id=602903 I've fixed that annoyance. Now, a small white line appears above the highest level on each meter, and can be reset via "Reset Peaks" button. Original source: http://git.alsa-project.org/?p=alsa-tools.git;a=blob_plain;f=envy24control/… Patch: http://nielsmayer.com/npm/602903.patch To run this version of envy24control grab the most recent stable release ( ftp://ftp.alsa-project.org/pub/tools/alsa-tools-1.0.23.tar.bz2 ) or git pull from trunk of the "alsa-tools" project ( http://alsa-project.org/main/index.php/GIT_Server ). After unpacking and assuming you've got the patch in ~/602903.patch do: >> cd alsa-tools-1.0.23 >> cat ~/602903.patch | patch -p1 it should give message "patching file envy24control/levelmeters.c" ... follow the directions to compile alsa-tools.... Can whoever's in charge of these things commit this change "upstream" and get it to propagate to the distros? Alternately, give me commit access and I'll do it myself, if people agree this patch is worth having. Next steps: (1) Think about building-in meter ballistics from Fons Adriaensen's jkmeter ( http://www.kokkinizita.net/linuxaudio/downloads/jkmeter-0.4.0.tar.bz2 ). Which helps implent Bob Katz' "K System" ( http://www.digido.com/level-practices-part-2-includes-the-k-system.html ). Although it probably most makes sense to implement such metering on the main "digital mixer" meter of envy24control, if it's not too inefficient, I'd want it available on all meters, despite the warning from Fons ( http://old.nabble.com/First-release-of-jkmeter-td18798950.html ). > This is the type of meter you want for live recording, > mixing and mastering. It probably makes no sense to > use it on all tracks of a DAW, where keeping digital > level within limits is the main purpose of metering. (2) Fix https://bugzilla.redhat.com/show_bug.cgi?id=602900 which causes 'envy24control' to crash when given "-D" argument. and behave incorrectly when given a correct non-numeric name for an audio device: e.g. >> envy24control --card M66 >> invalid card type (driver is USB-Audio) >> envy24control --card M66 --device M66 >> Segmentation fault (core dumped) (3) Apply more reasonable defaults and automatically size to correct dimensions. I use, for example: >> envy24control --card 2 --outputs 4 --input 4 --pcm_output 8 --view_spdif_playback --midichannel 1 --midienhanced --window_width 1275 --tall_eq_mixer_heights 1 & (4) Add midi output, in addition to midi input, which would monitor the hardware peak metering from the ice1712 ("amixer -c M66 cget iface=PCM,name='Multi Track Peak',numid=45") and output a MIDI note-on on the corresponding MIDI channel whenever a specified threshold value was exceeded. This could be used to implement "automatic gain control" in association with the midi-controllable ADC gain provided by envy24control. Niels http://nielsmayer.com PS: (*) http://alsa.opensrc.org/index.php/Envy24control Cards supported by this fix: * M Audio Delta 1010 * M Audio Delta 1010LT * M Audio Delta DiO 2496 * M Audio Delta 66 * M Audio Delta 44 * M Audio Delta 410 * M Audio Audiophile 2496 * TerraTec EWS 88MT * TerraTec EWS 88D * TerraTec EWX 24/96 * TerraTec DMX 6Fire * TerraTec Phase 88 * Hoontech SoundTrack DSP 24 * Hoontech SoundTrack DSP 24 Value * Hoontech SoundTrack DSP 24 Media 7.1 * Event Electronics, EZ8 * Digigram VX442 * Lionstracs, Mediastaton * Terrasoniq TS 88

3 2

[alsa-devel] [PATCH] ASoC: au1x: fix section mismatch in psc-i2s.c
by Manuel Lauss 13 Jul '10

13 Jul '10

Annotate platform probe callback with __devinit instead of plain __init. Signed-off-by: Manuel Lauss <manuel.lauss(a)googlemail.com> --- sound/soc/au1x/psc-i2s.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/au1x/psc-i2s.c b/sound/soc/au1x/psc-i2s.c index 495be6e..24454c9 100644 --- a/sound/soc/au1x/psc-i2s.c +++ b/sound/soc/au1x/psc-i2s.c @@ -300,7 +300,7 @@ struct snd_soc_dai au1xpsc_i2s_dai = { }; EXPORT_SYMBOL(au1xpsc_i2s_dai); -static int __init au1xpsc_i2s_drvprobe(struct platform_device *pdev) +static int __devinit au1xpsc_i2s_drvprobe(struct platform_device *pdev) { struct resource *r; unsigned long sel; -- 1.7.1.1 -- To unsubscribe from this list: send the line "unsubscribe alsa-devel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

3 2

[alsa-devel] [PATCH 34/36] sound/soc/blackfin: Remove unnecessary casts of private_data
by Joe Perches 13 Jul '10

13 Jul '10

Signed-off-by: Joe Perches <joe(a)perches.com> --- sound/soc/blackfin/bf5xx-ac97.c | 6 ++---- sound/soc/blackfin/bf5xx-tdm.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/soc/blackfin/bf5xx-ac97.c b/sound/soc/blackfin/bf5xx-ac97.c index 523b7fc..c0eba51 100644 --- a/sound/soc/blackfin/bf5xx-ac97.c +++ b/sound/soc/blackfin/bf5xx-ac97.c @@ -255,8 +255,7 @@ EXPORT_SYMBOL_GPL(soc_ac97_ops); #ifdef CONFIG_PM static int bf5xx_ac97_suspend(struct snd_soc_dai *dai) { - struct sport_device *sport = - (struct sport_device *)dai->private_data; + struct sport_device *sport = dai->private_data; pr_debug("%s : sport %d\n", __func__, dai->id); if (!dai->active) @@ -271,8 +270,7 @@ static int bf5xx_ac97_suspend(struct snd_soc_dai *dai) static int bf5xx_ac97_resume(struct snd_soc_dai *dai) { int ret; - struct sport_device *sport = - (struct sport_device *)dai->private_data; + struct sport_device *sport = dai->private_data; pr_debug("%s : sport %d\n", __func__, dai->id); if (!dai->active) diff --git a/sound/soc/blackfin/bf5xx-tdm.c b/sound/soc/blackfin/bf5xx-tdm.c index 4b36012..24c1426 100644 --- a/sound/soc/blackfin/bf5xx-tdm.c +++ b/sound/soc/blackfin/bf5xx-tdm.c @@ -210,8 +210,7 @@ static int bf5xx_tdm_set_channel_map(struct snd_soc_dai *dai, #ifdef CONFIG_PM static int bf5xx_tdm_suspend(struct snd_soc_dai *dai) { - struct sport_device *sport = - (struct sport_device *)dai->private_data; + struct sport_device *sport = dai->private_data; if (!dai->active) return 0; @@ -225,8 +224,7 @@ static int bf5xx_tdm_suspend(struct snd_soc_dai *dai) static int bf5xx_tdm_resume(struct snd_soc_dai *dai) { int ret; - struct sport_device *sport = - (struct sport_device *)dai->private_data; + struct sport_device *sport = dai->private_data; if (!dai->active) return 0; -- 1.7.1.337.g6068.dirty

3 2

[alsa-devel] [patch 0/2] Kirkwood audio fixes
by arnaud.patard＠rtp-net.org 13 Jul '10

13 Jul '10

Hi, While working on the t5325 audio support, I found two small buglets in the kirkwood ASoC support. The first one is aiming at fixing mono audio playback and should fix mono playback for all platforms. The second is adding support for muting/unmuting kirkwood audio. It's mainly usefull for the t5325 which has a bootloader playing with this (hardware default is not muted). Arnaud

3 5

[alsa-devel] [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags
by Kuninori Morimoto 13 Jul '10

13 Jul '10

There is no necessity that each bit in this area has the meaning. This patch modify it to sequence number Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- v2 -> v3 o don't use << 0 shift 2/6 - 6/6 doesn't depend on 1/6 patch include/sound/sh_fsi.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/sound/sh_fsi.h b/include/sound/sh_fsi.h index c022736..3ecdb96 100644 --- a/include/sound/sh_fsi.h +++ b/include/sound/sh_fsi.h @@ -55,12 +55,12 @@ #define SH_FSI_GET_IFMT(x) ((x >> 8) & SH_FSI_FMT_MASK) #define SH_FSI_GET_OFMT(x) ((x >> 0) & SH_FSI_FMT_MASK) -#define SH_FSI_FMT_MONO (1 << 0) -#define SH_FSI_FMT_MONO_DELAY (1 << 1) -#define SH_FSI_FMT_PCM (1 << 2) -#define SH_FSI_FMT_I2S (1 << 3) -#define SH_FSI_FMT_TDM (1 << 4) -#define SH_FSI_FMT_TDM_DELAY (1 << 5) +#define SH_FSI_FMT_MONO 0 +#define SH_FSI_FMT_MONO_DELAY 1 +#define SH_FSI_FMT_PCM 2 +#define SH_FSI_FMT_I2S 3 +#define SH_FSI_FMT_TDM 4 +#define SH_FSI_FMT_TDM_DELAY 5 #define SH_FSI_IFMT_TDM_CH(x) \ (SH_FSI_IFMT(TDM) | SH_FSI_SET_CH_I(x)) -- 1.7.0.4

3 2

[alsa-devel] [PATCH 0/2] ASoC: fsi: fixup patches
by Kuninori Morimoto 13 Jul '10

13 Jul '10

Dear Mark These are v2 bug fix patches for FSI driver. Kuninori Morimoto (2): ASoC: fsi: fixup clock inversion operation ASoC: fsi: fixup wrong value setting order of TDM v1 -> v2 It is bug fix only Best regards -- Kuninori Morimoto

3 4