[Sound-open-firmware] [PATCH v2] ASoC: SOF: ipc-msg-injector: fix copy in sof_msg_inject_ipc4_dfs_write()

Mark Brown broonie at kernel.org
Thu Jul 14 16:31:06 CEST 2022


On Fri, 8 Jul 2022 16:48:36 +0300, Dan Carpenter wrote:
> There are two bugs that have to do with when we copy the payload:
> 
> 	size = simple_write_to_buffer(ipc4_msg->data_ptr,
> 			      priv->max_msg_size, ppos, buffer,
> 			      count);
> 
> The value of "*ppos" was supposed to be zero but it is
> sizeof(ipc4_msg->header_u64) so it will copy the data into the middle of
> the "ipc4_msg->data_ptr" buffer instead of to the start.  The second
> problem is "buffer" should be "buffer + sizeof(ipc4_msg->header_u64)".
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: ipc-msg-injector: fix copy in sof_msg_inject_ipc4_dfs_write()
      commit: fa9b878ff86f4adccddf62492a5894fbdb04f97d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


More information about the Sound-open-firmware mailing list