[Sound-open-firmware] [PATCH] FIX: Add dma_stop when receive trigger stop cmd in host

[Jie, Yang]

>-----Original Message-----
>From: sound-open-firmware-bounces at alsa-project.org [mailto:sound-open-
>firmware-bounces at alsa-project.org] On Behalf Of Wu Zhigang
>Sent: Wednesday, May 2, 2018 5:34 PM
>To: sound-open-firmware at alsa-project.org
>Cc: Wu Zhigang <zhigang.wu at linux.intel.com>; Wu, Zhigang
><zhigang.wu at intel.com>
>Subject: [Sound-open-firmware] [PATCH] FIX: Add dma_stop when receive trigger
>stop cmd in host
>
>when ALSA lib detect xrun issue, it will send stop and start command to DSP
>without reset. it will hit error in hds_dma_start, if we did not add the dma_stop in

Small typo. Should be 'hda_dma_start'.

Others looks good to me.

Thanks,
~Keyon

>the host_trigger function.
>
>Signed-off-by: Wu Zhigang <zhigang.wu at linux.intel.com>
>
>---
>Test with:
>Apl-gpmrb with codec
>Linux sof-v4.14: 735b995d7b66
>SOF master: 85ae8e74181f
>SOF-tools master: b327539e98f1
>---
>---
> src/audio/host.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/audio/host.c b/src/audio/host.c index bee50ce..998c5ca 100644
>--- a/src/audio/host.c
>+++ b/src/audio/host.c
>@@ -466,6 +466,7 @@ static int host_trigger(struct comp_dev *dev, int cmd)
>
> 	switch (cmd) {
> 	case COMP_TRIGGER_STOP:
>+		ret = dma_stop(hd->dma, hd->chan);
> 		ret = host_stop(dev);
> 		break;
> 	case COMP_TRIGGER_START:
>--
>2.14.1
>
>_______________________________________________
>Sound-open-firmware mailing list
>Sound-open-firmware at alsa-project.org
>http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware