[Sound-open-firmware] [PATCH] Disable high frequent trace message in dw_dma_irq_handler().

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Mar 20 15:48:33 CET 2018


On 3/20/18 3:09 AM, yan.wang at linux.intel.com wrote:
> From: Yan Wang <yan.wang at linux.intel.com>
> 
> It will cause DMA trace local buffer overflow and unnecessary.

it feels like it's time to add trace_ratelimited?

> 
> Signed-off-by: Yan Wang <yan.wang at linux.intel.com>
> ---
>   src/drivers/dw-dma.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/drivers/dw-dma.c b/src/drivers/dw-dma.c
> index a5717f3..2c46545 100644
> --- a/src/drivers/dw-dma.c
> +++ b/src/drivers/dw-dma.c
> @@ -910,11 +910,12 @@ static void dw_dma_irq_handler(void *data)
>   	int i = dma_int->channel;
>   
>   	status_intr = dw_read(dma, DW_INTR_STATUS);
> -	if (!status_intr)
> +	if (!status_intr) {
>   		trace_dma_error("eDI");
> +		trace_value(status_intr);
> +	}
>   
> -	trace_dma("irq");
> -	trace_value(status_intr);
> +	tracev_dma("irq");
>   
>   	/* get the source of our IRQ. */
>   	status_block = dw_read(dma, DW_STATUS_BLOCK);
> 



More information about the Sound-open-firmware mailing list