[Sound-open-firmware] [PATCH] Use tracev instead of trace for some high frequent traces on APL/CNL.

yan.wang at linux.intel.com yan.wang at linux.intel.com
Mon Mar 19 04:05:00 CET 2018


From: Yan Wang <yan.wang at linux.intel.com>

DMA trace itself uses DMA copying which will cause some DMA copying
related traces are called recursively.
So use tracev to avoid this.

Signed-off-by: Yan Wang <yan.wang at linux.intel.com>
---
 src/drivers/hda-dma.c | 2 +-
 src/ipc/apl-ipc.c     | 4 ++--
 src/ipc/cnl-ipc.c     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/drivers/hda-dma.c b/src/drivers/hda-dma.c
index d2064e8..caea70e 100644
--- a/src/drivers/hda-dma.c
+++ b/src/drivers/hda-dma.c
@@ -114,7 +114,7 @@ static inline void hda_update_bits(struct dma *dma, uint32_t chan,
 /* notify DMA to copy bytes */
 static int hda_dma_copy(struct dma *dma, int channel, int bytes)
 {
-	trace_host("GwU");
+	tracev_host("GwU");
 
 	/* reset BSC before start next copy */
 	hda_update_bits(dma, channel, DGCS, DGCS_BSC, DGCS_BSC);
diff --git a/src/ipc/apl-ipc.c b/src/ipc/apl-ipc.c
index 4b8ee6b..5665482 100644
--- a/src/ipc/apl-ipc.c
+++ b/src/ipc/apl-ipc.c
@@ -61,7 +61,7 @@ static void irq_handler(void *arg)
 	uint32_t dipcie;
 	uint32_t msg = 0;
 
-	trace_ipc("IRQ");
+	tracev_ipc("IRQ");
 
 	dipct = ipc_read(IPC_DIPCT);
 	dipcie = ipc_read(IPC_DIPCIE);
@@ -86,7 +86,7 @@ static void irq_handler(void *arg)
 
 	/* reply message(done) from host */
 	if (dipcie & IPC_DIPCIE_DONE) {
-		trace_ipc("Rpy");
+		tracev_ipc("Rpy");
 		/* mask Done interrupt */
 		ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) & ~IPC_DIPCCTL_IPCIDIE);
 
diff --git a/src/ipc/cnl-ipc.c b/src/ipc/cnl-ipc.c
index 15687fc..347cad2 100644
--- a/src/ipc/cnl-ipc.c
+++ b/src/ipc/cnl-ipc.c
@@ -62,7 +62,7 @@ static void irq_handler(void *arg)
 	uint32_t dipcida;
 	uint32_t msg = 0;
 
-	trace_ipc("IRQ");
+	tracev_ipc("IRQ");
 
 	dipctdr = ipc_read(IPC_DIPCTDR);
 	dipcida = ipc_read(IPC_DIPCIDA);
@@ -86,7 +86,7 @@ static void irq_handler(void *arg)
 
 	/* reply message(done) from host */
 	if (dipcida & IPC_DIPCIDA_DONE) {
-		trace_ipc("Rpy");
+		tracev_ipc("Rpy");
 		/* mask Done interrupt */
 		ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) & ~IPC_DIPCCTL_IPCIDIE);
 
-- 
2.14.3



More information about the Sound-open-firmware mailing list