[Sound-open-firmware] [PATCH] topology: byt-rt5640. Fix DAI stream name.

Liam Girdwood liam.r.girdwood at linux.intel.com
Thu Mar 15 22:14:34 CET 2018


On Thu, 2018-03-15 at 15:58 -0500, Pierre-Louis Bossart wrote:
> 
> On 03/15/2018 06:40 AM, Liam Girdwood wrote:
> > Stream name should match bytcr driver and not legacy byt-rt5640 driver.
> > 
> > Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
> > ---
> >   topology/reef-byt-rt5640.m4 | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4
> > index c971d41..879e9a9 100644
> > --- a/topology/reef-byt-rt5640.m4
> > +++ b/topology/reef-byt-rt5640.m4
> > @@ -76,14 +76,14 @@ SectionGraph."pipe-byt-rt5640" {
> >   # playback DAI is SSP2 using 2 periods
> >   # Buffers use s24le format, with 48 frame per 1000us on core 0 with
> > priority 0
> >   DAI_ADD(sof/pipe-dai-playback.m4,
> > -	1, SSP, 2, Audio
> > +	1, SSP, 2, SSP-Codec
> 
> missing comma at the end of line?
> or is this intentional?
> >   	PIPELINE_SOURCE_1, 2, s24le,
> >   	48, 1000, 0, 0)
> >   
> >   # capture DAI is SSP2 using 2 periods
> >   # Buffers use s24le format, with 48 frame per 1000us on core 0 with
> > priority 0
> >   DAI_ADD(sof/pipe-dai-capture.m4,
> > -	2, SSP, 2, Audio,
> > +	2, SSP, 2, SSP-Codec,
> >   	PIPELINE_SINK_2, 2, s24le,
> >   	48, 1000, 0, 0)
> >   
> 
> I also see something wrong here:
> 
> DAI_CONFIG(SSP, 2, Baytrail Audio, I2S, 24,
> 
> shouldn't this be SSP2-Codec?


yes, I think we have a copy paste error and we have based this on both
deprecated and bytcr file... patch coming.

Liam



More information about the Sound-open-firmware mailing list