[Sound-open-firmware] [PATCH 1/5] dai: add lbm status for dai ssp

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Jun 20 18:40:31 CEST 2018


On 6/20/18 5:43 AM, Liam Girdwood wrote:
> On Wed, 2018-06-20 at 13:55 +0800, Pan, Xiuli wrote:
>> ipc_dai_config is a shared structure from host to DSP, it should not be
>> used to save some SSP only stauts and it may also not be generic.
>> This change is made for this reason as your last two comments about
>> adding flag in
>>
>> struct sof_ipc_dai_config and struct dai with this SSP only status.
> 
> but loopback is not just for SSP, other non Intel DAIs also support it.

Humm, not sure I agree here with the logic.

Some non-Intel DAIs support LBM.
One Intel DAI out of 4 - the SSP - supports LBM

-> so what is the reason for making this field generic?
It creates a case where LBM would be configurable for Intel DAIs who 
don't support it...


More information about the Sound-open-firmware mailing list