[Sound-open-firmware] [RFC PATCH 3/6] apl-ssp: fix SCR1_SCFR

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Jul 18 04:24:28 CEST 2018


This bitfield was used in codec slave mode when it's intended
for the codec master mode - though it's not clear if it's useful
to signal that the external clock is continuously running.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
 src/drivers/apl-ssp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/drivers/apl-ssp.c b/src/drivers/apl-ssp.c
index c0b4661..b706a20 100644
--- a/src/drivers/apl-ssp.c
+++ b/src/drivers/apl-ssp.c
@@ -172,7 +172,7 @@ static inline int ssp_set_config(struct dai *dai,
 	 */
 	sscr0 = SSCR0_PSP | SSCR0_RIM | SSCR0_TIM;
 
-	/* sscr1 dynamic settings are SFRMDIR, SCLKDIR, SCFR */
+	/* sscr1 dynamic settings are SFRMDIR, SCLKDIR */
 	sscr1 = SSCR1_TTE | SSCR1_TTELP | SSCR1_TRAIL | SSCR1_RSRE | SSCR1_TSRE;
 
 	/* sscr2 dynamic setting is LJDFD */
@@ -222,7 +222,6 @@ static inline int ssp_set_config(struct dai *dai,
 		 */
 		break;
 	case SOF_DAI_FMT_CBS_CFS:
-		sscr1 |= SSCR1_SCFR;
 		ssioc |= SSIOC_SCOE;
 		break;
 	case SOF_DAI_FMT_CBM_CFS:
@@ -236,7 +235,6 @@ static inline int ssp_set_config(struct dai *dai,
 		break;
 	case SOF_DAI_FMT_CBS_CFM:
 		ssioc |= SSIOC_SCOE;
-		sscr1 |= SSCR1_SCFR;
 		/* FIXME: this mode has not been tested */
 		break;
 	default:
-- 
2.14.1



More information about the Sound-open-firmware mailing list