[Sound-open-firmware] checkpatch results for last batch
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Tue Jan 23 20:39:20 CET 2018
quite a few warnings worth fixing?
---------------------------------------------------------------
0001-platform-byt-move-DW-DMA-specific-headers-into-DMA-d.patch
---------------------------------------------------------------
WARNING: space prohibited between function name and open parenthesis '('
#24: FILE: src/drivers/dw-dma.c:167:
+#elif defined (CONFIG_BAYTRAIL) || defined (CONFIG_CHERRYTRAIL)
WARNING: space prohibited between function name and open parenthesis '('
#24: FILE: src/drivers/dw-dma.c:167:
+#elif defined (CONFIG_BAYTRAIL) || defined (CONFIG_CHERRYTRAIL)
-----------------------------------------------------
0003-core-irq-Add-support-for-nested-interrupts.patch
-----------------------------------------------------
WARNING: missing space after return type
#76: FILE: src/include/reef/interrupt.h:64:
+ void(*handler)(void *arg), void *arg);
ERROR: spaces required around that '=' (ctx:WxV)
#238: FILE: src/lib/interrupt.c:109:
+ child =parent->child[REEF_IRQ_BIT(irq)];
^
ERROR: spaces required around that '=' (ctx:WxV)
#265: FILE: src/lib/interrupt.c:136:
+ child =parent->child[REEF_IRQ_BIT(irq)];
^
--------------------------------------------------------------
0005-ipc-trace-dma_trace-cant-use-page-tables-on-APL-CNL.patch
--------------------------------------------------------------
WARNING: 'cant' may be misspelled - perhaps 'can't'?
#4:
Subject: [PATCH 05/24] ipc: trace: dma_trace cant use page tables on APL/CNL
---------------------------------------------------------------
0009-drv-dw-dma-Add-support-for-apollolake-and-cannonlake.patch
---------------------------------------------------------------
WARNING: space prohibited between function name and open parenthesis '('
#23: FILE: src/drivers/dw-dma.c:199:
+#elif defined (CONFIG_APOLLOLAKE) || defined (CONFIG_CANNONLAKE)
WARNING: space prohibited between function name and open parenthesis '('
#23: FILE: src/drivers/dw-dma.c:199:
+#elif defined (CONFIG_APOLLOLAKE) || defined (CONFIG_CANNONLAKE)
-----------------------------------------------
0010-io-Add-support-for-16bit-register-IO.patch
-----------------------------------------------
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#23: FILE: src/include/reef/io.h:53:
+ return *((volatile uint16_t*)reg);
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#28: FILE: src/include/reef/io.h:58:
+ *((volatile uint16_t*)reg) = val;
---------------------------------------------------------
0014-platform-apl-Add-xtensa-headers-for-apollolake.patch
---------------------------------------------------------
WARNING: please, no spaces at the start of a line
#643: FILE: src/platform/apollolake/include/platform/memory.h:194:
+ (L2_SRAM_SIZE - L2_VECTOR_SIZE - REEF_TEXT_SIZE - REEF_DATA_SIZE - \$
WARNING: please, no spaces at the start of a line
#644: FILE: src/platform/apollolake/include/platform/memory.h:195:
+ REEF_BSS_DATA_SIZE - HEAP_RUNTIME_SIZE - REEF_STACK_SIZE -
HEAP_SYSTEM_SIZE)$
WARNING: please, no spaces at the start of a line
#781: FILE: src/platform/apollolake/include/platform/memory.h:332:
+ (LP_SRAM_SIZE - HEAP_LP_RUNTIME_SIZE - REEF_LP_STACK_SIZE -
HEAP_LP_SYSTEM_SIZE)$
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#858: FILE: src/platform/apollolake/include/platform/platform.h:46:
+#define PLATFORM_IPC_INTERUPT IRQ_EXT_IPC_LVL2(0)
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
#928: FILE: src/platform/apollolake/include/platform/platform.h:116:
+#define platform_trace_point(__x) \
+ sw_reg_write(SW_REG_STATUS, (0xace0000 | __x) & 0x3fffffff));\
+ sw_reg_write(SW_REG_ERRCODE, __x)
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1119: FILE: src/platform/apollolake/include/platform/shim.h:162:
+ return *((volatile uint32_t*)(SHIM_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1124: FILE: src/platform/apollolake/include/platform/shim.h:167:
+ *((volatile uint32_t*)(SHIM_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1129: FILE: src/platform/apollolake/include/platform/shim.h:172:
+ return *((volatile uint64_t*)(SHIM_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1134: FILE: src/platform/apollolake/include/platform/shim.h:177:
+ *((volatile uint64_t*)(SHIM_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1139: FILE: src/platform/apollolake/include/platform/shim.h:182:
+ return *((volatile uint32_t*)(SRAM_SW_REG_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1144: FILE: src/platform/apollolake/include/platform/shim.h:187:
+ *((volatile uint32_t*)(SRAM_SW_REG_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1149: FILE: src/platform/apollolake/include/platform/shim.h:192:
+ return *((volatile uint32_t*)(MN_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1154: FILE: src/platform/apollolake/include/platform/shim.h:197:
+ *((volatile uint32_t*)(MN_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1159: FILE: src/platform/apollolake/include/platform/shim.h:202:
+ return *((volatile uint32_t*)(IRQ_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1164: FILE: src/platform/apollolake/include/platform/shim.h:207:
+ *((volatile uint32_t*)(IRQ_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1169: FILE: src/platform/apollolake/include/platform/shim.h:212:
+ return *((volatile uint32_t*)(IPC_HOST_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1174: FILE: src/platform/apollolake/include/platform/shim.h:217:
+ *((volatile uint32_t*)(IPC_HOST_BASE + reg)) = val;
-----------------------------------------------------------
0016-platform-apl-Add-platform-drivers-for-apollolake.patch
-----------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
new file mode 100644
WARNING: please, no space before tabs
#1014: FILE: src/platform/apollolake/dai.c:120:
+^I^I^I.offset ^I= SSP_BASE(4) + SSDR,$
WARNING: please, no space before tabs
#1018: FILE: src/platform/apollolake/dai.c:124:
+^I^I^I.offset ^I= SSP_BASE(4) + SSDR,$
WARNING: please, no space before tabs
#1031: FILE: src/platform/apollolake/dai.c:137:
+^I^I^I.offset ^I= SSP_BASE(5) + SSDR,$
WARNING: please, no space before tabs
#1035: FILE: src/platform/apollolake/dai.c:141:
+^I^I^I.offset ^I= SSP_BASE(5) + SSDR,$
ERROR: "foo * bar" should be "foo *bar"
#1290: FILE: src/platform/apollolake/interrupt.c:45:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1333: FILE: src/platform/apollolake/interrupt.c:88:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1376: FILE: src/platform/apollolake/interrupt.c:131:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1419: FILE: src/platform/apollolake/interrupt.c:174:
+ struct irq_child * child = NULL;
WARNING: braces {} are not necessary for single statement blocks
#1546: FILE: src/platform/apollolake/interrupt.c:301:
+ for (i = 0; i < ARRAY_SIZE(dsp_irq); i++) {
+ spinlock_init(&dsp_irq[i].lock);
+ }
ERROR: Use of the '__DATE__' macro makes the build non-deterministic
#1618: FILE: src/platform/apollolake/platform.c:63:
+ .date = __DATE__,
ERROR: Use of the '__TIME__' macro makes the build non-deterministic
#1619: FILE: src/platform/apollolake/platform.c:64:
+ .time = __TIME__,
WARNING: 'postion' may be misspelled - perhaps 'position'?
#1900: FILE: src/platform/apollolake/timer.c:87:
+ /* get host postion */
WARNING: 'postion' may be misspelled - perhaps 'position'?
#1912: FILE: src/platform/apollolake/timer.c:99:
+ /* get DAI postion */
----------------------------------------------------
0017-ipc-apl-Add-support-for-IPC-on-apollolake.patch
----------------------------------------------------
ERROR: need consistent spacing around '|' (ctx:WxV)
#133: FILE: src/ipc/apl-ipc.c:94:
+ ipc_write(IPC_DIPCIE, ipc_read(IPC_DIPCIE) |IPC_DIPCIE_DONE);
^
ERROR: need consistent spacing around '|' (ctx:WxV)
#170: FILE: src/ipc/apl-ipc.c:131:
+ ipc_write(IPC_DIPCT, ipc_read(IPC_DIPCT) |IPC_DIPCT_BUSY );
^
ERROR: space prohibited before that close parenthesis ')'
#170: FILE: src/ipc/apl-ipc.c:131:
+ ipc_write(IPC_DIPCT, ipc_read(IPC_DIPCT) |IPC_DIPCT_BUSY );
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#246: FILE: src/ipc/apl-ipc.c:207:
+ interrupt_register(PLATFORM_IPC_INTERUPT, irq_handler, NULL);
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#247: FILE: src/ipc/apl-ipc.c:208:
+ interrupt_enable(PLATFORM_IPC_INTERUPT);
0020-platform-cnl-Add-xtensa-headers-for-cannonlake.patch has style
problems, please review.
-------------------------------------------------------
0021-platform-cnl-Add-cannonlake-platform-headers.patch
-------------------------------------------------------
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#848: FILE: src/platform/cannonlake/include/platform/platform.h:49:
+#define PLATFORM_IPC_INTERUPT IRQ_EXT_IPC_LVL2(0)
WARNING: line over 80 characters
#872: FILE: src/platform/cannonlake/include/platform/platform.h:73:
+/* DMA channel drain timeout in microseconds - TODO: caclulate based on
topology */
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
#918: FILE: src/platform/cannonlake/include/platform/platform.h:119:
+#define platform_trace_point(__x) \
+ sw_reg_write(SW_REG_STATUS, (0xace0000 | __x) & 0x3fffffff));\
+ sw_reg_write(SW_REG_ERRCODE, __x)
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1152: FILE: src/platform/cannonlake/include/platform/shim.h:205:
+ return *((volatile uint16_t*)(SHIM_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1157: FILE: src/platform/cannonlake/include/platform/shim.h:210:
+ *((volatile uint16_t*)(SHIM_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1162: FILE: src/platform/cannonlake/include/platform/shim.h:215:
+ return *((volatile uint32_t*)(SHIM_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1167: FILE: src/platform/cannonlake/include/platform/shim.h:220:
+ *((volatile uint32_t*)(SHIM_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1172: FILE: src/platform/cannonlake/include/platform/shim.h:225:
+ return *((volatile uint64_t*)(SHIM_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1177: FILE: src/platform/cannonlake/include/platform/shim.h:230:
+ *((volatile uint64_t*)(SHIM_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1182: FILE: src/platform/cannonlake/include/platform/shim.h:235:
+ return *((volatile uint32_t*)(SRAM_SW_REG_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1187: FILE: src/platform/cannonlake/include/platform/shim.h:240:
+ *((volatile uint32_t*)(SRAM_SW_REG_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1192: FILE: src/platform/cannonlake/include/platform/shim.h:245:
+ return *((volatile uint32_t*)(MN_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1197: FILE: src/platform/cannonlake/include/platform/shim.h:250:
+ *((volatile uint32_t*)(MN_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1202: FILE: src/platform/cannonlake/include/platform/shim.h:255:
+ return *((volatile uint32_t*)(IRQ_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1207: FILE: src/platform/cannonlake/include/platform/shim.h:260:
+ *((volatile uint32_t*)(IRQ_BASE + reg)) = val;
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1212: FILE: src/platform/cannonlake/include/platform/shim.h:265:
+ return *((volatile uint32_t*)(IPC_HOST_BASE + reg));
WARNING: Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rst
#1217: FILE: src/platform/cannonlake/include/platform/shim.h:270:
+ *((volatile uint32_t*)(IPC_HOST_BASE + reg)) = val;
-------------------------------------------------------
0022-platform-Add-platform-drivers-for-cannonlake.patch
-------------------------------------------------------
ERROR: "foo * bar" should be "foo *bar"
#1743: FILE: src/platform/cannonlake/interrupt.c:45:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1786: FILE: src/platform/cannonlake/interrupt.c:88:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1829: FILE: src/platform/cannonlake/interrupt.c:131:
+ struct irq_child * child = NULL;
ERROR: "foo * bar" should be "foo *bar"
#1872: FILE: src/platform/cannonlake/interrupt.c:174:
+ struct irq_child * child = NULL;
WARNING: braces {} are not necessary for single statement blocks
#1999: FILE: src/platform/cannonlake/interrupt.c:301:
+ for (i = 0; i < ARRAY_SIZE(dsp_irq); i++) {
+ spinlock_init(&dsp_irq[i].lock);
+ }
ERROR: Use of the '__DATE__' macro makes the build non-deterministic
#2073: FILE: src/platform/cannonlake/platform.c:65:
+ .date = __DATE__,
ERROR: Use of the '__TIME__' macro makes the build non-deterministic
#2074: FILE: src/platform/cannonlake/platform.c:66:
+ .time = __TIME__,
ERROR: need consistent spacing around '|' (ctx:WxV)
#2189: FILE: src/platform/cannonlake/platform.c:181:
+ IOPO_DMIC_FLAG |IOPO_I2S_FLAG);
^
ERROR: space required before the open parenthesis '('
#2272: FILE: src/platform/cannonlake/platform.c:264:
+ for(i = 0; i < PLATFORM_SSP_COUNT; i++) {
WARNING: 'postion' may be misspelled - perhaps 'position'?
#2374: FILE: src/platform/cannonlake/timer.c:88:
+ /* get host postion */
WARNING: 'postion' may be misspelled - perhaps 'position'?
#2386: FILE: src/platform/cannonlake/timer.c:100:
+ /* get DAI postion */
----------------------------------------------------
0023-ipc-cnl-Add-support-for-IPC-on-cannonlake.patch
----------------------------------------------------
ERROR: need consistent spacing around '|' (ctx:WxV)
#133: FILE: src/ipc/cnl-ipc.c:94:
+ ipc_write(IPC_DIPCIDA, ipc_read(IPC_DIPCIDA) |IPC_DIPCIDA_DONE);
^
WARNING: line over 80 characters
#136: FILE: src/ipc/cnl-ipc.c:97:
+ ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) |
IPC_DIPCCTL_IPCIDIE);
ERROR: need consistent spacing around '|' (ctx:WxV)
#170: FILE: src/ipc/cnl-ipc.c:131:
+ ipc_write(IPC_DIPCTDR, ipc_read(IPC_DIPCTDR) |IPC_DIPCTDR_BUSY);
^
ERROR: need consistent spacing around '|' (ctx:WxV)
#171: FILE: src/ipc/cnl-ipc.c:132:
+ ipc_write(IPC_DIPCTDA, ipc_read(IPC_DIPCTDA) |IPC_DIPCTDA_BUSY );
^
ERROR: space prohibited before that close parenthesis ')'
#171: FILE: src/ipc/cnl-ipc.c:132:
+ ipc_write(IPC_DIPCTDA, ipc_read(IPC_DIPCTDA) |IPC_DIPCTDA_BUSY );
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#244: FILE: src/ipc/cnl-ipc.c:205:
+ interrupt_register(PLATFORM_IPC_INTERUPT, irq_handler, NULL);
WARNING: 'INTERUPT' may be misspelled - perhaps 'INTERRUPT'?
#245: FILE: src/ipc/cnl-ipc.c:206:
+ interrupt_enable(PLATFORM_IPC_INTERUPT);
More information about the Sound-open-firmware
mailing list