[Sound-open-firmware] [PATCH 2/2] dai: add fall through comment in switch case

Liam Girdwood liam.r.girdwood at intel.com
Fri Jan 19 10:15:17 CET 2018


On Thu, 2018-01-18 at 14:31 -0600, Pierre-Louis Bossart wrote:
> Explicitly comment that the fall through in a switch case is not
> a typo to make Coverity warnings go away.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel
> .com>
> ---
>  src/audio/dai.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/audio/dai.c b/src/audio/dai.c
> index b7ad1b4..1112ec9 100644
> --- a/src/audio/dai.c
> +++ b/src/audio/dai.c
> @@ -559,6 +559,7 @@ static int dai_cmd(struct comp_dev *dev, int cmd,
> void *data)
>  		break;
>  	case COMP_CMD_XRUN:
>  		dd->xrun = 1;
> +		/* fall through */
>  	case COMP_CMD_PAUSE:
>  	case COMP_CMD_STOP:
>  		wait_init(&dd->complete);

Applied patch 2/2, I think it's better to make 1/2 static inline.

Thanks

Liam
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the Sound-open-firmware mailing list