[Sound-open-firmware] [PATCH] host: set host_size in params()

Keyon Jie yang.jie at linux.intel.com
Fri Jan 19 03:00:57 CET 2018


Hi Liam,

Could you help review and merge this?

It is small and easy one but it do fix the hd->host_size may be 
initialized multiple times issue.

Thanks,
~Keyon


On 2018年01月16日 21:59, Keyon Jie wrote:
> We don't need set host buffer size in each sg_elem, instead,
> we can set it only one time, here set it in params().
> 
> Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
> ---
> Sanity test passed on minnow turbot with rt5651.
> SOF #master: commit 83fec1559716d5a06137b43848abc18c244bc9e6
> SOF Tool #master: commit a6bb8de907acd642302a227f403bb9fb2c18d075
> Kernel: git at github.com:plbossart/sound.git #topic/sof-v4.14:
> 	commit 772ab0da7a8298d08edd42ab9a4f4177ec37aec6
> 
>   src/audio/host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/audio/host.c b/src/audio/host.c
> index 0a047b3..bdf947c 100644
> --- a/src/audio/host.c
> +++ b/src/audio/host.c
> @@ -390,6 +390,7 @@ static int host_params(struct comp_dev *dev)
>   	trace_host("par");
>   
>   	/* host params always installed by pipeline IPC */
> +	hd->host_size = dev->params.buffer.size;
>   
>   	/* determine source and sink buffer elems */
>   	if (dev->params.direction == SOF_IPC_STREAM_PLAYBACK) {
> @@ -559,7 +560,6 @@ static int host_buffer(struct comp_dev *dev, struct dma_sg_elem *elem,
>   		return -ENOMEM;
>   
>   	*e = *elem;
> -	hd->host_size = host_size;
>   
>   	list_item_append(&e->list, &hd->host.elem_list);
>   	return 0;
> 


More information about the Sound-open-firmware mailing list