[Sound-open-firmware] [PATCH 0/2] DMA trace level

[yanwang]

On Fri, 2018-04-13 at 00:09 +0800, Pan, Xiuli wrote:
> 
> On 4/12/2018 23:32, Yan Wang wrote:
> > 
> > 
> > 
> > On 4/12/2018 11:07 PM, Liam Girdwood wrote:
> > > 
> > > On Thu, 2018-04-12 at 22:48 +0800, Yan Wang wrote:
> > > > 
> > > > 
> > > > On 4/12/2018 10:14 PM, Liam Girdwood wrote:
> > > > > 
> > > > > On Thu, 2018-04-12 at 15:46 +0800, yan.wang at linux.intel.com
> > > > > wrote:
> > > > > > 
> > > > > > From: Yan Wang <yan.wang at linux.intel.com>
> > > > > > 
> > > > > > Implement DMA trace level based on modules.
> > > > > > User can switch on/off for DMA trace of one module.
> > > > > > 
> > > > > 
> > > > > Are there any updates to userspace rmbox tools to use this
> > > > > feature ?
> > > > 
> > > > No currently.
> > > > IMHO, we could use "echo/cat /sys/kernel/debug/sof/trace_level"
> > > > to
> > > > control it.
> > > > So need I also add another control path to control it by rmbox?
> > > > Thanks.
> > > > 
> > > 
> > > yeah, we could have a debugFS file "trace_control" and we would
> > > send :-
> > > 
> > > echo "VOL1.1:pipeline:2"
> > > 
> > > format is component:class:level
> > 
> > Some trace class may not bind with component. E.g. trace_ipc().
> > May we ignore component key in this case?
> > Thanks.
> > 
> You can handle that in the debugfs file write function.
> For those comp did not bind to PCM, you can check other formats.

Yes,  I can try it.

> 
> But there is also some risk here if we need to phrase these strings,
> we 
> may typo and may hard to modify the trace level.
> I suggest we add a tool alongside the rmbox to set these for us. We
> can 
> still use string for status check but a tool to generate the string
> for us.

Based on Liam's comments, I will add control into rmbox. I will try to
cover this point.
Thanks.

Yan Wang

> 
> Thanks
> Xiuli
> 
> > 
> > Yan Wang
> > 
> > > 
> > > 
> > > This would set trace to level 2 on component "VOL1.1" for
> > > pipeline 
> > > operations
> > > 
> > > cat trace_control
> > > 
> > > would list each widget and the trace level for that widget.
> > > 
> > > Liam
> > > 
> > > > 
> > > > Yan Wang
> > > > 
> > > > > 
> > > > > 
> > > > > Liam
> > > > > 
> > > > 
> > > > _______________________________________________
> > > > Sound-open-firmware mailing list
> > > > Sound-open-firmware at alsa-project.org
> > > > http://mailman.alsa-project.org/mailman/listinfo/sound-open-fir
> > > > mware
> > _______________________________________________
> > Sound-open-firmware mailing list
> > Sound-open-firmware at alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmwar
> > e
>