[Sound-open-firmware] [PATCH] ssp: irq: fix handler comment and remove FIFO empty loop

Liam Girdwood liam.r.girdwood at linux.intel.com
Thu Sep 21 00:33:23 CEST 2017


Comment is wrong and FIFO empty not needed in IRQ handler.

Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
---
 src/drivers/ssp.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/drivers/ssp.c b/src/drivers/ssp.c
index b87806e..7538edd 100644
--- a/src/drivers/ssp.c
+++ b/src/drivers/ssp.c
@@ -370,19 +370,14 @@ static int ssp_trigger(struct dai *dai, int cmd, int direction)
 	return 0;
 }
 
-/* The IRQ handler allows the SSP port to drain the playback FIFO to make sure
- * every sample has been played */
+/* clear IRQ sources atm */
 static void ssp_irq_handler(void *data)
 {
 	struct dai *dai = data;
-	int i;
 
+	trace_ssp("irq");
 	trace_value(ssp_read(dai, SSSR));
 
-	/* empty Rx FIFO */
-	for (i = 0; i < 16; i++)
-		ssp_read(dai, SSDR);
-
 	/* clear IRQ */
 	ssp_write(dai, SSSR, ssp_read(dai, SSSR));
 	platform_interrupt_clear(ssp_irq(dai), 1);
-- 
2.11.0



More information about the Sound-open-firmware mailing list