[Sound-open-firmware] [PATCH 4/4] ipc: values: read value ID and context from component data before use.
Liam Girdwood
liam.r.girdwood at linux.intel.com
Fri Jun 9 19:00:26 CEST 2017
Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
---
src/ipc/intel-ipc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c
index 0fd9b0c..57922cc 100644
--- a/src/ipc/intel-ipc.c
+++ b/src/ipc/intel-ipc.c
@@ -468,23 +468,24 @@ static uint32_t ipc_comp_set_value(uint32_t header, uint32_t cmd)
static uint32_t ipc_comp_get_value(uint32_t header, uint32_t cmd)
{
struct ipc_comp_dev *stream_dev;
- struct sof_ipc_ctrl_values values;
+ struct sof_ipc_ctrl_values *values = _ipc->comp_data;
int ret;
trace_ipc("VoG");
+
/* get the component */
- stream_dev = ipc_get_comp(_ipc, values.comp_id);
+ stream_dev = ipc_get_comp(_ipc, values->comp_id);
if (stream_dev == NULL)
return -ENODEV;
/* get component values */
- ret = comp_cmd(stream_dev->cd, COMP_CMD_VOLUME, &values);
+ ret = comp_cmd(stream_dev->cd, COMP_CMD_VOLUME, values);
if (ret < 0)
return ret;
/* write component values to the outbox */
- mailbox_outbox_write(&values, 0, sizeof(values));
+ mailbox_outbox_write(values, 0, sizeof(*values));
return 0;
}
--
2.11.0
More information about the Sound-open-firmware
mailing list