[Sound-open-firmware] [PATCH] byt-ipc: fix a src/dst error

Keyon Jie yang.jie at linux.intel.com
Fri Jul 7 10:08:55 CEST 2017


We should copy from [inbox_base + offset(0 here)] src to
msg->rx_data dst here, otherwise, copying to 0 dst will
crash the firmware here.

Reported-by: Luo Xionghu <xionghu.luo at intel.com>
Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
---
 src/ipc/byt-ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipc/byt-ipc.c b/src/ipc/byt-ipc.c
index b1bec23..ef30bbc 100644
--- a/src/ipc/byt-ipc.c
+++ b/src/ipc/byt-ipc.c
@@ -68,7 +68,7 @@ static void do_notify(void)
 
 	/* copy the data returned from DSP */
 	if (msg->rx_size && msg->rx_size < MSG_MAX_SIZE)
-		mailbox_inbox_read(0, msg->rx_data, msg->rx_size);
+		mailbox_inbox_read(msg->rx_data, 0, msg->rx_size);
 
 	/* any callback ? */
 	if (msg->cb)
-- 
2.11.0



More information about the Sound-open-firmware mailing list