[Sound-open-firmware] [PATCH] git-version: Fix REEF_TAG bug when having rc tags

Keyon Jie yang.jie at linux.intel.com
Mon Dec 4 10:12:10 CET 2017



On 2017年12月04日 03:40, Xiuli Pan wrote:
> From: Pan Xiuli <xiuli.pan at linux.intel.com>
> 
> Use git log to make sure REEF_TAG has git commit.

can you explain why it doesn't have git commit previously?

> ---
>   git-version.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-version.sh b/git-version.sh
> index faa0daa..1c2d275 100755
> --- a/git-version.sh
> +++ b/git-version.sh
> @@ -7,7 +7,7 @@ git describe --abbrev=4 > .version
>   git describe --abbrev=4 > .tarball-version
>   
>   # git commit for IPC
> -echo "#define REEF_TAG \"`git describe --abbrev=4 | cut -d- -f3`\"" > src/include/version.h

with this, we will output "gxxxx" to version.h

> +echo "#define REEF_TAG \"`git log --pretty=format:\"%h\" -1 | cut -c1-5`\"" > src/include/version.h

how about this?

Thanks,
~Keyon

>   
>   # build counter
>   if [ -e .build ]; then
> 


More information about the Sound-open-firmware mailing list