[Sound-open-firmware] [PATCH] ipc: make sure all messages start at 1 instead of 0 to simplify debug

Liam Girdwood liam.r.girdwood at linux.intel.com
Thu Aug 24 23:15:07 CEST 2017


Messages starting at offset 1 remove any ambiguity over whether the
message has been constructed correctly.

Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
---
 src/include/uapi/ipc.h | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h
index 003b96e..c820118 100644
--- a/src/include/uapi/ipc.h
+++ b/src/include/uapi/ipc.h
@@ -70,9 +70,9 @@
 
 
 /* topology */
-#define SOF_IPC_TPLG_COMP_NEW			SOF_CMD_TYPE(0x000)
-#define SOF_IPC_TPLG_COMP_FREE			SOF_CMD_TYPE(0x001)
-#define SOF_IPC_TPLG_COMP_CONNECT		SOF_CMD_TYPE(0x002)
+#define SOF_IPC_TPLG_COMP_NEW			SOF_CMD_TYPE(0x001)
+#define SOF_IPC_TPLG_COMP_FREE			SOF_CMD_TYPE(0x002)
+#define SOF_IPC_TPLG_COMP_CONNECT		SOF_CMD_TYPE(0x003)
 #define SOF_IPC_TPLG_PIPE_NEW			SOF_CMD_TYPE(0x010)
 #define SOF_IPC_TPLG_PIPE_FREE			SOF_CMD_TYPE(0x011)
 #define SOF_IPC_TPLG_PIPE_CONNECT		SOF_CMD_TYPE(0x012)
@@ -81,22 +81,22 @@
 #define SOF_IPC_TPLG_BUFFER_FREE		SOF_CMD_TYPE(0x021)
 
 /* PM */
-#define SOF_IPC_PM_CTX_SAVE			SOF_CMD_TYPE(0x000)
-#define SOF_IPC_PM_CTX_RESTORE			SOF_CMD_TYPE(0x001)
-#define SOF_IPC_PM_CTX_SIZE			SOF_CMD_TYPE(0x002)
-#define SOF_IPC_PM_CLK_SET			SOF_CMD_TYPE(0x003)
-#define SOF_IPC_PM_CLK_GET			SOF_CMD_TYPE(0x004)
-#define SOF_IPC_PM_CLK_REQ			SOF_CMD_TYPE(0x005)
+#define SOF_IPC_PM_CTX_SAVE			SOF_CMD_TYPE(0x001)
+#define SOF_IPC_PM_CTX_RESTORE			SOF_CMD_TYPE(0x002)
+#define SOF_IPC_PM_CTX_SIZE			SOF_CMD_TYPE(0x003)
+#define SOF_IPC_PM_CLK_SET			SOF_CMD_TYPE(0x004)
+#define SOF_IPC_PM_CLK_GET			SOF_CMD_TYPE(0x005)
+#define SOF_IPC_PM_CLK_REQ			SOF_CMD_TYPE(0x006)
 
 /* component - multiple different types */
-#define SOF_IPC_COMP_SET_VOLUME			SOF_CMD_TYPE(0x000)
-#define SOF_IPC_COMP_GET_VOLUME			SOF_CMD_TYPE(0x001)
-#define SOF_IPC_COMP_SET_MIXER			SOF_CMD_TYPE(0x002)
-#define SOF_IPC_COMP_GET_MIXER			SOF_CMD_TYPE(0x003)
-#define SOF_IPC_COMP_SET_MUX			SOF_CMD_TYPE(0x004)
-#define SOF_IPC_COMP_GET_MUX			SOF_CMD_TYPE(0x005)
-#define SOF_IPC_COMP_SET_SRC			SOF_CMD_TYPE(0x006)
-#define SOF_IPC_COMP_GET_SRC			SOF_CMD_TYPE(0x007)
+#define SOF_IPC_COMP_SET_VOLUME			SOF_CMD_TYPE(0x001)
+#define SOF_IPC_COMP_GET_VOLUME			SOF_CMD_TYPE(0x002)
+#define SOF_IPC_COMP_SET_MIXER			SOF_CMD_TYPE(0x003)
+#define SOF_IPC_COMP_GET_MIXER			SOF_CMD_TYPE(0x004)
+#define SOF_IPC_COMP_SET_MUX			SOF_CMD_TYPE(0x005)
+#define SOF_IPC_COMP_GET_MUX			SOF_CMD_TYPE(0x006)
+#define SOF_IPC_COMP_SET_SRC			SOF_CMD_TYPE(0x007)
+#define SOF_IPC_COMP_GET_SRC			SOF_CMD_TYPE(0x008)
 
 /* DAI messages */
 #define SOF_IPC_DAI_CONFIG			SOF_CMD_TYPE(0x001)
-- 
2.11.0



More information about the Sound-open-firmware mailing list