[Sound-open-firmware] [PATCH 0/8] SSP: baytrail 24 bits support

[Liam Girdwood]

On Tue, 2016-12-20 at 13:32 +0000, Jie, Yang wrote:
> > -----Original Message-----
> > From: Liam Girdwood [mailto:liam.r.girdwood at linux.intel.com]
> > Sent: Tuesday, December 20, 2016 6:42 PM
> > To: Keyon Jie <yang.jie at linux.intel.com>
> > Cc: sound-open-firmware at alsa-project.org; Jie, Yang <yang.jie at intel.com>;
> > Ingalsuo, Seppo <seppo.ingalsuo at intel.com>; Zhang, Keqiao
> > <keqiao.zhang at intel.com>; Lin, Mengdong <mengdong.lin at intel.com>
> > Subject: Re: [PATCH 0/8] SSP: baytrail 24 bits support
> > 
> > On Tue, 2016-12-20 at 15:46 +0800, Keyon Jie wrote:
> > > This series is created to change the SSP format setting for both Tx
> > > and Rx, and it is verified on MinnowMax +
> > > ALC5651 codec with I2S stereo both SSP_CLK_EXT and SSP_CLK_AUDIO mode.
> > > Changes including:
> > > 1. change ssp clock from 25M to 19.2M; 2. add 16bit <==> 24bit volume
> > > converting functions; 3. switch to use I2S mode(more common on host
> > > side); 4. change ssp stream format to 24 bits; 5. remove the usage of
> > > shim SSP divider and use SSCR0.SCR for BCLK generating.
> > >
> > 
> > Looks good, but can you do a V2 and also include a patch that removes the M/N
> > divider clock code (since we no longer use M/N).
> 
> Are you meaning that remove them from platform.c?
> Or shall we keep them ATM, and delete after verified they are not needed anymore?
> Patch 8/8 already removed the calling to them.
> 

Remove them completely from all the code. I think everything is using
SCR now with these patches ?

Liam

> Thanks,
> ~Keyon
> > 
> > Thanks
> > 
> > Liam
> > 
>