<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 11/12/2019 6:10 PM, Mark Brown
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20191112171022.GG5195@sirena.co.uk">
<pre class="moz-quote-pre" wrap="">On Tue, Nov 12, 2019 at 02:02:37PM +0100, Pawel Harlozinski wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> /* Disable jack detection */
regmap_update_bits(rt274->regmap, RT274_EAPD_GPIO_IRQ_CTRL,
RT274_IRQ_EN, RT274_IRQ_DIS);
-
+ disable_irq(rt274->i2c->irq);
return 0;
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Shouldn't the register update above be suppressing interrupts?</pre>
</blockquote>
For rt274 disable_irq is also needed, otherwise we're getting flood
of irq's in case of not loaded machine board.<br>
<blockquote type="cite"
cite="mid:20191112171022.GG5195@sirena.co.uk">
<pre class="moz-quote-pre" wrap="">disable_irq() is a bit of a hammer and interferes with things like
possible share use.
</pre>
</blockquote>
<p>This irq should be handled in codec code anyway - control of jack
detect events from non-codec code is done with set_jack.<br>
Similar solutions for jack report irq enable/disable flow are
implemented in rt5640 and rt5651.</p>
<blockquote type="cite"
cite="mid:20191112171022.GG5195@sirena.co.uk">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Alsa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Alsa-devel@alsa-project.org">Alsa-devel@alsa-project.org</a>
<a class="moz-txt-link-freetext" href="https://mailman.alsa-project.org/mailman/listinfo/alsa-devel">https://mailman.alsa-project.org/mailman/listinfo/alsa-devel</a>
</pre>
</blockquote>
</body>
</html>