[PATCH 2/4] ASoC: codecs: tas5720: add support for TAS5720A-Q1 (automotive) variant

Alexandru Ardelean alex at shruggie.ro
Sat Jan 28 09:17:46 CET 2023


On Wed, Jan 25, 2023 at 4:23 PM Mark Brown <broonie at kernel.org> wrote:
>
> On Sun, Jan 15, 2023 at 09:33:45PM +0200, Alexandru Ardelean wrote:
>
> >  static int tas5720_mute_soc_component(struct snd_soc_component *component, int mute)
> >  {
> > +     unsigned int reg, mask, val;
> >       int ret;
> >
> > -     ret = snd_soc_component_update_bits(component, TAS5720_DIGITAL_CTRL2_REG,
> > -                               TAS5720_MUTE, mute ? TAS5720_MUTE : 0);
> > +     switch (tas5720->devtype) {
> > +     case TAS5720A_Q1:
>
> This doesn't build:

My bad.
Will fix

>
> /build/stage/linux/sound/soc/codecs/tas5720.c:217:17: error: ‘tas5720’ undeclare
> d (first use in this function); did you mean ‘TAS5720’?
>   217 |         switch (tas5720->devtype) {
>       |                 ^~~~~~~
>       |                 TAS5720
> /build/stage/linux/sound/soc/codecs/tas5720.c:217:17: note: each undeclared iden
> tifier is reported only once for each function it appears in
> /build/stage/linux/sound/soc/codecs/tas5720.c:214:33: error: unused variable ‘va
> l’ [-Werror=unused-variable]
>   214 |         unsigned int reg, mask, val;
>       |                                 ^~~
> cc1: all warnings being treated as errors


More information about the Alsa-devel mailing list