[PATCH] ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure

AngeloGioacchino Del Regno angelogioacchino.delregno at collabora.com
Fri Jan 20 12:02:31 CET 2023


Il 20/01/23 11:21, Peter Ujfalusi ha scritto:
> If the swidget is NULL we skip the preparing of the widget and jump to
> handle the sink path of the widget.
> If the prepare fails in this case we would undo the prepare but the swidget
> is NULL (we skipped the prepare for the widget).
> 
> To avoid NULL pointer dereference in this case we must check swidget
> against NULL pointer once again.
> 
> 
> Fixes: 0ad84b11f2f8 ("ASoC: SOF: sof-audio: skip prepare/unprepare if swidget is NULL")
> Reported-by: kernel test robot <lkp at intel.com>
> Reported-by: Dan Carpenter <error27 at gmail.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at linux.intel.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>




More information about the Alsa-devel mailing list