[PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume

Thorsten Leemhuis regressions at leemhuis.info
Thu Jan 5 11:14:13 CET 2023


On 05.01.23 10:35, Takashi Iwai wrote:
> The recent commit to support the system suspend for CS35L41 caused a
> regression on the models with CS35L41_EXT_BOOST_NO_VSPK_SWITC boost
> type, as the suspend/resume callbacks just return -EINVAL.  This is
> eventually handled as a fatal error and blocks the whole system
> suspend/resume.
> 
> For avoiding the problem, this patch corrects the return code from
> cs35l41_system_suspend() and _resume() to 0, and replace dev_err()
> with dev_err_once() for stop spamming too much.
> 
> Fixes: 88672826e2a4 ("ALSA: hda: cs35l41: Support System Suspend")
> Cc: <stable at vger.kernel.org>

Thx for taking care of that.

> Link: https://lore.kernel.org/r/4262e3c4-6169-bbd2-e918-16b06f6994bc@protonmail.com

Lore says "Not found". I wonder if it was a private mail later send
again here:

https://lore.kernel.org/all/e6751ac2-34f3-d13f-13db-8174fade8308@pm.me/

Ciao, Thorsten


More information about the Alsa-devel mailing list