[PATCH 3/3] ASOC: sma1303: change the overall contents

Mark Brown broonie at kernel.org
Wed Jan 4 14:17:49 CET 2023


On Wed, Jan 04, 2023 at 03:43:42PM +0900, Kiseok Jo wrote:
> Change the component function like DAPM route, widget and controls.
> Apply the hw params according to DAI fmt.(Not be user controllable)
> Remove unnecessary content.
> Revise the style following the kernel coding style.

This is too many different things going on in one commit - it really
needs to be split up, and things like fixing to use hw_params should be
part of the original commit (which I've not looked at yet).  Try to have
one thing per commit with the commit log saying specifically what the
change is doing so that reviwers can make sure the code changes are
doign what they're supposed to.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20230104/f735c916/attachment.sig>


More information about the Alsa-devel mailing list