[PATCH 1/3] ASoC: dt-bindings: irondevice, sma1303: Rework binding and add missing properties

Ki-Seok Jo kiseok.jo at irondevice.com
Sat Feb 4 02:20:16 CET 2023


> 
> > +  sys-clk-id:
> > +    description:
> > +      select the using system clock.
> > +      0 = External Clock 19.2MHz
> > +      1 = External Clock 24.576MHz
> > +      2 = Using PLL in MCLK
> > +      3 = Using PLL in BCLK
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> > +    maximum: 3
> > +    default: 3
> 
> We really shouldn't have this as a custom property, we should be using a
> combination of the clock bindings.
> 
> In the driver this would turn into using clk_get() to get the MCLK, then
> we can query the rate with clk_get_rate() and use option 0 or 1 if the
> rate matches, or the PLL otherwise.  If we fail to get MCLK then we can
> fall back to using BCLK.

Okay, I got it.
I'll make it based on what you sent me using other drivers.
Thanks, your feedback.

Best regards,
Kiseok Jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 499 bytes
Desc: signature.asc
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20230204/adf3d280/attachment.sig>


More information about the Alsa-devel mailing list