[PATCH] ASoC: tas2562: Propagate the error in tas2562_dac_event()

[Martin Povišer]

> On 14. 9. 2022, at 1:17, Fabio Estevam <festevam at gmail.com> wrote:
> 
> From: Fabio Estevam <festevam at denx.de>
> 
> Since commit 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute") the
> following build warning is seen:
> 
> sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> 
> Fix the warning by returning the 'ret' variable.
> 
> Fixes: 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute")
> Signed-off-by: Fabio Estevam <festevam at denx.de>

That’s right, ret should be propagated. Thanks!

Reviewed-by: Martin Povišer <povik+lin at cutebit.org>

> ---
> sound/soc/codecs/tas2562.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
> index 66149055aba9..b486d0bd86c9 100644
> --- a/sound/soc/codecs/tas2562.c
> +++ b/sound/soc/codecs/tas2562.c
> @@ -439,7 +439,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w,
> 	struct snd_soc_component *component =
> 					snd_soc_dapm_to_component(w->dapm);
> 	struct tas2562_data *tas2562 = snd_soc_component_get_drvdata(component);
> -	int ret;
> +	int ret = 0;
> 
> 	switch (event) {
> 	case SND_SOC_DAPM_POST_PMU:
> @@ -455,7 +455,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w,
> 		return -EINVAL;
> 	}
> 
> -	return 0;
> +	return ret;
> }
> 
> static int tas2562_volume_control_get(struct snd_kcontrol *kcontrol,
> -- 
> 2.25.1
>