[PATCH 2/2] ASoC: dt-bindings: nau8825: Add ADCOUT IO drive strength control

Mark Brown broonie at kernel.org
Tue Sep 13 12:59:19 CEST 2022


On Tue, Sep 13, 2022 at 03:25:39PM +0800, AS50 CTLin0 wrote:

> OK, maybe I should change property name to "adcout-drive-strong" and the
> description to "make the drive strength of ADCOUT IO PIN strong if set.
> Otherwise, the drive keeps normal strength.".

That sounds good.

> > Perhaps adding something like "strong" would be good - with the
> > name I'd expected the property to be a numerical strength rather
> > than a boolean.

> From our design, the register just have one bit for this feature, so
> the strength just have normal or stronger. Therefore, I use boolean
> property for it.

Using a boolean property is fine, it just feels weird that it
doesn't say specifically what "stronger" means here.  I was just
thinking adding a note in the description but either way it's not
essential.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220913/96755af6/attachment.sig>


More information about the Alsa-devel mailing list