[PATCH] ASoC: ts3a227e: allow enabling the jack detect in driver

Astrid Rost astridr at axis.com
Mon Sep 12 09:17:12 CEST 2022


Hello,


 > New properties need to be documented, I'm happy for that to be in the
 > existing document though obviously a conversion to YAML would be very
 > much appreciated.  However...

Yes, I am doing the yaml conversion for the other patch.
I guess this one - I will try to do differently.

On 9/9/22 19:45, Mark Brown wrote:
> ...this is something that should be done in the machine driver rather
> than the CODEC, the way the device is wired up in an individual system
> may be surprising or the system may have some more specific labelling
> that can be usefully applied so this is all deferred to the card.
> 
> It would sense to convert ts3a277e_enable_jack_detect() to be a
> component set_jack() operation, that'd enable it to be used more easily
> with generic cards (though I see that it's not yet wired up for
> audio-graph-card unfortunately).

Thank you! Yes, set_jack I did not see.
I actually thinking of putting this into simple_card.c. But than it 
needs to be really generic.

I will have a look.

Astrid




More information about the Alsa-devel mailing list