[PATCH] ASoC: nau8825: Add ADCOUT IO drive strength control

David Lin ctlin0.linux at gmail.com
Sun Sep 11 08:33:05 CEST 2022


On 2022/9/7 下午 07:21, Mark Brown wrote:
> On Wed, Sep 07, 2022 at 02:51:27PM +0800, David Lin wrote:
>> Add a property to control the driving of ADCOUT.
>>
>> Signed-off-by: David Lin <CTLIN0 at nuvoton.com>
>> ---
>>   Documentation/devicetree/bindings/sound/nau8825.txt | 2 ++
>>   sound/soc/codecs/nau8825.c                          | 6 ++++++
>>   sound/soc/codecs/nau8825.h                          | 3 +++
>>   3 files changed, 11 insertions(+)
> Binding and driver patches should normally be separate patches.
OK, I will separate them.
>> +  - nuvoton,adcout-drive-str: ADCOUT IO drive strength. 0 - normal, 1 - stronger.
> Why not just make this a boolean property rather than requiring values?
>
>> +	nau8825->adcout_ds = device_property_read_bool(dev, "nuvoton,adcout-drive-str");
> It looks like it's being parsed as a boolean.

It's my fault. I will correct it as description of boolean.

Besides, kernel bot catch a build error, I will also fix it.



More information about the Alsa-devel mailing list