[PATCH] ASoC: sof_es8336: reduce pop noise on speaker

Mark Brown broonie at kernel.org
Thu Oct 27 13:34:25 CEST 2022


On Thu, Oct 27, 2022 at 03:38:07PM +0800, Zhu Ning wrote:

> +	case SNDRV_PCM_TRIGGER_SUSPEND:
> +	case SNDRV_PCM_TRIGGER_STOP:
> +		if (priv->speaker_en == false)
> +			if (substream->stream == 0)
> +				gpiod_set_value_cansleep(priv->gpio_speakers, true);

What happens if the stream is very briefly started or the system is
heavily loaded and the delayed work hasn't run yet?  We should probably
cancel the work here just to be safe.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20221027/a83ec80f/attachment.sig>


More information about the Alsa-devel mailing list